This revision was automatically updated to reflect the committed changes.
Closed by commit rC332635: [sanitizer] Don't add --export-dynamic for
Myriad (authored by waltl, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46452?vs=147233&id=147355#toc
Repository:
rC Clang
ht
waltl updated this revision to Diff 147233.
waltl added a comment.
Address CR comments
Repository:
rL LLVM
https://reviews.llvm.org/D46452
Files:
clang/lib/Driver/ToolChains/CommonArgs.cpp
Index: clang/lib/Driver/ToolChains/CommonArgs.cpp
=
alekseyshl added inline comments.
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:706
// to be dynamic to be sure we export sanitizer interface functions.
- if (AddExportDynamic)
+ if (AddExportDynamic && TC.getTriple().getVendor() != llvm::Triple::Myriad)
CmdArg
waltl created this revision.
waltl added reviewers: vitalybuka, eugenis, alekseyshl.
Herald added a subscriber: llvm-commits.
This is to work around a bug in some versions of gnu ld, where
--export-dynamic implies -shared even if -static is explicitly given.
Myriad supports static linking only, so