[PATCH] D66673: [OPENMP][NVPTX]Fix critical region codegen.

2019-08-26 Thread Alexey Bataev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL369946: [OPENMP][NVPTX]Fix critical region codegen. (authored by ABataev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST A

[PATCH] D66673: [OPENMP][NVPTX]Fix critical region codegen.

2019-08-26 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66673/new/ https://reviews.llvm.org/D66673 ___ cfe-comm

[PATCH] D66673: [OPENMP][NVPTX]Fix critical region codegen.

2019-08-23 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev updated this revision to Diff 216934. ABataev added a comment. Fix the test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66673/new/ https://reviews.llvm.org/D66673 Files: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp test/OpenMP/nvptx_parallel_codegen.cpp

[PATCH] D66673: [OPENMP][NVPTX]Fix critical region codegen.

2019-08-23 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In D66673#1643544 , @jdoerfert wrote: > I guess IR test should be affected already and it would be good to have the > run time test that breaks with barriers. Runtime test is libomptarget/deviceRTLs/nvptx/test/parallel/spmd_par

[PATCH] D66673: [OPENMP][NVPTX]Fix critical region codegen.

2019-08-23 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. I guess IR test should be affected already and it would be good to have the run time test that breaks with barriers. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66673/new/ https://reviews.llvm.org/D66673 __

[PATCH] D66673: [OPENMP][NVPTX]Fix critical region codegen.

2019-08-23 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev created this revision. ABataev added a reviewer: ABataev. Herald added subscribers: cfe-commits, guansong, jholewinski. Herald added a reviewer: jdoerfert. Herald added a project: clang. Previously critical regions were emitted with the barrier making it a worksharing construct though it i