This revision was automatically updated to reflect the committed changes.
Closed by commit rG64f74bf72eb4: [clang-tidy] Rewrite modernize-avoid-bind
check. (authored by zturner).
Changed prior to commit:
https://reviews.llvm.org/D70368?vs=230661=231793#toc
Repository:
rG LLVM Github
aaron.ballman accepted this revision.
aaron.ballman marked an inline comment as done.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM once you handle the last remaining nits from @Eugene.Zelenko.
Comment at:
Eugene.Zelenko added a comment.
Please mark addressed comments as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70368/new/
https://reviews.llvm.org/D70368
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Eugene.Zelenko added inline comments.
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:194
+ The check now supports supports diagnosing and fixing arbitrary callables
instead of
+ only simple free functions. The ``PermissiveParameterList`` option has also
been
+ added to
zturner updated this revision to Diff 230661.
zturner added a comment.
Addressed suggestions from @Eugene.Zelenko
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70368/new/
https://reviews.llvm.org/D70368
Files:
clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp
Eugene.Zelenko added a comment.
Changes should be also reflected in Release Notes.
Comment at: clang-tools-extra/docs/clang-tidy/checks/modernize-avoid-bind.rst:7
+The check finds uses of ``std::bind`` and ``boost::bind`` and replaces them
+with lambdas. Lambdas will use
zturner updated this revision to Diff 230495.
zturner added a comment.
- Updated documentation for this check
- Incorporated additional suggestions from @aaron.ballman
- Fixed an invalid transformation that was generated when binding a member
function and the second argument of `bind` (the
aaron.ballman added inline comments.
Comment at: clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp:153
+
+ return HNM.matchesNode(*dyn_cast(D));
+}
zturner wrote:
> aaron.ballman wrote:
> > This should probably use `cast<>` if it's going to assume the
zturner updated this revision to Diff 230162.
zturner added a comment.
Forgot to remove spurious `llvm::` namespace qualifications.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70368/new/
https://reviews.llvm.org/D70368
Files:
zturner updated this revision to Diff 230161.
zturner added a comment.
Updated with suggestions from @aaron.ballman
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70368/new/
https://reviews.llvm.org/D70368
Files:
clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp
zturner marked 2 inline comments as done.
zturner added inline comments.
Comment at: clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp:116
+static const Expr *ignoreTemporariesAndImplicitCasts(const Expr *E) {
+ if (const auto *T = dyn_cast(E))
+return
aaron.ballman added a comment.
This is a great re-write, thank you for working on it!
Comment at: clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp:105
+ CallableInfo Callable;
+
+ SmallVector BindArguments;
You can remove some newlines here.
Eugene.Zelenko added a comment.
Please describe changes in documentation and Release Notes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70368/new/
https://reviews.llvm.org/D70368
___
cfe-commits
zturner created this revision.
zturner added reviewers: aaron.ballman, dblaikie, jbcoe, NoQ.
Herald added a subscriber: xazax.hun.
This represents largely a full re-write of modernize-avoid-bind, adding
significant new functionality in the process. In particular:
1. Both boost::bind and
14 matches
Mail list logo
