This revision was automatically updated to reflect the committed changes.
jdoerfert marked an inline comment as done.
Closed by commit rG000c6a5038bc: [OpenMP] Use the OpenMPIRBuilder for `omp
cancel` (authored by jdoerfert).
Changed prior to commit:
https://reviews.llvm.org/D71948?vs=235448&id
jdoerfert marked 2 inline comments as done.
jdoerfert added inline comments.
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:241
+ // This seems to be used only once without much change of reuse, could live
in
+ // OMPKinds.def but seems not necessary.
+ Value *CancelKi
JonChesterfield accepted this revision.
JonChesterfield added a comment.
This revision is now accepted and ready to land.
I like this, thanks. Very clear.
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:241
+ // This seems to be used only once without much change of reus
merge_guards_bot added a comment.
{icon times-circle color=red} Unit tests: fail. 61126 tests passed, 1 failed
and 728 were skipped.
failed:
libc++.std/thread/thread_mutex/thread_mutex_requirements/thread_mutex_requirements_mutex/thread_mutex_class/try_lock.pass.cpp
{icon times-circle color=
jdoerfert created this revision.
jdoerfert added reviewers: kiranchandramohan, ABataev, RaviNarayanaswamy,
gtbercea, grokos, sdmitriev, JonChesterfield, fghanim.
Herald added subscribers: guansong, bollu, hiraditya.
Herald added a project: LLVM.
jdoerfert added a child revision: D70290: [OpenMP] U
