[PATCH] D72883: [clangd][test] Disable a particular testcase in FindExplicitReferencesTest when LLVM_ENABLE_EXPENSIVE_CHECKS

kadircet added a comment. Hi @jkorous, reverting this as d54d71b67e60 should've fixed this. Please let us know if that's not the case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72883: [clangd][test] Disable a particular testcase in FindExplicitReferencesTest when LLVM_ENABLE_EXPENSIVE_CHECKS

sammccall added a comment. Please revert this, it was already fixed by d54d71b67e60 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72883/new/ https://reviews.llvm.org/D72883

[PATCH] D72883: [clangd][test] Disable a particular testcase in FindExplicitReferencesTest when LLVM_ENABLE_EXPENSIVE_CHECKS

sammccall added a comment. kadir has a pending (or landed?) fix for this. It's just a usual fragile test - it's asserting the order, but findExplicitReferences just returns the order given by targetDecls which isn't stable. We settled on defining a stable (but arbitrary) order for targetDecl

[PATCH] D72883: [clangd][test] Disable a particular testcase in FindExplicitReferencesTest when LLVM_ENABLE_EXPENSIVE_CHECKS

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG42b3c38903c9: [clangd][test] Disable a particular testcase in FindExplicitReferencesTest when… (authored by jkorous).