[PATCH] D100276: [clang] p1099 using enum part 1

urnathan updated this revision to Diff 344396. urnathan edited the summary of this revision. urnathan edited reviewers, added: davrec; removed: Quuxplusone. urnathan added a comment. This update relies upon D101777 & D102239 (l

[PATCH] D100276: [clang] p1099 using enum part 1

urnathan updated this revision to Diff 339293. urnathan added a comment. Updated to fix formatting etc (pretty sure I got clang-format to work this time). I changed the pre-c++20 behaviour to be a warning along the lines you suggested. Trying to move the qualifier checking until after generati

[PATCH] D100276: [clang] p1099 using enum part 1

urnathan added a comment. thanks for the comments. My plan wrt documentation was to address that (and the feature macro) once the patches are in. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:12353 + ED = R->getAsSingle(); +else if (UD && UD->shadow_size () == 1) +

[PATCH] D100276: [clang] p1099 using enum part 1

bruno added a comment. Hi Nathan, thanks for implementing this. Besides formatting nitpicks, few other comments/questions: - Update needed in cxx_status.html - Should we support this as an extension for earlier C++ versions? This is a very handy feature. In clang terms, `warn_cxx17_compat_cons

[PATCH] D100276: [clang] p1099 using enum part 1

urnathan updated this revision to Diff 337416. urnathan added a comment. Remove orthogonal lbstdc++ FIXME comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100276/new/ https://reviews.llvm.org/D100276 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/S

[PATCH] D100276: [clang] p1099 using enum part 1

urnathan added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:12144 NameInfo.getName().getNameKind() != DeclarationName::CXXConstructorName) { +// FIXME: 2021-04-07: When was this hack needed? Can it be deleted now? // HACK: Work around a bug in lib

[PATCH] D100276: [clang] p1099 using enum part 1

urnathan added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:12144 NameInfo.getName().getNameKind() != DeclarationName::CXXConstructorName) { +// FIXME: 2021-04-07: When was this hack needed? Can it be deleted now? // HACK: Work around a bug in lib

[PATCH] D100276: [clang] p1099 using enum part 1

urnathan created this revision. urnathan added reviewers: rsmith, Quuxplusone, bruno. urnathan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds support for p1099's 'using SCOPED_ENUM::MEMNER;' functionality, bringing a member of an