On 7/26/18 1:38 PM, Richard Smith wrote:
On Thu, 26 Jul 2018 at 13:14, Erik Pilkington via cfe-commits
mailto:cfe-commits@lists.llvm.org>> wrote:
On 7/26/18 12:52 PM, Richard Smith wrote:
Other than the (fixed) ffmpeg false positive, I see this firing
in three places.
One
On Thu, 26 Jul 2018 at 13:22, Arthur O'Dwyer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Thu, Jul 26, 2018 at 12:52 PM, Richard Smith
> wrote:
>
>> Other than the (fixed) ffmpeg false positive, I see this firing in three
>> places.
>>
>> One of them is in the libc tests for memset a
On Thu, 26 Jul 2018 at 13:14, Erik Pilkington via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>
>
> On 7/26/18 12:52 PM, Richard Smith wrote:
>
> Other than the (fixed) ffmpeg false positive, I see this firing in three
> places.
>
> One of them is in the libc tests for memset and bzero, where
On Thu, Jul 26, 2018 at 12:52 PM, Richard Smith
wrote:
> Other than the (fixed) ffmpeg false positive, I see this firing in three
> places.
>
> One of them is in the libc tests for memset and bzero, where the 0
> argument is intentional.
> One of them is here: https://github.com/apache/xerces-c/b
On 7/26/18 12:52 PM, Richard Smith wrote:
Other than the (fixed) ffmpeg false positive, I see this firing in
three places.
One of them is in the libc tests for memset and bzero, where the 0
argument is intentional.
I don't find this case very convincing, if you're literally the one
person
Other than the (fixed) ffmpeg false positive, I see this firing in three
places.
One of them is in the libc tests for memset and bzero, where the 0 argument
is intentional.
One of them is here:
https://github.com/apache/xerces-c/blob/trunk/src/xercesc/util/XMLUTF16Transcoder.cpp#L114
(note that th
Sure, that seems pretty reasonable. r337706. Thanks for the suggestion!
On 7/21/18 1:40 PM, Arthur O'Dwyer wrote:
In this case Clang is complaining about
memset(complicated-expr, 0, 0);
which means that transposing the last two arguments would not "fix"
anything. Clang ought to not compl
On Sat, Jul 21, 2018 at 4:40 PM, Arthur O'Dwyer via cfe-commits
wrote:
> In this case Clang is complaining about
>
> memset(complicated-expr, 0, 0);
>
> which means that transposing the last two arguments would not "fix"
> anything. Clang ought to not complain in this case.
+1
~Aaron
> It d
In this case Clang is complaining about
memset(complicated-expr, 0, 0);
which means that transposing the last two arguments would not "fix"
anything. Clang ought to not complain in this case.
It doesn't have anything to do with coming from a macro; it's just that
*both* arguments are zero.
(I
This has a false positive on ffmpeg:
../../third_party/ffmpeg/libavcodec/options.c:273:64: error: 'size'
argument to memset is '0'; did you mean to transpose the last two
arguments? [-Werror,-Wmemset-transposed-args]
alloc_and_copy_or_fail(intra_matrix, 64 * sizeof(int16_t), 0);
With:
#define al
Author: epilk
Date: Thu Jul 19 09:46:15 2018
New Revision: 337470
URL: http://llvm.org/viewvc/llvm-project?rev=337470&view=rev
Log:
[Sema] Add a new warning, -Wmemset-transposed-args
This diagnoses calls to memset that have the second and third arguments
transposed, for example:
memset(buf, si
11 matches
Mail list logo