[PATCH] D120134: [analyzer] refactor makeIntValWithPtrWidth, remove getZeroWithPtrWidth (NFC)

vabridgers updated this revision to Diff 417415. vabridgers added a comment. update per @NoQ's latest comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120134/new/ https://reviews.llvm.org/D120134 Files: clang/include/clang/StaticAnalyzer/C

[PATCH] D120134: [analyzer] refactor makeIntValWithPtrWidth, remove getZeroWithPtrWidth (NFC)

vabridgers marked an inline comment as done. vabridgers added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2570 + State, TotalSize.castAs(), + svalBuilder.makeIntValWithPtrWidth(Arg1->getType(), 0)); NoQ wrote: > st

[PATCH] D121824: [clang] Do not crash on arrow operator on dependent type.

sammccall added a subscriber: rsmith. sammccall added a comment. In D121824#3400720 , @hokein wrote: > Sorry, I thought this crash is fixed as a bonus effort by improving the AST > for reference-type var-decl. > > Beyond the crash cased by the dependent-

[PATCH] D121824: [clang] Do not crash on arrow operator on dependent type.

sammccall added a comment. Oops, forgot conclusion: Thanks for incorporating my testcase, and the patch LGTM in its current form (most of the alternatives discussed also sound OK). I'll leave to Haojian to stamp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D118935: [SYCL] Disallow explicit casts between mismatching address spaces

hvdijk added a comment. In D118935#3399095 , @Fznamznon wrote: > I was under impression that the change is small and therefore easy to > understand. Would some comment like "SYCL re-uses OpenCL mode diagnostics to > emit errors in case the cast happens

[PATCH] D120573: [OpenMP] Support runtime user conditions in metadirective

abidmalikwaterloo added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1852 +int BestIdx = getBestVariantMatchForContext(StaticVMIs, OMPCtx); + +EmitStmt(StaticWhenClauses[BestIdx]->getDirective()); This approach is valid for static condi

[PATCH] D122265: [Clang][NFC] Cleanup dcl.constexpr/p3 tests

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Check for warnings instead of using -Werror, to avoid masking the type of diagnostic emitted - use different -verify l

[PATCH] D121951: [AMDGPU] Only warn when mixing printf and hostcall

scott.linder added a comment. In D121951#3393928 , @sameerds wrote: > In D121951#3392470 , @scott.linder > wrote: > >> In D121951#3391472 , @sameerds >> wrote: >> >>> Th

[PATCH] D120573: [OpenMP] Support runtime user conditions in metadirective

abidmalikwaterloo added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1793 +void CodeGenFunction::EmitOMPMetaDirective(const OMPMetaDirective &D) { + llvm::BasicBlock *AfterBlock = + createBasicBlock("omp.meta.user.condition.after"); Why a

[PATCH] D121873: [clang][extract-api] Add enum support

zixuw updated this revision to Diff 417424. zixuw added a comment. Rebase on main with changed and merged refactoring in D122160 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121873/new/ https://reviews.llvm.org/

[PATCH] D121969: Pass split-machine-functions to code generator when flto is used

wenlei added a comment. The linter warning seems legit, otherwise looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121969/new/ https://reviews.llvm.org/D121969 ___ cfe-commits mailing list cfe-c

[PATCH] D122202: [clang][extract-api] Add struct support

zixuw updated this revision to Diff 417430. zixuw added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122202/new/ https://reviews.llvm.org/D122202 Files: clang/include/clang/ExtractAPI/API.h clang/include/clang/ExtractAPI/Dec

[PATCH] D122271: [Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators

xbolva00 created this revision. xbolva00 added reviewers: efriedma, yonghong-song. Herald added a project: All. xbolva00 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang fails to diagnose: void test() { int j = 0; for (i

[clang-tools-extra] 07675b0 - [clang-tidy] Fix false positives in `misc-redundant-expression` check

Author: Fabian Wolff Date: 2022-03-23T00:32:45+01:00 New Revision: 07675b0b38e930c2c582122ac93efcdf7859a772 URL: https://github.com/llvm/llvm-project/commit/07675b0b38e930c2c582122ac93efcdf7859a772 DIFF: https://github.com/llvm/llvm-project/commit/07675b0b38e930c2c582122ac93efcdf7859a772.diff

[PATCH] D122111: [clang-tidy] Fix false positives in `misc-redundant-expression` check

This revision was automatically updated to reflect the committed changes. fwolff marked an inline comment as done. Closed by commit rG07675b0b38e9: [clang-tidy] Fix false positives in `misc-redundant-expression` check (authored by fwolff). Changed prior to commit: https://reviews.llvm.org/D1221

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa updated this revision to Diff 417435. yihanaa added a reviewer: xbolva00. yihanaa added a comment. Remove code formatting changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122248/new/ https://reviews.llvm.org/D122248 Files: clang/li

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa added a comment. In D122248#3400408 , @xbolva00 wrote: >>> the remaining changes are code formatting > > Please remove code formatting changes. Okay, i have removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D122202: [clang][extract-api] Add struct support

zixuw updated this revision to Diff 417438. zixuw marked 3 inline comments as done. zixuw added a comment. Address review issues: fix Symbol Graph struct kind identifiers and display names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122202/new/

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa updated this revision to Diff 417439. yihanaa added a comment. Remove useless comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122248/new/ https://reviews.llvm.org/D122248 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGe

[PATCH] D121927: [Clang] Work with multiple pragmas weak before definition

hubert.reinterpretcast updated this revision to Diff 417443. hubert.reinterpretcast added a comment. - Address review comments: Add release notes, expand comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121927/new/ https://reviews.llvm.org/D1

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

owenpan added inline comments. Comment at: clang/lib/Format/Format.cpp:2692-2695 + for (int i = Matches.size() - 1; i > 0; i--) { +if (!Matches[i].empty()) + return Matches[i]; + } I think you missed `Matches[0]`. Comment at: clang/l

[PATCH] D122277: [analyzer] Fix crash in RangedConstraintManager.cpp

vabridgers created this revision. vabridgers added reviewers: martong, NoQ. Herald added subscribers: manas, steakhal, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. vabridgers requested revie

[PATCH] D122277: [analyzer] Fix crash in RangedConstraintManager.cpp

vabridgers updated this revision to Diff 417450. vabridgers added a comment. remove assert that was commented out Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122277/new/ https://reviews.llvm.org/D122277 Files: clang/lib/StaticAnalyzer/Core/Ran

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

owenpan added inline comments. Comment at: clang/lib/Tooling/Inclusions/HeaderIncludes.cpp:176-188 const char IncludeRegexPattern[] = -R"(^[\t\ ]*#[\t\ ]*(import|include)[^"<]*(["<][^">]*[">]))"; +R"(^[\t\ ]*[@#][\t\ ]*(import|include)([^"]*("[^"]+")|[^<]*(<[^>]+>)|[\t\

[PATCH] D122175: [clang][extract-api] Enable processing of multiple headers

ributzka added inline comments. Comment at: clang/include/clang/SymbolGraph/FrontendActions.h:35 + /// This is called before executing the action on any inputs. This merges all + /// the provided headers into a single header for processing. + bool PrepareToExecuteAction(Compil

[PATCH] D122278: [clang] Improve diagnostic for reopened inline namespace

fwolff created this revision. fwolff added reviewers: rsmith, cor3ntin, mizvekov. fwolff added a project: clang. Herald added a project: All. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Fixes #50794 . Reopenin

[PATCH] D121969: Pass split-machine-functions to code generator when flto is used

junfd updated this revision to Diff 417458. junfd added a comment. Apply clang format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121969/new/ https://reviews.llvm.org/D121969 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Driv

[clang] 818e72d - [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in

Author: Akira Hatanaka Date: 2022-03-22T18:39:16-07:00 New Revision: 818e72d1b09bc5fc3b7a2c9f90b981a9c0d2a5db URL: https://github.com/llvm/llvm-project/commit/818e72d1b09bc5fc3b7a2c9f90b981a9c0d2a5db DIFF: https://github.com/llvm/llvm-project/commit/818e72d1b09bc5fc3b7a2c9f90b981a9c0d2a5db.diff

[PATCH] D122199: [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in TargetInfo.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG818e72d1b09b: [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D115248: [Clang] Fix PR28101

rZhBoYao updated this revision to Diff 417461. rZhBoYao retitled this revision from "[clang] Fix PR28101" to "[Clang] Fix PR28101". rZhBoYao edited the summary of this revision. rZhBoYao added a reviewer: cor3ntin. rZhBoYao set the repository for this revision to rG LLVM Github Monorepo. rZhBoYao

[clang] 6edfe45 - [AVR] Add more devices

Author: Ben Shi Date: 2022-03-23T02:00:15Z New Revision: 6edfe45a63125a8938a5bea13534a118b0e31023 URL: https://github.com/llvm/llvm-project/commit/6edfe45a63125a8938a5bea13534a118b0e31023 DIFF: https://github.com/llvm/llvm-project/commit/6edfe45a63125a8938a5bea13534a118b0e31023.diff LOG: [AVR]

[PATCH] D121359: [AVR] Add more devices

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6edfe45a6312: [AVR] Add more devices (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D118525: [modules] Merge ObjC interface ivars with anonymous types.

vsapsai updated this revision to Diff 417468. vsapsai added a comment. Fix bug with anonymous enum constant lookup in C++. Turns out the lookup was broken by using `ObjCInterfaceDecl` as a semantic decl context for anonymous enums. Fixing that fixed the lookup. Also added in tests checking scope

[PATCH] D121176: [ASTStructuralEquivalence] Add support for comparing ObjCCategoryDecl.

vsapsai added a comment. @shafik, can you please check the patch? Or maybe recommend somebody who worked both on ASTStructuralEquivalence and Objective-C part of clang? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121176/new/ https://reviews.llvm

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

dexonsmith accepted this revision. dexonsmith added a comment. LGTM too! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121812/new/ https://reviews.llvm.org/D121812 ___ cfe-commits mailing list cfe-commit

[PATCH] D122119: [C++20][Modules] Adjust handling of exports of namespaces and using-decls.

ChuanqiXu added a comment. In D122119#3400032 , @urnathan wrote: > In D122119#3398949 , @ChuanqiXu > wrote: > >> > > > >> The first feeling I saw the change is that not every C++ programmer knows >> about linka

[PATCH] D115248: [Clang] Fix PR28101

rZhBoYao updated this revision to Diff 417475. rZhBoYao added a comment. Don't break template declarations. re-clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115248/new/ https://reviews.llvm.org/D115248 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/SemaCXX/PR28101.cp

[PATCH] D119409: [C++20] [Modules] Remain dynamic initializing internal-linkage variables in module interface unit

ChuanqiXu added a subscriber: urnathan. ChuanqiXu added a comment. In D119409#3400287 , @dblaikie wrote: > In D119409#3398483 , @ChuanqiXu > wrote: > >> In D119409#3396690

[PATCH] D120874: [C++20] [Modules] Use '-' as the separator of partitions when searching in filesystems

ChuanqiXu added a comment. @iains ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120874/new/ https://reviews.llvm.org/D120874 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

jyu2 accepted this revision. jyu2 added a comment. This revision is now accepted and ready to land. This is okay with me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107141/new/ https://reviews.llvm.org/D107141 __

[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

pengfei added a comment. Thanks @jyu2 ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107141/new/ https://reviews.llvm.org/D107141 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D120397: [C++20] [Modules] Make the linkage consistent for template and its specialization

ChuanqiXu updated this revision to Diff 417479. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120397/new/ https://reviews.llvm.org/D120397 Files: clang/lib/AST/Decl.cpp clang/unittests/AST/DeclTest.cpp Index: clang/unittests/AST/DeclTe

[PATCH] D120397: [C++20] [Modules] Make the linkage consistent for template and its specialization

ChuanqiXu marked an inline comment as done. ChuanqiXu added a comment. In D120397#3399808 , @aaron.ballman wrote: > Can you also add a release note that explains we've fixed the crash? My thought is to edit a release note standalone. Since there are alr

[PATCH] D121868: [cc1as] Add support for emitting the build version load command for -darwin-target-variant

MaskRay added a comment. Herald added a subscriber: StephenFan. This may need a test in `clang/test/Misc/cc1as-*`. Can you add to the description what the `clang -cc1as` usage looks like? Comment at: clang/tools/driver/cc1as_main.cpp:217 +llvm::Triple TVT(A->getValue()); +

[clang] 3210360 - [Inline-asm] Add diagnosts for unsupported inline assembly arguments

Author: Phoebe Wang Date: 2022-03-23T11:25:19+08:00 New Revision: 32103608fc073700f04238872d8b22655ddec3fb URL: https://github.com/llvm/llvm-project/commit/32103608fc073700f04238872d8b22655ddec3fb DIFF: https://github.com/llvm/llvm-project/commit/32103608fc073700f04238872d8b22655ddec3fb.diff L

[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG32103608fc07: [Inline-asm] Add diagnosts for unsupported inline assembly arguments (authored by pengfei). Repository: rG LLVM Github Monorepo CHA

[PATCH] D118493: Set rpath on openmp executables

tstellar added a comment. In D118493#3398808 , @JonChesterfield wrote: > It lets applications run with the libomp and libomptarget built with the > toolchain. For users, they don't have to be root. For compiler devs, we test > our work instead of whate

[PATCH] D122285: [analyzer] Add path note tags to standard library function summaries.

NoQ created this revision. NoQ added reviewers: t-rasmud, Szelethus, martong, steakhal, ASDenysPetrov, balazske, gamesh411. Herald added subscribers: manas, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. NoQ requested

[PATCH] D122285: [analyzer] Add path note tags to standard library function summaries.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:41 // -// The following standard C functions are currently supported: -// This comment has been out of date for years and I don't think it makes sense to hav

[PATCH] D122277: [analyzer] Fix crash in RangedConstraintManager.cpp

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks! I agree that this assertion doesn't make much sense. Judging by the name, the function should be able to handle all symbols. Comment at: clang/lib/StaticAnalyzer/Core/Rang

[PATCH] D122271: [Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators

yonghong-song added a comment. LGTM. Maybe @efriedma can look at this as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122271/new/ https://reviews.llvm.org/D122271 ___ cfe-commits mailing list cfe-

[PATCH] D122104: [X86][regcall] Support passing / returning structures

pengfei updated this revision to Diff 417502. pengfei added a comment. clang-formatted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122104/new/ https://reviews.llvm.org/D122104 Files: clang/include/clang/CodeGen/CGFunctionInfo.h clang/lib/Co

[PATCH] D115248: [Clang] Fix PR28101

rZhBoYao updated this revision to Diff 417504. rZhBoYao set the repository for this revision to rG LLVM Github Monorepo. rZhBoYao added a comment. Diagnose "same name as its class" before setting the declarator invalid as otherwise it would not be diagnosed. This also aligns with gcc's behavior.

[PATCH] D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr.

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:1905 +if (SemaRef.LangOpts.CPlusPlus2b) { + if (!VD->getType()->isLiteralType(SemaRef.Context)) +SemaRef.Diag(VD->getLocation(), This seems to tr

[PATCH] D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr.

hubert.reinterpretcast added inline comments. Comment at: clang/test/SemaCXX/constant-expression-cxx2b.cpp:219 + NonLiteral n; // cxx2b-note {{non-literal type 'NonLiteral' cannot be used in a constant expression}} \ +// cxx2b-warning {{definition of a v

[clang] 98fd3b3 - Driver: Don't warn on -mbranch-protection when linking

Author: Tom Stellard Date: 2022-03-22T23:17:42-07:00 New Revision: 98fd3b359866f474ab1c097c22fb5c3be356b996 URL: https://github.com/llvm/llvm-project/commit/98fd3b359866f474ab1c097c22fb5c3be356b996 DIFF: https://github.com/llvm/llvm-project/commit/98fd3b359866f474ab1c097c22fb5c3be356b996.diff

[PATCH] D121983: Driver: Don't warn on -mbranch-protection when linking

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG98fd3b359866: Driver: Don't warn on -mbranch-protection when linking (authored by tstellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

tbaeder updated this revision to Diff 417509. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121201/new/ https://reviews.llvm.org/D121201 Files: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/DeclSpec.h clang/include/clang/Sema/ParsedAttr.h clang/include/clang/Sema/Se

[clang] 1089cdd - Revert "Driver: Don't warn on -mbranch-protection when linking"

Author: Tom Stellard Date: 2022-03-22T23:36:57-07:00 New Revision: 1089cdda776bbd437d6507242f2621ec83af7118 URL: https://github.com/llvm/llvm-project/commit/1089cdda776bbd437d6507242f2621ec83af7118 DIFF: https://github.com/llvm/llvm-project/commit/1089cdda776bbd437d6507242f2621ec83af7118.diff

<    1   2   3