[cp-patches] remove setBoundsCallback

2005-08-16 Thread Thomas Fitzsimmons
Hi, This patch removes setBoundsCallback from Window.java and replaces it with a new method of validating based on a Window resize event. This is more in line with how the JDK handles window resizing and allows both the GTK and Qt peers to handle resizing the same way. I committed this to mainli

Re: [cp-patches] RFC: qt4 peers build machinery

2005-08-16 Thread Dalibor Topic
Mark Wielaard wrote: Hi, On Tue, 2005-08-16 at 23:26 +0200, Dalibor Topic wrote: the attached patch adds the necessary build machinery for Qt 4 peers. Thanks! Still trying to get a clean build environment. But you will at least need a little update to the check_jni_methods.sh script. Attach

Re: [cp-patches] Reimplemented gtk-peers datatransfer support

2005-08-16 Thread Thomas Fitzsimmons
Hi, On Tue, 2005-08-16 at 20:00 +0200, Mark Wielaard wrote: > I would like for someone to review how I handled the native/gtk > lock/thread transitions. Since the datatransfer api is basically > synchronous, but the gtkclipboard is asynchronous we need to call into > gtk+ to setup callbacks and t

Re: [cp-patches] RFC: qt4 peers build machinery

2005-08-16 Thread Mark Wielaard
Hi, On Tue, 2005-08-16 at 23:26 +0200, Dalibor Topic wrote: > the attached patch adds the necessary build machinery for Qt 4 peers. Thanks! Still trying to get a clean build environment. But you will at least need a little update to the check_jni_methods.sh script. Attached. Cheers, Mark Index:

Re: [cp-patches] disable ecj warnings

2005-08-16 Thread Mark Wielaard
Hi, On Sun, 2005-08-14 at 19:00 -0400, Thomas Fitzsimmons wrote: > I committed this. The warning output from ecj was far too verbose. > -JAVAC = $(ECJ) -encoding UTF-8 -warn:-deprecation,serial -proceedOnError > -bootclasspath '' -classpath $(compile_classpath) -d . @classes > +JAVAC = $(ECJ) -

Re: [cp-patches] [generics] Patch: FYI: new class FormattableFlags

2005-08-16 Thread Mark Wielaard
Hi Tom, On Sat, 2005-08-13 at 18:48 -0600, Tom Tromey wrote: > +/** @since 1.5 */ > +public class FormattableFlags > +{ > + public static final int LEFT_JUSTIFY = 1; > + public static final int UPPERCASE = 2; > + public static final int ALTERNATE = 4; > + > + // Not instantiable. > + private

Re: [cp-patches] [generics] Patch: FYI: new class FormattableFlags

2005-08-16 Thread Tom Tromey
> "Mark" == Mark Wielaard <[EMAIL PROTECTED]> writes: Mark> Please add documentation when adding new classes, fields and methods. Mark> Similar for your Timer extensions. FWIW, I don't like to write the docs when I write the code, as I think I will probably copy the original javadoc too close

[cp-patches] Patch: FYI: more eclipse updates

2005-08-16 Thread Tom Tromey
I'm checking this in. I had renamed the "CreateLocaleData" launch configuration before my last patch, but somehow Eclipse failed to rename the launcher in .project. I fixed this by hand. I also added a build step to build the native code. Tom 2005-08-16 Tom Tromey <[EMAIL PROTECTED]>

[cp-patches] Patch: FYI: update eclipse build infrastructure

2005-08-16 Thread Tom Tromey
I'm checking this in. This updates the Eclipse build infrastructure a little. Now we ignore jdwp and make sure that LocaleData.java exists. It also fixes a little build buglet in the new example. With this you should once again be able to check out Classpath with Eclipse and have it automatical

[cp-patches] Patch: PasswordView fix

2005-08-16 Thread Lillian Angel
2005-08-16 Lillian Angel <[EMAIL PROTECTED]> * javax/swing/text/PasswordView.java (drawUnselectedText): Fixed so the password is drawn correctly in the text box and no * characters are drawn before anything was typed. Index: javax/swing/text/PasswordView.java ===

[cp-patches] FYI: BasicTreeUI fix

2005-08-16 Thread Anthony Balkissoon
This patch makes JTable key registrations match the JDK in that the UI InputMap-ActionMap pair is registered as the parents of the JTable's InputMap-ActionMap pair. Patch is attached. 2005-08-16 Anthony Balkissoon <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicLookAndFeel.java: (initCompon

Re: [cp-patches] [patch] fix BE image issues

2005-08-16 Thread Andreas Tobler
Tom Tromey wrote: "Andreas" == Andreas Tobler <[EMAIL PROTECTED]> writes: Andreas> 2005-07-24 Andreas Tobler <[EMAIL PROTECTED]> Andreas> * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkImage.c Andreas> (Java_gnu_java_awt_peer_gtk_GtkImage_setPixels): Adjust BE image Andreas> handling. Andre

[cp-patches] FYI: Update and document datatransfer example Demo

2005-08-16 Thread Mark Wielaard
Hi, This adds an example of using FlavorListeners to the datatransfer example Demo and add documentation for all the features used. 2005-08-16 Mark Wielaard <[EMAIL PROTECTED]> * examples/gnu/classpath/examples/datatransfer/Demo.java: Document and implement ItemListener and FlavorListe

[cp-patches] Patch: PasswordView

2005-08-16 Thread Lillian Angel
2005-08-16 Lillian Angel <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicLookAndFeel.java: Changed font for PasswordField because textbox was being drawn at an awkward height. * javax/swing/text/PasswordView.java (getPreferredSpan): Implemented (

RE: [cp-patches] RFC: AWT painting broken?

2005-08-16 Thread Roman Kennke
Am Dienstag, den 16.08.2005, 15:32 +0200 schrieb Jeroen Frijters: > Roman Kennke wrote: > > No it does not. The method processEvent is only intended to give > > applications with Component subclasses a chance to process the event. > > The AWT itself should not do any logic in these methods. > > Pl

RE: [cp-patches] RFC: AWT painting broken?

2005-08-16 Thread Jeroen Frijters
Roman Kennke wrote: > Oh sorry, the diff has confused me. It is ok then. Please check it in. Thanks. I've checked it in. Regards, Jeroen 2005-08-16 Jeroen Frijters <[EMAIL PROTECTED]> * java/awt/Component.java (dispatchEventImpl): Always call peer.handleEvent().

RE: [cp-patches] RFC: AWT painting broken?

2005-08-16 Thread Jeroen Frijters
Roman Kennke wrote: > No it does not. The method processEvent is only intended to give > applications with Component subclasses a chance to process the event. > The AWT itself should not do any logic in these methods. Please take another look at my patch. I did not alter the call to processEvent a

Re: [cp-patches] RFC: AWT painting broken?

2005-08-16 Thread Roman Kennke
Am Dienstag, den 16.08.2005, 14:36 +0200 schrieb Jeroen Frijters: > Hi, > > Maybe it's me (I'm always fighting with AWT whenever I work on it), but > the recent batch of changes to AWT broke painting for me (using my own > peers). > > I don't pretend to understand how this is supposed to work, so

[cp-patches] RFC: AWT painting broken?

2005-08-16 Thread Jeroen Frijters
Hi, Maybe it's me (I'm always fighting with AWT whenever I work on it), but the recent batch of changes to AWT broke painting for me (using my own peers). I don't pretend to understand how this is supposed to work, so it could very well be something in my peers, but I think attached patch makes s

[cp-patches] FYI: java/awt/Container.java fix.

2005-08-16 Thread Jeroen Frijters
Hi, A small fix to Container. Regards, Jeroen 2005-08-16 Jeroen Frijters <[EMAIL PROTECTED]> * java/awt/Container.java (addImpl, remove): Only repaint if the container is showing. Index: java/awt/Container.java ==

Re: [cp-patches] Rewrite split-for-gcj

2005-08-16 Thread Andrew Haley
Tom Tromey writes: > > "Andrew" == Andrew Haley <[EMAIL PROTECTED]> writes: > > >> I'm not an awk expert by any stretch ... one important thing here is > >> to make sure the code remains portable. Any ideas on that? > > Andrew> You'll have to tell me what problems you forsee. AFAIK us

Re: [cp-patches] FYI: FlowLayout fixlet

2005-08-16 Thread Roman Kennke
Hi Tom, Am Montag, den 15.08.2005, 10:17 -0600 schrieb Tom Tromey: > > "Roman" == Roman Kennke <[EMAIL PROTECTED]> writes: > > Roman> FlowLayout.setAlignment used to check for illegal values. However, the > Roman> JDK does not throw an exception in this case and treats unknown values > Roman>

[cp-patches] FYI: Remove Java_gnu_java_awt_peer_gtk_GtkToolkit_nativeQueueEmpty

2005-08-16 Thread Mark Wielaard
Hi, As pointed out by the autobuilder check_jni_methods script GtkToolkit.nativeQueueEmpty() isn't used anymore. This patch removes it and makes the tree build again. 2005-08-16 Mark Wielaard <[EMAIL PROTECTED]> * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkToolkit.c (Java_gnu_java_aw

[cp-patches] [Fwd: FYI: Container fix]

2005-08-16 Thread Sven de Marothy
-- Sven de Marothy <[EMAIL PROTECTED]> --- Begin Message --- Don't create peers for added components if the container doesn't have a peer yet! 2005-08-14 Sven de Marothy <[EMAIL PROTECTED]> * java/awt/Container.java (addImpl): Call addNotify() only if the container has a peer.

[cp-patches] FYI: Remove redundant ClasspathToolkit methods

2005-08-16 Thread Sven de Marothy
2005-08-14 Sven de Marothy <[EMAIL PROTECTED]> * gnu/java/awt/ClasspathToolkit.java (getScreenSize, getColorModel, getFontMetrics, getImage, createImage, createImageProducer, registerImageIOSpis): Remove redundant (overloaded) methods. * gnu/java/awt/peer

[cp-patches] FYI: Container fix

2005-08-16 Thread Sven de Marothy
Don't create peers for added components if the container doesn't have a peer yet! 2005-08-14 Sven de Marothy <[EMAIL PROTECTED]> * java/awt/Container.java (addImpl): Call addNotify() only if the container has a peer. Index: java/awt/Container.java =