Re: [cp-patches] [RFC] JSSE 1.5 classes and methods

2005-09-13 Thread Chris Burdess
Casey Marshall wrote: I'm looking for comments about this approach, since I imagine it is controversial; this looks closely compatible with 1.5, according to japicompat, but I'm not sure if that level of compatibility is close enough. There are a couple alternatives to a new class under 'gnu':

Re: [cp-patches] RFC: [Patch] rewrite of classpath/gnu/java/net/protocol/http/*

2005-09-13 Thread Chris Burdess
David Daney wrote: As I threatened last week, I made some major changes to the gnu.java.net.protocol.http package. ... The current version reads the entire body of a HTTP response in to a memory buffer (ByteArrayResponseBodyReader) and if user code needs the content it gets a ByteArrayInputS

Re: [cp-patches] [Patch] Improve/fix gnu.java.net.LineInputStream...

2005-09-13 Thread Chris Burdess
David Daney wrote: gnu.java.net.LineInputStream has at least one bug in it, but think its whole approach is incorrect. First the bug: len = in.available(); len = (len < MIN_LENGTH) ? MIN_LENGTH : len; I think the idea was to read all available bytes into its buffer (

[cp-patches] FYI: Added API comments to JTabbedPane

2005-09-13 Thread Roman Kennke
2005-09-13 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/JTabbedPane.java: Added API comments all over. /Roman Index: javax/swing/JTabbedPane.java === RCS file: /cvsroot/classpath/classpath/javax/swing/JTabbedPane.java,v r

[cp-patches] FYI: SizeRequirements fix

2005-09-13 Thread Roman Kennke
2005-09-13 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/SizeRequirements.java (toString): Implemented this method. (calculateAlignedPositions): Partly implemented this method. /RomanIndex: javax/swing/SizeRequirements.java =

[cp-patches] FYI: DefaultStyledDocument additions

2005-09-13 Thread Roman Kennke
Hi, I added lots of stuff to javax.swing.text.DefaultStyledDocument. 2005-09-13 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/text/DefaultStyledDocument.java (ElementSpec): New inner class. (ElementBuffer.change): Also store the DefaultDocumentEvent. (ElementBu

[cp-patches] FYI: JComboBox

2005-09-13 Thread David Gilbert
I committed this patch (and am about to put the corresponding tests into Mauve): 2005-09-13 David Gilbert <[EMAIL PROTECTED]> * javax/swing/JComboBox.java (getPrototypeDisplayValue): added API docs, (setPrototypeDisplayValue): fire property change event. Regards, Dave

Re: [cp-patches] [Patch] Improve/fix gnu.java.net.LineInputStream...

2005-09-13 Thread David Daney
Chris Burdess wrote: David Daney wrote: gnu.java.net.LineInputStream has at least one bug in it, but think its whole approach is incorrect. First the bug: len = in.available(); len = (len < MIN_LENGTH) ? MIN_LENGTH : len; I think the idea was to read all available

Re: [cp-patches] RFC: [Patch] rewrite of classpath/gnu/java/net/protocol/http/*

2005-09-13 Thread David Daney
Chris Burdess wrote: David Daney wrote: As I threatened last week, I made some major changes to the gnu.java.net.protocol.http package. ... The current version reads the entire body of a HTTP response in to a memory buffer (ByteArrayResponseBodyReader) and if user code needs the content it

Re: [cp-patches] RFC: [Patch] rewrite of classpath/gnu/java/net/protocol/http/*

2005-09-13 Thread Chris Burdess
David Daney wrote: You would probably have a better chance if you threw out all the inetlib classes and started from scratch with a pull-based client. What are you talking about? I am not using inetlib. The gnu.java.net.protocol.http package is the inetlib HTTP client. I do agree with secti

[cp-patches] FYI: java.io.ByteArrayOutputStream fix toString(int)...

2005-09-13 Thread David Daney
As approved by Tom Tromey on [EMAIL PROTECTED] 2005-09-13 David Daney <[EMAIL PROTECTED]> * java/io/ByteArrayOutputStream.java: Reformated copyright notice. (toString(int)): Pass correct parameters to String constructor. David Daney. Index: java/io/ByteArrayOutputStream.jav

Re: [cp-patches] RFC: [Patch] rewrite of classpath/gnu/java/net/protocol/http/*

2005-09-13 Thread David Daney
Chris Burdess wrote: David Daney wrote: You would probably have a better chance if you threw out all the inetlib classes and started from scratch with a pull-based client. What are you talking about? I am not using inetlib. The gnu.java.net.protocol.http package is the inetlib HTTP clien

Re: [cp-patches] [Patch] Improve/fix gnu.java.net.LineInputStream...

2005-09-13 Thread Tom Tromey
> "Chris" == Chris Burdess <[EMAIL PROTECTED]> writes: >> I did take the liberty of adding my own micro-optimization, in that >> if the encoding is US-ASCII, we can skip using String's character >> encoding system and just request hibyte of 0. I did this because a >> year ago with libgcj-3.4

Re: [cp-patches] [Patch] Improve/fix gnu.java.net.LineInputStream...

2005-09-13 Thread David Daney
Tom Tromey wrote: "Chris" == Chris Burdess <[EMAIL PROTECTED]> writes: I did take the liberty of adding my own micro-optimization, in that if the encoding is US-ASCII, we can skip using String's character encoding system and just request hibyte of 0. I did this because a year ago with libgc

[cp-patches] Patch: RFC: work around mprec problem on x86-64

2005-09-13 Thread Tom Tromey
I want to check this in to Classpath; once the 4.0 branch is unfrozen I will put it there as well. I thought I'd get some comments about this since this isn't really my area so much. This works around a bug with a particular test case. When run on a non-Pack_32 system (e.g., x86-64), mprec will

[cp-patches] fix JAWT self-deadlock

2005-09-13 Thread Thomas Fitzsimmons
Hi, Some JAWT-using demos were self-deadlocking on the GDK lock. I've removed the gdk_threads_enter and gdk_threads_leave calls from _Jv_AWTLock and _Jv_AWTUnlock. I'm not sure what these functions are meant to do so I've just left FIXME comments for now. Tom 2005-09-13 Thomas Fitzsimmons <[

Re: [cp-patches] [RFC] JSSE 1.5 classes and methods

2005-09-13 Thread Andrew John Hughes
On Mon, 2005-09-12 at 22:33 -0700, Casey Marshall wrote: > Hi, > > Attached is a patch to implement most of the javax.net.ssl methods > and classes introduced in J2SE 1.5. > Great. > This isn't complete, partly due to missing classes elsewhere > (java.security.KeyStore.Builder) and due to t

[cp-patches] Re: Patch for approval fixes bug # 23006

2005-09-13 Thread Anthony Balkissoon
Sorry, I sent this from my non-list account. On Tue, 2005-09-13 at 16:18 -0400, Anthony Balkissoon wrote: > To account for peers' size requirements, Components should be > invalidated before they are first shown on the screen. This patch calls > invalidateTree() when a Window is first shown. > >

[cp-patches]: Patch: JTree missing functions-

2005-09-13 Thread Lillian Angel
Added methods in JTree that were missing. 2005-09-13 Lillian Angel <[EMAIL PROTECTED]> * javax/swing/JTree.java (AccessibleJTree): Added new Inner class. (AccessibleJTree.addAccessibleSelection): New method. (AccessibleJTree.clearAccessibleSelection): New method.

[cp-patches] patch for approval fixes bug #23006

2005-09-13 Thread Anthony Balkissoon
My mail server isn't being friendly, sorry if this arrives more than once. To account for peers' size requirements, Components should be invalidated before they are first shown on the screen. This patch calls invalidateTree() when a Window is first shown. This fixes bug #23006. Patch is pending

[cp-patches] Patch: FYI: warning fixes

2005-09-13 Thread Tom Tromey
I'm checking this in. This mostly fixes some warnings related to javadoc but also a couple related to unused imports. It also adds a missing @since -- try to remember these, folks. Tom 2005-09-13 Tom Tromey <[EMAIL PROTECTED]> * java/lang/Process.java: Added import for javadoc.

[cp-patches] FYI: BasicComboBoxUI

2005-09-13 Thread David Gilbert
I committed this patch: 2005-09-13 David Gilbert <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicComboBoxUI.java (lightHighlight): removed, (installDefaults): only update component attributes if they are tagged with UIResource, initialise button colors from co

[cp-patches] FYI: MetalComboBoxButton and MetalComboBoxEditor

2005-09-13 Thread David Gilbert
I committed these new classes. The MetalComboBoxUI class that uses them isn't complete yet, but I'm working on it: 2005-09-13 David Gilbert <[EMAIL PROTECTED]> * javax/swing/plaf/metal/MetalComboBoxButton.java: new file, * javax/swing/plaf/metal/MetalComboBoxEditor.java: like

[cp-patches] DiffieHellman and RSA

2005-09-13 Thread Casey Marshall
I've checked these in. I put an RFC for these out some time ago [1], but didn't see Tromey's reply until now. This adds DiffieHellman key exchange and RSA cipher support; as I understand it, this should fix problems with using Eclipse's 'extssh' with free runtimes. 2005-09-13 Casey Marsh

[cp-patches] Patch: FYI: more javadoc fixes

2005-09-13 Thread Tom Tromey
I'm checking this in. This fixes a bunch more javadoc issues in java.util, java.lang, and java.io. Tom 2005-09-13 Tom Tromey <[EMAIL PROTECTED]> * java/util/regex/Matcher.java (matches): Javadoc fix. (start): Likewise. * java/lang/reflect/Proxy.java (equals): Javadoc f

[cp-patches] FYI: GapContent fixes

2005-09-13 Thread Roman Kennke
This is the next big patch in the javax.swing.text series ;-) I added mauve test to back most of the modifications, since GapContent seems to be a little fragile. 2005-09-14 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/text/GapContent.java (GapContentPosition.getOffset): Made

[cp-patches] [FYI] JOptionPane fixes

2005-09-13 Thread Robert Schuster
Hi, when using our JOptionPane throught the method JOptionPane.showConfirmDialog(Component, Object) it did not show a question mark icon and Yes-No-Cancel buttons like the JDK. This is now fixed. 2005-09-14 Robert Schuster <[EMAIL PROTECTED]> * javax/swing/JOptionPane.java: (showConfirm

[cp-patches] FYI: GlyphView additions

2005-09-13 Thread Roman Kennke
Hi, I did work alot an GlyphView (and other stuff in javax.swing.text -- see followup commits). This (together with the next view commits) basically enabled this: http://kennke.org/~roman/styletext.png 2005-09-14 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/text/GlyphView.java

[cp-patches] FYI: Lots of javax.swing.text fixlets

2005-09-13 Thread Roman Kennke
This is the remaining stuff that I have for javax.swing.text. Mostly these are small unrelated bits that I have come across while working on javax.swing.text like serialVerionUIDs, some defaults and so on. Please forgive me that I send these in a bulk commit. 2005-09-14 Roman Kennke <[EMAIL PROT

[cp-patches] Patch: FYI: update eclipse javadoc settings

2005-09-13 Thread Tom Tromey
I'm checking this in. I was getting a fair number of warnings for javadoc references to non-visible or deprecated members. The latter seemed reasonable to allow in our code; the former, well, maybe. I'm enabling both, and we can see how it goes. Tom 2005-09-13 Tom Tromey <[EMAIL PROTECTED]>