[cp-patches] FYI: JList.setModel() argument check

2005-11-09 Thread David Gilbert
I committed this small change to fix two failing Mauve tests: 2005-11-09 David Gilbert <[EMAIL PROTECTED]> * javax/swing/JList.java (setModel): throw IllegalArgumentException for null model. Regards, Dave Index: javax/swing/JList.java =

[cp-patches] FYI: Was: gnu_java_awt_peer_gtk_GdkFontPeer.c (initStaticState): missing NewGlobalRef?

2005-11-09 Thread Christian Thalinger
Hi! As discussed on classpath, this one is commited. Maybe more to come... TWISTI 2005-11-09 Christian Thalinger <[EMAIL PROTECTED]> * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkFontPeer.c (initStaticState): Register global variable glyphVector_class as global re

[cp-patches] FYI: BasicTextUI fixlet

2005-11-09 Thread Roman Kennke
I committed this little fixlet for the BasicTextUI. This should solve the problem with textfields where the text is slightly off when displaying right-aligned. 2005-11-09 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicTextUI.java (getVisibleEditorRect): Correctly

Re: [cp-patches] FYI: BasicTextUI fixlet

2005-11-09 Thread David Gilbert
Oddly, this seems to also have fixed a problem with the vertical alignment of text in editable JComboBoxes under the MetalLookAndFeel. I'm very happy about that... Regards, Dave Roman Kennke wrote: I committed this little fixlet for the BasicTextUI. This should solve the problem with textf

Re: [cp-patches] FYI: BasicTextUI fixlet

2005-11-09 Thread David Gilbert
I looked more closely at the patch, and it's not so odd that this problem is fixed. Thanks Roman! Regards, Dave David Gilbert wrote: Oddly, this seems to also have fixed a problem with the vertical alignment of text in editable JComboBoxes under the MetalLookAndFeel. I'm very happy about

[cp-patches] FYI: JComponent fixlet

2005-11-09 Thread Roman Kennke
I committed the attached fix that moves the getComponentGraphics() fetch from paintComponent() to paint(). Some simple tests show that this is the right thing and it also fixes a problem with an app I have here. 2005-11-09 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/JComponent.java

Re: [cp-patches] Patch: implemented InvocationEvent.getThrowable

2005-11-09 Thread Anthony Balkissoon
On Tue, 2005-11-08 at 18:30 -0700, Tom Tromey wrote: > > "Tony" == Anthony Balkissoon <[EMAIL PROTECTED]> writes: > > Tony> Thanks for the advice Mark, I fixed this up and committed it. > Tony> 2005-11-08 Anthony Balkissoon <[EMAIL PROTECTED]> > Tony> * java/awt/event/InvocationEvent

[cp-patches] FYI: ObjectReferenceFactory API fix.

2005-11-09 Thread Meskauskas Audrius
2005-11-09 Audrius Meskauskas <[EMAIL PROTECTED]> * org/omg/PortableInterceptor/ObjectReferenceFactory.java: Do not inherit from org.omg.CORBA.Object Index: org/omg/PortableInterceptor/ObjectReferenceFactory.java === RCS file: /cv

Re: [cp-patches] Patch: implemented InvocationEvent.getThrowable

2005-11-09 Thread Tom Tromey
> "Tony" == Anthony Balkissoon <[EMAIL PROTECTED]> writes: Tony> Ack, okay I'll put it back. For future reference, how do I know Tony> when a field is or isn't required for serialization? The simplest way is to look at the online javadoc. There is a "serialized form" link which shows how th

Re: [cp-patches] Patch: implemented InvocationEvent.getThrowable

2005-11-09 Thread Roman Kennke
Hi there, Am Mittwoch, den 09.11.2005, 10:40 -0500 schrieb Anthony Balkissoon: > On Tue, 2005-11-08 at 18:30 -0700, Tom Tromey wrote: > > > "Tony" == Anthony Balkissoon <[EMAIL PROTECTED]> writes: > > > > Tony> Thanks for the advice Mark, I fixed this up and committed it. > > Tony> 2005-11-08

[cp-patches] FYI: FileChooserDemo

2005-11-09 Thread David Gilbert
I added a demo for the JFileChooser component, and integrated this into the gnu.classpath.examples.swing.Demo class. I also made a change to the latter class so that the buttons at the bottom appear in two rows now, so that the demo frame isn't so wide: 2005-11-09 David Gilbert <[EMAIL PROT

[cp-patches] Patch: JTabbedPane fix

2005-11-09 Thread Lillian Angel
Made this fix because there were several problems when the layout mode was set to SCROLLING. There are still some problems I am working on. 2005-11-09 Lillian Angel <[EMAIL PROTECTED]> * javax/swing/JTabbedPane.java (setComponent): Added check to prevent infinite loops.

[cp-patches] FYI: New 1.5 CORBA classes.

2005-11-09 Thread Meskauskas Audrius
2005-11-09 Audrius Meskauskas <[EMAIL PROTECTED]> * org/omg/PortableInterceptor/ObjectReferenceTemplate.java, * org/omg/PortableInterceptor/ObjectReferenceTemplateHelper.java, * org/omg/PortableInterceptor/ObjectReferenceTemplateHolder.java: New files. ObjectReferenceTemplate.tar.gz Descript

[cp-patches] FYI: Two more CORBA classes

2005-11-09 Thread Meskauskas Audrius
2005-11-09 Audrius Meskauskas <[EMAIL PROTECTED]> * org/omg/PortableInterceptor/ObjectReferenceTemplateSeqHelper.java, * org/omg/PortableInterceptor/ObjectReferenceTemplateSeqHolder.java: New files. /* ObjectReferenceTemplateSeqHolder.java -- Copyright (C) 2005 Free Software Foundation, Inc.

[cp-patches] Patch: ComponentInputMaps implemented

2005-11-09 Thread Anthony Balkissoon
This patch fixes all the FIXME notes in ComponentInputMap and tidies a few places in JComponent relating to ComponentInputMap. The main method however, JComponent.udpateComponentInputMap is not fully implemented because I first have to write a KeyboardManager class, which I'll do now. 2005-11-09

Re: [cp-patches] Patch: implemented InvocationEvent.getThrowable

2005-11-09 Thread Anthony Balkissoon
On Tue, 2005-11-08 at 18:30 -0700, Tom Tromey wrote: > Actually, this field is still required for serialization. Fixed. 2005-11-09 Anthony Balkissoon <[EMAIL PROTECTED]> * java/awt/event/InvocationEvent.java: (exception): Replaced this field (removed yesterday) because it is

[cp-patches] Fix for Eclipse-related Ælfred2 bu g

2005-11-09 Thread Chris Burdess
This fixes a problem in the Ælfred2 SAX parser whereby a MalformedURLException was being thrown even though a custom URI resolver was set on the parser instance. Reported by Michael Koch. 2005-11-09 Chris Burdess <[EMAIL PROTECTED]> * gnu/xml/aelfred2/SAXDriver.java: Ensure that abso

[cp-patches] FYI: [doc] Add cp-tools gjdoc download link

2005-11-09 Thread Mark Wielaard
Hi, It was pointed out that there was no dowload link for cp-tools gjdoc on the website. This fixes that. 2005-11-09 Mark Wielaard <[EMAIL PROTECTED]> * doc/www.gnu.org/cp-tools/cp-tools.wml: Add gjdoc download link. Committed, Mark diff -u -r1.2 cp-tools.wml --- doc/www.gnu.org/cp-tool

[cp-patches] RFC: new VM interface for Socket impls

2005-11-09 Thread Roman Kennke
Hi, Ingo has abstracted out the native code from gnu.java.net.PlainSocketImpl and gnu.java.net.PlainDatagramSocketImpl into a new VM interface. This allows VM implementors to provide a different implementation for the native parts of these classes if they wish. Is this ok to commit as it is? Do yo

Re: [cp-patches] Patch: JTabbedPane fix

2005-11-09 Thread Lillian Angel
Another JTabbedPane fix. 2005-11-09 Lillian Angel <[EMAIL PROTECTED]> * javax/swing/JTabbedPane.java (setComponent): No need to remove and add tab. (remove): Fixed API documentation. (remove): Fixed API documentation. Re-implemented according to API. O

[cp-patches] removing duplicate --enable-xmlj from INSTALL

2005-11-09 Thread Petteri Räty
--enable-xmlj compile native libxml/xslt library default=no This line is twice in INSTALL. The attached patch removes the later one of these. Regards, Petteri Index: INSTALL === RCS file: /cvsroot/classpath/classpath/INST

Re: [cp-patches] Patch: JTabbedPane fix

2005-11-09 Thread Lillian Angel
I made a mistake in my last patch. In setComponent we do need to add and remove the tab, but it is done differently now. Before it was adding the tab with no title (therefore adding an empty tab), and removing it by calling the wrong remove function. This is now fixed. 2005-11-09 Lillian Angel <

[cp-patches] Patch (Suggestions Needed): JComponent key bindings

2005-11-09 Thread Anthony Balkissoon
This patch implements the package-private class javax.swing.KeyboardManager and makes some adjustments in JComponent to allow keybindings registered with the condition WHEN_IN_FOCUSED_WINDOW to work. This mechanism is not 100% correct yet. Attached is a test case that works. Click on the JButt

Re: [cp-patches] removing duplicate --enable-xmlj from INSTALL

2005-11-09 Thread Mark Wielaard
Hi Petteri, On Wed, 2005-11-09 at 23:37 +0200, Petteri Räty wrote: > --enable-xmlj compile native libxml/xslt library default=no > > This line is twice in INSTALL. The attached patch removes the later one > of these. Thanks. Committed as follows: 2005-11-09 Mark Wielaard <[EMAIL P

[cp-patches] FYI: InputStreamReader fixlet

2005-11-09 Thread Roman Kennke
Hi, The jIRCii app passes a CharseetDecoder to InputStreamReader that returns null for charset() (its named NoConversion). This must be catched in the InputStreamReader constructor. 2005-11-09 Roman Kennke <[EMAIL PROTECTED]> * java/io/InputStreamReader.java (InputStreamReader(

RE: [cp-patches] RFC: Remove lowercasing of Windows paths

2005-11-09 Thread Roman Kennke
Am Mittwoch, den 26.10.2005, 15:26 +0200 schrieb Jeroen Frijters: > Roman Kennke wrote: > > Ingo found a bug in the Windows path handling. In the PlatformHelper > > class we lowercase all Windows paths. This is kind of naive and > > shortsighted, because paths are not only file system paths, > > b

Re: [cp-patches] RFC: small PrintWriter improvement

2005-11-09 Thread Roman Kennke
Am Mittwoch, den 26.10.2005, 10:39 +0200 schrieb Roman Kennke: > Hi, > > here comes another fix from Friedjof Siebert that ensures that the field > line_separator is not null (in the unlikely but not impossible case that > the system property is not set). > > 2005-10-26 Roman Kennke <[EMAIL PRO

Re: [cp-patches] RFC: WeakHashMap improvement

2005-11-09 Thread Roman Kennke
Hi, Am Mittwoch, den 26.10.2005, 10:37 +0200 schrieb Roman Kennke: > Hi, > > Friedjof Siebert did some improvements on java.util.WeakHashMap that I'd > like to check in. They are meant to improve reliability of this class by > enabling the prove of a cast and the absence of a null-pointer. > > 2

Re: [cp-patches] RFC: WeakHashMap improvement

2005-11-09 Thread Mark Wielaard
Hi Roman, On Wed, 2005-11-09 at 23:52 +0100, Roman Kennke wrote: > + if (next == null) throw new InternalError("WeakHashMap in incosistent > state"); As Tom pointed out in the first review inconsistent is not spelled correctly here. Cheers, Mark signature.asc Description: This is a digita

Re: [cp-patches] RFC: WeakHashMap improvement

2005-11-09 Thread Tom Tromey
> "Roman" == Roman Kennke <[EMAIL PROTECTED]> writes: Two nits... Roman> + if (next == null) throw new InternalError("WeakHashMap in incosistent state"); This should not all be on one line. Also, 'inconsistent' is misspelled here. Tom _

[cp-patches] Patch: WHEN_IN_FOCUSED_WINDOW bindings implemented

2005-11-09 Thread Anthony Balkissoon
Thanks to rabbit78 and fitzsim I figured out the problems discussed earlier on the list. This patch re-registers WHEN_IN_FOCUSED_WINDOW bindings when a JComponent is added to a Container because its top level container may have changed. The testcase from my last email now works even when the butt

Re: [cp-patches] FYI: InputStreamReader fixlet

2005-11-09 Thread Tom Tromey
> "Roman" == Roman Kennke <[EMAIL PROTECTED]> writes: Roman> * java/io/InputStreamReader.java Roman> (InputStreamReader(InputStream, CharsetDecoder)): Catch the case Roman> when the CharsetDecoder returns a null charset and handle it like Roman> US-ASCII. Do we really want this to default to