Re: [cp-patches] Patch: remove bogus ServerSocket security check

2006-01-03 Thread Gary Benson
Mark Wielaard wrote: On Mon, 2005-12-26 at 19:05 -0800, Anthony Green wrote: This patch removes a bogus security check from ServerSocket.accept(), and replaces it with a request to implement a proper check. Once applied I will file a bug report for our records. Gary, do we have Mauve

Re: [cp-patches] java.security.Security

2006-01-03 Thread Raif S. Naffah
hello Mark, On Tuesday 03 January 2006 07:42, Mark Wielaard wrote: Hi, On Tue, 2006-01-03 at 01:34 +1100, Raif S. Naffah wrote: 2006-01-03 raif [EMAIL PROTECTED] * java/security/Security.java (getProvider): Ensures provider's name is not null, not an empty string, and is trimmed

[cp-patches] FYI: ElementBuffer.remove(Update) implemented

2006-01-03 Thread Roman Kennke
Hi, I implemented the missing methods javax.swing.text.DefaultStyledDocument.ElementBuffer.remove() and removeUpdate(). 2006-01-03 Roman Kennke [EMAIL PROTECTED] * javax/swing/text/DefaultStyledDocument.java (ElementBuffer.remove): New method.

[cp-patches] FYI: BasicListUI fix

2006-01-03 Thread Roman Kennke
This patch fixes JList rendering and size calculations for wrapping JLists. 2006-01-03 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicListUI.java (locationToIndex): Special case for when variable cell heights are possible. (cellHeights is used instead of

[cp-patches] FYI: Avoid ArrayIndexOutOfBoundsException in BasicListUI

2006-01-03 Thread Roman Kennke
The attached patch helps avoiding an ArrayIndexOutOfBoundsException in the BasicListUI. 2006-01-03 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicListUI.java (locationToIndex): Added check to avoid ArrayOutOfBoundsException. /Roman Index:

[cp-patches] Patch: FileChooser - small fixes

2006-01-03 Thread Lillian Angel
I made a small fix to match the JDK and I took out some inefficent code. 2006-01-03 Lillian Angel [EMAIL PROTECTED] * javax/swing/JList.java (init): visibleRowCount should be 7, like the JDK. * javax/swing/plaf/metal/MetalFileChooserUI.java (installComponents):

[cp-patches] Patch: JFileChooser width

2006-01-03 Thread Lillian Angel
Fixed the width of the JFileChooser. 2006-01-03 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicListUI.java (getPreferredSize): The JDK adds some extra space to the list, so we should as well. * javax/swing/plaf/metal/MetalFileChooserUI.java

Re: [cp-patches] FYI: Avoid ArrayIndexOutOfBoundsException in BasicListUI

2006-01-03 Thread Chris Lansdown
I tested it out, and it's not so much the row of what you click on, but the size of the directory which you enter. This patch isn't enough, because the problem is also that the visible row count never gets set. When you go into a directory with fewer than 8 elements, this array tries to iterate

[cp-patches] Patch: Constructor fixes

2006-01-03 Thread Lillian Angel
I fixed some constructor problems in several swing classes. These were pointed out by several mauve tests. 2006-01-03 Lillian Angel [EMAIL PROTECTED] * javax/swing/AbstractAction.java (AbstractAction): Fixed to pass in null. Should not be an empty string. Removed TODO

[cp-patches] Patch: Tree selection default

2006-01-03 Thread Lillian Angel
Fixed tree selection default. 2006-01-03 Lillian Angel [EMAIL PROTECTED] * javax/swing/tree/DefaultTreeSelectionModel.java (DefaultTreeSelectionModel): Default should be DISCONTIGUOUS_TREE_SELECTION. Index: javax/swing/tree/DefaultTreeSelectionModel.java

Re: [cp-patches] FYI: BasicLookAndFeel defaults

2006-01-03 Thread Lillian Angel
On Tue, 2006-01-03 at 14:51 -0500, Lillian Angel wrote: Obviously, with these changes, other bugs may be exposed. I fixed all the problems that were caused as a result of my last patch. 2006-01-03 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicFileChooserUI.java

Re: [cp-patches] RFC: JTextArea text == null in constructor patch

2006-01-03 Thread Roman Kennke
Hi Mark, Am Dienstag, den 03.01.2006, 20:57 +0100 schrieb Mark Wielaard: Hi, While playing with JEdit I encountered an exception because JEdit has a JTextArea subclass that doesn't expect its overridden setText() method to be called from the constructor. This patch makes it so:

[cp-patches] RFC: GdkGraphics2D.setBackground() set to white if null

2006-01-03 Thread Mark Wielaard
Hi, I had some trouble using Graphics2D with JEdit and myPod. This patch helps by making sure the background color is always set: 2006-01-03 Mark Wielaard [EMAIL PROTECTED] * gnu/java/awt/peer/gtk/GdkGraphics2D.java (setBackground): Set to Color.WHITE if null. This was inspired by

Re: [cp-patches] RFC: GdkGraphics2D.setBackground() set to white if null

2006-01-03 Thread Mark Wielaard
Hi, On Tue, 2006-01-03 at 23:20 +0100, Mark Wielaard wrote: 2006-01-03 Mark Wielaard [EMAIL PROTECTED] * gnu/java/awt/peer/gtk/GdkGraphics2D.java (setBackground): Set to Color.WHITE if null. This was inspired by setColor() which does the same (but defaults to black). What do

[cp-patches] FYI: Always call MetalLookAndFeel.createDefaultTheme()

2006-01-03 Thread Mark Wielaard
Hi, The KunstoffLookAndFeel (as used by myPod) depends on createDefaultTheme() always being called since it overrides it to set the theme. So this patch makes it so. 2006-01-03 Mark Wielaard [EMAIL PROTECTED] * javax/swing/plaf/metal/MetalLookAndFeel.java (MetalLookAndFeel): Always call

[cp-patches] Re: compiling Classpath on cigwin/win

2006-01-03 Thread Mark Wielaard
Hi Paul, On Tue, 2006-01-03 at 22:20 +, Paul Jenner wrote: On Tue, 2006-01-03 at 23:12 +0100, Mark Wielaard wrote: O, interesting. The class comment in that file contains some strange characters. Does removing them help? Just noticed that myself. Yep - remove the odd characters and

Re: [cp-patches] FYI: BasicListUI fix

2006-01-03 Thread Chris Lansdown
Roman, The loops loop like they will throw an OOB exception if the mouse click is below the last item, if there are too few items. Am I missing something? Thanks, Chris Lansdown On 01/03, Roman Kennke wrote: This patch fixes JList rendering and size calculations for wrapping JLists.

[cp-patches] RFC: JMenuItem null accelerators

2006-01-03 Thread Mark Wielaard
Hi, At various points we try to register a null KeyStroke with an InputMap. This gives some problems later on when InputMaps are copied because null entries aren't always expected. Does the following patch make sense? 2006-01-03 Mark Wielaard [EMAIL PROTECTED] * javax/swing/JMenuItem.java

[cp-patches] Patch: FYI: @since updates

2006-01-03 Thread Tom Tromey
I'm checking this in. I happened to notice that a few constructors were missing @since tags. Tom 2006-01-03 Tom Tromey [EMAIL PROTECTED] * java/io/OutputStreamWriter.java (OutputStreamWriter): Added @since. * java/io/InputStreamReader.java (InputStreamReader): Added @since.

[cp-patches] RFC: AX_CREATE_STDINT.m4

2006-01-03 Thread Dalibor Topic
Hi all, the attached patch adds a generated header for C99 fixed-size integer types that delegates to the underlying implementation (stdint.h, inttypes.h) and/or creates typedefs for the missing types. The patch uses the ax_create_stdint.m4 macro from Guido Draheim, taken from