[cp-patches] FYI: Rectangle.setRect() - modified rounding

2006-09-04 Thread David Gilbert
This patch (committed) changes the rounding used in the setRect() method: 2006-09-04 David Gilbert <[EMAIL PROTECTED]> * java/awt/Rectangle.java (setRect(double, double, double, double)): Modified rounding of input values. I have Mauve tests for this and will commit th

Re: [cp-patches] RFC: PR Classpath/28664 - GNU MP based BigInteger(compressed)

2006-09-04 Thread Raif S. Naffah
> On Sunday 03 September 2006 18:02, Jeroen Frijters wrote: > > ... > > Most people do not understand the (security) implications of using > > native code in combination with handles and most of the code out there > > is simply wrong (as is the current patch). See [1]. > > i'll have to read this do

RE: [cp-patches] RFC: PR Classpath/28664 - GNU MP based BigInteger(compressed)

2006-09-04 Thread Jeroen Frijters
Raif S. Naffah wrote; > i followed the advice given in [1] and synchronized the code > in the BigInteger finalize() method which now looks like so: This is not yet sufficient. *All* native method calls that use the native_ptr need to be synchronized. It is also not very good practice to synchron

Re: [cp-patches] RFC: PR Classpath/28664 - GNU MP based BigInteger (compressed)

2006-09-04 Thread Raif S. Naffah
hello Robert, On Sunday 03 September 2006 23:30, Robert Lougher wrote: > ... > Try commenting out the code in the function: > > setDoublePrecision() located in jamvm/src/os/linux/i386/init.c > > This changes the precision of the FPU to 64 bits from extended 80-bit > precision which is the Linux de

Re: [cp-patches] RFC: PR Classpath/28664 - GNU MP based BigInteger(compressed)

2006-09-04 Thread Raif S. Naffah
On Monday 04 September 2006 20:40, Jeroen Frijters wrote: > ... > ...*All* native method calls that use the > native_ptr need to be synchronized. i'm sorry but it is still not obvious to me why this should be so. every instance of a BigInteger has its own value of native_ptr. what are we protec

RE: [cp-patches] RFC: PR Classpath/28664 - GNU MP based BigInteger(compressed)

2006-09-04 Thread Jeroen Frijters
Raif S. Naffah wrote: > On Monday 04 September 2006 20:40, Jeroen Frijters wrote: > > ... > > ...*All* native method calls that use the > > native_ptr need to be synchronized. > > i'm sorry but it is still not obvious to me why this should > be so. every instance of a BigInteger has its own value

Re: [cp-patches] Merge NATIVE-LAYER to HEAD

2006-09-04 Thread Andrew John Hughes
On Mon, 2006-08-21 at 02:56 +0200, Mark Wielaard wrote: ... > > 2006-08-20 Mark Wielaard <[EMAIL PROTECTED]> ... > * native/jni/java-lang/java_lang_VMProcess.c > (Java_java_lang_VMProcess_nativeSpawn): Remove redirect argument. ... > * vm/reference/java/lang/VMProcess.java: Removed u

[cp-patches] Re: XPath test still not commited?

2006-09-04 Thread Chris Burdess
On 25 Aug 2006, at 13:23, Mario Torre wrote: Il giorno ven, 25/08/2006 alle 13.01 +0100, Chris Burdess ha scritto: Mark Wielaard wrote: The XPath test i submitted on August 16 has still not been committed. As this was my first submission to this list, It's quite possible I did something wro

Re: [cp-patches] Merge NATIVE-LAYER to HEAD

2006-09-04 Thread Mark Wielaard
On Mon, 2006-09-04 at 22:30 +0100, Andrew John Hughes wrote: > On Mon, 2006-08-21 at 02:56 +0200, Mark Wielaard wrote: > ... > > > > 2006-08-20 Mark Wielaard <[EMAIL PROTECTED]> > ... > > * native/jni/java-lang/java_lang_VMProcess.c > > (Java_java_lang_VMProcess_nativeSpawn): Remove redi