Re: [cp-patches] Patch: RFC: javax.sound.sampled

2005-11-13 Thread Michael Koch
On Sat, Nov 12, 2005 at 05:51:55PM -0700, Tom Tromey wrote: > I'm not checking this in yet. I haven't really done much testing of > it, and I wanted some feedback first as well. > > This implements javax.sound.sampled and javax.sound.sampled.spi. I would say: Please commit. Bugs can be fixed lat

Re: [cp-patches] FYI: New ProgressBar demo

2005-11-14 Thread Michael Koch
Hi Roman, Your patch looks really strange. :-) > Checking in examples/gnu/classpath/examples/swing/Demo.java; > /cvsroot/classpath/classpath/examples/gnu/classpath/examples/swing/Demo.java,v > <-- Demo.java > new revision: 1.29; previous revision: 1.28 > done > RCS file: > /cvsroot/class

Re: [cp-patches] FYI: Added some real functionality to SystemFlavorMap

2005-11-28 Thread Michael Koch
On Tue, Nov 29, 2005 at 12:33:29AM +0100, Jan R?hrich wrote: > I started to exchange some of SystemFlavorMaps implementation to a > version with real functionality. Btw. I implemented the methods that > were missing to JDK1.4 interface conformance. ... > + /** > + * This map maps native String

[cp-patches] RFC: new release of gjdoc

2005-12-18 Thread Michael Koch
- @@ -1,3 +1,7 @@ +2005-11-30 Michael Koch <[EMAIL PROTECTED]> + + * configure.ac (AC_INIT): Set version to 0.7.7. + 2005-11-30 Stephan Michels <[EMAIL PROTECTED]> PR gjdoc/24722: Index: configure.ac ===

Re: [cp-patches] Patch: FYI: URI fixlet

2005-02-08 Thread Michael Koch
On Tue, Feb 08, 2005 at 07:52:08PM -0700, Tom Tromey wrote: > I'm checking this in to libgcj and classpath. > > This fixes a bug in URI. The user and port parts of the authority > are optional. I think this used to "work" but a recent bug fix to > regex broke it. > > I've checked in a test case

[cp-patches] [Patch] java.awt.Scrollbar reformatted

2005-02-08 Thread Michael Koch
Hi list, I just commited the attached patch to reformat the file java/awt/Scrollbar.java. No code changes. Michael 2005-02-09 Michael Koch <[EMAIL PROTECTED]> * java/awt/Scrollbar.java: Reformatted. Index: java/awt/Scrollba

Re: [cp-patches] Suggested patch: java/text/Collator.java

2005-02-10 Thread Michael Koch
On Thu, Feb 10, 2005 at 11:11:10AM +0100, Jeroen Frijters wrote: > Hi, > > I'd like to apply the attached patch to make Collator.getInstance() work > even if the required resource is missing (as it currently is) and to > throw an InternalError instead of returning null should the rules fail > to p

[cp-patches] [Patch] java.awt.Container.paramString()

2005-02-10 Thread Michael Koch
Hi list, I just commited the attached patch to fix a silly bug in java.awt.Container.paramString(). Michael 2005-02-10 Michael Koch <[EMAIL PROTECTED]> * java/awt/Container.java (paramString): If layoutMgr is null just return result of super.paramString(). Index: ja

[cp-patches] [Patch] gnu_java_awt_peer_gtk_GtkImagePainter.c

2005-02-10 Thread Michael Koch
Hi list, I commited the attached patch to merge gnu_java_awt_peer_gtk_GtkImagePainter.c with java-gui-20050128-branch. Michael 2005-02-10 Michael Koch <[EMAIL PROTECTED]> * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkImagePainter.c: Merged file header from ja

[cp-patches] [Patch] Releasing of GDK lock

2005-02-10 Thread Michael Koch
Hi list, I just commited the attached patch to merge a patch by Graydon Hoare from java-gui-20080128-branch. It releases the GDK lock while doing gdk/gtk calls. Michael 2005-02-10 Graydon Hoare <[EMAIL PROTECTED]> * jni/gtk-peer/gnu_java_awt_peer_gtk_GtkEvents.c, jni/gtk-pe

[cp-patches] [Patch][gui] JTabbedPane

2005-02-10 Thread Michael Koch
Hi list, I commited the attached patch to fix a method in javax.swing.JTabbedPane. Michael 2005-02-10 Michael Koch <[EMAIL PROTECTED]> * javax/swing/JTabbedPane.java (Page.setDisplayedMnemonicIndex): Handle empty menmonic. Index: javax/swing/JTabbedPan

[cp-patches] [Patch] gnu.java.awt.peer.gtk.GdkGraphics2D and CAIRO support

2005-02-10 Thread Michael Koch
Hi list, gnu.java.awt.peer.gtk.GdkGraphics2D is useless without CAIRO support. I disabled its usage in gnu.java.awt.peer.gtk.GtkToolkit when CAIRO is not available. Michael 2005-02-10 Michael Koch <[EMAIL PROTECTED]> * configure.ac: Define GTK_CAIRO in config.h *

[cp-patches] [Patch] fix GTK FileDialog peer crashes

2005-02-11 Thread Michael Koch
Hi list, I merged the attached patch from GCC. Michael Tom's messgae was: This patch fixes the GTK FileDialog peer crashes. gnome-vfs's cancellation code is not thread-safe and we were calling it from multiple threads. This caused gnome_vfs_is_primary_thread to fail, triggering an assertio

[cp-patches] [Patch] Regenerated JNI headers

2005-02-12 Thread Michael Koch
Hi list, I regenerated two JNI headers which were originally generated by an too old version of gcjh. Michael 2005-02-12 Michael Koch <[EMAIL PROTECTED]> * include/gnu_java_awt_peer_gtk_GdkFontPeer.h, include/gnu_java_awt_peer_gtk_GdkGraphics2D.h: Regen

Re: [cp-patches] PING: java.util.Locale getISO* patch

2005-02-16 Thread Michael Koch
On Wed, Feb 16, 2005 at 01:30:10AM +, Andrew John Hughes wrote: > On Wed, 2005-01-05 at 16:19 +, Andrew John Hughes wrote: > > Hi all, > > > > Attached is a patch to change the getISOLanguages() and > > getISOCountries() > > methods to retrieving the data dynamically from the > > gnu

[cp-patches] [Patch] cleanup

2005-02-16 Thread Michael Koch
Hi list, I just commited the patch to fix some little issues. Michael 2005-02-16 Michael Koch <[EMAIL PROTECTED]> * java/awt/EventQueue.java: Reworked import statements. * java/lang/StringBuilder.java (DEFAULT_CAPACITY): Reordered modifiers. * jav

[cp-patches] [Patch] more cleanups of author tags

2005-02-16 Thread Michael Koch
Hi list, Here is the next cleanup patch that fixes the usage of the @author tag in the rest of then java.* packages. Michael 2005-02-16 Michael Koch <[EMAIL PROTECTED]> * java/applet/Applet.java, java/beans/AppletInitializer.java, java/beans/ExceptionListene

[cp-patches] [Patch] author tag cleanup in javax.*

2005-02-16 Thread Michael Koch
Hi list, I just commited the attached patch to cleanup the usage of the @author tag in javax.*. Michael 2005-02-16 Michael Koch <[EMAIL PROTECTED]> * javax/accessibility/Accessible.java, javax/accessibility/AccessibleAction.java, javax/accessi

[cp-patches] [Patch] fixed html in our javadoc comments

2005-02-16 Thread Michael Koch
Hi list, I just commited the attached patch to fix the usage of HTML in our javadoc comments. Michael 2005-02-16 Michael Koch <[EMAIL PROTECTED]> * java/awt/geom/Ellipse2D.java, java/beans/PropertyDescriptor.java, java/net/NetworkInterface.java, ja

[cp-patches] [Patch] fixed author tag in javax.xml

2005-02-16 Thread Michael Koch
Hi list, I just commited the last patch that fixes the usage of the @author tag. Michael 2005-02-16 Michael Koch <[EMAIL PROTECTED]> * javax/xml/XMLConstants.java, javax/xml/datatype/DatatypeConfigurationException.java, javax/xml/datatype/DatatypeConstant

[cp-patches] [Patch] updated checkstyle configuration

2005-02-16 Thread Michael Koch
Hi list, I just commited the attached patch to check some more stuff with checkstyle in classpath. An explanation on how to run checkstyle follows. Michael 2005-02-16 Michael Koch <[EMAIL PROTECTED]> * scripts/checkstyle-config.xml: Activate JavadocSty

[cp-patches] [Patch] made GTK peer checkstyle clean

2005-02-16 Thread Michael Koch
Hi list, I commited the attached patch to make the java part of our GTK peer checkstyly clean. Michael 2005-02-16 Michael Koch <[EMAIL PROTECTED]> * gnu/java/awt/peer/gtk/GThreadNativeMethodRunner.java, gnu/java/awt/peer/gtk/GdkFontPeer.java, gnu/java/awt/pe

[cp-patches] [Patch] FileChannelImpl.write

2005-02-17 Thread Michael Koch
Hi list, I just commited the attached patch from Ito to fix a little issue. A mauve testcase backs this patch. Michael 2005-02-17 Ito Kazumitsu <[EMAIL PROTECTED]> * gnu/java/nio/channels/FileChannelImpl.java (write(ByteBuffer)): Move the position of the source buffer forwa

Re: [cp-patches] ChannelReader .. again

2005-02-17 Thread Michael Koch
On Fri, Feb 18, 2005 at 03:43:33AM +0100, Robert Schuster wrote: > Hi. > I think I have fixed the remaining bits in the ChannelReader. This patch > adds support for the two missing constructors in > java.io.InputStreamReader and implements both variants of > java.nio.newChannel correctly (not be

[cp-patches] [Patch] java.awt.font.TransformAttribute

2005-02-18 Thread Michael Koch
it is + * not possible to modify the stored transform. + * * @author Michael Koch */ public final class TransformAttribute implements Serializable @@ -50,20 +57,40 @@ private AffineTransform affineTransform; + /** + * Creates a new attribute that contains a copy of the given tra

Re: [cp-patches] Small Throwable patch

2005-02-19 Thread Michael Koch
On Fri, Feb 18, 2005 at 09:05:29PM -0600, Archie Cobbs wrote: > I'm planning to commit this patch. The reason for it is that the > logic of initCause() is unnecessary in the constructor, and represents > unnecessary overhead which we pay for every time a chained exception > is created. The effect i

[cp-patches] [Patch] javax.swing.JToggleButton

2005-02-19 Thread Michael Koch
Hi list, I just commited the attached patch to merge javax/swing/JToggleButton.java with GCC trunk CVS. Michael 2005-02-19 Michael Koch <[EMAIL PROTECTED]> * javax/swing/JToggleButton.java: Removed empty line. Index: javax/swing/JToggleButto

Re: [cp-patches] [Patch] updated locale data from latest CLDR data

2005-02-20 Thread Michael Koch
On Sun, Feb 20, 2005 at 04:11:31AM +0100, Mark Wielaard wrote: > Hi Michael, > > On Sat, 2005-02-19 at 23:19 +0100, Michael Koch wrote: > > I updated our locale date against recent CLDR data. > > Something transformed the attached bz2 file to plain/text for me. > Any i

[cp-patches] [Patch] gnu.java.rmi.registry.RegistryImpl

2005-02-20 Thread Michael Koch
Hi list, I commited the attached patch from Anthony Green to merge gnu.java.rmi.registry.RegistryImpl with libgcj. Michael 2005-02-21 Anthony Green <[EMAIL PROTECTED]> * gnu/java/rmi/registry/RegistryImpl.java: Change year for '--version' to 2005. Index: gnu/java/rmi/regis

[cp-patches] [Patch] formatting cleanup

2005-02-21 Thread Michael Koch
Hi list, I just the attached patch to cleanup some formatting issues. Michael 2005-02-21 Michael Koch <[EMAIL PROTECTED]> * java/awt/Button.java, java/awt/Container.java, java/awt/Font.java, java/awt/Frame.java, jav

[cp-patches] [Patch] another formatting cleanup patch

2005-02-21 Thread Michael Koch
Hi list, I just commited that attached formatting cleanup patch to fix some small issues. Michael 2005-02-21 Michael Koch <[EMAIL PROTECTED]> * java/lang/Class.java, java/lang/SecurityManager.java, java/net/URL.java: Formatting cleanups. Index: jav

[cp-patches] [Patch] gnu_java_nio_channels_FileChannelImpl.h

2005-02-21 Thread Michael Koch
Hi list, I just commited the attached patch with a regenerated gnu_java_nio_channels_FileChannelImpl.h. Michael 2005-02-21 Michael Koch <[EMAIL PROTECTED]> * include/gnu_java_nio_channels_FileChannelImpl.h: Regenerated. Index: i

[cp-patches] [Patch] java.awt.CheckBox and java.awt.Window

2005-02-21 Thread Michael Koch
i list, the attached patch adds generation of widget names for java.awt.CheckBox and java.awt.Window objects. Its that way this is done in other widgets in java.awt. Michael 2005-02-21 Michael Koch <[EMAIL PROTECTED]> * java/awt/Checkbox.java (next_checkbox_number

[cp-patches] [Patch] Robot.waitForIdle

2005-02-21 Thread Michael Koch
Hi list, I commited the attached patch. This patch fixes java.awt.Robot's waitForIdle implementation and corrects a typo in the documentation. Michael 2005-02-22 Thomas Fitzsimmons <[EMAIL PROTECTED]> * java/awt/Robot.java (waitForIdle): Call invokeAndWait on an empty Runna

[cp-patches] [Patch] Fixing handling of frame extents

2005-02-21 Thread Michael Koch
ght methods. * jni/gtk-peer/gtkpeer.h (postInsetsChangedEventID): Declare jmethodID. (windowGetWidthID): Likewise. (windowGetHeightID): Likewise. 2005-02-22 Michael Koch <[EMAIL PROTECTED]> * include/gnu_java_awt_peer_gtk_GtkWindowPeer.h: Regenerated.

[cp-patches] [Patch] replace snprintf with g_snprintf

2005-02-22 Thread Michael Koch
Hi list, I just merged the attached patch from GCC trunk branch. For GCC this fixed a compiler warning but this warning doesnt happened for classpath. I wonder why ... Michael 2005-02-22 Thomas Fitzsimmons <[EMAIL PROTECTED]> * native/jni/gtk-peer/gthread-jni.c (throw): Cal

[cp-patches] [Patch] mouse button modifiers in gtk peer

2005-02-22 Thread Michael Koch
Hi list, I just commited the attached patch to merge it from GCC trunk branch. button_to_awt_mods was returning the new-style modifier masks where it should have been returning the old-style ones. Michael 2005-02-22 Thomas Fitzsimmons <[EMAIL PROTECTED]> * native/jni/gtk-peer/gnu_j

[cp-patches] [Patch] copyright header fixes

2005-02-22 Thread Michael Koch
Hi list, I commited the attached patch to make our comparison tool recognize these files as merged between classpath and libgcj. In fact they are merged but the copright was not prepared for the script to be considered as merged. Michael 2005-02-22 Michael Koch <[EMAIL PROTEC

[cp-patches] [Patch] java.awt.font.TextAttribute

2005-02-23 Thread Michael Koch
Hi list, I just commited the attached patch to fix some little issues in java.awt.font.TextAttribute and add some javadocs. Michael 2005-02-24 David Gilbert <[EMAIL PROTECTED]> * java/awt/font/TextAttribute.java: changed names to lower case; (readResolve): implemented.

Re: [cp-patches] Fixing inaccurate work of javax.swing.Timer

2005-02-23 Thread Michael Koch
On Wed, Feb 23, 2005 at 06:17:31PM +0100, Meskauskas Audrius wrote: > The javax.swing.Timer fires action events. It has two properties, one > specifying the waiting time before firing the first action event, and another > the time > gap between firing the subsequent events. > > The new Mauve te

[cp-patches] [Patch] gnu.java.net.BASE64

2005-02-24 Thread Michael Koch
Hi list, I just merged the attached fix from GNU inetlib. Michael 2005-02-24 Chris Burdess <[EMAIL PROTECTED]> * BASE64.java: Truncate encoded byte array. Index: gnu/java/net/BASE64.java === RCS file: /cvsroot/classpa

Re: [cp-patches] Fixing the incorrect work of javax.swing.Timer.getInitialDelay()

2005-02-24 Thread Michael Koch
On Thu, Feb 24, 2005 at 12:28:55PM +0100, Meskauskas Audrius wrote: > 1. The Mauve test indicates the wrong work of > javax.swing.Timer.getInitialDelay() immediately after calling the > constructor. Regardless of that was passed to > the constructor, getInitialDelay() always returns 0. > > 2. A

Re: [cp-patches] Suggesting headers for public methods for javax.swing.Timer

2005-02-24 Thread Michael Koch
On Thu, Feb 24, 2005 at 10:37:56PM +0100, Meskauskas Audrius wrote: > This class is undocumented. I suggest some headers at least for for public > methods and also tried to apply several Michael's recommendations on > formatting. > The code itself is not altered. Some comments from me. >@@ -34

[cp-patches] [Patch] java.net.InetAddress.toString()

2005-02-25 Thread Michael Koch
Hi list, I commited the attached patch from Sven de Morathy to fix on bug in InetAddress.troString(). Michael 2005-02-25 Sven de Marothy <[EMAIL PROTECTED]> * java/net/InetAddress.java (toString): Don't print empty hostnames. Fixes bug #11956 Index: java/net/InetAd

Re: [cp-patches] Suggested formatting for javax.swing.timer: second version

2005-02-25 Thread Michael Koch
On Fri, Feb 25, 2005 at 04:43:27PM +0100, Meskauskas Audrius wrote: > This path replaces "documentme" with documentation comments. > > >From the previous discussion it seems that it is problematic to discuss the > whitespace using pathes. Instead, the complete java file with suggested > comments

[cp-patches] Re: Usage of the @see tags

2005-02-25 Thread Michael Koch
On Fri, Feb 25, 2005 at 10:22:45PM +0100, Meskauskas Audrius wrote: > >The @see tag should be used inline in the javadocs instead of the > >somemethod() constructs, as discussed privately. > >Michael > What exactly do you mean? > > The @see tag is not used inline. All @see tags must be grouped und

Re: [cp-patches] Suggested formatting for javax.swing.timer: third version

2005-02-26 Thread Michael Koch
On Sat, Feb 26, 2005 at 12:31:14AM +0100, Meskauskas Audrius wrote: > This path replaces "documentme" with documentation comments. > > >From the previous discussion it seems that it is problematic to discuss the > whitespace using pathes. Instead, the complete java file with suggested > comments a

Re: [cp-patches] JList fix

2005-02-26 Thread Michael Koch
On Sat, Feb 26, 2005 at 11:32:48AM +0100, Roman Kennke wrote: > Index: ChangeLog > === > RCS file: /cvsroot/classpath/classpath/ChangeLog,v > retrieving revision 1.3262 > diff -r1.3262 ChangeLog > 0a1,6 > > 2005-02-26 Roman Kennke <

Re: [cp-patches] JList fix

2005-02-26 Thread Michael Koch
On Sat, Feb 26, 2005 at 05:33:42PM +0100, Roman Kennke wrote: > > > > I think that is okay for now. We can later optimize this. > > IMO that's not a very good approach, because chances are good that this > will long/never be touched again. Also, I have found a way of having a > notification of r

Re: [cp-patches] fixing the JTextArea.replaceRange

2005-02-26 Thread Michael Koch
On Sat, Feb 26, 2005 at 08:00:58PM +0100, Meskauskas Audrius wrote: > The Mauve test gnu.testlet.javax.swing.JTextArea.text indicates the incorrect > work of the text replacement methods in JTextArea. For example, if the string > is > "0123456789", the replaceRange(3,5, "replacement") should res

Re: [cp-patches] No more suggestions for formatting the javax.swing.timer

2005-02-26 Thread Michael Koch
On Sat, Feb 26, 2005 at 09:21:27PM +0100, Meskauskas Audrius wrote: > >The javadoc for queueLock is a bit suspicios. Perhaps it should better > >read as "Locking object for the queue.". > > This is true.The Java programming language does not allow to put a lock on > the 'long', only on objects, a

Re: [cp-patches] wrapping-capable JList

2005-02-26 Thread Michael Koch
On Sat, Feb 26, 2005 at 11:52:07PM +0100, Roman Kennke wrote: > Hi there again, > > I again improved the JList implementation so that is now aware of the > property layoutOrientation. To get a quick view of how a wrapping list > may look like please refer to the screenshot at (the left one): > >

Re: [cp-patches] Aelfred2 cleanup patch

2005-02-27 Thread Michael Koch
On Sun, Feb 27, 2005 at 12:42:31PM +, Chris Burdess wrote: > I'd like to apply the following patch to Classpath in order to > improve readability and maintainability of the Aelfred2 SAX parser. It's > pretty huge, but there are few logical changes and it has been tested with > no regressions.

Re: [cp-patches] Fixing the selection handling in JTextComponent.

2005-02-27 Thread Michael Koch
On Sat, Feb 26, 2005 at 07:58:41PM +0100, Meskauskas Audrius wrote: > The Mauve test have indicated wrong work of the > JTextComponent.getSelectedText(). For example, if the text is 0123456789 and > the selection covers the interval > 2..5, the expected value is '234' and the returned value is '

Re: [cp-patches] Fixing item event management in JComboBox

2005-02-27 Thread Michael Koch
On Sun, Feb 27, 2005 at 05:27:56PM +0100, Meskauskas Audrius wrote: > When changing a selected item, JComboBox always fires two item events. The > first is the deselection event, notifying, that the previously selected item > is no > longer selected. Next follows the selection event, notifying a

Re: [cp-patches] Formatting change of JTextComponent.java

2005-02-27 Thread Michael Koch
On Sun, Feb 27, 2005 at 05:25:53PM +0100, Meskauskas Audrius wrote: > This path replaces occuring tabs by spaces, assuming the tabulation size 8. > The code layout and content is not changed. While some lines look shifted in > the > path file, this seems being because the + and tab results the c

Re: [cp-patches] FYI: some fixlets for javax.swing.plaf.basic.BasicListUI

2005-02-27 Thread Michael Koch
On Sun, Feb 27, 2005 at 05:03:42PM +0100, Roman Kennke wrote: > I committed the attached patch, which fixes the modifiers of several > fields, methods and inner classes of javax.swing.plaf.basic.BasicListUI > to match the spec. > > /Roman > > Index: ChangeLog > ==

Re: [cp-patches] Formatting change of JTextComponent.java

2005-02-27 Thread Michael Koch
On Sun, Feb 27, 2005 at 06:48:25PM +0100, Meskauskas Audrius wrote: > Because otherwise the path is impossible to read, as my text editor was > configured not to use tabs. As a result, the path contains instructions to > replace > tabs by spaces, including lines where I have never done any chang

Re: [cp-patches] FYI: implemented javax.swing.CellRendererPane

2005-02-27 Thread Michael Koch
On Sun, Feb 27, 2005 at 09:35:50PM +0100, Roman Kennke wrote: > Hi there again, > > I committed the attached fix, which implements the class > javax.swing.CellRendererPane (the methods were only present as dummy > methods before) and makes the JList UI make use of it for rendering its > cells. >

Re: [cp-patches] scrollable JList

2005-02-28 Thread Michael Koch
On Mon, Feb 28, 2005 at 11:27:30AM +0100, Roman Kennke wrote: > Hi, > > please review the attached patch that improves the behaviour of JList > within a scrolling container, especially with layoutOrientation set to > JList.HORIZONTAL_WRAP or VERTICAL_WRAP. Is the ChangeLog entry ok? > > 2005-02-2

Re: [cp-patches] Report #4742: the patch is easy to make, but should we really fix that bug?

2005-02-28 Thread Michael Koch
On Mon, Feb 28, 2005 at 04:09:54PM +0100, Meskauskas Audrius wrote: > The bug #4742 contains a comprehensive test, verifying the work of > StreamTokenizer by parsing randomly generated data under randomly set > options. It reveals the single difference > between the Sun and Classpath implementatio

[cp-patches] [Patch] remove stale gjdoc file

2005-03-02 Thread Michael Koch
Hi list, I commited the attached patch to remove gjdoc_rawcomment.cache on clean when it exists. It stays there when gjdoc dies unexpectedly. Michael 2005-03-02 Michael Koch <[EMAIL PROTECTED]> * doc/api/Makefile.am: Remove gjdoc_rawcomment.cache if neccesary. Index: d

[cp-patches] [Patch] Fix copyright headers in gnu.java.awt.color

2005-03-02 Thread Michael Koch
Hi list, I commited the attached patch to make the classes in gnu.java.awt.color use our standard copyright header. Michael 2005-03-02 Michael Koch <[EMAIL PROTECTED]> * gnu/java/awt/color/CieXyzConverter.java, gnu/java/awt/color/ClutProfileConverter.java, gn

[cp-patches] [Patch] small fixes in gnu.*

2005-03-02 Thread Michael Koch
Hi list, I just commited the attached patch to fix some small issues in gnu.*. Michael 2005-03-02 Michael Koch <[EMAIL PROTECTED]> * gnu/java/awt/Buffers.java, gnu/java/awt/ComponentDataBlitOp.java, gnu/java/awt/EmbeddedWindowSupport.java, gnu/ja

[cp-patches] [Patch] import statement cleanup for gnu.java.security

2005-03-02 Thread Michael Koch
Hi list, I just commited the patch with the ChangeLog entry below. Unfortunately I forgot to create a patch before commiting. It was pretty straightforward. It just reordered import statements and replaced implicit imports with explicit imports. Michael 2005-03-02 Michael Koch <[EM

Re: [cp-patches] [Patch] small fixes in gnu.*

2005-03-02 Thread Michael Koch
On Wed, Mar 02, 2005 at 05:49:13PM +, Chris Burdess wrote: > Michael Koch wrote: > >I just commited the attached patch to fix some small issues in gnu.*. > > gnu/java/net/protocol/http/ChunkedInputStream.java, > > I must say I'm not particularly happy about some

[cp-patches] [Patch] clarified style about import statements

2005-03-02 Thread Michael Koch
Hi list, I just commited the attached patch to clarify our coding style regarding import statements. Thanks to Chris Burdess for proofreading. Michael 2005-03-02 Michael Koch <[EMAIL PROTECTED]> * doc/hacking.texinfo: Improved explanation of our coding style reg

Re: [cp-patches] [Patch] small fixes in gnu.*

2005-03-02 Thread Michael Koch
On Wed, Mar 02, 2005 at 12:37:25PM -0600, Archie Cobbs wrote: > Michael Koch wrote: > >>'n' comes before 'O' in English collation. This "fix" is a regression. > > > > No. Uppercase charcters are ordered before lowercase. That is what > >

Re: [cp-patches] [patch] native/fdlim unitialized fixes

2005-03-05 Thread Michael Koch
On Sat, Mar 05, 2005 at 02:12:12PM +0100, Andreas Tobler wrote: > Hello, > > on request of Michael I put the diff together I applied to libgcj. > Here against classpath cvs. I built it but I could not test classpath so far. > I tested it on libgcj. > > Andreas > > P.S, if accepted could someone

Re: [cp-patches] FYI:swing.text.html.parser

2005-03-07 Thread Michael Koch
On Mon, Mar 07, 2005 at 06:15:14PM +0100, Meskauskas Audrius wrote: > I commit the implementation of the error tolerant swing.text.html.parser > package (SGML DTD driven HTML 4.01 parser). > > The implementation is too large to be sent into mailing list directly. > Instead, you need to download

[cp-patches] [Patch] java.awt.Font.decode - bug fixes

2005-03-08 Thread Michael Koch
Hi list, I commited this patch by David Gilbert and approved by Thomas Fitzsimmons. This closes https://savannah.gnu.org/patch/index.php?func=detailitem&item_id=3799. Michael 2005-03-08 David Gilbert <[EMAIL PROTECTED]> * java/awt/Font.java (decode): Handle null argument and allow

Re: [cp-patches] Re: [commit-cp] classpath daily snapshot 20050309 FAILED

2005-03-08 Thread Michael Koch
On Wed, Mar 09, 2005 at 07:02:01AM +0100, Robert Schuster wrote: > Hi, > adding > > import gnu.CORBA.primitiveTypeCode; > > to org.omg.CORBA.Any.java will fix the compilation problem. I would apply it > myself but somehow my upload working directories shows no 'omg' in org. Call "cvs update" wi

[cp-patches] [Patch] Fixed imports in org.omg.CORBA.AnyHolder

2005-03-09 Thread Michael Koch
Hi list, I just commited the attached patch to fix classpath build again. Michael 2005-03-09 Michael Koch <[EMAIL PROTECTED]> * org/omg/CORBA/AnyHolder.java: Added missing import. Index: org/omg/CORBA/AnyHolde

[cp-patches] [Patch] use standard copyright header on org.omg.CORBA

2005-03-09 Thread Michael Koch
Hi list, I just commited the attached patch to make org.omg.CORBA use our standard copyright header. Michael 2005-03-09 Michael Koch <[EMAIL PROTECTED]> * org/omg/CORBA/ARG_IN.java, org/omg/CORBA/ARG_INOUT.java, org/omg/CORBA/ARG_OUT.java, org/omg

Re: [cp-patches] [Patch] use standard copyright header on org.omg.CORBA

2005-03-09 Thread Michael Koch
On Wed, Mar 09, 2005 at 02:52:11PM +0100, Meskauskas Audrius wrote: > The copyright headers seems looking exactly as they were before applying > the patch and the CVS repository returns an empty page after I ask for the > differences. > > Is our CVS server still working properly? You maybe have

[cp-patches] [Patch] locale data updated

2005-03-09 Thread Michael Koch
Hi list, I just commited the attached patch to regenerated the locale information with latest gnu.localegen. That was needed to get fixed data for calendar handling. Michael 2005-03-09 Michael Koch <[EMAIL PROTECTED]> * gnu/java/locale/LocaleInformation.java, gn

[cp-patches] Re: [commit-cp] classpath ./ChangeLog testsuite/javax.swing.tex...

2005-03-10 Thread Michael Koch
On Thu, Mar 10, 2005 at 07:29:58AM -0500, Audrius Me?kauskas wrote: > CVSROOT: /cvsroot/classpath > Module name: classpath > Branch: > Changes by: Audrius MeĀškauskas <[EMAIL PROTECTED]> 05/03/10 12:29:57 > > Modified files: > . : ChangeLog > Added files: >

Re: [cp-patches] FYI: Patch java/lang/Class.java

2005-03-11 Thread Michael Koch
On Fri, Mar 11, 2005 at 12:20:02PM +0100, Jeroen Frijters wrote: > Hi, > > The previous patch wasn't quite enough. Fixed it. Attached is the second > patch that I committed. And an you actually tell as what this fixed ? Is there a mauve testcase (or more) for this ? Michael -- Java Trap: http:

[cp-patches] [Patch] Typo fix in XmlParser.java

2005-03-13 Thread Michael Koch
Hi list, I just commited the attached patch to fix a typo in XmlParser.java. Michael 2005-03-13 Michael Koch <[EMAIL PROTECTED]> * gnu/xml/aelfred2/XmlParser.java: Fixed typo. Index: gnu/xml/aelfred2/XmlParse

[cp-patches] [Patch] Import statements cleaned up in gnu.javax.swing.text.html.parser

2005-03-13 Thread Michael Koch
Hi list, I just commited the attached patch to clean up some import statements. Michael 2005-03-13 Michael Koch <[EMAIL PROTECTED]> * gnu/javax/swing/text/html/parser/HTML_401F.java, gnu/javax/swing/text/html/parser/gnuDTD.java, gnu/javax/swing/text/html/

[cp-patches] [Patch] imports fixed in https handler

2005-03-13 Thread Michael Koch
Hi list, I just commited the attached obvious fix for the import statements in the https handler. Michael 2005-03-13 Michael Koch <[EMAIL PROTECTED]> * gnu/java/net/protocol/https/Handler.java: Reworked import statements. Index: gnu/java/net/protocol/https/Handle

[cp-patches] [Patch] code cleanup in org.omg.CORBA

2005-03-13 Thread Michael Koch
Hi list, I commited the attached patch to do some code style changes found by checkstyle. Michael 2005-03-13 Michael Koch <[EMAIL PROTECTED]> * org/omg/CORBA/ARG_IN.java: Removed redundant modifiers. * org/omg/CORBA/ARG_INOUT.java: Likewise. * org/omg

Re: [cp-patches] FYI: New CORBA helpers and holders

2005-03-13 Thread Michael Koch
On Sun, Mar 13, 2005 at 04:34:18PM +0100, Meskauskas Audrius wrote: > 2005-03-13 Audrius Meskauskas <[EMAIL PROTECTED]> > > * org/omg/CORBA/AnySeqHolder.java, > org/omg/CORBA/AnySeqHelper.java, > org/omg/CORBA/CompletionStatusHelper.java: It would be nice to have the changes actually described

Re: [cp-patches] Bug in java_nio_VMDirectByteBuffer.c

2005-03-15 Thread Michael Koch
On Tue, Mar 15, 2005 at 10:25:50PM -0600, Archie Cobbs wrote: > There is a bug in java_nio_VMDirectByteBuffer.c in the function > Java_java_nio_VMDirectByteBuffer_init(). > > This function sets "classRawData", which is a static variable of type > jclass, from the result of calling (*env)->FindClas

Re: [cp-patches] Patch: FYI: MainThread -vs- class loader

2005-03-16 Thread Michael Koch
On Wed, Mar 16, 2005 at 04:41:30PM -0700, Tom Tromey wrote: > I'm checking this in. > I'm going to put something similar in libgcj shortly. > > While implementing java.endorsed.dirs, I discovered that MainThread > tries to load the main class using its own class loader. However, it > is probable

Re: [cp-patches] RFC: JNI implementation of Selector #1

2005-03-16 Thread Michael Koch
On Thu, Mar 17, 2005 at 06:49:50AM +0100, Robert Schuster wrote: > Brings Sourceforge's current no2 most-often downloaded p2p app to life. > > Well, this code is a straight adaption of GCJ's CNI equivalent. However two > bug reports have been created out of this. Great work. > Please review the

Re: [cp-patches] [generics] FYI: Minor fixes to java.lang

2005-03-27 Thread Michael Koch
On Tue, Mar 22, 2005 at 10:09:00AM +0100, Meskauskas Audrius wrote: > +/** > + * For compatability with Sun's JDK > + */ > > If possible, I would suggest not referring to our shiny Sun without the real > need. > > Generally, it is very good to have serialVersionUID fixed, and not jus

Re: [cp-patches] Patch: RFC: enable Jessie by default

2005-03-27 Thread Michael Koch
On Wed, Mar 23, 2005 at 02:43:21PM -0700, Tom Tromey wrote: > What do people think of letting our URL implementation know about > Jessie by default? We recommend Jessie on our front page, so this > seemed reasonable to me. (Also, in java-gcj-compat, we currently set > java.protocol.handler.pkgs t

[cp-patches] [Patch] Typo fixes in java.awt.geom

2005-03-29 Thread Michael Koch
Hi list, I just commited the attached patch to fix two typos in the name of Brian Cough. Michael 2005-03-30 Michael Koch <[EMAIL PROTECTED]> * java/awt/geom/CubicCurve2D.java, java/awt/geom/QuadCurve2D.java: Fixed typo in name of Brian Cough. Index: java/aw

[cp-patches] [Patch] Revert typo fix in XmlParser.java

2005-03-29 Thread Michael Koch
Hi list, I commited the attached patch to revert a typo fix I commited a while ago. Michael 2005-03-30 Michael Koch <[EMAIL PROTECTED]> * gnu/xml/aelfred2/XmlParser.java: Revert my typo fix. Index: gnu/xml/aelfred2/XmlParse

[cp-patches] [Patch] Removed eclipse comment

2005-03-29 Thread Michael Koch
Hi list, I commited the attached patch to remove a comment for Eclipse. Michael 2005-03-30 Michael Koch <[EMAIL PROTECTED]> * java/awt/image/ConvolveOp.java: Removed comment added by eclipse. Index: java/awt/image/ConvolveO

[cp-patches] [Patch] added a bit of beancontext support

2005-03-30 Thread Michael Koch
Hi list, I just commited the attached patch to add some bean context support. This patch was a while on my hard disk and makes the openstreetmap applet a bit more working with gcjwebplugin. Michael 2005-03-30 Michael Koch <[EMAIL PROTECTED]> * java/beans/beanc

[cp-patches] [Patch] GTK peer and java.beans fixes

2005-03-31 Thread Michael Koch
Hi list, I just commited the attached patch to merge code from Graphics2D.java to Graphics.java and to implement some mre methods in BeanContextSupport.java. Michael 2005-03-31 Michael Koch <[EMAIL PROTECTED]> * gnu/java/awt/peer/gtk/GdkGraphics.java (getClip

[cp-patches] [Patch] PipedInputStream.read()

2005-04-01 Thread Michael Koch
Hi list, I commited the attached patch to fix a bug reported by Olafur Bragason. Michael 2005-04-01 Michael Koch <[EMAIL PROTECTED]> * java/io/PipedInputStream.java (read): Make sure a positive byte value is returned. Revised javadoc. Thanks to Olafur Bragas

Re: [cp-patches] Reindented native/jni code

2005-04-09 Thread Michael Koch
On Sat, Apr 09, 2005 at 02:19:03AM +0200, Mark Wielaard wrote: > Hi Guilhem. > > On Fri, 2005-04-08 at 14:34 +0200, Guilhem Lavaux wrote: > > GNU Indent (GNU style) seems to show a lot of differences after having > > been run on the native/jni code. I have run it on classpath, java-* > > directori

Re: [cp-patches] Re: -ko on libjava/external/sax/org/xml/sax/helpers/NamespaceSupport.java

2005-04-10 Thread Michael Koch
On Sat, Apr 09, 2005 at 11:17:55PM +0100, Andrew John Hughes wrote: > On Sat, 2005-04-09 at 13:07 -0700, Geoffrey Keating wrote: > > I did > > > > cvs admin -ko > > libjava/external/sax/org/xml/sax/helpers/NamespaceSupport.java > > > > because it contains an $Id$ tag. (I would have just removed

Re: [cp-patches] META-INF support

2005-04-10 Thread Michael Koch
On Sun, Apr 10, 2005 at 03:42:39AM +0200, Robert Schuster wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hi, > AFAIK we support not only delivery as glibj.zip but as glibj.jar and as > a plain directory. The patch looks as if it only works for the zip-case. > Are there any reasons to

Re: [cp-patches] META-INF support

2005-04-10 Thread Michael Koch
On Mon, Apr 11, 2005 at 03:59:00AM +0100, Andrew John Hughes wrote: > As to a jar version, we considered this recently on the list. One > reason we call it glibj.zip is because it can't be used as a normal jar, > and using a different file extension (which still fits the content, > because jars,

[cp-patches] [Patch] wrong casting in ImageIO

2005-04-10 Thread Michael Koch
Hi list, I just commited the attached patch to fix an issue in javax.imageio.ImageIO. A cast was wrong in ReaderFormatFilter.filter(). Thanks to David Gilbert for reporting this bug. Michael 2005-04-11 Michael Koch <[EMAIL PROTECTED]> * javax/imageio/ImageI

Re: PING: Re: [cp-patches] RFC: Fix for "XXX" use in java.util.Currency

2005-04-11 Thread Michael Koch
On Mon, Apr 11, 2005 at 08:46:42AM +0200, Jeroen Frijters wrote: > Andrew John Hughes wrote: > > On Mon, 2005-03-28 at 01:41 +0100, Andrew John Hughes wrote: > > > The attached patch allows examples such as the following: > > > > > > NumberFormat.getCurrencyInstance(Locale.ENGLISH).getCurrency() >

  1   2   >