Re: RFR: 7001973: java/awt/Graphics2D/CopyAreaOOB.java fails

2021-09-28 Thread Masanori Yano
On Fri, 24 Sep 2021 19:57:50 GMT, Sergey Bylokhov wrote: > So the "sun.awt.noerasebackground" property may fix the problem? Yes. With `-Dsun.awt.noerasebackground=true`, original CopyAreaOOB.java is Passed. But it is just a workaround. paint() is called twice with default settings on Windows,

RFR: 8274381 missing CAccessibility definitions in JNI code

2021-09-28 Thread Artem Semenov
accessibilityHitTest in JavaComponentAccessibility and getAxComponentSize in JavaAccessibilityUtilities use but do not define sjc_CAccessibility. It works when sjc_CAccessibility is defined by other methods, otherwise it crashes. - Commit messages: - 8274381 missing CAccessibility

Re: RFR: 8274381 missing CAccessibility definitions in JNI code

2021-09-28 Thread Pankaj Bansal
On Tue, 28 Sep 2021 08:45:22 GMT, Artem Semenov wrote: > accessibilityHitTest in JavaComponentAccessibility and getAxComponentSize in > JavaAccessibilityUtilities use but do not define sjc_CAccessibility. It works > when sjc_CAccessibility is defined by other methods, otherwise it crashes. Co

Re: RFR: 8274381 missing CAccessibility definitions in JNI code [v2]

2021-09-28 Thread Artem Semenov
> accessibilityHitTest in JavaComponentAccessibility and getAxComponentSize in > JavaAccessibilityUtilities use but do not define sjc_CAccessibility. It works > when sjc_CAccessibility is defined by other methods, otherwise it crashes. Artem Semenov has updated the pull request incrementally wit

Re: RFR: 8274381 missing CAccessibility definitions in JNI code

2021-09-28 Thread Artem Semenov
On Tue, 28 Sep 2021 08:45:22 GMT, Artem Semenov wrote: > accessibilityHitTest in JavaComponentAccessibility and getAxComponentSize in > JavaAccessibilityUtilities use but do not define sjc_CAccessibility. It works > when sjc_CAccessibility is defined by other methods, otherwise it crashes. By

Re: RFR: 8274381 missing CAccessibility definitions in JNI code [v2]

2021-09-28 Thread Pankaj Bansal
On Tue, 28 Sep 2021 09:12:37 GMT, Artem Semenov wrote: >> accessibilityHitTest in JavaComponentAccessibility and getAxComponentSize in >> JavaAccessibilityUtilities use but do not define sjc_CAccessibility. It >> works when sjc_CAccessibility is defined by other methods, otherwise it >> crash

Integrated: 8273581: Change the mechanism by which JDK loads the platform-specific FontManager class

2021-09-28 Thread Alexander Scherbatiy
On Wed, 15 Sep 2021 05:52:54 GMT, Alexander Scherbatiy wrote: > FontManagerFactory class uses reflection to load platform specific > FontManager classes from "sun.font.fontmanager" property. > > Fix proposes creating FontManager platform specific classes directly in the > similar way as it ha

RFR: 8274383 JNI call of getAccessibleSelection on a wrong thread

2021-09-28 Thread Artem Semenov
[ComboBoxAccessibility accessibilityValue] defines the getAccessibleSelection method on the AccessibleContext class, however the call should go through CAccessibility so that it is executed on the Event Dispatch thread. - Commit messages: - 8274383 JNI call of getAccessibleSelectio

Re: RFR: 8274381 missing CAccessibility definitions in JNI code [v2]

2021-09-28 Thread Anton Tarasov
On Tue, 28 Sep 2021 09:12:37 GMT, Artem Semenov wrote: >> accessibilityHitTest in JavaComponentAccessibility and getAxComponentSize in >> JavaAccessibilityUtilities use but do not define sjc_CAccessibility. It >> works when sjc_CAccessibility is defined by other methods, otherwise it >> crash

Re: RFR: 8273617: UninitializedDisplayModeChangeTest.java times out on macOS 12 [v2]

2021-09-28 Thread Prasanta Sadhukhan
> java/awt/FullScreen/UninitializedDisplayModeChangeTest/UninitializedDisplayModeChangeTest.java > is timing out every time on macOS 12 even though the test passed. > Looks like the the main process waits for child process created in the test > forever, making it timeout after jtreg timeout of 2m

Re: RFR: 8273617: UninitializedDisplayModeChangeTest.java times out on macOS 12

2021-09-28 Thread Prasanta Sadhukhan
On Thu, 23 Sep 2021 06:47:33 GMT, Prasanta Sadhukhan wrote: > java/awt/FullScreen/UninitializedDisplayModeChangeTest/UninitializedDisplayModeChangeTest.java > is timing out every time on macOS 12 even though the test passed. > Looks like the the main process waits for child process created in t

Re: RFR: 8274381 missing CAccessibility definitions in JNI code [v2]

2021-09-28 Thread Artem Semenov
On Tue, 28 Sep 2021 09:09:09 GMT, Anton Tarasov wrote: >> Artem Semenov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8274381 missing CAccessibility definitions in JNI code > > src/java.desktop/macosx/native/libawt_lwawt/awt/JavaAccess

Re: RFR: 8274397: [macOS] Stop setting env. var JAVA_MAIN_CLASS_ in launcher code [v2]

2021-09-28 Thread Roger Riggs
On Mon, 27 Sep 2021 23:50:38 GMT, Phil Race wrote: >> macOS launcher code sets JAVA_MAIN_CLASS_ which is read by AWT to set >> the name of the application in the system menu bar. >> >> Because this set shortly after the VM is running, it causes a thread safety >> issue described in https://bug

Re: RFR: 8274397: [macOS] Stop setting env. var JAVA_MAIN_CLASS_ in launcher code [v2]

2021-09-28 Thread Doug Simon
On Mon, 27 Sep 2021 23:50:38 GMT, Phil Race wrote: >> macOS launcher code sets JAVA_MAIN_CLASS_ which is read by AWT to set >> the name of the application in the system menu bar. >> >> Because this set shortly after the VM is running, it causes a thread safety >> issue described in https://bug

Re: RFR: 8274381 missing CAccessibility definitions in JNI code [v2]

2021-09-28 Thread Alexander Zuev
On Tue, 28 Sep 2021 09:12:37 GMT, Artem Semenov wrote: >> accessibilityHitTest in JavaComponentAccessibility and getAxComponentSize in >> JavaAccessibilityUtilities use but do not define sjc_CAccessibility. It >> works when sjc_CAccessibility is defined by other methods, otherwise it >> crash

Re: RFR: 8274383 JNI call of getAccessibleSelection on a wrong thread

2021-09-28 Thread Alexander Zuev
On Tue, 28 Sep 2021 09:47:02 GMT, Artem Semenov wrote: > [ComboBoxAccessibility accessibilityValue] defines the getAccessibleSelection > method on the AccessibleContext class, however the call should go through > CAccessibility so that it is executed on the Event Dispatch thread. Marked as re

Integrated: 8274381 missing CAccessibility definitions in JNI code

2021-09-28 Thread Artem Semenov
On Tue, 28 Sep 2021 08:45:22 GMT, Artem Semenov wrote: > accessibilityHitTest in JavaComponentAccessibility and getAxComponentSize in > JavaAccessibilityUtilities use but do not define sjc_CAccessibility. It works > when sjc_CAccessibility is defined by other methods, otherwise it crashes. Th

Re: RFR: 8274383 JNI call of getAccessibleSelection on a wrong thread

2021-09-28 Thread Anton Tarasov
On Tue, 28 Sep 2021 09:47:02 GMT, Artem Semenov wrote: > [ComboBoxAccessibility accessibilityValue] defines the getAccessibleSelection > method on the AccessibleContext class, however the call should go through > CAccessibility so that it is executed on the Event Dispatch thread. src/java.des

Re: RFR: 8274383 JNI call of getAccessibleSelection on a wrong thread [v2]

2021-09-28 Thread Anton Tarasov
On Tue, 28 Sep 2021 16:42:24 GMT, Artem Semenov wrote: >> [ComboBoxAccessibility accessibilityValue] defines the >> getAccessibleSelection method on the AccessibleContext class, however the >> call should go through CAccessibility so that it is executed on the Event >> Dispatch thread. > > Ar

Re: RFR: 8274383 JNI call of getAccessibleSelection on a wrong thread [v2]

2021-09-28 Thread Artem Semenov
> [ComboBoxAccessibility accessibilityValue] defines the getAccessibleSelection > method on the AccessibleContext class, however the call should go through > CAccessibility so that it is executed on the Event Dispatch thread. Artem Semenov has updated the pull request incrementally with one addi

Re: RFR: 8274383 JNI call of getAccessibleSelection on a wrong thread [v2]

2021-09-28 Thread Pankaj Bansal
On Tue, 28 Sep 2021 16:42:24 GMT, Artem Semenov wrote: >> [ComboBoxAccessibility accessibilityValue] defines the >> getAccessibleSelection method on the AccessibleContext class, however the >> call should go through CAccessibility so that it is executed on the Event >> Dispatch thread. > > Ar

Re: RFR: 8274383 JNI call of getAccessibleSelection on a wrong thread [v2]

2021-09-28 Thread Artem Semenov
On Tue, 28 Sep 2021 11:22:58 GMT, Anton Tarasov wrote: >> Artem Semenov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> JDK-8274383: JNI call of getAccessibleSelection on a wrong thread > > src/java.desktop/macosx/native/libawt_lwawt/awt

Integrated: 8274383 JNI call of getAccessibleSelection on a wrong thread

2021-09-28 Thread Artem Semenov
On Tue, 28 Sep 2021 09:47:02 GMT, Artem Semenov wrote: > [ComboBoxAccessibility accessibilityValue] defines the getAccessibleSelection > method on the AccessibleContext class, however the call should go through > CAccessibility so that it is executed on the Event Dispatch thread. This pull re

Re: RFR: 8274396: Suppress more warnings on non-serializable non-transient intance fields in client libs [v2]

2021-09-28 Thread Iris Clark
On Mon, 27 Sep 2021 22:48:24 GMT, Joe Darcy wrote: >> Follow-up changes to JDK-8231334. , augmentations to javac's Xlint:serial >> checking are out for review (#5709) and various client libraries would need >> some changes to pass under the expanded checks. >> >> The changes are to suppress wa

Re: RFR: 8262945: [macos] Regression Manual Test for Key Events Fails [v3]

2021-09-28 Thread Victor Dyakov
On Mon, 27 Sep 2021 16:19:21 GMT, Alisen Chung wrote: >> Added a check for active keyboard language and added support for Russian >> NSEvent keyCodes to JavaVirtualKeyCode translation. Originally, only English >> characters were checked for even if other languages were in native >> letterChar

Integrated: 8239502: [TEST_BUG] Test javax/swing/text/FlowView/6318524/bug6318524.java never fails

2021-09-28 Thread Alexey Ivanov
On Thu, 23 Sep 2021 18:41:38 GMT, Alexey Ivanov wrote: > The test is being moved from the closed to open. It's nearly a complete > re-write of the original test. > > I made the test headless by painting into image. > > To detect failure, the test uses the position of the caret at the end of >

Integrated: 8273634: [TEST_BUG] Improve javax/swing/text/ParagraphView/6364882/bug6364882.java

2021-09-28 Thread Alexey Ivanov
On Thu, 23 Sep 2021 19:19:34 GMT, Alexey Ivanov wrote: > The test is being moved from the closed to open. > > I updated the `bug6364882.java` test so that it's headless now. If it fails, > the image of the `editorPane` is saved for analysis. I also added more > asserts which verify: > > • the

Integrated: 8273972: Multi-core choke point in CMM engine (LCMSTransform.doTransform)

2021-09-28 Thread Sergey Bylokhov
On Fri, 24 Sep 2021 04:38:13 GMT, Sergey Bylokhov wrote: > Initially, the bug was discussed here: > https://stackoverflow.com/questions/35264582/why-is-multithreading-slowing-down/35264813 > > The root cause is that if for some reason directly or indirectly the color > transform object is share

Integrated: 8274396: Suppress more warnings on non-serializable non-transient instance fields in client libs

2021-09-28 Thread Joe Darcy
On Mon, 27 Sep 2021 20:21:43 GMT, Joe Darcy wrote: > Follow-up changes to JDK-8231334. , augmentations to javac's Xlint:serial > checking are out for review (#5709) and various client libraries would need > some changes to pass under the expanded checks. > > The changes are to suppress warning

Re: RFR: 8264666: Reuse Math.multiplyExact/addExact in the LCMSImageLayout class

2021-09-28 Thread Sergey Bylokhov
On Fri, 2 Apr 2021 23:02:50 GMT, Sergey Bylokhov wrote: > - The hand-crafted methods for addition and multiplication are replaced by > the "Math" versions. > - Cleanup: the usage of do/while(false) is removed not now - PR: https://git.openjdk.java.net/jdk/pull/

Re: RFR: 8273617: UninitializedDisplayModeChangeTest.java times out on macOS 12 [v2]

2021-09-28 Thread Sergey Bylokhov
On Tue, 28 Sep 2021 10:02:52 GMT, Prasanta Sadhukhan wrote: >> java/awt/FullScreen/UninitializedDisplayModeChangeTest/UninitializedDisplayModeChangeTest.java >> is timing out every time on macOS 12 even though the test passed. >> Looks like the the main process waits for child process created i

Integrated: 8274016: Replace 'for' cycles with iterator with enhanced-for in java.desktop

2021-09-28 Thread Andrey Turbanov
On Sun, 19 Sep 2021 10:13:49 GMT, Andrey Turbanov wrote: > There are few places in code where manual `for` loop is used with Iterator to > iterate over Collection. > Instead of manual `for` cycles it's preferred to use enhanced-for cycle > instead: it's less verbose, makes code easier to read

RFR: 8274465: Mark javax/swing/text/ParagraphView/6364882/bug6364882.java as headful

2021-09-28 Thread Jie Fu
Hi all, javax/swing/text/ParagraphView/6364882/bug6364882.java was observed failing on our non-GUI platforms. So I guess it should be marked as headful. Thanks. Best regards, Jie - Commit messages: - 8274465: Mark javax/swing/text/ParagraphView/6364882/bug6364882.java as headful

Re: RFR: 7001973: java/awt/Graphics2D/CopyAreaOOB.java fails

2021-09-28 Thread Sergey Bylokhov
On Tue, 28 Sep 2021 07:15:44 GMT, Masanori Yano wrote: > Yes. With `-Dsun.awt.noerasebackground=true`, original CopyAreaOOB.java is > Passed. But it is just a workaround. Yes, it is just a workaround that most probably will not work on other platforms. But EDT freeze for some time after copyar

Re: RFR: 8274465: Mark javax/swing/text/ParagraphView/6364882/bug6364882.java as headful

2021-09-28 Thread Sergey Bylokhov
On Tue, 28 Sep 2021 23:39:45 GMT, Jie Fu wrote: > Hi all, > > javax/swing/text/ParagraphView/6364882/bug6364882.java was observed failing > on our non-GUI platforms. > So I guess it should be marked as headful. > > Thanks. > Best regards, > Jie What exception is caused the test failure? This

Re: RFR: 8274465: Mark javax/swing/text/ParagraphView/6364882/bug6364882.java as headful

2021-09-28 Thread Jie Fu
On Wed, 29 Sep 2021 00:58:12 GMT, Sergey Bylokhov wrote: > #5661 This test passed on our GUI platforms but failed without GUI. STDERR: java.lang.reflect.InvocationTargetException at java.desktop/java.awt.EventQueue.invokeAndWait(EventQueue.java:1371) at java.desktop/java.awt.Eve

Re: RFR: 8274465: Mark javax/swing/text/ParagraphView/6364882/bug6364882.java as headful

2021-09-28 Thread Sergey Bylokhov
On Tue, 28 Sep 2021 23:39:45 GMT, Jie Fu wrote: > Hi all, > > javax/swing/text/ParagraphView/6364882/bug6364882.java was observed failing > on our non-GUI platforms. > So I guess it should be marked as headful. > > Thanks. > Best regards, > Jie This is a plain test failure, since exception is

Re: RFR: 8274465: Mark javax/swing/text/ParagraphView/6364882/bug6364882.java as headful

2021-09-28 Thread Jie Fu
On Wed, 29 Sep 2021 01:19:03 GMT, Sergey Bylokhov wrote: > This is a plain test failure, since exception is not a HeadlessException > caused by some API required the desktop session. headful key should not apply > to it. So any idea to fix it? Thanks. - PR: https://git.openjdk.ja

Re: RFR: 8274465: Mark javax/swing/text/ParagraphView/6364882/bug6364882.java as headful

2021-09-28 Thread Sergey Bylokhov
On Tue, 28 Sep 2021 23:39:45 GMT, Jie Fu wrote: > Hi all, > > javax/swing/text/ParagraphView/6364882/bug6364882.java was observed failing > on our non-GUI platforms. > So I guess it should be marked as headful. > > Thanks. > Best regards, > Jie It is possible that the test is too strict or th

Re: RFR: 8274465: Mark javax/swing/text/ParagraphView/6364882/bug6364882.java as headful

2021-09-28 Thread Jie Fu
On Wed, 29 Sep 2021 01:33:43 GMT, Sergey Bylokhov wrote: > It is possible that the test is too strict or this is a jdk bug. But I am not > sure it is possible to investigate this issue based on the bug description in > the JBS. @aivanov-jdk please take a look. Can I problemlist this test? Then

Re: RFR: 8274397: [macOS] Stop setting env. var JAVA_MAIN_CLASS_ in launcher code [v2]

2021-09-28 Thread Sergey Bylokhov
On Mon, 27 Sep 2021 23:50:38 GMT, Phil Race wrote: >> macOS launcher code sets JAVA_MAIN_CLASS_ which is read by AWT to set >> the name of the application in the system menu bar. >> >> Because this set shortly after the VM is running, it causes a thread safety >> issue described in https://bug

Re: RFR: 8274397: [macOS] Stop setting env. var JAVA_MAIN_CLASS_ in launcher code [v2]

2021-09-28 Thread Phil Race
On Wed, 29 Sep 2021 01:46:32 GMT, Sergey Bylokhov wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8274397: [macOS] Stop setting env. var JAVA_MAIN_CLASS_ in launcher >> code > > src/java.base/macosx/native/libjli/jav

Re: RFR: 8273634: [TEST_BUG] Improve javax/swing/text/ParagraphView/6364882/bug6364882.java

2021-09-28 Thread Phil Race
On Thu, 23 Sep 2021 19:19:34 GMT, Alexey Ivanov wrote: > The test is being moved from the closed to open. > > I updated the `bug6364882.java` test so that it's headless now. If it fails, > the image of the `editorPane` is saved for analysis. I also added more > asserts which verify: > > • the

Re: RFR: 8274397: [macOS] Stop setting env. var JAVA_MAIN_CLASS_ in launcher code [v3]

2021-09-28 Thread Phil Race
> macOS launcher code sets JAVA_MAIN_CLASS_ which is read by AWT to set > the name of the application in the system menu bar. > > Because this set shortly after the VM is running, it causes a thread safety > issue described in https://bugs.openjdk.java.net/browse/JDK-8270549 > > Since the AWT a

Re: RFR: 8274397: [macOS] Stop setting env. var JAVA_MAIN_CLASS_ in launcher code [v2]

2021-09-28 Thread Phil Race
On Mon, 27 Sep 2021 23:50:38 GMT, Phil Race wrote: >> macOS launcher code sets JAVA_MAIN_CLASS_ which is read by AWT to set >> the name of the application in the system menu bar. >> >> Because this set shortly after the VM is running, it causes a thread safety >> issue described in https://bug

Re: RFR: 8274397: [macOS] Stop setting env. var JAVA_MAIN_CLASS_ in launcher code [v3]

2021-09-28 Thread Phil Race
On Wed, 29 Sep 2021 03:39:09 GMT, Phil Race wrote: >> macOS launcher code sets JAVA_MAIN_CLASS_ which is read by AWT to set >> the name of the application in the system menu bar. >> >> Because this set shortly after the VM is running, it causes a thread safety >> issue described in https://bug

Re: RFR: 8273617: UninitializedDisplayModeChangeTest.java times out on macOS 12 [v2]

2021-09-28 Thread Prasanta Sadhukhan
On Tue, 28 Sep 2021 10:02:52 GMT, Prasanta Sadhukhan wrote: >> java/awt/FullScreen/UninitializedDisplayModeChangeTest/UninitializedDisplayModeChangeTest.java >> is timing out every time on macOS 12 even though the test passed. >> Looks like the the main process waits for child process created i