This is an initial PR for expanded lint warnings done under two bugs:
8202056: Expand serial warning to check for bad overloads of serial-related
methods and ineffectual fields
8160675: Issue lint warning for non-serializable non-transient instance fields
in serializable type
to get feedback on
Follow-up changes to JDK-8231334. , augmentations to javac's Xlint:serial
checking are out for review (#5709) and various client libraries would need
some changes to pass under the expanded checks.
The changes are to suppress warnings where non-transient fields in serializable
types are not dec
s in
> serializable types are not declared with a type statically known to be
> serializable. That isn't necessarily a correctness issues, but it does merit
> further scrutiny.
>
> I'll run a script to update the copyright year before pushing.
Joe Darcy has updated the p
On Mon, 27 Sep 2021 21:40:13 GMT, Sergey Bylokhov wrote:
>
>
> Can we add comments to SuppressWarnings on why it was added? Previously we
> use this text
>
> > // Not statically typed as Serializable
Added in revision; used a different comment wording.
-
PR: https://git.openjdk
On Mon, 27 Sep 2021 20:21:43 GMT, Joe Darcy wrote:
> Follow-up changes to JDK-8231334. , augmentations to javac's Xlint:serial
> checking are out for review (#5709) and various client libraries would need
> some changes to pass under the expanded checks.
>
> The cha
On Thu, 18 Nov 2021 21:51:30 GMT, Brent Christian wrote:
> Here are the code changes for the "Deprecate finalizers in the standard Java
> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
> review.
>
> This change makes the indicated deprecations, and updates the API spec
In JDK 18, JDK-8189591 added the ability to suppress doclint warnings.
Therefore, it is now possible to enable the full doclint checks for the
java.desktop module if the instances of warnings are suppressed. This patch
does this; it would be preferable to address the doc warnings directly, but
On Fri, 3 Dec 2021 01:18:20 GMT, Joe Darcy wrote:
> In JDK 18, JDK-8189591 added the ability to suppress doclint warnings.
> Therefore, it is now possible to enable the full doclint checks for the
> java.desktop module if the instances of warnings are suppressed. This patch
> d
On Fri, 3 Dec 2021 01:18:20 GMT, Joe Darcy wrote:
> In JDK 18, JDK-8189591 added the ability to suppress doclint warnings.
> Therefore, it is now possible to enable the full doclint checks for the
> java.desktop module if the instances of warnings are suppressed. This patch
> d
On Fri, 3 Dec 2021 20:55:23 GMT, Sergey Bylokhov wrote:
> The "missing-explicit-ctor" check was disabled by the
> [JDK-8071961](https://bugs.openjdk.java.net/browse/JDK-8071961) and later was
> fixed by the [JDK-8250853](https://bugs.openjdk.java.net/browse/JDK-8250853).
> So we can re-enable
Use presumed syntax that will be introduced by JDK-8280488.
-
Commit messages:
- JDK-8280492: Address remaining doclint issues in JDK build
Changes: https://git.openjdk.java.net/jdk/pull/7189/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7189&range=00
Issue: https:/
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote:
> Use presumed syntax that will be introduced by JDK-8280488.
This should be the (near) final step to fully enable all doclint checks during
the javac portion of the build. The "reference" doclint check is currently
disabled
On Mon, 24 Jan 2022 11:33:18 GMT, Pavel Rappo wrote:
> > Use presumed syntax that will be introduced by JDK-8280488.
>
> Is that a wrong bug? If you are talking about module-prefix syntax for links,
> then it was introduced in JDK 15; JDK-8164408: Add module support for @see,
> @link and @link
> Use presumed syntax that will be introduced by JDK-8280488.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains three additional commits si
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote:
> Use presumed syntax that will be introduced by JDK-8280488.
This pull request has now been integrated.
Changeset: 8e82d002
Author: Joe Darcy
URL:
https://git.openjdk.java.net/jdk/commit/8e82d0021c119b7793870811fad37d7659c11
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
Marked as reviewed by darcy (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7268
On Mon, 28 Mar 2022 16:30:50 GMT, Phil Race wrote:
> JDK 17 delivered JEP 409: Sealed Classes : https://openjdk.java.net/jeps/409
> In essence this JEP allows a class to limit which classes can subclass it.
> If a class has no subclasses and cannot be subclassed outside the JDK it can
> also be
On Mon, 28 Mar 2022 16:30:50 GMT, Phil Race wrote:
> JDK 17 delivered JEP 409: Sealed Classes : https://openjdk.java.net/jeps/409
> In essence this JEP allows a class to limit which classes can subclass it.
> If a class has no subclasses and cannot be subclassed outside the JDK it can
> also be
On Tue, 29 Mar 2022 04:16:06 GMT, Prasanta Sadhukhan
wrote:
> > Suitable classes across the JDK are being retro-fitted to be sealed
>
> How does this "suitability" check done? Are these exhaustive or more awt
> classes will be added? Do we need to do the same for swing classes too?
I wrote an
On Wed, 6 Apr 2022 05:25:43 GMT, Sergey Bylokhov wrote:
>> Update Swing classes to use JEP 409 sealed and non-sealed modifiers and add
>> the final modifier where appropriate.
>>
>> jtreg tests and JCK API tests pass
>>
>> CSR for review here : https://bugs.openjdk.java.net/browse/JDK-8284214
On Wed, 6 Apr 2022 20:14:12 GMT, Sergey Bylokhov wrote:
>> Yes, that is fine; javadoc will filter out displaying non-public classes in
>> a permits clause.
>
> Just to double-check, it is fine to have it in the output of the
> getPermittedSubclasses for the public class as well?
I'm not certai
On Thu, 7 Apr 2022 19:33:28 GMT, Phil Race wrote:
>> Thank you for your clarification.
>
> You have to include it in the list, else it would not be a permitted
> sub-class, and then you couldn't use the new syntax at all.
>
> the javadoc doesn't mention it - it still just says
> public sealed c
To enable more complete doclint checking (courtesy @jonathan-gibbons), please
review this PR to add type-level @param tags where they are missing.
To the maintainers of java.util.concurrent, those changes could be separated
out in another bug if that would ease maintenance of that code.
Making
On Wed, 27 Apr 2022 01:39:27 GMT, Stuart Marks wrote:
>> To enable more complete doclint checking (courtesy @jonathan-gibbons),
>> please review this PR to add type-level @param tags where they are missing.
>>
>> To the maintainers of java.util.concurrent, those changes could be separated
>> o
On Wed, 27 Apr 2022 10:54:00 GMT, Daniel Fuchs wrote:
>> To enable more complete doclint checking (courtesy @jonathan-gibbons),
>> please review this PR to add type-level @param tags where they are missing.
>>
>> To the maintainers of java.util.concurrent, those changes could be separated
>> o
On Wed, 27 Apr 2022 10:55:22 GMT, Daniel Fuchs wrote:
>> Joe Darcy has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains three
tenance of that code.
>
> Making these library fixes is a blocker for correcting and expanding the
> doclint checks (JDK-8285496).
>
> I'll update copyright years before pushing.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The increm
tenance of that code.
>
> Making these library fixes is a blocker for correcting and expanding the
> doclint checks (JDK-8285496).
>
> I'll update copyright years before pushing.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last
On Wed, 27 Apr 2022 23:24:57 GMT, Stuart Marks wrote:
>> I said "keys maintained", omitting "by this map" to finesse the question of
>> if the SimpleEntry class *is* a map, or is used to implement a map, etc. I
>> can change it to include "by this map" if the map/entry distinction is okay
>> t
On Thu, 28 Apr 2022 08:08:37 GMT, Alan Bateman wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to more review feedback.
>
> src/java.base/share/classes/java/nio/file/Secu
tenance of that code.
>
> Making these library fixes is a blocker for correcting and expanding the
> doclint checks (JDK-8285496).
>
> I'll update copyright years before pushing.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last
On Thu, 28 Apr 2022 08:10:38 GMT, Alan Bateman wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to more review feedback.
>
> src/java.base/share/classes/java/nio/file/Wat
tenance of that code.
>
> Making these library fixes is a blocker for correcting and expanding the
> doclint checks (JDK-8285496).
>
> I'll update copyright years before pushing.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The increm
On Tue, 26 Apr 2022 22:24:26 GMT, Joe Darcy wrote:
> To enable more complete doclint checking (courtesy @jonathan-gibbons), please
> review this PR to add type-level @param tags where they are missing.
>
> To the maintainers of java.util.concurrent, those changes could be separat
On Mon, 9 May 2022 15:56:35 GMT, Adam Sotona wrote:
> Please review this patch adding new lint option, **lossy-conversions**, to
> javac to warn about type casts in compound assignments with possible lossy
> conversions.
>
> The new lint warning is shown if the type of the right-hand operand o
Client libs counterpart of JDK-8286783, refactor the docs in AudioInputStream
to inhertiDoc text from InputStream.
I'll update copyrights before pushing.
-
Commit messages:
- JDK-8286787: Expand use of @inheritDoc in AudioInputStream
Changes: https://git.openjdk.java.net/jdk/pull/
> Client libs counterpart of JDK-8286783, refactor the docs in AudioInputStream
> to inhertiDoc text from InputStream.
>
> I'll update copyrights before pushing.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental we
On Sun, 15 May 2022 21:05:47 GMT, Joe Darcy wrote:
> Client libs counterpart of JDK-8286783, refactor the docs in AudioInputStream
> to inhertiDoc text from InputStream.
>
> I'll update copyrights before pushing.
This pull request has now been integrated.
Changeset: af2918
38 matches
Mail list logo
