Review: Approve continuous-integration
PASSED: Continuous integration, rev:ef13ce3def0728ed8c95c675c4552c1258f4d5d0
https://jenkins.ubuntu.com/server/job/cloud-init-ci/1/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/1
SUCCESS:
https:/
Joshua Powers has proposed merging ~powersj/cloud-init:test-ci into
cloud-init:master.
Commit message:
doc: test
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/325777
DO NOT MERGE
This is a
The proposal to merge ~powersj/cloud-init:test-ci into cloud-init:master has
been updated.
Description changed to:
DO NOT MERGE
This is a test for the new CI system only!
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/325777
--
Your team cloud-init
I'm marking this merged as the intent of it is merged.
the merge proposal above is in, and I think you should be good for building on
freebsd now.
--
https://code.launchpad.net/~redriver/cloud-init/+git/cloud-init/+merge/325718
Your team cloud-init commiters is requested to review the proposed
The proposal to merge ~redriver/cloud-init:fail_to_install_on_frbsd into
cloud-init:master has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~redriver/cloud-init/+git/cloud-init/+merge/325718
--
Your team cloud-init commiters is requested to
The proposal to merge ~smoser/cloud-init:feature/freebsd-variant into
cloud-init:master has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/325760
--
Your team cloud-init commiters is requested to review th
The proposal to merge ~redriver/cloud-init:fix-ifdown-for-frbsd-on-Azure into
cloud-init:master has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~redriver/cloud-init/+git/cloud-init/+merge/325713
--
Your team cloud-init commiters is requested to
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:14fc9449865810012cbf2f705b18efb3890b9096
https://jenkins.ubuntu.com/server/job/cloud-init-ci/540/
Executed test runs:
FAILURE:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/540/console
Diff comments:
> diff --git a/cloudinit/sources/DataSourceAzure.py
> b/cloudinit/sources/DataSourceAzure.py
> index ebb53d0..e5514ad 100644
> --- a/cloudinit/sources/DataSourceAzure.py
> +++ b/cloudinit/sources/DataSourceAzure.py
> @@ -803,18 +803,22 @@ def encrypt_pass(password, salt_id="$6$")
The proposal to merge ~smoser/cloud-init:fix/freebsd-test-failure into
cloud-init:master has been updated.
Commit Message changed to:
FreeBSD: fix test failure
The previous commit caused test failure.
This separates out _check_freebsd_cdrom and mocks it in a test
rather than patching open.
For
Scott Moser has proposed merging ~smoser/cloud-init:fix/freebsd-test-failure
into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/325771
--
Your team cloud-init commiters is
The proposal to merge ~smoser/cloud-init:feature/freebsd-variant into
cloud-init:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/325760
--
Your team cloud-init commiters is requested to rev
+1 on that suggestion
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/325760
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:feature/freebsd-variant into cloud-init:master.
___
Mai
actually, on further thought, lets leve suse out right now.
there is a 'sles' distro (cloudinit/distros/sles.py) but per
https://github.com/hpcugent/easybuild/wiki/OS_flavor_name_version
we would see 'suse' as the dist.
not sure what the right change is.
i didn't *change* any behavior here i do
Diff comments:
> diff --git a/cloudinit/util.py b/cloudinit/util.py
> index 415ca37..817d347 100644
> --- a/cloudinit/util.py
> +++ b/cloudinit/util.py
> @@ -598,37 +598,29 @@ def get_cfg_option_int(yobj, key, default=0):
> def system_info():
> info = {
> 'platform': platform.plat
The proposal to merge ~b1sandmann/cloud-init:fix-debian-template into
cloud-init:master has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~b1sandmann/cloud-init/+git/cloud-init/+merge/325478
--
Your team cloud-init commiters is requested to revie
The proposal to merge ~redriver/cloud-init:fix-ifdown-for-frbsd-on-Azure into
cloud-init:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~redriver/cloud-init/+git/cloud-init/+merge/325713
--
Your team cloud-init commiters is reques
Looks pretty good, I'd like to see other unit tests specifically looking at
return vals from util.system_info() but that can come in a later branch. Minor
nits but code looks good.
I have no bsd system available otherwise I'd check it out with a couple of runs.
Diff comments:
> diff --git a/clo
Review: Approve continuous-integration
PASSED: Continuous integration, rev:c6af5b9a1648c208c82b3a2704668391abadd8ab
https://jenkins.ubuntu.com/server/job/cloud-init-ci/539/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/539
SUCCESS:
htt
The proposal to merge ~smoser/cloud-init:feature/freebsd-variant into
cloud-init:master has been updated.
Commit Message changed to:
freebsd: Make freebsd a variant, fix unittests and tools/build-on-freebsd.
- Simplify the logic of 'variant' in util.system_info
much of the data from
http
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:2151902fa7a5cba7e420a14f51c851ee06d83d30
https://jenkins.ubuntu.com/server/job/cloud-init-ci/538/
Executed test runs:
FAILURE:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/538/console
this replaces some of the changes from
https://code.launchpad.net/~redriver/cloud-init/+git/cloud-init/+merge/325718
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/325760
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:feat
i've put up
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/325760
that covers most of these.
--
https://code.launchpad.net/~redriver/cloud-init/+git/cloud-init/+merge/325718
Your team cloud-init commiters is requested to review the proposed merge of
~redriver/cloud-init:f
Scott Moser has proposed merging ~smoser/cloud-init:feature/freebsd-variant
into cloud-init:master.
Commit message:
fixes for freebsd
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/325760
--
over all nice.
some comments.
thank you, Julien.
Diff comments:
> diff --git a/cloudinit/sources/DataSourceScaleway.py
> b/cloudinit/sources/DataSourceScaleway.py
> new file mode 100644
> index 000..ed3fef2
> --- /dev/null
> +++ b/cloudinit/sources/DataSourceScaleway.py
> @@ -0,0 +1,235 @@
Review: Approve continuous-integration
PASSED: Continuous integration, rev:a0748674f74e97e70a3274d312c9592b28a6dc08
https://jenkins.ubuntu.com/server/job/cloud-init-ci/537/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/537
SUCCESS:
htt
Diff comments:
> diff --git a/tools/build-on-freebsd b/tools/build-on-freebsd
> index ccc10b4..f16d62e 100755
> --- a/tools/build-on-freebsd
> +++ b/tools/build-on-freebsd
> @@ -17,6 +17,7 @@ pkgs="
> py27-jsonpatch
> py27-jsonpointer
> py27-oauth
we can drop py27-oauth now. its rep
Some things, and some content inline:
* We'll need some unit tests for this. Otherwise it is at increased risk of
being inadvertently broken.
* We will need to add knowledge of the datasource to tools/ds-identify
(without that your datasource will only ever be considered if it is a single
en
Review: Approve continuous-integration
PASSED: Continuous integration, rev:adfca12743e2dd78ac1ad7f83253f41c06eb3795
https://jenkins.ubuntu.com/server/job/cloud-init-ci/536/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/536
SUCCESS:
htt
Julien Castets has proposed merging ~jcastets/cloud-init:scaleway-datasource
into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~jcastets/cloud-init/+git/cloud-init/+merge/325740
Implements Scaleway datasource wit
this seems sane just looking at the diff, i'll look further today.
i think you'd opened a bug though... need to link to it.
--
https://code.launchpad.net/~redriver/cloud-init/+git/cloud-init/+merge/325713
Your team cloud-init commiters is requested to review the proposed merge of
~redriver/clou
I'll look at this later, but i'm not sure we can just
- 'platform': platform.platform(),
+ 'platform': platform.uname()[0],
without breaking other things. I'll try this out today though and will find a
freebsd to test on.
--
https://code.launchpad.net/~redriver/cloud-init/+git/cloud-init/+me
Andrew,
thanks. I think the code looks good
But a few things
a.) maybe 'detach_tty' as the name? 'no_tty=False' seems to imply that there
would be a tty, when we are not actually creating one.
b.) need some sort of test, at least to push it through here. it might be
tricky to do, but i'd like t
33 matches
Mail list logo
