Re: [Cluster-devel] [PATCH 6/8] gfs2: instrumentation wrt log_flush stuck

2020-06-05 Thread Bob Peterson
Hi Andreas, - Original Message - (snip) > > @@ -970,7 +969,16 @@ void gfs2_log_flush(struct gfs2_sbd *sdp, struct > > gfs2_glock *gl, u32 flags) > > > > if (!(flags & GFS2_LOG_HEAD_FLUSH_NORMAL)) { > > if (!sdp->sd_log_idle) { > > + unsigned

Re: [Cluster-devel] [PATCH 6/8] gfs2: instrumentation wrt log_flush stuck

2020-06-05 Thread Andreas Gruenbacher
On Fri, Jun 5, 2020 at 4:49 PM Bob Peterson wrote: > Hi Andreas, > > - Original Message - > (snip) > > > @@ -970,7 +969,16 @@ void gfs2_log_flush(struct gfs2_sbd *sdp, struct > > > gfs2_glock *gl, u32 flags) > > > > > > if (!(flags & GFS2_LOG_HEAD_FLUSH_NORMAL)) { > > >

Re: [Cluster-devel] [PATCH 6/8] gfs2: instrumentation wrt log_flush stuck

2020-06-05 Thread Bob Peterson
- Original Message - > On Fri, Jun 5, 2020 at 4:49 PM Bob Peterson wrote: > > Hi Andreas, > > > > - Original Message - > > (snip) > > > > @@ -970,7 +969,16 @@ void gfs2_log_flush(struct gfs2_sbd *sdp, struct > > > > gfs2_glock *gl, u32 flags) > > > > > > > > if (!(flags &

Re: [Cluster-devel] [PATCH 6/8] gfs2: instrumentation wrt log_flush stuck

2020-06-05 Thread Andreas Gruenbacher
On Fri, Jun 5, 2020 at 6:15 PM Bob Peterson wrote: > - Original Message - > > On Fri, Jun 5, 2020 at 4:49 PM Bob Peterson wrote: > > > Hi Andreas, > > > > > > - Original Message - > > > (snip) > > > > > @@ -970,7 +969,16 @@ void gfs2_log_flush(struct gfs2_sbd *sdp, struct > > > >

Re: [Cluster-devel] [PATCH 6/8] gfs2: instrumentation wrt log_flush stuck

2020-06-05 Thread Andreas Gruenbacher
Hi Bob, On Tue, May 26, 2020 at 3:05 PM Bob Peterson wrote: > This adds checks for gfs2_log_flush being stuck, similarly to the check > in gfs2_ail1_flush. > > Signed-off-by: Bob Peterson > --- > fs/gfs2/log.c | 14 +++--- > 1 file changed, 11 insertions(+), 3 deletions(-) > > diff

[Cluster-devel] [PATCH 6/8] gfs2: instrumentation wrt log_flush stuck

2020-05-26 Thread Bob Peterson
This adds checks for gfs2_log_flush being stuck, similarly to the check in gfs2_ail1_flush. Signed-off-by: Bob Peterson --- fs/gfs2/log.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/fs/gfs2/log.c b/fs/gfs2/log.c index 1d51b4781bdd..636c82dda68b 100644 ---