Thank you everyone for the feedback!
I’ve updated the document based on the feedback.
In addition to this document I’m also working on putting together a set of
coding standards/guidelines/tips that are more LLVM-specific. When I get that
together I’ll also send it over here for feedback.
The
Hi there!
I added that feature in the attached patch.
Best regards
André Klitzing
From 856b9e78b00180a232d4b9d498a726489778a07d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Klitzing?=
Date: Thu, 28 Apr 2016 21:03:26 +0200
Subject: [PATCH] Add support for
Hi Chris,
Thanks for doing this. I've had a quick scan and I have a few minor comments.
# Scripting overview
This is personal preference but I don't like ``add_definitions()`` due
to its global behaviour so I think its use should be discouraged. I
much prefer ``target_compile_definitions()``
Hi Chris,
This is great! I do have a suggestion that perhaps Brad could weigh in on
(may disagree). Since your already looking at a reasonably recent minimum
requirement in your examples (3.2) and discussing bumping the minimum up to
3.4.3 even, I think it would be worthwhile to let even some
On 04/27/2016 07:12 PM, Daniel Pfeifer wrote:
> It took a while, but i figured out .clang-format definitions (there
> are two required) and a script that, after applying, does not break
> compilation and unit tests.
Thanks! I'll try that out myself when I get a chance.
> I have attached a patch
On 04/27/2016 06:48 PM, Daniel Pfeifer wrote:
> It is unrelated. Clang-Tidy picks the interesting pieces from the
> compiler command line and ignores the rest. Whether cc is given or not
> makes no difference.
> But maybe we should leave the decision what to pick to Clang-Tidy? It
> may be clearer
On 04/27/2016 04:39 PM, Chris Bieneman wrote:
> attached the working draft of my documentation
Good work! Most of it looks great. Here are minor some comments.
Please add a link to the cmake-language(7) manual:
https://cmake.org/cmake/help/v3.5/manual/cmake-language.7.html
somewhere. It
The following issue has been SUBMITTED.
==
https://cmake.org/Bug/view.php?id=16086
==
Reported By:Florent Castelli
Assigned To: