[jira] [Created] (AIRFLOW-3650) Fix flaky test in TestTriggerDag

2019-01-07 Thread Tao Feng (JIRA)
Tao Feng created AIRFLOW-3650: - Summary: Fix flaky test in TestTriggerDag Key: AIRFLOW-3650 URL: https://issues.apache.org/jira/browse/AIRFLOW-3650 Project: Apache Airflow Issue Type: Bug

[GitHub] feng-tao commented on issue #4457: [AIRFLOW-3650] Skip running on mysql for the flaky test

2019-01-07 Thread GitBox
feng-tao commented on issue #4457: [AIRFLOW-3650] Skip running on mysql for the flaky test URL: https://github.com/apache/airflow/pull/4457#issuecomment-452203627 PTAL @kaxil @Fokko I think the issue is not on the actual test itself, but on mysqlclient library. The session can't g

[jira] [Updated] (AIRFLOW-3650) Fix flaky test in TestTriggerDag

2019-01-07 Thread Tao Feng (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tao Feng updated AIRFLOW-3650: -- Description: The test_trigger_dag_button test fails for mysql ORM almost everytime > Fix flaky test

[jira] [Assigned] (AIRFLOW-3592) Logs cannot be viewed while in rescheduled state

2019-01-07 Thread Stefan Seelmann (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seelmann reassigned AIRFLOW-3592: Assignee: Stefan Seelmann > Logs cannot be viewed while in rescheduled state > -

[jira] [Assigned] (AIRFLOW-3591) Fix start date, end date, duration for rescheduled tasks

2019-01-07 Thread Stefan Seelmann (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seelmann reassigned AIRFLOW-3591: Assignee: Stefan Seelmann > Fix start date, end date, duration for rescheduled t

[GitHub] seelmann commented on issue #4408: [AIRFLOW-3589] Visualize reschedule state in all views

2019-01-07 Thread GitBox
seelmann commented on issue #4408: [AIRFLOW-3589] Visualize reschedule state in all views URL: https://github.com/apache/airflow/pull/4408#issuecomment-452194510 @ashb @Fokko PTAL, ready to merge from my PoV. I tested in our test env with Celery executor and added some tests for the

[jira] [Updated] (AIRFLOW-3649) Feature to add extra labels to kubernetes worker pods

2019-01-07 Thread Bo Blanton (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Blanton updated AIRFLOW-3649: Priority: Minor (was: Major) > Feature to add extra labels to kubernetes worker pods > -

[jira] [Commented] (AIRFLOW-3649) Feature to add extra labels to kubernetes worker pods

2019-01-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736807#comment-16736807 ] ASF GitHub Bot commented on AIRFLOW-3649: - wyndhblb commented on pull request #

[GitHub] wyndhblb opened a new pull request #4459: [AIRFLOW-3649] Feature to add extra labels to kubernetes worker pods

2019-01-07 Thread GitBox
wyndhblb opened a new pull request #4459: [AIRFLOW-3649] Feature to add extra labels to kubernetes worker pods URL: https://github.com/apache/airflow/pull/4459 Make sure you have checked _all_ steps below. ### Jira - [ X] My PR addresses the following [Airflow Jira](https://i

[jira] [Created] (AIRFLOW-3649) Feature to add extra labels to kubernetes worker pods

2019-01-07 Thread Bo Blanton (JIRA)
Bo Blanton created AIRFLOW-3649: --- Summary: Feature to add extra labels to kubernetes worker pods Key: AIRFLOW-3649 URL: https://issues.apache.org/jira/browse/AIRFLOW-3649 Project: Apache Airflow

[GitHub] msumit commented on issue #3533: [AIRFLOW-161] New redirect route and extra links

2019-01-07 Thread GitBox
msumit commented on issue #3533: [AIRFLOW-161] New redirect route and extra links URL: https://github.com/apache/airflow/pull/3533#issuecomment-452189430 @ArgentFalcon maybe you want to update the screenshots and description of the PR as well? -

[jira] [Commented] (AIRFLOW-3648) Default to gcp project id in connection for all gcp hooks/operators

2019-01-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736754#comment-16736754 ] ASF GitHub Bot commented on AIRFLOW-3648: - jmcarp commented on pull request #44

[GitHub] jmcarp opened a new pull request #4458: [AIRFLOW-3648] Default to connection project id in gcp cloud sql.

2019-01-07 Thread GitBox
jmcarp opened a new pull request #4458: [AIRFLOW-3648] Default to connection project id in gcp cloud sql. URL: https://github.com/apache/airflow/pull/4458 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow Jira](https://issues.

[jira] [Created] (AIRFLOW-3648) Default to gcp project id in connection for all gcp hooks/operators

2019-01-07 Thread Josh Carp (JIRA)
Josh Carp created AIRFLOW-3648: -- Summary: Default to gcp project id in connection for all gcp hooks/operators Key: AIRFLOW-3648 URL: https://issues.apache.org/jira/browse/AIRFLOW-3648 Project: Apache Air

[GitHub] jmcarp commented on a change in pull request #4390: [AIRFLOW-3584] Use ORM DAGs for index view.

2019-01-07 Thread GitBox
jmcarp commented on a change in pull request #4390: [AIRFLOW-3584] Use ORM DAGs for index view. URL: https://github.com/apache/airflow/pull/4390#discussion_r245878602 ## File path: airflow/www_rbac/compile_assets.sh ## @@ -23,6 +23,6 @@ if [ -d airflow/www_rbac/static/dist

[GitHub] jmcarp commented on a change in pull request #4390: [AIRFLOW-3584] Use ORM DAGs for index view.

2019-01-07 Thread GitBox
jmcarp commented on a change in pull request #4390: [AIRFLOW-3584] Use ORM DAGs for index view. URL: https://github.com/apache/airflow/pull/4390#discussion_r245878561 ## File path: airflow/models/__init__.py ## @@ -240,6 +240,20 @@ def clear_task_instances(tis,

[GitHub] feng-tao commented on issue #4421: [AIRFLOW-3468] Remove KnownEvent(Event)?

2019-01-07 Thread GitBox
feng-tao commented on issue #4421: [AIRFLOW-3468] Remove KnownEvent(Event)? URL: https://github.com/apache/airflow/pull/4421#issuecomment-452174547 @Fokko , regarding not having a migration script, I wonder what will happen for the following case: assume we have three tables: ``A``, ``B`

[GitHub] feng-tao edited a comment on issue #4421: [AIRFLOW-3468] Remove KnownEvent(Event)?

2019-01-07 Thread GitBox
feng-tao edited a comment on issue #4421: [AIRFLOW-3468] Remove KnownEvent(Event)? URL: https://github.com/apache/airflow/pull/4421#issuecomment-452174547 @Fokko , regarding not having a migration script, I wonder what will happen for the following case: assume we have three tables: ``A

[GitHub] feng-tao commented on a change in pull request #4457: [AIRFLOW-XXX] Fix TestTriggerDag flaky test

2019-01-07 Thread GitBox
feng-tao commented on a change in pull request #4457: [AIRFLOW-XXX] Fix TestTriggerDag flaky test URL: https://github.com/apache/airflow/pull/4457#discussion_r245870276 ## File path: tests/www_rbac/test_views.py ## @@ -1464,12 +1464,9 @@ def test_trigger_dag_button_normal_

[GitHub] XD-DENG commented on a change in pull request #4457: [AIRFLOW-XXX] Fix TestTriggerDag flaky test

2019-01-07 Thread GitBox
XD-DENG commented on a change in pull request #4457: [AIRFLOW-XXX] Fix TestTriggerDag flaky test URL: https://github.com/apache/airflow/pull/4457#discussion_r245869601 ## File path: tests/www_rbac/test_views.py ## @@ -1464,12 +1464,9 @@ def test_trigger_dag_button_normal_e

[GitHub] feng-tao opened a new pull request #4457: Fix TestTriggerDag flaky test

2019-01-07 Thread GitBox
feng-tao opened a new pull request #4457: Fix TestTriggerDag flaky test URL: https://github.com/apache/airflow/pull/4457 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) is

[GitHub] feng-tao commented on issue #4407: [AIRFLOW-3600] Remove dagbag from trigger

2019-01-07 Thread GitBox
feng-tao commented on issue #4407: [AIRFLOW-3600] Remove dagbag from trigger URL: https://github.com/apache/airflow/pull/4407#issuecomment-452156950 another failure in https://travis-ci.org/apache/airflow/jobs/476638427 for https://github.com/apache/airflow/pull/4436. It seems the test fail

[GitHub] jmcarp commented on issue #4436: [AIRFLOW-3631] Update flake8 and fix lint.

2019-01-07 Thread GitBox
jmcarp commented on issue #4436: [AIRFLOW-3631] Update flake8 and fix lint. URL: https://github.com/apache/airflow/pull/4436#issuecomment-452143443 Updated. This is an automated message from the Apache Git Service. To respond

[GitHub] jmcarp commented on a change in pull request #4436: [AIRFLOW-3631] Update flake8 and fix lint.

2019-01-07 Thread GitBox
jmcarp commented on a change in pull request #4436: [AIRFLOW-3631] Update flake8 and fix lint. URL: https://github.com/apache/airflow/pull/4436#discussion_r245854403 ## File path: airflow/settings.py ## @@ -90,7 +90,7 @@ def timing(cls, stat, dt): /| |_ /__ ___/_

[GitHub] kaxil commented on issue #4444: [AIRFLOW-3281] Fix Kubernetes operator with git-sync

2019-01-07 Thread GitBox
kaxil commented on issue #: [AIRFLOW-3281] Fix Kubernetes operator with git-sync URL: https://github.com/apache/airflow/pull/#issuecomment-452132314 @feng-tao I have included that commit as well. @dimberman I have spent some time today and cherry-picked and resolved some co

[GitHub] feng-tao commented on issue #4421: [AIRFLOW-3468] Remove KnownEvent(Event)?

2019-01-07 Thread GitBox
feng-tao commented on issue #4421: [AIRFLOW-3468] Remove KnownEvent(Event)? URL: https://github.com/apache/airflow/pull/4421#issuecomment-452119451 but CI is failing. This is an automated message from the Apache Git Service. T

[GitHub] feng-tao commented on issue #4421: [AIRFLOW-3468] Remove KnownEvent(Event)?

2019-01-07 Thread GitBox
feng-tao commented on issue #4421: [AIRFLOW-3468] Remove KnownEvent(Event)? URL: https://github.com/apache/airflow/pull/4421#issuecomment-452119383 @Fokko , I see your point. +1 This is an automated message from the Apache Git

[GitHub] codecov-io commented on issue #4399: [AIRFLOW-3594] Unify different License Header

2019-01-07 Thread GitBox
codecov-io commented on issue #4399: [AIRFLOW-3594] Unify different License Header URL: https://github.com/apache/airflow/pull/4399#issuecomment-452114962 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4399?src=pr&el=h1) Report > Merging [#4399](https://codecov.io/gh/apache/airf

[jira] [Commented] (AIRFLOW-3645) Use a base_executor_config and merge operator level executor_config

2019-01-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736462#comment-16736462 ] ASF GitHub Bot commented on AIRFLOW-3645: - Mokubyow commented on pull request #

[GitHub] Mokubyow opened a new pull request #4456: [AIRFLOW-3645] Add base_executor_config

2019-01-07 Thread GitBox
Mokubyow opened a new pull request #4456: [AIRFLOW-3645] Add base_executor_config URL: https://github.com/apache/airflow/pull/4456 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/A

[jira] [Commented] (AIRFLOW-3647) Contributed SparkSubmitOperator doesn't honor --archives configuration

2019-01-07 Thread Ken Melms (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736460#comment-16736460 ] Ken Melms commented on AIRFLOW-3647: I have the code for this ready to go - I just

[jira] [Updated] (AIRFLOW-3647) Contributed SparkSubmitOperator doesn't honor --archives configuration

2019-01-07 Thread Ken Melms (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Melms updated AIRFLOW-3647: --- Description: The contributed SparkSubmitOperator has no ability to honor the spark-submit configur

[jira] [Created] (AIRFLOW-3647) Contributed SparkSubmitOperator doesn't honor --archives configuration

2019-01-07 Thread Ken Melms (JIRA)
Ken Melms created AIRFLOW-3647: -- Summary: Contributed SparkSubmitOperator doesn't honor --archives configuration Key: AIRFLOW-3647 URL: https://issues.apache.org/jira/browse/AIRFLOW-3647 Project: Apache

[GitHub] felipegasparini commented on issue #4036: [AIRFLOW-2744] Allow RBAC to accept plugins for views and links.

2019-01-07 Thread GitBox
felipegasparini commented on issue #4036: [AIRFLOW-2744] Allow RBAC to accept plugins for views and links. URL: https://github.com/apache/airflow/pull/4036#issuecomment-452113006 We also need to fix the example in the documentation (https://airflow.apache.org/plugins.html#example). It is c

[GitHub] feng-tao commented on issue #4407: [AIRFLOW-3600] Remove dagbag from trigger

2019-01-07 Thread GitBox
feng-tao commented on issue #4407: [AIRFLOW-3600] Remove dagbag from trigger URL: https://github.com/apache/airflow/pull/4407#issuecomment-452107835 @Fokko , looking at recent commit, this is the one that modifies this part of the code. And the CI is not always fails with this test(sometime

[GitHub] Fokko commented on issue #4405: [AIRFLOW-3598] Add tests for MsSqlToHiveTransfer

2019-01-07 Thread GitBox
Fokko commented on issue #4405: [AIRFLOW-3598] Add tests for MsSqlToHiveTransfer URL: https://github.com/apache/airflow/pull/4405#issuecomment-452107449 Thanks! This is an automated message from the Apache Git Service. To resp

[jira] [Work started] (AIRFLOW-3645) Use a base_executor_config and merge operator level executor_config

2019-01-07 Thread Kyle Hamlin (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on AIRFLOW-3645 started by Kyle Hamlin. > Use a base_executor_config and merge operator level executor_config > --

[jira] [Assigned] (AIRFLOW-3645) Use a base_executor_config and merge operator level executor_config

2019-01-07 Thread Kyle Hamlin (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kyle Hamlin reassigned AIRFLOW-3645: Assignee: Kyle Hamlin > Use a base_executor_config and merge operator level executor_con

[GitHub] Fokko commented on issue #4399: [AIRFLOW-3594] Unify different License Header

2019-01-07 Thread GitBox
Fokko commented on issue #4399: [AIRFLOW-3594] Unify different License Header URL: https://github.com/apache/airflow/pull/4399#issuecomment-452106547 @feluelle I've restarted the test, but due to the recent renaming, I'm not sure if the status of the CI will propagate properly. --

[GitHub] Fokko commented on issue #4407: [AIRFLOW-3600] Remove dagbag from trigger

2019-01-07 Thread GitBox
Fokko commented on issue #4407: [AIRFLOW-3600] Remove dagbag from trigger URL: https://github.com/apache/airflow/pull/4407#issuecomment-452106154 ``` == 42) FAIL: test_trigger_dag_button (tests.www_rbac.test_views.Test

[GitHub] galak75 removed a comment on issue #4292: [AIRFLOW-2508] Handle non string types in Operators templatized fields

2019-01-07 Thread GitBox
galak75 removed a comment on issue #4292: [AIRFLOW-2508] Handle non string types in Operators templatized fields URL: https://github.com/apache/airflow/pull/4292#issuecomment-445222367 Everything went well on our fork (see https://travis-ci.org/VilledeMontreal/incubator-airflow/builds/4647

[GitHub] ArgentFalcon commented on issue #3533: [AIRFLOW-161] New redirect route and extra links

2019-01-07 Thread GitBox
ArgentFalcon commented on issue #3533: [AIRFLOW-161] New redirect route and extra links URL: https://github.com/apache/airflow/pull/3533#issuecomment-452102290 Oh yeah, I should finish this up. I have to pull some more changes that we did internally at Lyft that make it more versatile. -

[GitHub] Fokko commented on a change in pull request #4436: [AIRFLOW-3631] Update flake8 and fix lint.

2019-01-07 Thread GitBox
Fokko commented on a change in pull request #4436: [AIRFLOW-3631] Update flake8 and fix lint. URL: https://github.com/apache/airflow/pull/4436#discussion_r245818023 ## File path: airflow/settings.py ## @@ -90,7 +90,7 @@ def timing(cls, stat, dt): /| |_ /__ ___/_

[GitHub] ArgentFalcon commented on issue #3533: [AIRFLOW-161] New redirect route and extra links

2019-01-07 Thread GitBox
ArgentFalcon commented on issue #3533: [AIRFLOW-161] New redirect route and extra links URL: https://github.com/apache/airflow/pull/3533#issuecomment-452102449 Maybe I should just fix the commits and merge it and then make a new PR with more changes. I'll do that. ---

[GitHub] feluelle commented on issue #4405: [AIRFLOW-3598] Add tests for MsSqlToHiveTransfer

2019-01-07 Thread GitBox
feluelle commented on issue #4405: [AIRFLOW-3598] Add tests for MsSqlToHiveTransfer URL: https://github.com/apache/airflow/pull/4405#issuecomment-452102237 Sure. This is an automated message from the Apache Git Service. To re

[GitHub] Fokko commented on a change in pull request #4390: [AIRFLOW-3584] Use ORM DAGs for index view.

2019-01-07 Thread GitBox
Fokko commented on a change in pull request #4390: [AIRFLOW-3584] Use ORM DAGs for index view. URL: https://github.com/apache/airflow/pull/4390#discussion_r245817009 ## File path: airflow/www_rbac/compile_assets.sh ## @@ -23,6 +23,6 @@ if [ -d airflow/www_rbac/static/dist

[GitHub] Fokko commented on a change in pull request #4390: [AIRFLOW-3584] Use ORM DAGs for index view.

2019-01-07 Thread GitBox
Fokko commented on a change in pull request #4390: [AIRFLOW-3584] Use ORM DAGs for index view. URL: https://github.com/apache/airflow/pull/4390#discussion_r245817248 ## File path: airflow/models/__init__.py ## @@ -240,6 +240,20 @@ def clear_task_instances(tis,

[GitHub] Fokko commented on issue #4405: [AIRFLOW-3598] Add tests for MsSqlToHiveTransfer

2019-01-07 Thread GitBox
Fokko commented on issue #4405: [AIRFLOW-3598] Add tests for MsSqlToHiveTransfer URL: https://github.com/apache/airflow/pull/4405#issuecomment-452100848 @feluelle Can you rebase onto master? This is an automated message from t

[GitHub] Fokko commented on issue #4445: [AIRFLOW-3635] Fix incorrect logic in detele_dag (introduced in PR#4406)

2019-01-07 Thread GitBox
Fokko commented on issue #4445: [AIRFLOW-3635] Fix incorrect logic in detele_dag (introduced in PR#4406) URL: https://github.com/apache/airflow/pull/4445#issuecomment-452100655 Thanks for picking this up @XD-DENG This is an

[GitHub] Fokko commented on issue #4378: AIRFLOW-3573 - Remove DagStat table

2019-01-07 Thread GitBox
Fokko commented on issue #4378: AIRFLOW-3573 - Remove DagStat table URL: https://github.com/apache/airflow/pull/4378#issuecomment-452100456 @ffinfo PTAL This is an automated message from the Apache Git Service. To respond to t

[GitHub] Fokko commented on issue #4: Create separate images with python2 and python3 support

2019-01-07 Thread GitBox
Fokko commented on issue #4: Create separate images with python2 and python3 support URL: https://github.com/apache/airflow-ci/pull/4#issuecomment-452100290 This is something that we still want, but I don't have the time to look into this because this will probably will break the master bu

[GitHub] Fokko commented on issue #4351: [AIRFLOW-3554] Remove contrib folder from code cov omit list

2019-01-07 Thread GitBox
Fokko commented on issue #4351: [AIRFLOW-3554] Remove contrib folder from code cov omit list URL: https://github.com/apache/airflow/pull/4351#issuecomment-452098776 I'm okay with this as well. The contrib code should have tests as well. -

[GitHub] Fokko commented on a change in pull request #4298: [AIRFLOW-3478] Make sure that the session is closed

2019-01-07 Thread GitBox
Fokko commented on a change in pull request #4298: [AIRFLOW-3478] Make sure that the session is closed URL: https://github.com/apache/airflow/pull/4298#discussion_r245813920 ## File path: airflow/bin/cli.py ## @@ -423,14 +418,11 @@ def unpause(args, dag=None): def set_is_

[GitHub] Fokko commented on issue #4383: [AIRFLOW-3475] Move ImportError out of models.py

2019-01-07 Thread GitBox
Fokko commented on issue #4383: [AIRFLOW-3475] Move ImportError out of models.py URL: https://github.com/apache/airflow/pull/4383#issuecomment-452097714 @BasPH I've restarted the failed tests. Maybe do a rebase? It seems to fail on k8s. -

[GitHub] Fokko commented on issue #4298: [AIRFLOW-3478] Make sure that the session is closed

2019-01-07 Thread GitBox
Fokko commented on issue #4298: [AIRFLOW-3478] Make sure that the session is closed URL: https://github.com/apache/airflow/pull/4298#issuecomment-452096893 Rebased :-) This is an automated message from the Apache Git Service.

[GitHub] Fokko commented on issue #4320: [AIRFLOW-3515] Remove the run_duration option

2019-01-07 Thread GitBox
Fokko commented on issue #4320: [AIRFLOW-3515] Remove the run_duration option URL: https://github.com/apache/airflow/pull/4320#issuecomment-452096465 I've rebased onto master and resolved the conflicts This is an automated mes

[GitHub] Fokko commented on issue #4421: [AIRFLOW-3468] Remove KnownEvent(Event)?

2019-01-07 Thread GitBox
Fokko commented on issue #4421: [AIRFLOW-3468] Remove KnownEvent(Event)? URL: https://github.com/apache/airflow/pull/4421#issuecomment-452095834 Rebased. @feng-tao I've looked into the Alembic script, but it becomes quite nasty in my opinion. The upgrade will be a `DROP TABLE IF EXISTS`, an

[GitHub] feng-tao commented on issue #4036: [AIRFLOW-2744] Allow RBAC to accept plugins for views and links.

2019-01-07 Thread GitBox
feng-tao commented on issue #4036: [AIRFLOW-2744] Allow RBAC to accept plugins for views and links. URL: https://github.com/apache/airflow/pull/4036#issuecomment-452093401 @oliviersm199 , it seems that PluginRBACTest fails(currently it is disabled) if re-enable. Do you think you have time

[jira] [Comment Edited] (AIRFLOW-3292) `delete_dag` endpoint and cli commands don't delete on exact dag_id matching

2019-01-07 Thread Teresa Martyny (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736368#comment-16736368 ] Teresa Martyny edited comment on AIRFLOW-3292 at 1/7/19 9:25 PM:

[jira] [Commented] (AIRFLOW-3292) `delete_dag` endpoint and cli commands don't delete on exact dag_id matching

2019-01-07 Thread Teresa Martyny (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736368#comment-16736368 ] Teresa Martyny commented on AIRFLOW-3292: - Sorry Ash, I just saw this response.

[GitHub] feng-tao edited a comment on issue #4444: [AIRFLOW-3281] Fix Kubernetes operator with git-sync

2019-01-07 Thread GitBox
feng-tao edited a comment on issue #: [AIRFLOW-3281] Fix Kubernetes operator with git-sync URL: https://github.com/apache/airflow/pull/#issuecomment-452078774 hey @kaxil , that's great news. I think we may need to revert this commit(https://github.com/apache/airflow/commit/b5b9287a

[GitHub] feng-tao commented on issue #4444: [AIRFLOW-3281] Fix Kubernetes operator with git-sync

2019-01-07 Thread GitBox
feng-tao commented on issue #: [AIRFLOW-3281] Fix Kubernetes operator with git-sync URL: https://github.com/apache/airflow/pull/#issuecomment-452079131 @kaxil, thanks for running the release :) This is an automated me

[GitHub] feng-tao edited a comment on issue #4444: [AIRFLOW-3281] Fix Kubernetes operator with git-sync

2019-01-07 Thread GitBox
feng-tao edited a comment on issue #: [AIRFLOW-3281] Fix Kubernetes operator with git-sync URL: https://github.com/apache/airflow/pull/#issuecomment-452078774 hey @kaxil , that's great news. I think we may need to revert this commit(https://github.com/apache/airflow/commit/b5b9287a

[GitHub] feng-tao commented on issue #4444: [AIRFLOW-3281] Fix Kubernetes operator with git-sync

2019-01-07 Thread GitBox
feng-tao commented on issue #: [AIRFLOW-3281] Fix Kubernetes operator with git-sync URL: https://github.com/apache/airflow/pull/#issuecomment-452078774 hey @kaxil , that's great news. I think we may need to revert this commit(https://github.com/apache/airflow/commit/b5b9287a75596a6

[GitHub] kaxil commented on issue #4444: [AIRFLOW-3281] Fix Kubernetes operator with git-sync

2019-01-07 Thread GitBox
kaxil commented on issue #: [AIRFLOW-3281] Fix Kubernetes operator with git-sync URL: https://github.com/apache/airflow/pull/#issuecomment-452076833 Trying to resolve conflicts :D so that we can include https://github.com/apache/incubator-airflow/pull/3770 and your DAG-level access

[jira] [Commented] (AIRFLOW-3402) Set default kubernetes affinity and toleration settings in airflow.cfg

2019-01-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736325#comment-16736325 ] ASF GitHub Bot commented on AIRFLOW-3402: - kaxil commented on pull request #445

[GitHub] kaxil closed pull request #4454: [AIRFLOW-3402] Port PR #4247 to 1.10-test

2019-01-07 Thread GitBox
kaxil closed pull request #4454: [AIRFLOW-3402] Port PR #4247 to 1.10-test URL: https://github.com/apache/airflow/pull/4454 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] feluelle commented on a change in pull request #4455: [AIRFLOW-3519] Fix example http operator

2019-01-07 Thread GitBox
feluelle commented on a change in pull request #4455: [AIRFLOW-3519] Fix example http operator URL: https://github.com/apache/airflow/pull/4455#discussion_r245791673 ## File path: airflow/example_dags/example_http_operator.py ## @@ -92,7 +92,7 @@ http_conn_id='http_de

[GitHub] feng-tao commented on issue #4444: [AIRFLOW-3281] Fix Kubernetes operator with git-sync

2019-01-07 Thread GitBox
feng-tao commented on issue #: [AIRFLOW-3281] Fix Kubernetes operator with git-sync URL: https://github.com/apache/airflow/pull/#issuecomment-452075293 what is the issue @kaxil ? This is an automated message from the

[GitHub] feng-tao edited a comment on issue #4444: [AIRFLOW-3281] Fix Kubernetes operator with git-sync

2019-01-07 Thread GitBox
feng-tao edited a comment on issue #: [AIRFLOW-3281] Fix Kubernetes operator with git-sync URL: https://github.com/apache/airflow/pull/#issuecomment-452075293 @kaxil, what is the issue? This is an automated message fr

[GitHub] kaxil edited a comment on issue #4444: [AIRFLOW-3281] Fix Kubernetes operator with git-sync

2019-01-07 Thread GitBox
kaxil edited a comment on issue #: [AIRFLOW-3281] Fix Kubernetes operator with git-sync URL: https://github.com/apache/airflow/pull/#issuecomment-452074777 Sorry, I merged it and had to revert which caused this piece to fail. May well have to create a new PR. -

[GitHub] kaxil commented on issue #4444: [AIRFLOW-3281] Fix Kubernetes operator with git-sync

2019-01-07 Thread GitBox
kaxil commented on issue #: [AIRFLOW-3281] Fix Kubernetes operator with git-sync URL: https://github.com/apache/airflow/pull/#issuecomment-452074777 Sorry, I merged it and had to revert. Let me know when it is ready T

[GitHub] kaxil commented on a change in pull request #4455: [AIRFLOW-3519] Fix example http operator

2019-01-07 Thread GitBox
kaxil commented on a change in pull request #4455: [AIRFLOW-3519] Fix example http operator URL: https://github.com/apache/airflow/pull/4455#discussion_r245790529 ## File path: airflow/example_dags/example_http_operator.py ## @@ -92,7 +92,7 @@ http_conn_id='http_defau

[GitHub] feluelle commented on a change in pull request #4455: [AIRFLOW-3519] Fix example http operator

2019-01-07 Thread GitBox
feluelle commented on a change in pull request #4455: [AIRFLOW-3519] Fix example http operator URL: https://github.com/apache/airflow/pull/4455#discussion_r245789254 ## File path: airflow/example_dags/example_http_operator.py ## @@ -92,7 +92,7 @@ http_conn_id='http_de

[GitHub] kaxil closed pull request #4444: [AIRFLOW-3281] Fix Kubernetes operator with git-sync

2019-01-07 Thread GitBox
kaxil closed pull request #: [AIRFLOW-3281] Fix Kubernetes operator with git-sync URL: https://github.com/apache/airflow/pull/ This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[jira] [Commented] (AIRFLOW-3281) Kubernetes git sync implementation is broken

2019-01-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736311#comment-16736311 ] ASF GitHub Bot commented on AIRFLOW-3281: - kaxil commented on pull request #444

[GitHub] benjamingregory edited a comment on issue #3055: [AIRFLOW-2125] Using binary package psycopg2-binary

2019-01-07 Thread GitBox
benjamingregory edited a comment on issue #3055: [AIRFLOW-2125] Using binary package psycopg2-binary URL: https://github.com/apache/airflow/pull/3055#issuecomment-452071229 @bern4rdelli @jgao54 @Fokko Question as to why this was changed to `psychopg2-binary` given the following war

[GitHub] benjamingregory commented on issue #3055: [AIRFLOW-2125] Using binary package psycopg2-binary

2019-01-07 Thread GitBox
benjamingregory commented on issue #3055: [AIRFLOW-2125] Using binary package psycopg2-binary URL: https://github.com/apache/airflow/pull/3055#issuecomment-452071229 @bern4rdelli @jgao54 @Fokko Question as to why this was changed to `psychopg2-binary` given the following warning fr

[GitHub] kaxil commented on a change in pull request #4455: [AIRFLOW-3519] Fix example http operator

2019-01-07 Thread GitBox
kaxil commented on a change in pull request #4455: [AIRFLOW-3519] Fix example http operator URL: https://github.com/apache/airflow/pull/4455#discussion_r245784539 ## File path: airflow/example_dags/example_http_operator.py ## @@ -92,7 +92,7 @@ http_conn_id='http_defau

[jira] [Created] (AIRFLOW-3646) Fix plugin manager test

2019-01-07 Thread Tao Feng (JIRA)
Tao Feng created AIRFLOW-3646: - Summary: Fix plugin manager test Key: AIRFLOW-3646 URL: https://issues.apache.org/jira/browse/AIRFLOW-3646 Project: Apache Airflow Issue Type: Bug Repo

[GitHub] feng-tao commented on issue #4399: [AIRFLOW-3594] Unify different License Header

2019-01-07 Thread GitBox
feng-tao commented on issue #4399: [AIRFLOW-3594] Unify different License Header URL: https://github.com/apache/airflow/pull/4399#issuecomment-452035908 PTAL @bolkedebruin This is an automated message from the Apache Git Serv

[jira] [Commented] (AIRFLOW-3272) Create gRPC hook for creating generic grpc connection

2019-01-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736141#comment-16736141 ] ASF GitHub Bot commented on AIRFLOW-3272: - morgendave commented on pull request

[jira] [Created] (AIRFLOW-3645) Use a base_executor_config and merge operator level executor_config

2019-01-07 Thread Kyle Hamlin (JIRA)
Kyle Hamlin created AIRFLOW-3645: Summary: Use a base_executor_config and merge operator level executor_config Key: AIRFLOW-3645 URL: https://issues.apache.org/jira/browse/AIRFLOW-3645 Project: Apache

[jira] [Commented] (AIRFLOW-3272) Create gRPC hook for creating generic grpc connection

2019-01-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736140#comment-16736140 ] ASF GitHub Bot commented on AIRFLOW-3272: - morgendave commented on pull request

[GitHub] morgendave closed pull request #4101: [AIRFLOW-3272] Add base grpc hook

2019-01-07 Thread GitBox
morgendave closed pull request #4101: [AIRFLOW-3272] Add base grpc hook URL: https://github.com/apache/airflow/pull/4101 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull re

[GitHub] morgendave opened a new pull request #4101: [AIRFLOW-3272] Add base grpc hook

2019-01-07 Thread GitBox
morgendave opened a new pull request #4101: [AIRFLOW-3272] Add base grpc hook URL: https://github.com/apache/airflow/pull/4101 Make sure you have checked all steps below. Jira My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[A

[GitHub] feng-tao commented on issue #4453: [AIRFLOW-XXX] Fix existing flake8 errors

2019-01-07 Thread GitBox
feng-tao commented on issue #4453: [AIRFLOW-XXX] Fix existing flake8 errors URL: https://github.com/apache/airflow/pull/4453#issuecomment-452019385 @yohei1126 , I think this test is pretty flaky. This is an automated message f

[GitHub] feng-tao commented on issue #4453: [AIRFLOW-XXX] Fix existing flake8 errors

2019-01-07 Thread GitBox
feng-tao commented on issue #4453: [AIRFLOW-XXX] Fix existing flake8 errors URL: https://github.com/apache/airflow/pull/4453#issuecomment-452019252 @yohei1126 , not sure which one you are looking at, but the master CI passes(https://travis-ci.org/apache/airflow/builds/476197675). Th

[GitHub] feng-tao commented on issue #4407: [AIRFLOW-3600] Remove dagbag from trigger

2019-01-07 Thread GitBox
feng-tao commented on issue #4407: [AIRFLOW-3600] Remove dagbag from trigger URL: https://github.com/apache/airflow/pull/4407#issuecomment-452019084 @ffinfo , please let me know if you will investigate the issue. If not, I prefer to revert this change until the flaky test is fixed. What do

[jira] [Commented] (AIRFLOW-3519) example_http_operator is failing due to

2019-01-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736031#comment-16736031 ] ASF GitHub Bot commented on AIRFLOW-3519: - feluelle commented on pull request #

[jira] [Created] (AIRFLOW-3644) AIP-8 Split Hooks/Operators out of core package and repository

2019-01-07 Thread Tim Swast (JIRA)
Tim Swast created AIRFLOW-3644: -- Summary: AIP-8 Split Hooks/Operators out of core package and repository Key: AIRFLOW-3644 URL: https://issues.apache.org/jira/browse/AIRFLOW-3644 Project: Apache Airflow

[GitHub] feluelle opened a new pull request #4455: [AIRFLOW-3519] Fix example http operator

2019-01-07 Thread GitBox
feluelle opened a new pull request #4455: [AIRFLOW-3519] Fix example http operator URL: https://github.com/apache/airflow/pull/4455 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/

[GitHub] Mokubyow edited a comment on issue #4309: [AIRFLOW-3504] Extend/refine the functionality of "/health" endpoint

2019-01-07 Thread GitBox
Mokubyow edited a comment on issue #4309: [AIRFLOW-3504] Extend/refine the functionality of "/health" endpoint URL: https://github.com/apache/airflow/pull/4309#issuecomment-451993107 Emmanual Bard brought up a good point about the scheduler health check. What you have only checks the last

[GitHub] Mokubyow edited a comment on issue #4309: [AIRFLOW-3504] Extend/refine the functionality of "/health" endpoint

2019-01-07 Thread GitBox
Mokubyow edited a comment on issue #4309: [AIRFLOW-3504] Extend/refine the functionality of "/health" endpoint URL: https://github.com/apache/airflow/pull/4309#issuecomment-451993107 Emmanual Bard brought up a good point about the scheduler health check. What you have only checks the last

[GitHub] Mokubyow commented on issue #4309: [AIRFLOW-3504] Extend/refine the functionality of "/health" endpoint

2019-01-07 Thread GitBox
Mokubyow commented on issue #4309: [AIRFLOW-3504] Extend/refine the functionality of "/health" endpoint URL: https://github.com/apache/airflow/pull/4309#issuecomment-451993107 Emmanual Bard brought up a good point about the scheduler health check. What you have only checks the last schedul

[jira] [Comment Edited] (AIRFLOW-3519) example_http_operator is failing due to

2019-01-07 Thread Felix Uellendall (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736002#comment-16736002 ] Felix Uellendall edited comment on AIRFLOW-3519 at 1/7/19 4:04 PM: --

[jira] [Commented] (AIRFLOW-3519) example_http_operator is failing due to

2019-01-07 Thread Felix Uellendall (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736002#comment-16736002 ] Felix Uellendall commented on AIRFLOW-3519: --- I would rather change the respon

[jira] [Assigned] (AIRFLOW-3519) example_http_operator is failing due to

2019-01-07 Thread Felix Uellendall (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Uellendall reassigned AIRFLOW-3519: - Assignee: Felix Uellendall > example_http_operator is failing due to > --

[jira] [Work started] (AIRFLOW-3601) update operators to BigQuery to support location

2019-01-07 Thread Yohei Onishi (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on AIRFLOW-3601 started by Yohei Onishi. - > update operators to BigQuery to support location > ---

[GitHub] XD-DENG commented on a change in pull request #4436: [AIRFLOW-3631] Update flake8 and fix lint.

2019-01-07 Thread GitBox
XD-DENG commented on a change in pull request #4436: [AIRFLOW-3631] Update flake8 and fix lint. URL: https://github.com/apache/airflow/pull/4436#discussion_r245611643 ## File path: airflow/settings.py ## @@ -90,7 +90,7 @@ def timing(cls, stat, dt): /| |_ /__ ___/_

  1   2   >