[GitHub] [airflow] uranusjr commented on a change in pull request #17592: Support for passing arguments to SqlSensor underlying hooks

2021-08-17 Thread GitBox
uranusjr commented on a change in pull request #17592: URL: https://github.com/apache/airflow/pull/17592#discussion_r690955205 ## File path: airflow/models/connection.py ## @@ -286,8 +286,11 @@ def rotate_fernet_key(self): if self._extra and self.is_extra_encrypted:

[GitHub] [airflow] Aakcht commented on pull request #17637: hdfs provider: allow SSL webhdfs connections

2021-08-17 Thread GitBox
Aakcht commented on pull request #17637: URL: https://github.com/apache/airflow/pull/17637#issuecomment-900867939 Hello, @potiuk ,any updates on this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [airflow] uranusjr edited a comment on pull request #17654: Only call `task_runner.return_code` from `LocalTaskJob._execute`

2021-08-17 Thread GitBox
uranusjr edited a comment on pull request #17654: URL: https://github.com/apache/airflow/pull/17654#issuecomment-900837843 > I think that if we end a runner without it heartbeating, we should explicitly use SIGKILL Hmm, that makes sense as well. I don’t have a strong opinion either w

[GitHub] [airflow] uranusjr commented on a change in pull request #17654: Only call `task_runner.return_code` from `LocalTaskJob._execute`

2021-08-17 Thread GitBox
uranusjr commented on a change in pull request #17654: URL: https://github.com/apache/airflow/pull/17654#discussion_r690952602 ## File path: airflow/task/task_runner/standard_task_runner.py ## @@ -110,7 +110,6 @@ def terminate(self): return # Reap the ch

[GitHub] [airflow] ephraimbuddy commented on pull request #17654: Only call `task_runner.return_code` from `LocalTaskJob._execute`

2021-08-17 Thread GitBox
ephraimbuddy commented on pull request #17654: URL: https://github.com/apache/airflow/pull/17654#issuecomment-900864076 > > I think that if we end a runner without it heartbeating, we should explicitly use SIGKILL > > Hmm, that makes sense as well. I don’t have a strong opinion eithe

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #17654: Only call `task_runner.return_code` from `LocalTaskJob._execute`

2021-08-17 Thread GitBox
ephraimbuddy commented on a change in pull request #17654: URL: https://github.com/apache/airflow/pull/17654#discussion_r690949248 ## File path: airflow/task/task_runner/standard_task_runner.py ## @@ -110,7 +110,6 @@ def terminate(self): return # Reap th

[GitHub] [airflow] sudohainguyen commented on issue #13487: DockerOperator Could not serialize the XCom value into JSON

2021-08-17 Thread GitBox
sudohainguyen commented on issue #13487: URL: https://github.com/apache/airflow/issues/13487#issuecomment-900862456 > > > enable_xcom_pickling = True > > > > > > This worked for me too. > > Did not work for me. Any alternatives? any screenshots? -- This is an auto

[GitHub] [airflow] uranusjr commented on a change in pull request #17421: Add ShortCircuitOperator configurability for respecting downstream trigger rules

2021-08-17 Thread GitBox
uranusjr commented on a change in pull request #17421: URL: https://github.com/apache/airflow/pull/17421#discussion_r690937723 ## File path: airflow/operators/python.py ## @@ -203,13 +220,26 @@ def execute(self, context: Dict): self.log.info('Proceeding with downst

[GitHub] [airflow] uranusjr commented on a change in pull request #17421: Add ShortCircuitOperator configurability for respecting downstream trigger rules

2021-08-17 Thread GitBox
uranusjr commented on a change in pull request #17421: URL: https://github.com/apache/airflow/pull/17421#discussion_r690936498 ## File path: airflow/operators/python.py ## @@ -185,16 +190,28 @@ def execute(self, context: Dict): class ShortCircuitOperator(PythonOperator, SkipMi

[GitHub] [airflow] uranusjr commented on a change in pull request #17421: Add ShortCircuitOperator configurability for respecting downstream trigger rules

2021-08-17 Thread GitBox
uranusjr commented on a change in pull request #17421: URL: https://github.com/apache/airflow/pull/17421#discussion_r690936002 ## File path: airflow/operators/python.py ## @@ -26,6 +26,11 @@ from textwrap import dedent from typing import Any, Callable, Dict, Iterable, List, O

[GitHub] [airflow] uranusjr closed pull request #17450: Add missing menu access for dag dependencies and configurations pages

2021-08-17 Thread GitBox
uranusjr closed pull request #17450: URL: https://github.com/apache/airflow/pull/17450 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [airflow] github-actions[bot] commented on pull request #17640: redshift to S3: add optional SQL parameters

2021-08-17 Thread GitBox
github-actions[bot] commented on pull request #17640: URL: https://github.com/apache/airflow/pull/17640#issuecomment-900852481 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not m

[GitHub] [airflow] uranusjr closed pull request #17397: Update to Celery 5

2021-08-17 Thread GitBox
uranusjr closed pull request #17397: URL: https://github.com/apache/airflow/pull/17397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [airflow] uranusjr commented on pull request #17651: Add AirflowException in case of error during cmd command executing

2021-08-17 Thread GitBox
uranusjr commented on pull request #17651: URL: https://github.com/apache/airflow/pull/17651#issuecomment-900850537 What is the reason behind the change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [airflow] uranusjr commented on a change in pull request #17651: Add AirflowException in case of error during cmd command executing

2021-08-17 Thread GitBox
uranusjr commented on a change in pull request #17651: URL: https://github.com/apache/airflow/pull/17651#discussion_r690930859 ## File path: tests/test_utils/logging_command_executor.py ## @@ -41,11 +41,13 @@ def execute_cmd(self, cmd, silent=False, cwd=None, env=None):

[GitHub] [airflow] uranusjr commented on a change in pull request #17654: Only call `task_runner.return_code` from `LocalTaskJob._execute`

2021-08-17 Thread GitBox
uranusjr commented on a change in pull request #17654: URL: https://github.com/apache/airflow/pull/17654#discussion_r690927981 ## File path: airflow/task/task_runner/standard_task_runner.py ## @@ -110,7 +110,6 @@ def terminate(self): return # Reap the ch

[GitHub] [airflow] uranusjr commented on pull request #17654: Only call `task_runner.return_code` from `LocalTaskJob._execute`

2021-08-17 Thread GitBox
uranusjr commented on pull request #17654: URL: https://github.com/apache/airflow/pull/17654#issuecomment-900837843 > I think that if we end a runner without it heartbeating, we should explicitly use SIGKILL Hmm, that makes sense as well. I don’t have a strong opinion either way (th

[GitHub] [airflow] uranusjr commented on pull request #17667: [DOCS] Update DAG.is_active property

2021-08-17 Thread GitBox
uranusjr commented on pull request #17667: URL: https://github.com/apache/airflow/pull/17667#issuecomment-900832092 One pedantic nit; why change the ordering? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [airflow] uranusjr commented on a change in pull request #17671: Allow google-auth < 3

2021-08-17 Thread GitBox
uranusjr commented on a change in pull request #17671: URL: https://github.com/apache/airflow/pull/17671#discussion_r690920880 ## File path: setup.py ## @@ -319,7 +319,7 @@ def write_version(filename: str = os.path.join(*[my_dir, "airflow", "git_version 'pandas-gbq<0.15.0

[GitHub] [airflow] uranusjr opened a new pull request #17676: Mark DAG.param as a decorated field

2021-08-17 Thread GitBox
uranusjr opened a new pull request #17676: URL: https://github.com/apache/airflow/pull/17676 Fix #17582. This mainly affects how this field is deserialized; previously it would be deserialized as-is, which is problematic if the param is a nested dict since the inner dicts were seria

[GitHub] [airflow] uranusjr edited a comment on issue #17582: DAG trigger with config params visualisation with proper deserialisation

2021-08-17 Thread GitBox
uranusjr edited a comment on issue #17582: URL: https://github.com/apache/airflow/issues/17582#issuecomment-900825011 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [airflow] uranusjr commented on issue #17582: DAG trigger with config params visualisation with proper deserialisation

2021-08-17 Thread GitBox
uranusjr commented on issue #17582: URL: https://github.com/apache/airflow/issues/17582#issuecomment-900825011 Those `__type` and `__val` keys are added by Airflow’s DAG serialisation logic, and the UI shouldn’t see them in the first place. I’m suspecting this is a bug in (de)serialisation

[GitHub] [airflow] glingle05 commented on issue #14417: DruidOperator failing to submit ingestion tasks : Getting 500 error code from Druid

2021-08-17 Thread GitBox
glingle05 commented on issue #14417: URL: https://github.com/apache/airflow/issues/14417#issuecomment-900799207 This fix is a workaround to a bug in the DruidHook.submit_indexing_job() itself. The requests.post line in submit_indexing_job is the real problem: ` req_index =

[GitHub] [airflow] jedcunningham commented on a change in pull request #17675: Update docs on syncing forks

2021-08-17 Thread GitBox
jedcunningham commented on a change in pull request #17675: URL: https://github.com/apache/airflow/pull/17675#discussion_r690875650 ## File path: CONTRIBUTING.rst ## @@ -1230,11 +1230,11 @@ How to sync your fork When you have your fork, you should periodically synchronize the

[GitHub] [airflow] SimonOsipov commented on issue #17629: KubernetesExecutor do not spawn Kubernetes Pod Operator pods.

2021-08-17 Thread GitBox
SimonOsipov commented on issue #17629: URL: https://github.com/apache/airflow/issues/17629#issuecomment-900755679 I redeployed configmap, used with the git-sync container, and this problem above (`Kubernetes resource version is too old`) is gone. But the problem with 1.20 Kubernetes rema

[GitHub] [airflow] LionelZhao28 commented on a change in pull request #17502: localize the run_id in dagrun

2021-08-17 Thread GitBox
LionelZhao28 commented on a change in pull request #17502: URL: https://github.com/apache/airflow/pull/17502#discussion_r690845281 ## File path: airflow/models/dagrun.py ## @@ -286,7 +287,17 @@ def find( @staticmethod def generate_run_id(run_type: DagRunType, executio

[GitHub] [airflow] josh-fell commented on a change in pull request #16866: Remove default_args pattern + added get_current_context() use for Core Airflow example DAGs

2021-08-17 Thread GitBox
josh-fell commented on a change in pull request #16866: URL: https://github.com/apache/airflow/pull/16866#discussion_r690843263 ## File path: airflow/example_dags/example_xcom.py ## @@ -78,6 +104,14 @@ def puller(**kwargs): pull = PythonOperator( task_id='puller',

[GitHub] [airflow] josh-fell commented on a change in pull request #16866: Remove default_args pattern + added get_current_context() use for Core Airflow example DAGs

2021-08-17 Thread GitBox
josh-fell commented on a change in pull request #16866: URL: https://github.com/apache/airflow/pull/16866#discussion_r690843020 ## File path: airflow/example_dags/example_xcom.py ## @@ -18,50 +18,76 @@ """Example DAG demonstrating the usage of XComs.""" from airflow import

[GitHub] [airflow] kaxil opened a new pull request #17675: Update docs on syncing forks

2021-08-17 Thread GitBox
kaxil opened a new pull request #17675: URL: https://github.com/apache/airflow/pull/17675 closes https://github.com/apache/airflow/issues/17665 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/mai

[airflow] branch constraints-2-1 updated: Updating constraints. Build id:1141271872

2021-08-17 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-2-1 in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-2-1 by this push: new a6726b9 Updating constra

[airflow] branch main updated: Dev: Remove duplicate step to push Docker Image (#17674)

2021-08-17 Thread jhtimmins
This is an automated email from the ASF dual-hosted git repository. jhtimmins pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 7c96800 Dev: Remove duplicate step to push Dock

[GitHub] [airflow] jhtimmins merged pull request #17674: Dev: Remove duplicate step to push Docker Image

2021-08-17 Thread GitBox
jhtimmins merged pull request #17674: URL: https://github.com/apache/airflow/pull/17674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[GitHub] [airflow] github-actions[bot] commented on pull request #17674: Dev: Remove duplicate step to push Docker Image

2021-08-17 Thread GitBox
github-actions[bot] commented on pull request #17674: URL: https://github.com/apache/airflow/pull/17674#issuecomment-900734527 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] kaxil opened a new pull request #17674: Dev: Remove duplicate step to push Docker Image

2021-08-17 Thread GitBox
kaxil opened a new pull request #17674: URL: https://github.com/apache/airflow/pull/17674 We have the same step few lines below "## Prepare production Docker Image" --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/ap

[GitHub] [airflow] kaxil merged pull request #17670: Fix link to generating constraints in BREEZE.rst

2021-08-17 Thread GitBox
kaxil merged pull request #17670: URL: https://github.com/apache/airflow/pull/17670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[airflow] branch main updated: Fix link to generating constraints in BREEZE.rst (#17670)

2021-08-17 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new dfdffa6 Fix link to generating constraints in B

[airflow] annotated tag constraints-2.1.3rc1 updated (595fb4c -> 3a0b413)

2021-08-17 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to annotated tag constraints-2.1.3rc1 in repository https://gitbox.apache.org/repos/asf/airflow.git. *** WARNING: tag constraints-2.1.3rc1 was modified! *** from 595fb4c (commit) to 3a0b413

svn commit: r49550 - /dev/airflow/2.1.3rc1/

2021-08-17 Thread kaxilnaik
Author: kaxilnaik Date: Wed Aug 18 00:16:40 2021 New Revision: 49550 Log: Update artifacts for Airflow 2.1.3rc1 Modified: dev/airflow/2.1.3rc1/apache-airflow-2.1.3-source.tar.gz dev/airflow/2.1.3rc1/apache-airflow-2.1.3-source.tar.gz.asc dev/airflow/2.1.3rc1/apache-airflow-2.1.3-sourc

[GitHub] [airflow] VLADPOLUNIN commented on issue #17582: DAG trigger with config params visualisation with proper deserialisation

2021-08-17 Thread GitBox
VLADPOLUNIN commented on issue #17582: URL: https://github.com/apache/airflow/issues/17582#issuecomment-900715611 👋😊 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[airflow] annotated tag 2.1.3rc1 updated (c46bccb -> bfa2dad)

2021-08-17 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to annotated tag 2.1.3rc1 in repository https://gitbox.apache.org/repos/asf/airflow.git. *** WARNING: tag 2.1.3rc1 was modified! *** from c46bccb (tag) to bfa2dad (tag) tagging 2b80c1edec8

[airflow] branch v2-1-stable updated (130e2f4 -> 2b80c1e)

2021-08-17 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch v2-1-stable in repository https://gitbox.apache.org/repos/asf/airflow.git. from 130e2f4 Add Changelog updates for 2.1.3 add 7cc13c1 Add new committers: ``Jed`` and ``TP`` (#16671)

[GitHub] [airflow] kaxil merged pull request #17673: Sync v2-1-test and v2-1-stable

2021-08-17 Thread GitBox
kaxil merged pull request #17673: URL: https://github.com/apache/airflow/pull/17673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [airflow] github-actions[bot] commented on pull request #17673: Sync v2-1-test and v2-1-stable

2021-08-17 Thread GitBox
github-actions[bot] commented on pull request #17673: URL: https://github.com/apache/airflow/pull/17673#issuecomment-900712086 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

[GitHub] [airflow] kaxil opened a new pull request #17673: Sync v2-1-test and v2-1-stable

2021-08-17 Thread GitBox
kaxil opened a new pull request #17673: URL: https://github.com/apache/airflow/pull/17673 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more infor

[GitHub] [airflow] github-actions[bot] commented on issue #16298: Scheduler fails with BrokenPipeError

2021-08-17 Thread GitBox
github-actions[bot] commented on issue #16298: URL: https://github.com/apache/airflow/issues/16298#issuecomment-900710661 This issue has been automatically marked as stale because it has been open for 30 days with no response from the author. It will be closed in next 7 days if no further

[GitHub] [airflow] github-actions[bot] closed pull request #14176: Simplify CONTRIBUTING.rst

2021-08-17 Thread GitBox
github-actions[bot] closed pull request #14176: URL: https://github.com/apache/airflow/pull/14176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #16755: Add option to ignore host for misconfigured passive FTP servers

2021-08-17 Thread GitBox
github-actions[bot] commented on pull request #16755: URL: https://github.com/apache/airflow/pull/16755#issuecomment-900710635 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank y

[airflow] branch constraints-2-1 updated: Bump to 7.2.1

2021-08-17 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch constraints-2-1 in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-2-1 by this push: new 595fb4c Bump to 7.2.1 59

[airflow] branch main updated: Update pre-commit checks-flynt to 0.66 (#17672)

2021-08-17 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 495535b Update pre-commit checks-flynt to 0.66

[GitHub] [airflow] kaxil merged pull request #17672: Update pre-commit checks - flynt to 0.66

2021-08-17 Thread GitBox
kaxil merged pull request #17672: URL: https://github.com/apache/airflow/pull/17672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [airflow] mik-laj opened a new pull request #17672: Update pre-commit checks - flynt to 0.66

2021-08-17 Thread GitBox
mik-laj opened a new pull request #17672: URL: https://github.com/apache/airflow/pull/17672 Additionally, we now download flynt configurations from the official repository, which allows us to automatically download updates using the `pre-commit autoupdate` command --- **^ Add

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17671: Allow google-auth < 3

2021-08-17 Thread GitBox
boring-cyborg[bot] commented on pull request #17671: URL: https://github.com/apache/airflow/pull/17671#issuecomment-900694234 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Con

[GitHub] [airflow] busunkim96 opened a new pull request #17671: Allow google-auth < 3

2021-08-17 Thread GitBox
busunkim96 opened a new pull request #17671: URL: https://github.com/apache/airflow/pull/17671 `google-auth` recently published a 2.0.0 release which removed support for Python 2.7. `google-auth` now requires Python >=3.6. No other breaking changes were made. You can see the full list of c

[GitHub] [airflow] jedcunningham commented on a change in pull request #17666: [Chart] Add option to set loadBalancerSourceRanges in webserver service

2021-08-17 Thread GitBox
jedcunningham commented on a change in pull request #17666: URL: https://github.com/apache/airflow/pull/17666#discussion_r690778830 ## File path: chart/values.schema.json ## @@ -1818,6 +1818,12 @@ ], "default": null

[airflow] 03/03: Bump ``sphinxcontrib-spelling`` and minor improvements (#16675)

2021-08-17 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch v2-1-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 5f9930bd3df4119b19baedd2722b4e9c3359b08e Author: Kaxil Naik AuthorDate: Sat Jun 26 18:33:22 2021 +0100 Bump

[airflow] 01/03: Add new committers: ``Jed`` and ``TP`` (#16671)

2021-08-17 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch v2-1-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit f010eb9a878108f757e38249b3bbb5d5dc7ab3ee Author: Kaxil Naik AuthorDate: Sat Jun 26 09:04:57 2021 +0100 Add n

[airflow] branch v2-1-test updated (332415a -> 5f9930b)

2021-08-17 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch v2-1-test in repository https://gitbox.apache.org/repos/asf/airflow.git. from 332415a Add Changelog updates for 2.1.3 new f010eb9 Add new committers: ``Jed`` and ``TP`` (#16671)

[airflow] 02/03: Add Aneesh Joseph as Airflow Committer (#16835)

2021-08-17 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch v2-1-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit b71bda6945659e367a3374378f4ca31706aacccd Author: Kaxil Naik AuthorDate: Tue Jul 6 16:08:55 2021 +0100 Add An

svn commit: r49549 - /dev/airflow/2.1.2rc1/

2021-08-17 Thread kaxilnaik
Author: kaxilnaik Date: Tue Aug 17 22:54:22 2021 New Revision: 49549 Log: Remove old release: 2.1.2 Removed: dev/airflow/2.1.2rc1/

[GitHub] [airflow] github-actions[bot] commented on pull request #17670: Fix link to generating constraints in BREEZE.rst

2021-08-17 Thread GitBox
github-actions[bot] commented on pull request #17670: URL: https://github.com/apache/airflow/pull/17670#issuecomment-900683787 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

svn commit: r49548 - /dev/airflow/2.1.3rc1/

2021-08-17 Thread kaxilnaik
Author: kaxilnaik Date: Tue Aug 17 22:53:34 2021 New Revision: 49548 Log: Add artifacts for Airflow 2.1.3rc1 Added: dev/airflow/2.1.3rc1/ dev/airflow/2.1.3rc1/apache-airflow-2.1.3-source.tar.gz (with props) dev/airflow/2.1.3rc1/apache-airflow-2.1.3-source.tar.gz.asc dev/airflow/

[GitHub] [airflow] jedcunningham commented on issue #17343: Dags added by DagBag interrupt randomly

2021-08-17 Thread GitBox
jedcunningham commented on issue #17343: URL: https://github.com/apache/airflow/issues/17343#issuecomment-900681488 If it were me, I'd use `TriggerDagRunOperator` directly and put a `ShortCircuirOperator` in front of it to check your `random_condition`, something like: ``` check

[GitHub] [airflow] baryluk commented on pull request #17649: Do not fail KubernetesPodOperator tasks if log following fails

2021-08-17 Thread GitBox
baryluk commented on pull request #17649: URL: https://github.com/apache/airflow/pull/17649#issuecomment-900678795 > We also need test coverage for this change. That makes sense. Let me take a look at mocking facilities available to test this. -- This is an automated message from

[GitHub] [airflow] baryluk commented on a change in pull request #17649: Do not fail KubernetesPodOperator tasks if log following fails

2021-08-17 Thread GitBox
baryluk commented on a change in pull request #17649: URL: https://github.com/apache/airflow/pull/17649#discussion_r690771413 ## File path: airflow/providers/cncf/kubernetes/utils/pod_launcher.py ## @@ -143,12 +143,21 @@ def monitor_pod(self, pod: V1Pod, get_logs: bool) -> Tup

[GitHub] [airflow] baryluk commented on a change in pull request #17649: Do not fail KubernetesPodOperator tasks if log following fails

2021-08-17 Thread GitBox
baryluk commented on a change in pull request #17649: URL: https://github.com/apache/airflow/pull/17649#discussion_r690766253 ## File path: airflow/providers/cncf/kubernetes/utils/pod_launcher.py ## @@ -143,12 +143,21 @@ def monitor_pod(self, pod: V1Pod, get_logs: bool) -> Tup

[GitHub] [airflow] baryluk commented on a change in pull request #17649: Do not fail KubernetesPodOperator tasks if log following fails

2021-08-17 Thread GitBox
baryluk commented on a change in pull request #17649: URL: https://github.com/apache/airflow/pull/17649#discussion_r690765281 ## File path: airflow/providers/cncf/kubernetes/utils/pod_launcher.py ## @@ -217,7 +223,7 @@ def base_container_is_running(self, pod: V1Pod):

[airflow] annotated tag 2.1.3rc1 updated (039d1af -> c46bccb)

2021-08-17 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to annotated tag 2.1.3rc1 in repository https://gitbox.apache.org/repos/asf/airflow.git. *** WARNING: tag 2.1.3rc1 was modified! *** from 039d1af (tag) to c46bccb (tag) tagging d25854dd413

[airflow] annotated tag 2.1.3rc1 updated (d25854d -> 039d1af)

2021-08-17 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to annotated tag 2.1.3rc1 in repository https://gitbox.apache.org/repos/asf/airflow.git. *** WARNING: tag 2.1.3rc1 was modified! *** from d25854d (commit) to 039d1af (tag) tagging d25854dd

[GitHub] [airflow] jedcunningham opened a new pull request #17670: Fix link to generating constraints in BREEZE.rst

2021-08-17 Thread GitBox
jedcunningham opened a new pull request #17670: URL: https://github.com/apache/airflow/pull/17670 Ran across this broken deep link when trying to generate constraints. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[airflow] branch v2-1-stable updated (d25854d -> 130e2f4)

2021-08-17 Thread jhtimmins
This is an automated email from the ASF dual-hosted git repository. jhtimmins pushed a change to branch v2-1-stable in repository https://gitbox.apache.org/repos/asf/airflow.git. from d25854d Update changelog with Python 3.9 support. (#16918) new 6720544 Fix permissions for CodeQL wor

[airflow] branch v2-1-test updated (6dc2d31 -> 332415a)

2021-08-17 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch v2-1-test in repository https://gitbox.apache.org/repos/asf/airflow.git. discard 6dc2d31 Add Changelog updates for 2.1.3 (#17644) discard b2dbe4b Remove repeated test. discard 236233c Im

[GitHub] [airflow] jedcunningham commented on a change in pull request #17649: Do not fail KubernetesPodOperator tasks if log following fails

2021-08-17 Thread GitBox
jedcunningham commented on a change in pull request #17649: URL: https://github.com/apache/airflow/pull/17649#discussion_r690623986 ## File path: airflow/providers/cncf/kubernetes/utils/pod_launcher.py ## @@ -217,7 +223,7 @@ def base_container_is_running(self, pod: V1Pod):

[GitHub] [airflow] jhtimmins merged pull request #17669: Sync v2-1-test and v2-1-stable

2021-08-17 Thread GitBox
jhtimmins merged pull request #17669: URL: https://github.com/apache/airflow/pull/17669 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[GitHub] [airflow] github-actions[bot] commented on pull request #17669: Sync v2-1-test and v2-1-stable

2021-08-17 Thread GitBox
github-actions[bot] commented on pull request #17669: URL: https://github.com/apache/airflow/pull/17669#issuecomment-900662858 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

[airflow] branch v2-1-test updated (e6478fe -> 6dc2d31)

2021-08-17 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch v2-1-test in repository https://gitbox.apache.org/repos/asf/airflow.git. omit e6478fe Add Changelog updates for 2.1.3 (#17644) omit 489f9be Remove repeated test. omit 8f3cce6 Im

[GitHub] [airflow] github-actions[bot] commented on pull request #17667: [DOCS] Update DAG.is_active property

2021-08-17 Thread GitBox
github-actions[bot] commented on pull request #17667: URL: https://github.com/apache/airflow/pull/17667#issuecomment-900658458 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not m

[GitHub] [airflow] kaxil opened a new pull request #17669: Sync v2-1-test and v2-1-stable

2021-08-17 Thread GitBox
kaxil opened a new pull request #17669: URL: https://github.com/apache/airflow/pull/17669 Just needs an approval so that we can push commits from v2-1-test to v2-1-stable --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github

[GitHub] [airflow] kaxil closed pull request #17668: Prepare v2 1 3

2021-08-17 Thread GitBox
kaxil closed pull request #17668: URL: https://github.com/apache/airflow/pull/17668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [airflow] jhtimmins opened a new pull request #17668: Prepare v2 1 3

2021-08-17 Thread GitBox
jhtimmins opened a new pull request #17668: URL: https://github.com/apache/airflow/pull/17668 v2-1-test is stable. So this PR attempts to sync v2-1-stable with v2-1-test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[airflow] 05/06: Remove repeated test.

2021-08-17 Thread jhtimmins
This is an automated email from the ASF dual-hosted git repository. jhtimmins pushed a commit to branch v2-1-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 489f9be29892cd82abfc34742ec5f921817ee51a Author: James Timmins AuthorDate: Mon Aug 16 19:04:13 2021 -0700 Re

[airflow] 03/06: Fix task retries when they receive sigkill and have retries and properly handle sigterm (#16301)

2021-08-17 Thread jhtimmins
This is an automated email from the ASF dual-hosted git repository. jhtimmins pushed a commit to branch v2-1-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 4f2f346b84c5102d5f636214d920258edaa036db Author: Ephraim Anierobi AuthorDate: Wed Jul 28 15:57:35 2021 +0100

[airflow] 02/06: Add Pytest fixture to create dag and dagrun and use it on local task job tests (#16889)

2021-08-17 Thread jhtimmins
This is an automated email from the ASF dual-hosted git repository. jhtimmins pushed a commit to branch v2-1-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 95e251af19e884ae249975111d9bedf33d8ca004 Author: Ephraim Anierobi AuthorDate: Tue Jul 20 18:48:35 2021 +0100

[airflow] 06/06: Add Changelog updates for 2.1.3 (#17644)

2021-08-17 Thread jhtimmins
This is an automated email from the ASF dual-hosted git repository. jhtimmins pushed a commit to branch v2-1-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit e6478fe749aeed18d5c73249cfe037fd5769197b Author: James Timmins AuthorDate: Tue Aug 17 14:12:35 2021 -0700 Ad

[airflow] 04/06: Improve `dag_maker` fixture (#17324)

2021-08-17 Thread jhtimmins
This is an automated email from the ASF dual-hosted git repository. jhtimmins pushed a commit to branch v2-1-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 8f3cce6e2e7a3f831c1abeeeccbab9b4e9ff789e Author: Ephraim Anierobi AuthorDate: Mon Aug 2 07:37:40 2021 +0100

[airflow] branch v2-1-test updated (02d3703 -> e6478fe)

2021-08-17 Thread jhtimmins
This is an automated email from the ASF dual-hosted git repository. jhtimmins pushed a change to branch v2-1-test in repository https://gitbox.apache.org/repos/asf/airflow.git. from 02d3703 Add Changelog updates for 2.1.3 new 970c6a2 Run mini scheduler in LocalTaskJob during task exit

[airflow] 01/06: Run mini scheduler in LocalTaskJob during task exit (#16289)

2021-08-17 Thread jhtimmins
This is an automated email from the ASF dual-hosted git repository. jhtimmins pushed a commit to branch v2-1-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 970c6a2af420156c51137772e138d4f6e7313360 Author: Ephraim Anierobi AuthorDate: Thu Jun 10 14:29:30 2021 +0100

[GitHub] [airflow] gmcrocetti opened a new pull request #17667: [DOCS] Update DAG.is_active property

2021-08-17 Thread GitBox
gmcrocetti opened a new pull request #17667: URL: https://github.com/apache/airflow/pull/17667 Description --- Pretty simple patch updating documentation. Adds `readOnly=True` to `DAG.is_active`. closes: #17639 --- **^ Add meaningful description above** Read the *

[airflow] 02/02: Add Changelog updates for 2.1.3

2021-08-17 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch v2-1-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 02d370312ea962999c545a40259ed0980856699a Author: James Timmins AuthorDate: Mon Aug 16 18:39:18 2021 -0700 Ad

[airflow] branch v2-1-test updated (dff4950 -> 02d3703)

2021-08-17 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch v2-1-test in repository https://gitbox.apache.org/repos/asf/airflow.git. discard dff4950 Forces rebuilding the image for cache pushing discard f5954bb Add Changelog updates for 2.1.3

[airflow] 01/02: Forces rebuilding the image for cache pushing

2021-08-17 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch v2-1-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 53b3adba13f9839eb5fb9285fea6383fd40fc4a4 Author: Jarek Potiuk AuthorDate: Mon Aug 16 16:07:47 2021 +0200 For

[GitHub] [airflow] ShakaibKhan commented on pull request #15385: Added table to view providers in airflow ui under admin tab

2021-08-17 Thread GitBox
ShakaibKhan commented on pull request #15385: URL: https://github.com/apache/airflow/pull/15385#issuecomment-900638820 Looks like I re-commited all my commits. Although pre-commit and statickcheck passed locally -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [airflow] potiuk commented on issue #17662: Dags volume not getting mounted in webserver pod?

2021-08-17 Thread GitBox
potiuk commented on issue #17662: URL: https://github.com/apache/airflow/issues/17662#issuecomment-900638058 See this page - it explains everything https://airflow.apache.org/docs/apache-airflow/stable/dag-serialization.html -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] potiuk commented on issue #17662: Dags volume not getting mounted in webserver pod?

2021-08-17 Thread GitBox
potiuk commented on issue #17662: URL: https://github.com/apache/airflow/issues/17662#issuecomment-900637436 This has been also possible to not mount dags in few last versions of airflow if you had serialization turned on BTW. Simply in Airlfow 2 Dag Serialization is the only way. -- T

[GitHub] [airflow] potiuk commented on issue #17662: Dags volume not getting mounted in webserver pod?

2021-08-17 Thread GitBox
potiuk commented on issue #17662: URL: https://github.com/apache/airflow/issues/17662#issuecomment-900636540 This is also done through DB - there is a DB "import errors" that is populated by scheduler (and I believe it's always been like that) -- This is an automated message from the Ap

[airflow] branch main updated (c22ed08 -> 808fb2a)

2021-08-17 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from c22ed08 Chart: use serviceaccount template for log reader rolebinding (#17645) add 808fb2a Add Changelog up

[GitHub] [airflow] kaxil merged pull request #17644: Add Changelog updates for 2.1.3

2021-08-17 Thread GitBox
kaxil merged pull request #17644: URL: https://github.com/apache/airflow/pull/17644 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [airflow] kaxil commented on a change in pull request #17644: Add Changelog updates for 2.1.3

2021-08-17 Thread GitBox
kaxil commented on a change in pull request #17644: URL: https://github.com/apache/airflow/pull/17644#discussion_r690726494 ## File path: CHANGELOG.txt ## @@ -1,3 +1,62 @@ +Airflow 2.1.3, 2021-08-23 +- + +Bug Fixes +" + +- Fix task retries when t

[GitHub] [airflow] kn6405 commented on issue #17662: Dags volume not getting mounted in webserver pod?

2021-08-17 Thread GitBox
kn6405 commented on issue #17662: URL: https://github.com/apache/airflow/issues/17662#issuecomment-900632611 > This is correct behaviour. Dags no longer need to be mounted in Webserver in Airflow 2. Webserver reads everything it needs from Serialized DAGs table and will never read DAGs fro

[GitHub] [airflow] potiuk commented on issue #17662: Dags volume not getting mounted in webserver pod?

2021-08-17 Thread GitBox
potiuk commented on issue #17662: URL: https://github.com/apache/airflow/issues/17662#issuecomment-900624765 This is correct behaviour. Dags no longer need to be mounted in Webserver in Airflow 2. Webserver reads everything it needs from Serialized DAGs table and will never read DAGs from

[GitHub] [airflow] potiuk closed issue #17662: Dags volume not getting mounted in webserver pod?

2021-08-17 Thread GitBox
potiuk closed issue #17662: URL: https://github.com/apache/airflow/issues/17662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

  1   2   3   >