[GitHub] [calcite] julianhyde commented on a diff in pull request #2988: [CALCITE-5399] Remove Proj4J from the api dependencies

2022-11-29 Thread GitBox
julianhyde commented on code in PR #2988: URL: https://github.com/apache/calcite/pull/2988#discussion_r1035407621 ## site/_docs/howto.md: ## @@ -841,6 +841,8 @@ your key to the keyservers used by Nexus, see above. that the `META-INF` directory contains `LICENSE`, `NOTICE`

[GitHub] [calcite] julianhyde commented on a diff in pull request #2988: [CALCITE-5399] Remove Proj4J from the api dependencies

2022-11-29 Thread GitBox
julianhyde commented on code in PR #2988: URL: https://github.com/apache/calcite/pull/2988#discussion_r1035403678 ## site/_docs/howto.md: ## @@ -841,6 +841,8 @@ your key to the keyservers used by Nexus, see above. that the `META-INF` directory contains `LICENSE`, `NOTICE`

[calcite] branch main updated: [CALCITE-5259] Add getParameterRowType method to Planner interface

2022-11-29 Thread jbalint
This is an automated email from the ASF dual-hosted git repository. jbalint pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 531dc3d3fa [CALCITE-5259] Add getParameterRowType

[GitHub] [calcite] jbalint merged pull request #2890: [CALCITE-5259] Add getParameterRowType method to Planner interface

2022-11-29 Thread GitBox
jbalint merged PR #2890: URL: https://github.com/apache/calcite/pull/2890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] jbalint commented on a diff in pull request #2890: [CALCITE-5259] Add getParameterRowType method to Planner interface

2022-11-29 Thread GitBox
jbalint commented on code in PR #2890: URL: https://github.com/apache/calcite/pull/2890#discussion_r1035051360 ## core/src/main/java/org/apache/calcite/prepare/PlannerImpl.java: ## @@ -237,6 +237,15 @@ private void ready() { return Pair.of(validatedNode, type); } +

[GitHub] [calcite] bchapuis commented on a diff in pull request #2988: [CALCITE-5399] Remove Proj4J from the api dependencies

2022-11-29 Thread GitBox
bchapuis commented on code in PR #2988: URL: https://github.com/apache/calcite/pull/2988#discussion_r1034935144 ## site/_docs/howto.md: ## @@ -841,6 +841,8 @@ your key to the keyservers used by Nexus, see above. that the `META-INF` directory contains `LICENSE`, `NOTICE`

[GitHub] [calcite] bchapuis commented on a diff in pull request #2988: [CALCITE-5399] Remove Proj4J from the api dependencies

2022-11-29 Thread GitBox
bchapuis commented on code in PR #2988: URL: https://github.com/apache/calcite/pull/2988#discussion_r1034935144 ## site/_docs/howto.md: ## @@ -841,6 +841,8 @@ your key to the keyservers used by Nexus, see above. that the `META-INF` directory contains `LICENSE`, `NOTICE`

[GitHub] [calcite] bchapuis commented on a diff in pull request #2988: [CALCITE-5399] Remove Proj4J from the api dependencies

2022-11-29 Thread GitBox
bchapuis commented on code in PR #2988: URL: https://github.com/apache/calcite/pull/2988#discussion_r1034935144 ## site/_docs/howto.md: ## @@ -841,6 +841,8 @@ your key to the keyservers used by Nexus, see above. that the `META-INF` directory contains `LICENSE`, `NOTICE`

[GitHub] [calcite] bchapuis commented on a diff in pull request #2988: [CALCITE-5399] Remove Proj4J from the api dependencies

2022-11-29 Thread GitBox
bchapuis commented on code in PR #2988: URL: https://github.com/apache/calcite/pull/2988#discussion_r1034935144 ## site/_docs/howto.md: ## @@ -841,6 +841,8 @@ your key to the keyservers used by Nexus, see above. that the `META-INF` directory contains `LICENSE`, `NOTICE`

[GitHub] [calcite] dssysolyatin commented on a diff in pull request #2890: [CALCITE-5259] Add getParameterRowType method to Planner interface

2022-11-29 Thread GitBox
dssysolyatin commented on code in PR #2890: URL: https://github.com/apache/calcite/pull/2890#discussion_r1034930593 ## core/src/main/java/org/apache/calcite/prepare/PlannerImpl.java: ## @@ -237,6 +237,15 @@ private void ready() { return Pair.of(validatedNode, type); }

[GitHub] [calcite] jbalint commented on a diff in pull request #2890: [CALCITE-5259] Add getParameterRowType method to Planner interface

2022-11-29 Thread GitBox
jbalint commented on code in PR #2890: URL: https://github.com/apache/calcite/pull/2890#discussion_r1034916228 ## core/src/main/java/org/apache/calcite/prepare/PlannerImpl.java: ## @@ -237,6 +237,15 @@ private void ready() { return Pair.of(validatedNode, type); } +

[calcite] 01/02: [CALCITE-5217] Add support for INTERVAL qualifier for Firebolt

2022-11-29 Thread jbalint
This is an automated email from the ASF dual-hosted git repository. jbalint pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git commit bae84c7e17e038169fefb7119bfd43af6707f8da Author: Aymeric AuthorDate: Sat Jul 23 09:50:04 2022 +0100 [CALCITE-5217]

[calcite] 02/02: [CALCITE-5217] Improve support for INTERVAL qualifier for Firebolt

2022-11-29 Thread jbalint
This is an automated email from the ASF dual-hosted git repository. jbalint pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git commit 35c879044c3a1178760009fae0dd583e79856371 Author: Aymeric AuthorDate: Wed Jul 27 17:04:23 2022 +0100 [CALCITE-5217]

[calcite] branch main updated (52922f9a67 -> 35c879044c)

2022-11-29 Thread jbalint
This is an automated email from the ASF dual-hosted git repository. jbalint pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git from 52922f9a67 Upgrade jackson to 2.14.1 new bae84c7e17 [CALCITE-5217] Add support for INTERVAL qualifier for

[GitHub] [calcite] jbalint merged pull request #2860: [CALCITE-5217] Add support for INTERVAL qualifier for Firebolt

2022-11-29 Thread GitBox
jbalint merged PR #2860: URL: https://github.com/apache/calcite/pull/2860 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] dssysolyatin commented on pull request #2819: [CALCITE-5159] Postgres dialect should support implicit cast from string literal to array literal

2022-11-29 Thread GitBox
dssysolyatin commented on PR #2819: URL: https://github.com/apache/calcite/pull/2819#issuecomment-1330769024 @julianhyde if you have time, please review this PR again. This PR is actively used in one of our project, I have to fix conflicts quite often. Thanks ! -- This is an automated

[GitHub] [calcite] bchapuis commented on a diff in pull request #2988: [CALCITE-5399] Remove Proj4J from the api dependencies

2022-11-29 Thread GitBox
bchapuis commented on code in PR #2988: URL: https://github.com/apache/calcite/pull/2988#discussion_r1034797722 ## core/build.gradle.kts: ## @@ -57,6 +54,11 @@ dependencies { api("org.checkerframework:checker-qual") api("org.slf4j:slf4j-api") +

[GitHub] [calcite] bchapuis commented on a diff in pull request #2988: [CALCITE-5399] Remove Proj4J from the api dependencies

2022-11-29 Thread GitBox
bchapuis commented on code in PR #2988: URL: https://github.com/apache/calcite/pull/2988#discussion_r1034797722 ## core/build.gradle.kts: ## @@ -57,6 +54,11 @@ dependencies { api("org.checkerframework:checker-qual") api("org.slf4j:slf4j-api") +

[GitHub] [calcite] bchapuis commented on a diff in pull request #2988: [CALCITE-5399] Remove Proj4J from the api dependencies

2022-11-29 Thread GitBox
bchapuis commented on code in PR #2988: URL: https://github.com/apache/calcite/pull/2988#discussion_r1034797722 ## core/build.gradle.kts: ## @@ -57,6 +54,11 @@ dependencies { api("org.checkerframework:checker-qual") api("org.slf4j:slf4j-api") +

[GitHub] [calcite] bchapuis commented on a diff in pull request #2988: [CALCITE-5399] Remove Proj4J from the api dependencies

2022-11-29 Thread GitBox
bchapuis commented on code in PR #2988: URL: https://github.com/apache/calcite/pull/2988#discussion_r1034737271 ## core/build.gradle.kts: ## @@ -57,6 +54,11 @@ dependencies { api("org.checkerframework:checker-qual") api("org.slf4j:slf4j-api") +

[GitHub] [calcite] bchapuis commented on a diff in pull request #2988: [CALCITE-5399] Remove Proj4J from the api dependencies

2022-11-29 Thread GitBox
bchapuis commented on code in PR #2988: URL: https://github.com/apache/calcite/pull/2988#discussion_r1034723743 ## core/src/main/java/org/apache/calcite/runtime/ProjectionTransformer.java: ## @@ -40,6 +40,14 @@ /** * Transforms the projection of a geometry. + * + * This

[GitHub] [calcite] zabetak commented on a diff in pull request #2988: [CALCITE-5399] Remove Proj4J from the api dependencies

2022-11-29 Thread GitBox
zabetak commented on code in PR #2988: URL: https://github.com/apache/calcite/pull/2988#discussion_r1034587984 ## site/_docs/howto.md: ## @@ -841,6 +841,8 @@ your key to the keyservers used by Nexus, see above. that the `META-INF` directory contains `LICENSE`, `NOTICE` *

[GitHub] [calcite] libenchao commented on pull request #2868: [CALCITE-5230] Fix PERCENTILE_DISC return type derivation

2022-11-29 Thread GitBox
libenchao commented on PR #2868: URL: https://github.com/apache/calcite/pull/2868#issuecomment-1330293444 @julianhyde Very thanks for the reminder  , I did plan to do that while merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [calcite] julianhyde commented on pull request #2868: [CALCITE-5230] Fix PERCENTILE_DISC return type derivation

2022-11-29 Thread GitBox
julianhyde commented on PR #2868: URL: https://github.com/apache/calcite/pull/2868#issuecomment-1330281838 @libenchao when you merge, please change the commit message to something that doesn’t start with “fix” -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] rubenada commented on a diff in pull request #2988: [CALCITE-5399] Remove Proj4J from the api dependencies

2022-11-29 Thread GitBox
rubenada commented on code in PR #2988: URL: https://github.com/apache/calcite/pull/2988#discussion_r1034434709 ## core/src/main/java/org/apache/calcite/runtime/ProjectionTransformer.java: ## @@ -40,6 +40,14 @@ /** * Transforms the projection of a geometry. + * + * This