davsclaus merged PR #1097:
URL: https://github.com/apache/camel-spring-boot/pull/1097
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lburgazzoli commented on code in PR #1097:
URL:
https://github.com/apache/camel-spring-boot/pull/1097#discussion_r1511402167
##
core/camel-spring-boot-xml/src/main/java/org/apache/camel/spring/boot/xml/SpringBootXmlCamelContextConfigurer.java:
##
@@ -47,6 +45,8 @@ public void
davsclaus commented on PR #1097:
URL:
https://github.com/apache/camel-spring-boot/pull/1097#issuecomment-1976782101
There was some leftover in the camel-spring-boot core module. If this gets
reverted then this PR is only adding a new camel-k module, and then its perfect
fine to merged.
davsclaus commented on code in PR #1097:
URL:
https://github.com/apache/camel-spring-boot/pull/1097#discussion_r1511302250
##
core/camel-spring-boot-xml/src/main/java/org/apache/camel/spring/boot/xml/SpringBootXmlCamelContextConfigurer.java:
##
@@ -47,6 +45,8 @@ public void
davsclaus commented on code in PR #1097:
URL:
https://github.com/apache/camel-spring-boot/pull/1097#discussion_r1511301812
##
core/camel-spring-boot/src/main/java/org/apache/camel/spring/boot/CamelAutoConfiguration.java:
##
@@ -95,11 +95,14 @@ public class
lburgazzoli commented on PR #1097:
URL:
https://github.com/apache/camel-spring-boot/pull/1097#issuecomment-1976686609
ok so now failures are because there is no yet a -SNAPSHOT ready
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
davsclaus commented on PR #1097:
URL:
https://github.com/apache/camel-spring-boot/pull/1097#issuecomment-1976601318
pushed fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
davsclaus commented on PR #1097:
URL:
https://github.com/apache/camel-spring-boot/pull/1097#issuecomment-1976596363
fixing this now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
davsclaus commented on PR #1097:
URL:
https://github.com/apache/camel-spring-boot/pull/1097#issuecomment-1976589949
Ah sorry its those darn test copy from core, that have little value and get
out of date
--
This is an automated message from the Apache Git Service.
To respond to the
lburgazzoli commented on PR #1097:
URL:
https://github.com/apache/camel-spring-boot/pull/1097#issuecomment-1976589846
> Are you on old code ?
No, rebased on main, I see that OpenApi v2 is hardcoded in some of the tests
davsclaus commented on PR #1097:
URL:
https://github.com/apache/camel-spring-boot/pull/1097#issuecomment-1976582513
Are you on old code ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lburgazzoli commented on PR #1097:
URL:
https://github.com/apache/camel-spring-boot/pull/1097#issuecomment-1976570366
Looks like there are some issues related to openapi v2 rmeoval
```
[INFO] Running org.apache.camel.openapi.RestOpenApiReaderTest
[ERROR] Tests run: 1, Failures:
lburgazzoli commented on code in PR #1097:
URL:
https://github.com/apache/camel-spring-boot/pull/1097#discussion_r1511013365
##
core/camel-spring-boot/src/main/java/org/apache/camel/spring/boot/CamelAutoConfiguration.java:
##
@@ -95,19 +99,23 @@ public class
lburgazzoli commented on code in PR #1097:
URL:
https://github.com/apache/camel-spring-boot/pull/1097#discussion_r1511013049
##
core/camel-spring-boot-xml/src/main/java/org/apache/camel/spring/boot/xml/SpringBootXmlCamelContextConfigurer.java:
##
@@ -47,7 +49,9 @@ public void
lburgazzoli commented on code in PR #1097:
URL:
https://github.com/apache/camel-spring-boot/pull/1097#discussion_r1511012570
##
core/camel-spring-boot/src/main/java/org/apache/camel/spring/boot/CamelAutoConfiguration.java:
##
@@ -189,6 +197,12 @@ public static CamelContext
lburgazzoli commented on code in PR #1097:
URL:
https://github.com/apache/camel-spring-boot/pull/1097#discussion_r1508827045
##
core/camel-spring-boot/src/main/java/org/apache/camel/spring/boot/CamelAutoConfiguration.java:
##
@@ -189,6 +197,12 @@ public static CamelContext
davsclaus commented on code in PR #1097:
URL:
https://github.com/apache/camel-spring-boot/pull/1097#discussion_r1508650701
##
core/camel-spring-boot/src/main/java/org/apache/camel/spring/boot/CamelAutoConfiguration.java:
##
@@ -95,19 +99,23 @@ public class
davsclaus commented on code in PR #1097:
URL:
https://github.com/apache/camel-spring-boot/pull/1097#discussion_r1508650168
##
core/camel-spring-boot-xml/src/main/java/org/apache/camel/spring/boot/xml/SpringBootXmlCamelContextConfigurer.java:
##
@@ -47,7 +49,9 @@ public void
davsclaus commented on code in PR #1097:
URL:
https://github.com/apache/camel-spring-boot/pull/1097#discussion_r1508649146
##
core/camel-spring-boot/src/main/java/org/apache/camel/spring/boot/CamelAutoConfiguration.java:
##
@@ -189,6 +197,12 @@ public static CamelContext
davsclaus commented on code in PR #1097:
URL:
https://github.com/apache/camel-spring-boot/pull/1097#discussion_r1508649398
##
core/camel-spring-boot/src/main/java/org/apache/camel/spring/boot/CamelAutoConfiguration.java:
##
@@ -189,6 +197,12 @@ public static CamelContext
davsclaus commented on code in PR #1097:
URL:
https://github.com/apache/camel-spring-boot/pull/1097#discussion_r1508646772
##
core/camel-spring-boot/src/main/java/org/apache/camel/spring/boot/CamelAutoConfiguration.java:
##
@@ -189,6 +197,12 @@ public static CamelContext
davsclaus commented on code in PR #1097:
URL:
https://github.com/apache/camel-spring-boot/pull/1097#discussion_r1508642687
##
core/camel-spring-boot/src/main/java/org/apache/camel/spring/boot/CamelAutoConfiguration.java:
##
@@ -189,6 +197,12 @@ public static CamelContext
lburgazzoli commented on code in PR #1097:
URL:
https://github.com/apache/camel-spring-boot/pull/1097#discussion_r1508642462
##
core/camel-spring-boot/src/main/java/org/apache/camel/spring/boot/CamelAutoConfiguration.java:
##
@@ -189,6 +197,12 @@ public static CamelContext
davsclaus commented on code in PR #1097:
URL:
https://github.com/apache/camel-spring-boot/pull/1097#discussion_r1508641940
##
core/camel-spring-boot/src/main/java/org/apache/camel/spring/boot/CamelAutoConfiguration.java:
##
@@ -189,6 +197,12 @@ public static CamelContext
davsclaus commented on code in PR #1097:
URL:
https://github.com/apache/camel-spring-boot/pull/1097#discussion_r1508638758
##
core/camel-spring-boot/src/main/java/org/apache/camel/spring/boot/CamelAutoConfiguration.java:
##
@@ -189,6 +197,12 @@ public static CamelContext
lburgazzoli commented on code in PR #1097:
URL:
https://github.com/apache/camel-spring-boot/pull/1097#discussion_r1507505050
##
core/camel-spring-boot/src/main/java/org/apache/camel/spring/boot/CamelAutoConfiguration.java:
##
@@ -189,6 +197,12 @@ public static CamelContext
lburgazzoli commented on code in PR #1097:
URL:
https://github.com/apache/camel-spring-boot/pull/1097#discussion_r1507505050
##
core/camel-spring-boot/src/main/java/org/apache/camel/spring/boot/CamelAutoConfiguration.java:
##
@@ -189,6 +197,12 @@ public static CamelContext
lburgazzoli opened a new pull request, #1097:
URL: https://github.com/apache/camel-spring-boot/pull/1097
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
28 matches
Mail list logo