[GitHub] rafaelweingartner commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'.

2018-04-16 Thread GitBox
rafaelweingartner commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'. URL: https://github.com/apache/cloudstack/pull/2572#issuecomment-381552499 @borisstoyanov yes I did. I created RPM packages with this PR, then I installed them, and used ACS to see if there was

[GitHub] rafaelweingartner commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'.

2018-04-13 Thread GitBox
rafaelweingartner commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'. URL: https://github.com/apache/cloudstack/pull/2572#issuecomment-381159586 The method `encodeURIComponent` is not a third party library. It is a native function in Javascript.

[GitHub] rafaelweingartner commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'.

2018-04-13 Thread GitBox
rafaelweingartner commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'. URL: https://github.com/apache/cloudstack/pull/2572#issuecomment-381138853 Good question. Why not use directly a function that everybody knows (everybody that works with javascript)? When

[GitHub] rafaelweingartner commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'.

2018-04-13 Thread GitBox
rafaelweingartner commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'. URL: https://github.com/apache/cloudstack/pull/2572#issuecomment-381138853 Good question. Why not use directly a function that everybody knows (everybody that works with javascript)? When