LiangliangSui commented on PR #1474:
URL: https://github.com/apache/incubator-fury/pull/1474#issuecomment-2041312743
> LGTM, We may need to update our pr template too
The pr template already contains [perf
This is an automated email from the ASF dual-hosted git repository.
chaokunyang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-fury.git
The following commit(s) were added to refs/heads/main by this push:
new f892802f docs: Use perf type when pr
chaokunyang merged PR #1474:
URL: https://github.com/apache/incubator-fury/pull/1474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
LiangliangSui opened a new pull request, #1474:
URL: https://github.com/apache/incubator-fury/pull/1474
When PR has an impact on Fury performance, it is recommended to use perf
type and provide benchmark data in the PR description.
--
This is an automated message from the Apache Git
LiangliangSui commented on issue #1459:
URL:
https://github.com/apache/incubator-fury/issues/1459#issuecomment-2041296983
I agree with you, `Fury` and `ClassRegister` have a `has-a` relationship.
If we don't implement some interfaces in `FuryBuilder`, then we can only
repeatedly
chaokunyang commented on issue #1459:
URL:
https://github.com/apache/incubator-fury/issues/1459#issuecomment-2041287630
I perfer not. `Fury` is not a `ClassRegister`, there is no such a
straightforward `is-a` relationship between these two classes. And it's not
that intuitive for a
GitHub user chaokunyang added a comment to the discussion: At least two owners
approve before they can be merged PR.
That's what I want to do too. But our community is still in early stage, not
all code owner are always online, and unfortunately
we don't have enough owners at this time. So I
GitHub user chaokunyang edited a comment on the discussion: At least two owners
approve before they can be merged PR.
@LiangliangSui That's what I want to do too. But our community is still in
early stage, not all code owner are always online, and unfortunately
we don't have enough owners at
This is an automated email from the ASF dual-hosted git repository.
chaokunyang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-fury.git
The following commit(s) were added to refs/heads/main by this push:
new d28b14da chore(java): add comments for
chaokunyang merged PR #1450:
URL: https://github.com/apache/incubator-fury/pull/1450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chaokunyang commented on code in PR #1472:
URL: https://github.com/apache/incubator-fury/pull/1472#discussion_r1554641365
##
java/fury-core/src/test/java/org/apache/fury/serializer/PrimitiveSerializersTest.java:
##
@@ -54,4 +59,62 @@ public void testUint16Serializer() {
chaokunyang commented on PR #1472:
URL: https://github.com/apache/incubator-fury/pull/1472#issuecomment-2041145222
Here is the benchmark result:
```
With This PR:
Benchmark (bufferType) (objectType)
(references) Mode CntScore
chaokunyang commented on PR #1472:
URL: https://github.com/apache/incubator-fury/pull/1472#issuecomment-2041140777
> Hi @chaokunyang , I have a suggestion. For this kind of optimization PR,
we should force the submitter to provide a benchmark data in the PR, so that we
can ensure that the
chaokunyang commented on code in PR #1472:
URL: https://github.com/apache/incubator-fury/pull/1472#discussion_r1554641365
##
java/fury-core/src/test/java/org/apache/fury/serializer/PrimitiveSerializersTest.java:
##
@@ -54,4 +59,62 @@ public void testUint16Serializer() {
chaokunyang commented on code in PR #1472:
URL: https://github.com/apache/incubator-fury/pull/1472#discussion_r1554641104
##
java/fury-core/src/main/java/org/apache/fury/memory/MemoryBuffer.java:
##
@@ -2318,6 +2205,37 @@ public float readFloat() {
}
}
+ // Reduce
chaokunyang commented on code in PR #1434:
URL: https://github.com/apache/incubator-fury/pull/1434#discussion_r1554640857
##
java/fury-core/src/main/java/org/apache/fury/memory/MemoryBuffer.java:
##
@@ -1233,49 +1233,9 @@ public int readVarInt() {
* to avoid using two
chaokunyang commented on PR #1451:
URL: https://github.com/apache/incubator-fury/pull/1451#issuecomment-2041128594
New readBytesString are too large for inline:
Old version:
LiangliangSui commented on issue #1459:
URL:
https://github.com/apache/incubator-fury/issues/1459#issuecomment-2041122588
> One concern is that BaseFury already supports register
classes/serializers, do we still need to add this API to FuryBuilder?
We can extract all `register(...)`
LiangliangSui commented on code in PR #1468:
URL: https://github.com/apache/incubator-fury/pull/1468#discussion_r1554628240
##
docs/guide/xlang_type_mapping.md:
##
@@ -4,4 +4,75 @@ sidebar_position: 3
id: xlang_type_mapping
---
-Coming soon.
+Note:
+
+- For type definition,
LiangliangSui commented on code in PR #1468:
URL: https://github.com/apache/incubator-fury/pull/1468#discussion_r1554628240
##
docs/guide/xlang_type_mapping.md:
##
@@ -4,4 +4,75 @@ sidebar_position: 3
id: xlang_type_mapping
---
-Coming soon.
+Note:
+
+- For type definition,
LiangliangSui commented on code in PR #1434:
URL: https://github.com/apache/incubator-fury/pull/1434#discussion_r1554626407
##
java/fury-core/src/main/java/org/apache/fury/memory/MemoryBuffer.java:
##
@@ -1233,49 +1233,9 @@ public int readVarInt() {
* to avoid using two
LiangliangSui commented on code in PR #1434:
URL: https://github.com/apache/incubator-fury/pull/1434#discussion_r1554626407
##
java/fury-core/src/main/java/org/apache/fury/memory/MemoryBuffer.java:
##
@@ -1233,49 +1233,9 @@ public int readVarInt() {
* to avoid using two
LiangliangSui commented on PR #1472:
URL: https://github.com/apache/incubator-fury/pull/1472#issuecomment-204294
Hi @chaokunyang , I have a suggestion. For this kind of optimization PR, we
should force the submitter to provide a benchmark data in the PR, so that we
can ensure that the
LiangliangSui commented on code in PR #1472:
URL: https://github.com/apache/incubator-fury/pull/1472#discussion_r1554623191
##
java/fury-core/src/test/java/org/apache/fury/serializer/PrimitiveSerializersTest.java:
##
@@ -54,4 +59,62 @@ public void testUint16Serializer() {
LiangliangSui commented on PR #1450:
URL: https://github.com/apache/incubator-fury/pull/1450#issuecomment-2041108710
> @LiangliangSui There are some conflict between your branch and main
branch, could you resolve the conflict?
Updated, ptal.
--
This is an automated message from
The GitHub Actions job "Fury CI" on incubator-fury.git has succeeded.
Run started by GitHub user LiangliangSui (triggered by LiangliangSui).
Head commit for run:
63750ec67139b4a6a48af455ae144ae96a0d0516 / LiangliangSui
Rerun ci.
Signed-off-by: LiangliangSui
Report URL:
The GitHub Actions job "Fury CI" on incubator-fury.git has failed.
Run started by GitHub user LiangliangSui (triggered by LiangliangSui).
Head commit for run:
3a31459121599362de7e480fd351d86b52cfe05a / LiangliangSui
chore(java): Add comments for loop unrolling
Signed-off-by: LiangliangSui
chaokunyang commented on PR #1451:
URL: https://github.com/apache/incubator-fury/pull/1451#issuecomment-2041104708
Method spilit threshold:
- 15
```
Benchmark (bufferType) (objectType)
(references) Mode CntScoreError Units
The GitHub Actions job "Fury CI" on incubator-fury.git has failed.
Run started by GitHub user chaokunyang (triggered by chaokunyang).
Head commit for run:
4932c70708687df07c1c0ff0ea98fa0e639c9f57 / chaokunyang
import platform
Report URL:
The GitHub Actions job "Fury CI" on incubator-fury.git has failed.
Run started by GitHub user chaokunyang (triggered by chaokunyang).
Head commit for run:
e30effa9c5b549b03a2a0e59a33700d7ce3ba3fa / chaokunyang
import platform
Report URL:
The GitHub Actions job "Fury CI" on incubator-fury.git has failed.
Run started by GitHub user chaokunyang (triggered by chaokunyang).
Head commit for run:
98a028a55e7053c1200b6b9720281ab593a8b03c / chaokunyang
fix merge conflict
Report URL:
The GitHub Actions job "Fury CI" on incubator-fury.git has failed.
Run started by GitHub user chaokunyang (triggered by chaokunyang).
Head commit for run:
3c0fb9dd2a1df4cb5752e7db48d95d9c59c28f1f / chaokunyang
Merge remote-tracking branch 'ant/main' into streaming_deserialization
Report URL:
This is an automated email from the ASF dual-hosted git repository.
chaokunyang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-fury.git
The following commit(s) were added to refs/heads/main by this push:
new 1d302ef1 feat(java): optimize read
chaokunyang merged PR #1472:
URL: https://github.com/apache/incubator-fury/pull/1472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
The GitHub Actions job "Fury CI" on incubator-fury.git has succeeded.
Run started by GitHub user theweipeng (triggered by theweipeng).
Head commit for run:
959796233fdd25a3bf47bc2dd75c6d60e5d7d08e / Shawn Yang
feat(spec): add xlang type mapping (#1468)
Report URL:
The GitHub Actions job "Fury CI" on incubator-fury.git has succeeded.
Run started by GitHub user chaokunyang (triggered by chaokunyang).
Head commit for run:
c42cdd4592802183e79342d7fbf8c85c115f327e / chaokunyang
fix unsafeGetDouble
Report URL:
The GitHub Actions job "Fury CI" on incubator-fury.git has failed.
Run started by GitHub user chaokunyang (triggered by chaokunyang).
Head commit for run:
93940b91be52e9048a5d57ebb1715f78d3659b22 / chaokunyang
fix unsafeGetDouble
Report URL:
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch deploy
in repository https://gitbox.apache.org/repos/asf/incubator-fury-site.git
The following commit(s) were added to refs/heads/deploy by this push:
new 0ca9a20 deploy:
theweipeng commented on code in PR #1468:
URL: https://github.com/apache/incubator-fury/pull/1468#discussion_r1554556705
##
docs/guide/xlang_type_mapping.md:
##
@@ -4,4 +4,75 @@ sidebar_position: 3
id: xlang_type_mapping
---
-Coming soon.
+Note:
+
+- For type definition,
This is an automated email from the ASF dual-hosted git repository.
chaokunyang pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-fury-site.git
from d6f914d add fury serialization specification tab (#108)
new 45472f0 synced local
The GitHub Actions job "Fury CI" on incubator-fury.git has failed.
Run started by GitHub user chaokunyang (triggered by chaokunyang).
Head commit for run:
cd2390b3257d5e4040b6593662d098e2f44fb20b / chaokunyang
fix merge conflict
Report URL:
This is an automated email from the ASF dual-hosted git repository.
chaokunyang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-fury-site.git
commit 45472f09d1474dba9615705be6b1cc480e0370dd
Author: chaokunyang
AuthorDate: Sat Apr 6 12:31:02 2024 +
This is an automated email from the ASF dual-hosted git repository.
chaokunyang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-fury-site.git
commit 4deb175d6ce38b37bd3a84bbca9f36e4285af8d0
Author: chaokunyang
AuthorDate: Sat Apr 6 12:31:02 2024 +
This is an automated email from the ASF dual-hosted git repository.
wangweipeng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-fury.git
The following commit(s) were added to refs/heads/main by this push:
new 95979623 feat(spec): add xlang type
theweipeng merged PR #1468:
URL: https://github.com/apache/incubator-fury/pull/1468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chaokunyang opened a new pull request, #1472:
URL: https://github.com/apache/incubator-fury/pull/1472
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
This is an automated email from the ASF dual-hosted git repository.
chaokunyang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-fury.git
The following commit(s) were added to refs/heads/main by this push:
new 4c60eb97 feat(java): optimize read
chaokunyang merged PR #1471:
URL: https://github.com/apache/incubator-fury/pull/1471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chaokunyang opened a new pull request, #1471:
URL: https://github.com/apache/incubator-fury/pull/1471
- optimize read char jvm jit inline by separate little/big endian methods
- optimize read short jvm jit inline by separate little/big endian methods
- generate unsafe get short code
The GitHub Actions job "Fury CI" on incubator-fury.git has succeeded.
Run started by GitHub user chaokunyang (triggered by chaokunyang).
Head commit for run:
f6e9c732a0701c7f59444282ff33c234d8548e5d / Shawn Yang
feat(java): reduce code size of read long to optimize jvm jit inline (#1470)
This
The GitHub Actions job "Fury CI" on incubator-fury.git has failed.
Run started by GitHub user chaokunyang (triggered by chaokunyang).
Head commit for run:
3801cfa6980fe65d163f37d3063fe41cf4eef77e / chaokunyang
fix readSliLongLE/BE naming
Report URL:
chaokunyang merged PR #1470:
URL: https://github.com/apache/incubator-fury/pull/1470
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
chaokunyang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-fury.git
The following commit(s) were added to refs/heads/main by this push:
new f6e9c732 feat(java): reduce code size
The GitHub Actions job "Fury CI" on incubator-fury.git has succeeded.
Run started by GitHub user chaokunyang (triggered by chaokunyang).
Head commit for run:
9a72a88c8831e0eb3036a5da18aed1308d1e9e4a / chaokunyang
add readSliLongLE/BE method
Report URL:
The GitHub Actions job "Fury CI" on incubator-fury.git has failed.
Run started by GitHub user chaokunyang (triggered by chaokunyang).
Head commit for run:
fdce72d5794842ea46b6be70ba0bd94796de8556 / chaokunyang
generate unsafeGetLong online
Report URL:
The GitHub Actions job "Fury CI" on incubator-fury.git has failed.
Run started by GitHub user chaokunyang (triggered by chaokunyang).
Head commit for run:
d5f4745994c652a618a0e1704bb5c0a991ce17a2 / chaokunyang
optimize readVarLong code size
Report URL:
chaokunyang opened a new pull request, #1470:
URL: https://github.com/apache/incubator-fury/pull/1470
This PR reduced code size of read long for jvm jit inline:
- Reduced readVarLong code size by separating little/big endian
- Reduced readLong code size by separating little/big endian
This is an automated email from the ASF dual-hosted git repository.
chaokunyang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-fury.git
The following commit(s) were added to refs/heads/main by this push:
new d73c3d9f feat(java): reduce
chaokunyang merged PR #1469:
URL: https://github.com/apache/incubator-fury/pull/1469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chaokunyang commented on PR #1469:
URL: https://github.com/apache/incubator-fury/pull/1469#issuecomment-2041042694
Before:
After:
chaokunyang commented on issue #1113:
URL:
https://github.com/apache/incubator-fury/issues/1113#issuecomment-2041036344
> OK, I'll separate those by different PRs starting from `TypeRef`
implementation, which looks like the most hard one, so it'll take some time...
Yep, the
Munoon commented on issue #1113:
URL:
https://github.com/apache/incubator-fury/issues/1113#issuecomment-2041035399
OK, I'll separate those by different PRs starting from `TypeRef`
implementation, which looks like the most hard one, so it'll take some time...
--
This is an automated
chaokunyang commented on PR #1468:
URL: https://github.com/apache/incubator-fury/pull/1468#issuecomment-2041027971
BYW, I was thinking whether we should make all type id starts from 0, and
let users to register type id from 64. In this way, we don't have to add ID by
64, and there won't be
This is an automated email from the ASF dual-hosted git repository.
chaokunyang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-fury.git
The following commit(s) were added to refs/heads/main by this push:
new ca996d4e feat(java): extract public
chaokunyang merged PR #1467:
URL: https://github.com/apache/incubator-fury/pull/1467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chaokunyang commented on issue #1113:
URL:
https://github.com/apache/incubator-fury/issues/1113#issuecomment-2041000105
> > @Munoon That would be really great. Actually I am on the work of first
release of Fury under asf and don't have enough time for this feature
>
> Can you please
chaokunyang commented on issue #1409:
URL:
https://github.com/apache/incubator-fury/issues/1409#issuecomment-2040992654
Hi @tommyettinger , thanks for this hard work.
Fury has a `src/main/java/org/apache/fury/benchmark/MapSuite.java` which did
some benchmarks for IdentityMap.
chaokunyang commented on PR #1450:
URL: https://github.com/apache/incubator-fury/pull/1450#issuecomment-2040991342
@LiangliangSui There are some conflict between your branch and main branch,
could you resolve the conflict?
--
This is an automated message from the Apache Git Service.
To
chaokunyang commented on code in PR #1450:
URL: https://github.com/apache/incubator-fury/pull/1450#discussion_r1554535283
##
java/fury-core/src/main/java/org/apache/fury/memory/MemoryBuffer.java:
##
@@ -1316,24 +1316,15 @@ public int readPositiveVarInt() {
}
private int
tommyettinger commented on issue #1409:
URL:
https://github.com/apache/incubator-fury/issues/1409#issuecomment-2040990074
I'm making progress on the rest of the map types now; IdentityMap seems done
and ObjectIntMap might be done or close to it. Hybridizing the two shouldn't be
hard at
70 matches
Mail list logo
