Re: [PR] [CI] Add CMake format check [incubator-gluten]

2024-06-07 Thread via GitHub
liuneng1994 commented on code in PR #5941: URL: https://github.com/apache/incubator-gluten/pull/5941#discussion_r1630740681 ## cpp-ch/CMakeLists.txt: ## @@ -27,93 +29,93 @@ message("CH_COMMIT=${CH_COMMIT}") project(libch LANGUAGES C CXX ASM) file(GLOB clickhouse_files

Re: [PR] [CI] Add CMake format check [incubator-gluten]

2024-06-07 Thread via GitHub
liuneng1994 commented on PR #5941: URL: https://github.com/apache/incubator-gluten/pull/5941#issuecomment-2154215349 > @liuneng1994, do you have any comment? There is generally no problem, but subjectively, the effect of cmake-format seems to make some places more messy.

Re: [I] Diff when overflow happens while executing cast big decimal to int [incubator-gluten]

2024-06-07 Thread via GitHub
taiyang-li commented on issue #6016: URL: https://github.com/apache/incubator-gluten/issues/6016#issuecomment-2154203226 It was found in d_926_0.sql -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[I] Diff when overflow happens while executing cast big decimal to int [incubator-gluten]

2024-06-07 Thread via GitHub
taiyang-li opened a new issue, #6016: URL: https://github.com/apache/incubator-gluten/issues/6016 ### Backend CH (ClickHouse) ### Bug description In CH ``` select cast(300582 as Decimal(29, 2)) as x, x::Int32 Received exception from server (version

Re: [PR] [CI] Add CMake format check [incubator-gluten]

2024-06-07 Thread via GitHub
PHILO-HE commented on PR #5941: URL: https://github.com/apache/incubator-gluten/pull/5941#issuecomment-2154199654 @liuneng1994, do you have any comment? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [CH] Disable automatic switching of sort shuffle [incubator-gluten]

2024-06-07 Thread via GitHub
github-actions[bot] commented on PR #6015: URL: https://github.com/apache/incubator-gluten/pull/6015#issuecomment-2154181375 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CH] Disable automatic switching of sort shuffle [incubator-gluten]

2024-06-07 Thread via GitHub
github-actions[bot] commented on PR #6015: URL: https://github.com/apache/incubator-gluten/pull/6015#issuecomment-2154179607 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [CH] Disable automatic switching of sort shuffle [incubator-gluten]

2024-06-07 Thread via GitHub
github-actions[bot] commented on PR #6015: URL: https://github.com/apache/incubator-gluten/pull/6015#issuecomment-2154179881 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] [GLUTEN-5248][VL] Directly pass legacySizeOfNull to native size function [incubator-gluten]

2024-06-07 Thread via GitHub
PHILO-HE opened a new pull request, #6014: URL: https://github.com/apache/incubator-gluten/pull/6014 ## What changes were proposed in this pull request? Spark Size function's legacySizeOfNull is specified either by other functions like `ArraySize` or by configuration. So we need to

[PR] [CH] Disable automatic switching of sort shuffle [incubator-gluten]

2024-06-07 Thread via GitHub
liuneng1994 opened a new pull request, #6015: URL: https://github.com/apache/incubator-gluten/pull/6015 ## What changes were proposed in this pull request? Disable automatic switching of sort shuffle ## How was this patch tested? unit tests (If this patch

Re: [PR] [GLUTEN-5248][VL] Directly pass legacySizeOfNull to native size function [incubator-gluten]

2024-06-07 Thread via GitHub
github-actions[bot] commented on PR #6014: URL: https://github.com/apache/incubator-gluten/pull/6014#issuecomment-2154179127 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5248][VL] Directly pass legacySizeOfNull to native size function [incubator-gluten]

2024-06-07 Thread via GitHub
github-actions[bot] commented on PR #6014: URL: https://github.com/apache/incubator-gluten/pull/6014#issuecomment-2154178827 https://github.com/apache/incubator-gluten/issues/5248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [VL] Pass file size and modification time to split [incubator-gluten]

2024-06-07 Thread via GitHub
github-actions[bot] commented on PR #5632: URL: https://github.com/apache/incubator-gluten/pull/5632#issuecomment-2154172502 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Provide options to combine small batches before sending to shuffle [incubator-gluten]

2024-06-07 Thread via GitHub
github-actions[bot] commented on PR #6009: URL: https://github.com/apache/incubator-gluten/pull/6009#issuecomment-2154153081 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4836][VL]Add support for WindowGroupLimitExec in gluten [incubator-gluten]

2024-06-07 Thread via GitHub
EpsilonPrime commented on code in PR #5398: URL: https://github.com/apache/incubator-gluten/pull/5398#discussion_r1630694098 ## gluten-core/src/main/resources/substrait/proto/substrait/algebra.proto: ## @@ -495,6 +504,7 @@ message Rel { GenerateRel generate = 17;

Re: [PR] [GLUTEN-5981][CH] Make the result be null when the queried field is `null` [incubator-gluten]

2024-06-07 Thread via GitHub
github-actions[bot] commented on PR #6001: URL: https://github.com/apache/incubator-gluten/pull/6001#issuecomment-2154139427 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5981][CH] Make the result be null when the queried field is `null` [incubator-gluten]

2024-06-06 Thread via GitHub
lgbo-ustc commented on code in PR #6001: URL: https://github.com/apache/incubator-gluten/pull/6001#discussion_r1630684215 ## backends-clickhouse/src/test/scala/org/apache/gluten/execution/GlutenClickhouseFunctionSuite.scala: ## @@ -66,6 +66,11 @@ class

Re: [PR] [GLUTEN-4836][VL]Add support for WindowGroupLimitExec in gluten [incubator-gluten]

2024-06-06 Thread via GitHub
acvictor commented on code in PR #5398: URL: https://github.com/apache/incubator-gluten/pull/5398#discussion_r1630683249 ## gluten-core/src/main/resources/substrait/proto/substrait/algebra.proto: ## @@ -495,6 +504,7 @@ message Rel { GenerateRel generate = 17; WriteRel

Re: [PR] [VL] Update to_utc_timestamp and from_utc_timestamp tests [incubator-gluten]

2024-06-06 Thread via GitHub
acvictor commented on PR #5358: URL: https://github.com/apache/incubator-gluten/pull/5358#issuecomment-2154129584 @PHILO-HE can you please review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [VL] Daily Update Velox Version (2024_06_06) [incubator-gluten]

2024-06-06 Thread via GitHub
zhztheplayer commented on PR #6005: URL: https://github.com/apache/incubator-gluten/pull/6005#issuecomment-2154116778 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [VL] Daily Update Velox Version (2024_06_07) [incubator-gluten]

2024-06-06 Thread via GitHub
PHILO-HE commented on PR #6007: URL: https://github.com/apache/incubator-gluten/pull/6007#issuecomment-2154090046 /Benchmark Velox TPCDS -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Can't drop SortExecTransformer in convert SortAggregateExec to HashAggregateExecBaseTransformer when ras enbled [incubator-gluten]

2024-06-06 Thread via GitHub
zml1206 commented on issue #6011: URL: https://github.com/apache/incubator-gluten/issues/6011#issuecomment-2154018895 > If it's about the golden check of RAS, you can just put whatever the suite generates as new golden file in PR and ping me with a comment. I would take care of that part

Re: [PR] [CI] Add CMake format check [incubator-gluten]

2024-06-06 Thread via GitHub
github-actions[bot] commented on PR #5941: URL: https://github.com/apache/incubator-gluten/pull/5941#issuecomment-2154008750 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] Can't drop SortExecTransformer in convert SortAggregateExec to HashAggregateExecBaseTransformer when ras enbled [incubator-gluten]

2024-06-06 Thread via GitHub
zhztheplayer commented on issue #6011: URL: https://github.com/apache/incubator-gluten/issues/6011#issuecomment-2153972125 If it's about the golden check of RAS, you can just put whatever the suite generates as new golden file in PR and ping me with a comment. I would take care of that

Re: [I] Can't drop SortExecTransformer in convert SortAggregateExec to HashAggregateExecBaseTransformer when ras enbled [incubator-gluten]

2024-06-06 Thread via GitHub
zhztheplayer commented on issue #6011: URL: https://github.com/apache/incubator-gluten/issues/6011#issuecomment-2153959366 This is a known issue. Based on current development status of RAS, one of the best solution is to have an individual rule to match on `Sort + Sort Agg` to remove that

[I] Enhancement - provide option for gluten to pass s3 credentials in to velox using the configured spark.hadoop.fs.s3a.aws.credentials.provider [incubator-gluten]

2024-06-06 Thread via GitHub
xushichangdesmond opened a new issue, #6012: URL: https://github.com/apache/incubator-gluten/issues/6012 ### Description Velox backend does not use the configured spark.hadoop.fs.s3a.aws.credentials.provider as its not using the Java AWS sdk, but rather the C++ one. One helpful

Re: [PR] [VL] Provide options to combine small batches before sending to shuffle [incubator-gluten]

2024-06-06 Thread via GitHub
github-actions[bot] commented on PR #6009: URL: https://github.com/apache/incubator-gluten/pull/6009#issuecomment-2153921466 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Optimize the performance of hash based shuffle by accumulating batches [incubator-gluten]

2024-06-06 Thread via GitHub
zhztheplayer commented on PR #5951: URL: https://github.com/apache/incubator-gluten/pull/5951#issuecomment-2153866781 The change makes sense to me. I think it's operational to merge this and use #6009 as follow-up which adds an individual Spark operator controlling this behavior for being

Re: [I] Can't drop SortExecTransformer in convert SortAggregateExec to HashAggregateExecBaseTransformer when ras enbled [incubator-gluten]

2024-06-06 Thread via GitHub
zml1206 commented on issue #6011: URL: https://github.com/apache/incubator-gluten/issues/6011#issuecomment-2153854680 Is this a known issue? @zhztheplayer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[I] Can't drop SortExecTransformer in convert SortAggregateExec to HashAggregateExecBaseTransformer when ras enbled [incubator-gluten]

2024-06-06 Thread via GitHub
zml1206 opened a new issue, #6011: URL: https://github.com/apache/incubator-gluten/issues/6011 ### Backend VL (Velox) ### Bug description ``` withSQLConf( ("spark.sql.adaptive.enabled", "false"), ("spark.sql.test.forceApplySortAggregate", "true"),

Re: [PR] [VL] Optimize the performance of hash based shuffle by accumulating batches [incubator-gluten]

2024-06-06 Thread via GitHub
zhztheplayer commented on PR #5951: URL: https://github.com/apache/incubator-gluten/pull/5951#issuecomment-2153794304 Oops. I missed this PR before opening [this](https://github.com/apache/incubator-gluten/pull/6009) for similar purpose... -- This is an automated message from the

Re: [PR] [VL] Provide options to combine small batches before sending to shuffle [incubator-gluten]

2024-06-06 Thread via GitHub
marin-ma commented on PR #6009: URL: https://github.com/apache/incubator-gluten/pull/6009#issuecomment-2153790260 cc: @WangGuangxin @FelixYBW -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [VL] Add gluten iceberg jar to bundle package [incubator-gluten]

2024-06-06 Thread via GitHub
yma11 commented on PR #6008: URL: https://github.com/apache/incubator-gluten/pull/6008#issuecomment-2153776532 @leoluan2009 Thanks for contribution. For data lake support like iceberg and delta lake, we don't include them in Gluten jar as it's not used by all customers and will make the

Re: [PR] [VL] Add gluten iceberg jar to bundle package [incubator-gluten]

2024-06-06 Thread via GitHub
zhouyuan commented on PR #6008: URL: https://github.com/apache/incubator-gluten/pull/6008#issuecomment-2153773219 CC @yma11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [VL] Provide options to combine small batches before sending to shuffle [incubator-gluten]

2024-06-06 Thread via GitHub
zhztheplayer commented on PR #6009: URL: https://github.com/apache/incubator-gluten/pull/6009#issuecomment-2153767337 /Benchmark Velox TPCDS -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [VL] Provide options to combine small batches before sending to shuffle [incubator-gluten]

2024-06-06 Thread via GitHub
zhztheplayer commented on PR #6009: URL: https://github.com/apache/incubator-gluten/pull/6009#issuecomment-2153766943 /Benchmark Velox -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [VL] Provide options to combine small batches before sending to shuffle [incubator-gluten]

2024-06-06 Thread via GitHub
github-actions[bot] commented on PR #6009: URL: https://github.com/apache/incubator-gluten/pull/6009#issuecomment-2153764783 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240607) [incubator-gluten]

2024-06-06 Thread via GitHub
baibaichen commented on PR #6010: URL: https://github.com/apache/incubator-gluten/pull/6010#issuecomment-2153764148 We need merge this pr due to rebase failed with https://github.com/ClickHouse/ClickHouse/pull/64423 -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240607) [incubator-gluten]

2024-06-06 Thread via GitHub
github-actions[bot] commented on PR #6010: URL: https://github.com/apache/incubator-gluten/pull/6010#issuecomment-2153761222 https://github.com/apache/incubator-gluten/issues/1632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240607) [incubator-gluten]

2024-06-06 Thread via GitHub
github-actions[bot] commented on PR #6010: URL: https://github.com/apache/incubator-gluten/pull/6010#issuecomment-2153761381 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240607) [incubator-gluten]

2024-06-06 Thread via GitHub
kyligence-git opened a new pull request, #6010: URL: https://github.com/apache/incubator-gluten/pull/6010 Auto commit by gluten daily build, please check the build status and merge it if it's green. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [VL] Provide options to combine small batches before sending to shuffle [incubator-gluten]

2024-06-06 Thread via GitHub
zhztheplayer commented on PR #6009: URL: https://github.com/apache/incubator-gluten/pull/6009#issuecomment-2153754440 @marin-ma There might be some batch-wise overhead around shuffle split processing. We may want to figure it out later to avoid doing such batch coalesce operations that

Re: [PR] [VL] Provide options to combine small batches before sending to shuffle [incubator-gluten]

2024-06-06 Thread via GitHub
github-actions[bot] commented on PR #6009: URL: https://github.com/apache/incubator-gluten/pull/6009#issuecomment-2153752582 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Provide options to combine small batches before sending to shuffle [incubator-gluten]

2024-06-06 Thread via GitHub
github-actions[bot] commented on PR #6009: URL: https://github.com/apache/incubator-gluten/pull/6009#issuecomment-2153750521 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Provide options to combine small batches before sending to shuffle [incubator-gluten]

2024-06-06 Thread via GitHub
github-actions[bot] commented on PR #6009: URL: https://github.com/apache/incubator-gluten/pull/6009#issuecomment-2153750359 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Provide options to combine small batches before sending to shuffle [incubator-gluten]

2024-06-06 Thread via GitHub
zhztheplayer opened a new pull request, #6009: URL: https://github.com/apache/incubator-gluten/pull/6009 It's observed that Velox hash-based shuffle is slowed down by small input batches. The patch: 1. Adds two options: -

Re: [PR] Add gluten iceberg jar to bundle package [incubator-gluten]

2024-06-06 Thread via GitHub
github-actions[bot] commented on PR #6008: URL: https://github.com/apache/incubator-gluten/pull/6008#issuecomment-2153720813 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [GLUTEN-5981][CH] Make the result be null when the queried field is `null` [incubator-gluten]

2024-06-06 Thread via GitHub
zzcclp commented on code in PR #6001: URL: https://github.com/apache/incubator-gluten/pull/6001#discussion_r1630524718 ## backends-clickhouse/src/test/scala/org/apache/gluten/execution/GlutenClickhouseFunctionSuite.scala: ## @@ -66,6 +66,11 @@ class

Re: [I] [VL] Support file cache spill in Gluten [incubator-gluten]

2024-06-06 Thread via GitHub
yma11 commented on issue #5884: URL: https://github.com/apache/incubator-gluten/issues/5884#issuecomment-2153715084 @zhli1142015 @FelixYBW @zhouyuan @zhztheplayer The code changes are available in following PRs: [Spark](https://github.com/yma11/spark/pull/4/files),

[PR] [VL] Daily Update Velox Version (2024_06_07) [incubator-gluten]

2024-06-06 Thread via GitHub
GlutenPerfBot opened a new pull request, #6007: URL: https://github.com/apache/incubator-gluten/pull/6007 Upstream Velox's New Commits: ```txt 35fbc2ea1 by Masha Basmanova, Add from_iso8601_timestamp Presto function (10062) 7164f92ae by Jimmy Lu, Optimize

Re: [PR] Update CPP Formatting Script [incubator-gluten]

2024-06-06 Thread via GitHub
GlutenPerfBot commented on PR #6006: URL: https://github.com/apache/incubator-gluten/pull/6006#issuecomment-2153694756 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL] Daily Update Velox Version (2024_06_07) [incubator-gluten]

2024-06-06 Thread via GitHub
github-actions[bot] commented on PR #6007: URL: https://github.com/apache/incubator-gluten/pull/6007#issuecomment-2153695357 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [GLUTEN-5910] [CH] add custom type to ASTLiteral [incubator-gluten]

2024-06-06 Thread via GitHub
github-actions[bot] commented on PR #5911: URL: https://github.com/apache/incubator-gluten/pull/5911#issuecomment-2153688739 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Simplify ExecutionCtx + Handle JNI code pattern [incubator-gluten]

2024-06-06 Thread via GitHub
INBreezefall commented on PR #3239: URL: https://github.com/apache/incubator-gluten/pull/3239#issuecomment-2153660309 > A clean-up to JNI code by pulling up a common pattern `ExecutionCtx` + `Handle`. Hi, I am a Gluten newbie. I have a simple question, hope you can help me. I

Re: [PR] Update CPP Formatting Script [incubator-gluten]

2024-06-06 Thread via GitHub
FelixYBW merged PR #6006: URL: https://github.com/apache/incubator-gluten/pull/6006 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Pass file size and modification time to split [incubator-gluten]

2024-06-06 Thread via GitHub
acvictor commented on PR #5632: URL: https://github.com/apache/incubator-gluten/pull/5632#issuecomment-2152985875 > Can you comment a bit how these info are used by Velox? Is it aligned with Spark's behavior? In Spark, properties are present in the split and obtained during listing.

Re: [PR] [VL] Update to_utc_timestamp and from_utc_timestamp tests [incubator-gluten]

2024-06-06 Thread via GitHub
github-actions[bot] commented on PR #5358: URL: https://github.com/apache/incubator-gluten/pull/5358#issuecomment-2152980133 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Pass file size and modification time to split [incubator-gluten]

2024-06-06 Thread via GitHub
github-actions[bot] commented on PR #5632: URL: https://github.com/apache/incubator-gluten/pull/5632#issuecomment-2152967097 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Move JoinSelectionOverrides logic to ColumnarOverrides [incubator-gluten]

2024-06-06 Thread via GitHub
github-actions[bot] commented on PR #6004: URL: https://github.com/apache/incubator-gluten/pull/6004#issuecomment-2152910863 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Pass file size and modification time to split [incubator-gluten]

2024-06-06 Thread via GitHub
github-actions[bot] commented on PR #5632: URL: https://github.com/apache/incubator-gluten/pull/5632#issuecomment-2152880931 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Update CPP Formatting Script [incubator-gluten]

2024-06-06 Thread via GitHub
acvictor commented on PR #6006: URL: https://github.com/apache/incubator-gluten/pull/6006#issuecomment-2152770803 @zhli1142015 @PHILO-HE can you please review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] Update CPP Formatting Script [incubator-gluten]

2024-06-06 Thread via GitHub
acvictor opened a new pull request, #6006: URL: https://github.com/apache/incubator-gluten/pull/6006 ## What changes were proposed in this pull request? Update formatcppcode.sh to install clang 15 if not present. -- This is an automated message from the Apache Git Service. To

Re: [PR] Update CPP Formatting Script [incubator-gluten]

2024-06-06 Thread via GitHub
github-actions[bot] commented on PR #6006: URL: https://github.com/apache/incubator-gluten/pull/6006#issuecomment-2152722473 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [VL] Pass file size and modification time to split [incubator-gluten]

2024-06-06 Thread via GitHub
github-actions[bot] commented on PR #5632: URL: https://github.com/apache/incubator-gluten/pull/5632#issuecomment-2152714716 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Pass file size and modification time to split [incubator-gluten]

2024-06-06 Thread via GitHub
github-actions[bot] commented on PR #5632: URL: https://github.com/apache/incubator-gluten/pull/5632#issuecomment-2152656543 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Pass file size and modification time to split [incubator-gluten]

2024-06-06 Thread via GitHub
github-actions[bot] commented on PR #5632: URL: https://github.com/apache/incubator-gluten/pull/5632#issuecomment-2152640173 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Move JoinSelectionOverrides logic to ColumnarOverrides [incubator-gluten]

2024-06-06 Thread via GitHub
github-actions[bot] commented on PR #6004: URL: https://github.com/apache/incubator-gluten/pull/6004#issuecomment-2152480747 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Daily Update Velox Version (2024_06_05) [incubator-gluten]

2024-06-06 Thread via GitHub
GlutenPerfBot commented on PR #5998: URL: https://github.com/apache/incubator-gluten/pull/5998#issuecomment-2152440618 = Performance report for TPCH SF2000 with Velox backend, for reference only query

[PR] [VL] Daily Update Velox Version (2024_06_06) [incubator-gluten]

2024-06-06 Thread via GitHub
GlutenPerfBot opened a new pull request, #6005: URL: https://github.com/apache/incubator-gluten/pull/6005 Upstream Velox's New Commits: ```txt 7637d567f by Ke, Add bucket verification in TableWriter Fuzzer (10039) 4845e903a by xiaoxmeng, Parallelize the spill processing inside

Re: [PR] [VL] Daily Update Velox Version (2024_06_06) [incubator-gluten]

2024-06-06 Thread via GitHub
github-actions[bot] commented on PR #6005: URL: https://github.com/apache/incubator-gluten/pull/6005#issuecomment-2152360386 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [CORE] Move JoinSelectionOverrides logic to ColumnarOverrides [incubator-gluten]

2024-06-06 Thread via GitHub
github-actions[bot] commented on PR #6004: URL: https://github.com/apache/incubator-gluten/pull/6004#issuecomment-2152276703 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Daily Update Velox Version (2024_06_05) [incubator-gluten]

2024-06-06 Thread via GitHub
PHILO-HE merged PR #5998: URL: https://github.com/apache/incubator-gluten/pull/5998 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-5827][CH]support utc timestamp transfrom [incubator-gluten]

2024-06-06 Thread via GitHub
github-actions[bot] commented on PR #5828: URL: https://github.com/apache/incubator-gluten/pull/5828#issuecomment-2152039410 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Move JoinSelectionOverrides logic to ColumnarOverrides [incubator-gluten]

2024-06-06 Thread via GitHub
github-actions[bot] commented on PR #6004: URL: https://github.com/apache/incubator-gluten/pull/6004#issuecomment-2151949609 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Move JoinSelectionOverrides logic to ColumnarOverrides [incubator-gluten]

2024-06-06 Thread via GitHub
github-actions[bot] commented on PR #6004: URL: https://github.com/apache/incubator-gluten/pull/6004#issuecomment-2151949208 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [CORE] Move JoinSelectionOverrides logic to ColumnarOverrides [incubator-gluten]

2024-06-06 Thread via GitHub
zml1206 opened a new pull request, #6004: URL: https://github.com/apache/incubator-gluten/pull/6004 ## What changes were proposed in this pull request? 1. Drop custom strategy and move `JoinSelectionOverrides` logic to `ColumnarOverrides` 2. Clickhouse backend already support AQE,

Re: [PR] [Gluten-229] Support Spark SortShuffleManager for ClickHouse Backend [incubator-gluten]

2024-06-06 Thread via GitHub
zml1206 commented on code in PR #230: URL: https://github.com/apache/incubator-gluten/pull/230#discussion_r1629075647 ## jvm/src/main/scala/io/glutenproject/extension/StrategyOverrides.scala: ## @@ -76,8 +69,26 @@ object JoinSelectionOverrides extends Strategy with

Re: [PR] [VL] Make ColumnarBatch::getRowBytes leak-safe [incubator-gluten]

2024-06-06 Thread via GitHub
GlutenPerfBot commented on PR #6002: URL: https://github.com/apache/incubator-gluten/pull/6002#issuecomment-2151751915 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [DNM][GLUTEN-5548][VL] test dynamic setting [incubator-gluten]

2024-06-06 Thread via GitHub
zhli1142015 closed pull request #5506: [DNM][GLUTEN-5548][VL] test dynamic setting URL: https://github.com/apache/incubator-gluten/pull/5506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [DNM] test min [incubator-gluten]

2024-06-06 Thread via GitHub
zhli1142015 closed pull request #5964: [DNM] test min URL: https://github.com/apache/incubator-gluten/pull/5964 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [GLUTEN-5910] [CH] add custom type to ASTLiteral [incubator-gluten]

2024-06-06 Thread via GitHub
github-actions[bot] commented on PR #5911: URL: https://github.com/apache/incubator-gluten/pull/5911#issuecomment-2151681224 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] HiveFileFormat has incompatible class error when running TPC-H q18 [incubator-gluten]

2024-06-06 Thread via GitHub
lgbo-ustc commented on issue #3351: URL: https://github.com/apache/incubator-gluten/issues/3351#issuecomment-2151622431 > How is this solved? @JkSelf @kelvin-qin 。 We also meet this problem > > ```shell > NATIVE_WRITER_CONF="--conf spark.gluten.sql.native.writer.enabled=true >

Re: [I] HiveFileFormat has incompatible class error when running TPC-H q18 [incubator-gluten]

2024-06-06 Thread via GitHub
lgbo-ustc commented on issue #3351: URL: https://github.com/apache/incubator-gluten/issues/3351#issuecomment-2151621681 > ```shell > HiveFileFormat > ``` Found the problem. The path configuration `spark.driver.extraClassPath` is wrong -- This is an automated message from

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240606) [incubator-gluten]

2024-06-06 Thread via GitHub
baibaichen merged PR #5999: URL: https://github.com/apache/incubator-gluten/pull/5999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Make ColumnarBatch::getRowBytes leak-safe [incubator-gluten]

2024-06-06 Thread via GitHub
zhztheplayer merged PR #6002: URL: https://github.com/apache/incubator-gluten/pull/6002 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-5827][CH]support utc timestamp transfrom [incubator-gluten]

2024-06-06 Thread via GitHub
github-actions[bot] commented on PR #5828: URL: https://github.com/apache/incubator-gluten/pull/5828#issuecomment-2151564344 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] HiveFileFormat has incompatible class error when running TPC-H q18 [incubator-gluten]

2024-06-06 Thread via GitHub
lgbo-ustc commented on issue #3351: URL: https://github.com/apache/incubator-gluten/issues/3351#issuecomment-2151558970 How is this solved? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [GLUTEN-5827][CH]support utc timestamp transfrom [incubator-gluten]

2024-06-06 Thread via GitHub
github-actions[bot] commented on PR #5828: URL: https://github.com/apache/incubator-gluten/pull/5828#issuecomment-2151554568 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [VL] can not write hive table on HDFS [incubator-gluten]

2024-06-06 Thread via GitHub
RaoZhiRou-Z commented on issue #5879: URL: https://github.com/apache/incubator-gluten/issues/5879#issuecomment-2151552175 @PHILO-HE I have tried the bug-fix,and there is another core error,the core stack shows that: **#0 __GI_raise (sig=sig@entry=6) at

Re: [I] [VL] can not write hive table on HDFS [incubator-gluten]

2024-06-06 Thread via GitHub
RaoZhiRou-Z commented on issue #5879: URL: https://github.com/apache/incubator-gluten/issues/5879#issuecomment-2151549794 @PHILO-HE I have tried the bug-fix,and there is another core error,the core stack shows that: `#0 __GI_raise (sig=sig@entry=6) at

Re: [PR] [GLUTEN-5981][CH] Make the result be null when the queried field is `null` [incubator-gluten]

2024-06-06 Thread via GitHub
github-actions[bot] commented on PR #6001: URL: https://github.com/apache/incubator-gluten/pull/6001#issuecomment-2151538528 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Handle try_subtract, try_multiply, try_divide [incubator-gluten]

2024-06-06 Thread via GitHub
GlutenPerfBot commented on PR #5985: URL: https://github.com/apache/incubator-gluten/pull/5985#issuecomment-2151520949 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [Gluten-229] Support Spark SortShuffleManager for ClickHouse Backend [incubator-gluten]

2024-06-06 Thread via GitHub
zzcclp commented on code in PR #230: URL: https://github.com/apache/incubator-gluten/pull/230#discussion_r1628850760 ## jvm/src/main/scala/io/glutenproject/extension/StrategyOverrides.scala: ## @@ -76,8 +69,26 @@ object JoinSelectionOverrides extends Strategy with

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-06-05 Thread via GitHub
PHILO-HE commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2151468471 > > ubase64: #4482 > > I see you've map the from_base64 to unbase64, and respectively I find the base64 is almost the same as to_base64, so it's just a missing or

Re: [I] [CH] Not found column when the mixed join condition involves right keys [incubator-gluten]

2024-06-05 Thread via GitHub
baibaichen closed issue #5996: [CH] Not found column when the mixed join condition involves right keys URL: https://github.com/apache/incubator-gluten/issues/5996 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [GLUTEN-5996][CH] Fixed missing columns in join with mixed conditions [incubator-gluten]

2024-06-05 Thread via GitHub
baibaichen merged PR #5997: URL: https://github.com/apache/incubator-gluten/pull/5997 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[I] Static build issue when GCS is enabled [incubator-gluten]

2024-06-05 Thread via GitHub
PHILO-HE opened a new issue, #6003: URL: https://github.com/apache/incubator-gluten/issues/6003 ### Problem description Here is error log in building abal (vcpkg installed version is not the required one), required by google cloud cpp. Looks raw_logging.h (an old version of absl)

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-06-05 Thread via GitHub
Donvi commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2151449323 > ubase64: #4482 I see you've map the from_base64 to unbase64, and respectively I find the base64 is almost the same as to_base64, so it's just a missing or is there

Re: [PR] [VL] Handle try_subtract, try_multiply, try_divide [incubator-gluten]

2024-06-05 Thread via GitHub
zhli1142015 merged PR #5985: URL: https://github.com/apache/incubator-gluten/pull/5985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Make ColumnarBatch::getRowBytes leak-safe [incubator-gluten]

2024-06-05 Thread via GitHub
zhztheplayer commented on PR #6002: URL: https://github.com/apache/incubator-gluten/pull/6002#issuecomment-2151428336 cc @JkSelf -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

  1   2   3   4   5   6   7   8   9   10   >