[GitHub] [hudi] n3nash merged pull request #2030: [HUDI-1130] hudi-test-suite support for schema evolution (can be trig…

2020-09-08 Thread GitBox
n3nash merged pull request #2030: URL: https://github.com/apache/hudi/pull/2030 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[hudi] branch master updated: [HUDI-1130] hudi-test-suite support for schema evolution (can be triggered on any insert/upsert DAG node).

2020-09-08 Thread nagarwal
This is an automated email from the ASF dual-hosted git repository. nagarwal pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git The following commit(s) were added to refs/heads/master by this push: new fec7cd3 [HUDI-1130] hudi-test-suite support for

[GitHub] [hudi] n3nash merged pull request #2039: [HUDI-830] Test Suite Fixes

2020-09-08 Thread GitBox
n3nash merged pull request #2039: URL: https://github.com/apache/hudi/pull/2039 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hudi] n3nash commented on pull request #2045: [HUDI-1147] Modify GenericRecordFullPayloadGenerator to generate vali…

2020-09-08 Thread GitBox
n3nash commented on pull request #2045: URL: https://github.com/apache/hudi/pull/2045#issuecomment-689318428 @nbalajee can you please rebase ? This is an automated message from the Apache Git Service. To respond to the messag

[hudi] branch master updated: Test Suite should work with Docker + Unit Tests

2020-09-08 Thread nagarwal
This is an automated email from the ASF dual-hosted git repository. nagarwal pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git The following commit(s) were added to refs/heads/master by this push: new 53d1e55 Test Suite should work with Docker + Un

[GitHub] [hudi] n3nash commented on pull request #2039: [HUDI-830] Test Suite Fixes

2020-09-08 Thread GitBox
n3nash commented on pull request #2039: URL: https://github.com/apache/hudi/pull/2039#issuecomment-689317926 @modi95 This LGTM, tried it manually and it works, thanks for taking this over the finish line. This is an automate

[GitHub] [hudi] bvaradar commented on pull request #2058: [HUDI-1259] Cache some framework binaries to speed up the progress of building docker image in local env

2020-09-08 Thread GitBox
bvaradar commented on pull request #2058: URL: https://github.com/apache/hudi/pull/2058#issuecomment-689300968 @yanghua : ```I just want to speed up the local build progress so that I can verify new changes frequently.``` Can you kindly clarify what you mean by changes here ?

[GitHub] [hudi] n3nash commented on issue #2066: [SUPPORT] Hudi is increasing the storage size big time

2020-09-08 Thread GitBox
n3nash commented on issue #2066: URL: https://github.com/apache/hudi/issues/2066#issuecomment-689299100 @KarthickAN Making hoodie_record_key virtual is actively being worked on. There will be an initial implementation in the next few weeks and you might be able to try it out as an WIP feat

[jira] [Commented] (HUDI-83) Map Timestamp type in spark to corresponding Timestamp type in Hive during Hive sync

2020-09-08 Thread cdmikechen (Jira)
[ https://issues.apache.org/jira/browse/HUDI-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192611#comment-17192611 ] cdmikechen commented on HUDI-83: [~uditme] Yes, in hive3 it is supported, and we can just re

[jira] [Commented] (HUDI-83) Map Timestamp type in spark to corresponding Timestamp type in Hive during Hive sync

2020-09-08 Thread cdmikechen (Jira)
[ https://issues.apache.org/jira/browse/HUDI-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192604#comment-17192604 ] cdmikechen commented on HUDI-83: [~shivnarayan] I will open a PR recently. I have completed

[hudi] branch master updated: [HUDI-1181] Fix decimal type display issue for record key field (#1953)

2020-09-08 Thread uditme
This is an automated email from the ASF dual-hosted git repository. uditme pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git The following commit(s) were added to refs/heads/master by this push: new 2fee087 [HUDI-1181] Fix decimal type display issu

[GitHub] [hudi] umehrot2 merged pull request #1953: [HUDI-1181] Fix decimal type display issue for record key field

2020-09-08 Thread GitBox
umehrot2 merged pull request #1953: URL: https://github.com/apache/hudi/pull/1953 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [hudi] sathyaprakashg commented on a change in pull request #2012: [HUDI-1129] Deltastreamer Add support for schema evolution

2020-09-08 Thread GitBox
sathyaprakashg commented on a change in pull request #2012: URL: https://github.com/apache/hudi/pull/2012#discussion_r485249027 ## File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java ## @@ -127,12 +128,59 @@ public static GenericRecord bytesToAvro(byt

[GitHub] [hudi] bvaradar commented on issue #2020: [SUPPORT] Compaction fails with "java.io.FileNotFoundException"

2020-09-08 Thread GitBox
bvaradar commented on issue #2020: URL: https://github.com/apache/hudi/issues/2020#issuecomment-689173851 @zherenyu831 @dm-tran : Good catch about incremental timeline syncing. This is an experimental feature still and is disabled by default. There could be a bug here. I will investigate

[jira] [Updated] (HUDI-1275) Incremental TImeline Syncing causes compaction to fail with FileNotFound exception

2020-09-08 Thread Balaji Varadarajan (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balaji Varadarajan updated HUDI-1275: - Status: Open (was: New) > Incremental TImeline Syncing causes compaction to fail with Fil

[jira] [Created] (HUDI-1275) Incremental TImeline Syncing causes compaction to fail with FileNotFound exception

2020-09-08 Thread Balaji Varadarajan (Jira)
Balaji Varadarajan created HUDI-1275: Summary: Incremental TImeline Syncing causes compaction to fail with FileNotFound exception Key: HUDI-1275 URL: https://issues.apache.org/jira/browse/HUDI-1275

[jira] [Assigned] (HUDI-1275) Incremental TImeline Syncing causes compaction to fail with FileNotFound exception

2020-09-08 Thread Balaji Varadarajan (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balaji Varadarajan reassigned HUDI-1275: Assignee: Balaji Varadarajan > Incremental TImeline Syncing causes compaction to fa

[jira] [Commented] (HUDI-83) Map Timestamp type in spark to corresponding Timestamp type in Hive during Hive sync

2020-09-08 Thread sivabalan narayanan (Jira)
[ https://issues.apache.org/jira/browse/HUDI-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192515#comment-17192515 ] sivabalan narayanan commented on HUDI-83: - [~chenxiang]: looks like there is some in

[GitHub] [hudi] bvaradar commented on issue #2076: [SUPPORT] load data partition wise

2020-09-08 Thread GitBox
bvaradar commented on issue #2076: URL: https://github.com/apache/hudi/issues/2076#issuecomment-689170277 @Yogashri12 : It does not make sense to have different types deduced for the same column. If you want such mismatch partition-types to be inserted, you can simply cast the partition co

[GitHub] [hudi] pratyakshsharma commented on a change in pull request #1984: [HUDI-1200] Fix NullPointerException, CustomKeyGenerator does not work

2020-09-08 Thread GitBox
pratyakshsharma commented on a change in pull request #1984: URL: https://github.com/apache/hudi/pull/1984#discussion_r485182381 ## File path: hudi-spark/src/main/java/org/apache/hudi/keygen/KeyGenerator.java ## @@ -41,7 +41,7 @@ private static final String STRUCT_NAME = "ho

[jira] [Assigned] (HUDI-1200) CustomKeyGenerator does not work,java.lang.NullPointerException

2020-09-08 Thread Pratyaksh Sharma (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pratyaksh Sharma reassigned HUDI-1200: -- Assignee: Pratyaksh Sharma (was: liujinhui) > CustomKeyGenerator does not work,java.la

[GitHub] [hudi] pratyakshsharma commented on a change in pull request #1984: [HUDI-1200] Fix NullPointerException, CustomKeyGenerator does not work

2020-09-08 Thread GitBox
pratyakshsharma commented on a change in pull request #1984: URL: https://github.com/apache/hudi/pull/1984#discussion_r485151075 ## File path: hudi-spark/src/main/java/org/apache/hudi/keygen/KeyGenerator.java ## @@ -41,7 +41,7 @@ private static final String STRUCT_NAME = "ho

[GitHub] [hudi] pratyakshsharma commented on a change in pull request #1984: [HUDI-1200] Fix NullPointerException, CustomKeyGenerator does not work

2020-09-08 Thread GitBox
pratyakshsharma commented on a change in pull request #1984: URL: https://github.com/apache/hudi/pull/1984#discussion_r485151075 ## File path: hudi-spark/src/main/java/org/apache/hudi/keygen/KeyGenerator.java ## @@ -41,7 +41,7 @@ private static final String STRUCT_NAME = "ho

[GitHub] [hudi] bradleyhurley commented on issue #2068: [SUPPORT]Deltastreamer Upsert Very Slow / Never Completes After Initial Data Load

2020-09-08 Thread GitBox
bradleyhurley commented on issue #2068: URL: https://github.com/apache/hudi/issues/2068#issuecomment-689064559 I made some tweaks and was able to get the job to complete. - Executor Cores = 1 - Executors = 300 - Driver Memory = 4G - Executor Memory = 6G - spark.kryoseriali

[GitHub] [hudi] pratyakshsharma commented on pull request #1984: [HUDI-1200] Fix NullPointerException, CustomKeyGenerator does not work

2020-09-08 Thread GitBox
pratyakshsharma commented on pull request #1984: URL: https://github.com/apache/hudi/pull/1984#issuecomment-689053835 > @pratyakshsharma I would like to get this into 0.6.1 if possible. please prioritize accordingly Checking this. --

[GitHub] [hudi] nsivabalan commented on pull request #1978: [HUDI-1184] Fix the support of hbase index partition path change

2020-09-08 Thread GitBox
nsivabalan commented on pull request #1978: URL: https://github.com/apache/hudi/pull/1978#issuecomment-689043555 @hj2016 : can you fix the build failure. This is an automated message from the Apache Git Service. To respond to

[GitHub] [hudi] wangxianghu commented on a change in pull request #1827: [HUDI-1089] Refactor hudi-client to support multi-engine

2020-09-08 Thread GitBox
wangxianghu commented on a change in pull request #1827: URL: https://github.com/apache/hudi/pull/1827#discussion_r485058261 ## File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/SparkWorkloadProfile.java ## @@ -22,49 +22,22 @@ import org.apache.hudi

[GitHub] [hudi] bvaradar commented on issue #2072: [SUPPORT] Hudi Pyspark Application Example

2020-09-08 Thread GitBox
bvaradar commented on issue #2072: URL: https://github.com/apache/hudi/issues/2072#issuecomment-688979127 Try running refresh CLI command and then call show rollbacks ? This is an automated message from the Apache Git Service

[GitHub] [hudi] wangxianghu commented on a change in pull request #1827: [HUDI-1089] Refactor hudi-client to support multi-engine

2020-09-08 Thread GitBox
wangxianghu commented on a change in pull request #1827: URL: https://github.com/apache/hudi/pull/1827#discussion_r485027583 ## File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/HoodieSparkMergeHandle.java ## @@ -71,34 +77,25 @@ protected boolean use

[GitHub] [hudi] wangxianghu commented on a change in pull request #1827: [HUDI-1089] Refactor hudi-client to support multi-engine

2020-09-08 Thread GitBox
wangxianghu commented on a change in pull request #1827: URL: https://github.com/apache/hudi/pull/1827#discussion_r485026581 ## File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/HoodieSparkMergeHandle.java ## @@ -54,9 +60,9 @@ import java.util.Set;

[GitHub] [hudi] wangxianghu commented on a change in pull request #1827: [HUDI-1089] Refactor hudi-client to support multi-engine

2020-09-08 Thread GitBox
wangxianghu commented on a change in pull request #1827: URL: https://github.com/apache/hudi/pull/1827#discussion_r485016294 ## File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/embedded/SparkEmbeddedTimelineService.java ## @@ -0,0 +1,51 @@ +/* + *

[GitHub] [hudi] wangxianghu commented on a change in pull request #1827: [HUDI-1089] Refactor hudi-client to support multi-engine

2020-09-08 Thread GitBox
wangxianghu commented on a change in pull request #1827: URL: https://github.com/apache/hudi/pull/1827#discussion_r485016294 ## File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/embedded/SparkEmbeddedTimelineService.java ## @@ -0,0 +1,51 @@ +/* + *

[GitHub] [hudi] n3nash commented on a change in pull request #2012: [HUDI-1129] Deltastreamer Add support for schema evolution

2020-09-08 Thread GitBox
n3nash commented on a change in pull request #2012: URL: https://github.com/apache/hudi/pull/2012#discussion_r485009679 ## File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java ## @@ -127,12 +128,59 @@ public static GenericRecord bytesToAvro(byte[] byte

[GitHub] [hudi] n3nash commented on a change in pull request #2012: [HUDI-1129] Deltastreamer Add support for schema evolution

2020-09-08 Thread GitBox
n3nash commented on a change in pull request #2012: URL: https://github.com/apache/hudi/pull/2012#discussion_r485009679 ## File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java ## @@ -127,12 +128,59 @@ public static GenericRecord bytesToAvro(byte[] byte

[GitHub] [hudi] n3nash commented on pull request #2012: [HUDI-1129] Deltastreamer Add support for schema evolution

2020-09-08 Thread GitBox
n3nash commented on pull request #2012: URL: https://github.com/apache/hudi/pull/2012#issuecomment-688954187 @sathyaprakashg Thanks for looking into this. I see that the `org.apache.spark.sql.avro.SchemaConverters` uses the `fixed` name so it's difficult to workaround it. Your approach sou

[GitHub] [hudi] wangxianghu commented on pull request #1827: [HUDI-1089] Refactor hudi-client to support multi-engine

2020-09-08 Thread GitBox
wangxianghu commented on pull request #1827: URL: https://github.com/apache/hudi/pull/1827#issuecomment-688918271 > One more pass. > > @wangxianghu do the tests pass locally? 50 min is the travis limit, if its consistently exceeding that limit, we need to understand why and fix it. I

[GitHub] [hudi] ashishmgofficial commented on issue #2072: [SUPPORT] Hudi Pyspark Application Example

2020-09-08 Thread GitBox
ashishmgofficial commented on issue #2072: URL: https://github.com/apache/hudi/issues/2072#issuecomment-688903435 @bvaradar Im trying to do rollbacks and Savepoints through Hudi CLI in ver.0.6.0 . Im able to successfully create savepoints and rollback to the savepoint. But after rollback,

[GitHub] [hudi] wangxianghu commented on a change in pull request #1827: [HUDI-1089] Refactor hudi-client to support multi-engine

2020-09-08 Thread GitBox
wangxianghu commented on a change in pull request #1827: URL: https://github.com/apache/hudi/pull/1827#discussion_r484940203 ## File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/bootstrap/SparkBootstrapCommitActionExecutor.java ## @@ -77,34 +8

[GitHub] [hudi] wangxianghu commented on a change in pull request #1827: [HUDI-1089] Refactor hudi-client to support multi-engine

2020-09-08 Thread GitBox
wangxianghu commented on a change in pull request #1827: URL: https://github.com/apache/hudi/pull/1827#discussion_r484933755 ## File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/SparkCreateHandleFactory.java ## @@ -0,0 +1,46 @@ +/* + * Licensed to the A

[GitHub] [hudi] wangxianghu commented on a change in pull request #1827: [HUDI-1089] Refactor hudi-client to support multi-engine

2020-09-08 Thread GitBox
wangxianghu commented on a change in pull request #1827: URL: https://github.com/apache/hudi/pull/1827#discussion_r484933013 ## File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/HoodieSparkWriteClient.java ## @@ -0,0 +1,360 @@ +/* + * Licensed to th

[GitHub] [hudi] wangxianghu commented on a change in pull request #1827: [HUDI-1089] Refactor hudi-client to support multi-engine

2020-09-08 Thread GitBox
wangxianghu commented on a change in pull request #1827: URL: https://github.com/apache/hudi/pull/1827#discussion_r484931317 ## File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/HoodieSparkWriteClient.java ## @@ -0,0 +1,360 @@ +/* + * Licensed to th

[GitHub] [hudi] wangxianghu commented on a change in pull request #1827: [HUDI-1089] Refactor hudi-client to support multi-engine

2020-09-08 Thread GitBox
wangxianghu commented on a change in pull request #1827: URL: https://github.com/apache/hudi/pull/1827#discussion_r484931707 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java ## @@ -716,32 +674,97 @@ private void r

[GitHub] [hudi] wangxianghu commented on a change in pull request #1827: [HUDI-1089] Refactor hudi-client to support multi-engine

2020-09-08 Thread GitBox
wangxianghu commented on a change in pull request #1827: URL: https://github.com/apache/hudi/pull/1827#discussion_r484931161 ## File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/testutils/HoodieClientTestUtils.java ## @@ -81,7 +82,9 @@ */ public sta

[GitHub] [hudi] wangxianghu commented on a change in pull request #1827: [HUDI-1089] Refactor hudi-client to support multi-engine

2020-09-08 Thread GitBox
wangxianghu commented on a change in pull request #1827: URL: https://github.com/apache/hudi/pull/1827#discussion_r484928117 ## File path: hudi-spark/src/main/java/org/apache/hudi/bootstrap/SparkParquetBootstrapDataProvider.java ## @@ -43,18 +43,18 @@ /** * Spark Data frame

[GitHub] [hudi] wangxianghu commented on a change in pull request #1827: [HUDI-1089] Refactor hudi-client to support multi-engine

2020-09-08 Thread GitBox
wangxianghu commented on a change in pull request #1827: URL: https://github.com/apache/hudi/pull/1827#discussion_r484925689 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/commit/BaseMergeHelper.java ## @@ -161,11 +108,11 @@ private sta

[GitHub] [hudi] hj2016 commented on a change in pull request #1978: [HUDI-1184] Fix the support of hbase index partition path change

2020-09-08 Thread GitBox
hj2016 commented on a change in pull request #1978: URL: https://github.com/apache/hudi/pull/1978#discussion_r484922986 ## File path: hudi-client/src/test/java/org/apache/hudi/index/hbase/TestHBaseIndex.java ## @@ -156,6 +160,53 @@ public void testSimpleTagLocationAndUpdate()

[GitHub] [hudi] wangxianghu commented on a change in pull request #1827: [HUDI-1089] Refactor hudi-client to support multi-engine

2020-09-08 Thread GitBox
wangxianghu commented on a change in pull request #1827: URL: https://github.com/apache/hudi/pull/1827#discussion_r484921994 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/hbase/BaseHoodieHBaseIndex.java ## @@ -0,0 +1,295 @@ +/* + * Licensed t

[GitHub] [hudi] wangxianghu commented on a change in pull request #1827: [HUDI-1089] Refactor hudi-client to support multi-engine

2020-09-08 Thread GitBox
wangxianghu commented on a change in pull request #1827: URL: https://github.com/apache/hudi/pull/1827#discussion_r484921612 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/bloom/BaseHoodieBloomIndex.java ## @@ -0,0 +1,71 @@ +/* + * Licensed to

[GitHub] [hudi] rajgowtham24 commented on issue #2075: [SUPPORT] hoodie.datasource.write.precombine.field not working as expected

2020-09-08 Thread GitBox
rajgowtham24 commented on issue #2075: URL: https://github.com/apache/hudi/issues/2075#issuecomment-688806064 Hi @tooptoop4 , While reading the csv file i have used inferschema option as mentioned below input_df = spark.read.format("csv").option("header","true").option("infers

[GitHub] [hudi] wangxianghu commented on a change in pull request #1827: [HUDI-1089] Refactor hudi-client to support multi-engine

2020-09-08 Thread GitBox
wangxianghu commented on a change in pull request #1827: URL: https://github.com/apache/hudi/pull/1827#discussion_r484832824 ## File path: hudi-client/pom.xml ## @@ -68,6 +107,12 @@ + + + org.scala-lang Review comment: > should we limit scala to j

[GitHub] [hudi] wangxianghu commented on a change in pull request #1827: [HUDI-1089] Refactor hudi-client to support multi-engine

2020-09-08 Thread GitBox
wangxianghu commented on a change in pull request #1827: URL: https://github.com/apache/hudi/pull/1827#discussion_r484828823 ## File path: hudi-spark/src/main/scala/org/apache/hudi/IncrementalRelation.scala ## @@ -64,8 +64,7 @@ class IncrementalRelation(val sqlContext: SQLConte

[GitHub] [hudi] wangxianghu commented on a change in pull request #1827: [HUDI-1089] Refactor hudi-client to support multi-engine

2020-09-08 Thread GitBox
wangxianghu commented on a change in pull request #1827: URL: https://github.com/apache/hudi/pull/1827#discussion_r484828652 ## File path: style/checkstyle.xml ## @@ -62,7 +62,7 @@ - + Review comment: > let's dis

[GitHub] [hudi] wangxianghu commented on a change in pull request #1827: [HUDI-1089] Refactor hudi-client to support multi-engine

2020-09-08 Thread GitBox
wangxianghu commented on a change in pull request #1827: URL: https://github.com/apache/hudi/pull/1827#discussion_r484823465 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/RollbackUtils.java ## @@ -0,0 +1,134 @@ +/* + * License

[GitHub] [hudi] nsivabalan commented on a change in pull request #1978: [HUDI-1184] Fix the support of hbase index partition path change

2020-09-08 Thread GitBox
nsivabalan commented on a change in pull request #1978: URL: https://github.com/apache/hudi/pull/1978#discussion_r484820440 ## File path: hudi-client/src/test/java/org/apache/hudi/index/hbase/TestHBaseIndex.java ## @@ -156,6 +160,53 @@ public void testSimpleTagLocationAndUpdat

[GitHub] [hudi] wangxianghu commented on a change in pull request #1827: [HUDI-1089] Refactor hudi-client to support multi-engine

2020-09-08 Thread GitBox
wangxianghu commented on a change in pull request #1827: URL: https://github.com/apache/hudi/pull/1827#discussion_r484816690 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/keygen/KeyGeneratorInterface.java ## @@ -34,8 +33,4 @@ List getRecordKey

[GitHub] [hudi] wangxianghu commented on a change in pull request #1827: [HUDI-1089] Refactor hudi-client to support multi-engine

2020-09-08 Thread GitBox
wangxianghu commented on a change in pull request #1827: URL: https://github.com/apache/hudi/pull/1827#discussion_r484815402 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieIndex.java ## @@ -21,94 +21,52 @@ import org.apache.hudi.ApiMatu

[GitHub] [hudi] wangxianghu commented on a change in pull request #1827: [HUDI-1089] Refactor hudi-client to support multi-engine

2020-09-08 Thread GitBox
wangxianghu commented on a change in pull request #1827: URL: https://github.com/apache/hudi/pull/1827#discussion_r484815015 ## File path: hudi-client/hudi-client-common/pom.xml ## @@ -0,0 +1,44 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLS

[GitHub] [hudi] liujinhui1994 commented on pull request #1968: [HUDI-1192] Make create hive database automatically configurable

2020-09-08 Thread GitBox
liujinhui1994 commented on pull request #1968: URL: https://github.com/apache/hudi/pull/1968#issuecomment-688749502 Ok i will deal with this soon This is an automated message from the Apache Git Service. To respond to the mes

[jira] [Commented] (HUDI-1269) Make whether the failure of sync hudi data to hive affects hudi ingest process configurable

2020-09-08 Thread wangxianghu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192074#comment-17192074 ] wangxianghu commented on HUDI-1269: --- [~liujinhui] sure, feel free to take it  > Make wh

[jira] [Commented] (HUDI-1269) Make whether the failure of sync hudi data to hive affects hudi ingest process configurable

2020-09-08 Thread liujinhui (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192072#comment-17192072 ] liujinhui commented on HUDI-1269: - I am interested in hive related issues, may i take this

[jira] [Assigned] (HUDI-1269) Make whether the failure of sync hudi data to hive affects hudi ingest process configurable

2020-09-08 Thread wangxianghu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wangxianghu reassigned HUDI-1269: - Assignee: liujinhui (was: wangxianghu) > Make whether the failure of sync hudi data to hive affe

[jira] [Closed] (HUDI-1193) Upgrade http dependent version

2020-09-08 Thread liujinhui (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liujinhui closed HUDI-1193. --- > Upgrade http dependent version > -- > > Key: HUDI-1193 >

[jira] [Commented] (HUDI-1200) CustomKeyGenerator does not work,java.lang.NullPointerException

2020-09-08 Thread liujinhui (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192063#comment-17192063 ] liujinhui commented on HUDI-1200: - [~vinoth] Yes, it has been resolved, the production env

[jira] [Assigned] (HUDI-1274) Hive synchronization supports hourly partition

2020-09-08 Thread liujinhui (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liujinhui reassigned HUDI-1274: --- Assignee: liujinhui > Hive synchronization supports hourly partition > --

[jira] [Updated] (HUDI-1274) Hive synchronization supports hourly partition

2020-09-08 Thread liujinhui (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liujinhui updated HUDI-1274: Status: Open (was: New) > Hive synchronization supports hourly partition >

[GitHub] [hudi] garyli1019 commented on pull request #1938: [HUDI-920] Support Incremental query for MOR table

2020-09-08 Thread GitBox
garyli1019 commented on pull request #1938: URL: https://github.com/apache/hudi/pull/1938#issuecomment-688685118 Ready for review. cc: @vinothchandar @bhasudha This is an automated message from the Apache Git Service. To res

[GitHub] [hudi] garyli1019 commented on a change in pull request #1938: [HUDI-920] Support Incremental query for MOR table

2020-09-08 Thread GitBox
garyli1019 commented on a change in pull request #1938: URL: https://github.com/apache/hudi/pull/1938#discussion_r484701932 ## File path: hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/HoodieInputFormatUtils.java ## @@ -443,4 +444,45 @@ private static HoodieBaseFile

[hudi] branch master updated: [MINOR] fix typo

2020-09-08 Thread garyli
This is an automated email from the ASF dual-hosted git repository. garyli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git The following commit(s) were added to refs/heads/master by this push: new 51b16bd [MINOR] fix typo new e3cf34d Merge

[GitHub] [hudi] garyli1019 merged pull request #2077: [MINOR] fix typo

2020-09-08 Thread GitBox
garyli1019 merged pull request #2077: URL: https://github.com/apache/hudi/pull/2077 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hudi] garyli1019 commented on pull request #2077: [MINOR] fix typo

2020-09-08 Thread GitBox
garyli1019 commented on pull request #2077: URL: https://github.com/apache/hudi/pull/2077#issuecomment-688661449 thanks for opening this PR, LGTM. merging This is an automated message from the Apache Git Service. To respond t