[GitHub] [hudi] danny0405 commented on a diff in pull request #8568: [HUDI-6134] prevent two clean run concurrently in flink.

2023-05-16 Thread via GitHub
danny0405 commented on code in PR #8568: URL: https://github.com/apache/hudi/pull/8568#discussion_r1194859993 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/clustering/ClusteringCommitSink.java: ## @@ -179,7 +179,7 @@ private void doCommit(String

[GitHub] [hudi] danny0405 commented on a diff in pull request #8568: [HUDI-6134] prevent two clean run concurrently in flink.

2023-05-16 Thread via GitHub
danny0405 commented on code in PR #8568: URL: https://github.com/apache/hudi/pull/8568#discussion_r1194806781 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/clustering/ClusteringCommitSink.java: ## @@ -179,7 +179,7 @@ private void doCommit(String

[GitHub] [hudi] danny0405 commented on a diff in pull request #8568: [HUDI-6134] prevent two clean run concurrently in flink.

2023-04-26 Thread via GitHub
danny0405 commented on code in PR #8568: URL: https://github.com/apache/hudi/pull/8568#discussion_r1177902562 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/clustering/ClusteringCommitSink.java: ## @@ -179,7 +179,7 @@ private void doCommit(String

[GitHub] [hudi] danny0405 commented on a diff in pull request #8568: [HUDI-6134] prevent two clean run concurrently in flink.

2023-04-25 Thread via GitHub
danny0405 commented on code in PR #8568: URL: https://github.com/apache/hudi/pull/8568#discussion_r1177309173 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/clustering/ClusteringCommitSink.java: ## @@ -179,7 +179,7 @@ private void doCommit(String

[GitHub] [hudi] danny0405 commented on a diff in pull request #8568: [HUDI-6134] prevent two clean run concurrently in flink.

2023-04-25 Thread via GitHub
danny0405 commented on code in PR #8568: URL: https://github.com/apache/hudi/pull/8568#discussion_r1177250127 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/CleanFunction.java: ## @@ -64,7 +64,19 @@ public void open(Configuration parameters) throws

[GitHub] [hudi] danny0405 commented on a diff in pull request #8568: [HUDI-6134] prevent two clean run concurrently in flink.

2023-04-25 Thread via GitHub
danny0405 commented on code in PR #8568: URL: https://github.com/apache/hudi/pull/8568#discussion_r1177250127 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/CleanFunction.java: ## @@ -64,7 +64,19 @@ public void open(Configuration parameters) throws