[GitHub] [hudi] danny0405 commented on pull request #7159: [HUDI-5173] Skip if there is only one file in clusteringGroup

2023-03-21 Thread via GitHub
danny0405 commented on PR #7159: URL: https://github.com/apache/hudi/pull/7159#issuecomment-1478872465 You need to configure the clustering strategy to avoid this issue. Maybe your clustering startegy is a little aggresive. -- This is an automated message from the Apache Git Service. To

[GitHub] [hudi] danny0405 commented on pull request #7159: [HUDI-5173] Skip if there is only one file in clusteringGroup

2023-03-20 Thread via GitHub
danny0405 commented on PR #7159: URL: https://github.com/apache/hudi/pull/7159#issuecomment-1477276212 No, this is not a bug fix, only bug fixes can be merged into the minor version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hudi] danny0405 commented on pull request #7159: [HUDI-5173]Skip if there is only one file in clusteringGroup

2023-02-21 Thread via GitHub
danny0405 commented on PR #7159: URL: https://github.com/apache/hudi/pull/7159#issuecomment-1438186067 Thanks for the contribution, I have reviewed and attached a patch: [5173.zip](https://github.com/apache/hudi/files/10792217/5173.zip) You can apply the patch with cmd: `git apply

[GitHub] [hudi] danny0405 commented on pull request #7159: [HUDI-5173]Skip if there is only one file in clusteringGroup

2023-02-07 Thread via GitHub
danny0405 commented on PR #7159: URL: https://github.com/apache/hudi/pull/7159#issuecomment-1421982912 > > My only concern is we touch too many existing tests to make it right, not sure whether we have better way to achive the same gole. > > How about add a config : force_clustering

[GitHub] [hudi] danny0405 commented on pull request #7159: [HUDI-5173]Skip if there is only one file in clusteringGroup

2023-02-06 Thread via GitHub
danny0405 commented on PR #7159: URL: https://github.com/apache/hudi/pull/7159#issuecomment-1420183403 My only concern is we touch too many existing tests to make it right, not sure whether we have better way to achive the same gole. -- This is an automated message from the Apache Git

[GitHub] [hudi] danny0405 commented on pull request #7159: [HUDI-5173]Skip if there is only one file in clusteringGroup

2022-11-22 Thread GitBox
danny0405 commented on PR #7159: URL: https://github.com/apache/hudi/pull/7159#issuecomment-1324463330 There are many tests fails with clustering, should fix it though ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hudi] danny0405 commented on pull request #7159: [HUDI-5173]Skip if there is only one file in clusteringGroup

2022-11-20 Thread GitBox
danny0405 commented on PR #7159: URL: https://github.com/apache/hudi/pull/7159#issuecomment-1321385967 Did you apply the patch yet, i didn't see it. And there are test failures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hudi] danny0405 commented on pull request #7159: [HUDI-5173]Skip if there is only one file in clusteringGroup

2022-11-17 Thread GitBox
danny0405 commented on PR #7159: URL: https://github.com/apache/hudi/pull/7159#issuecomment-1319497037 Thanks for the contribution, I have reviewed and created a patch here: [5173.zip](https://github.com/apache/hudi/files/10037492/5173.zip) You can apply the patch with cmd: `git