[GitHub] [hudi] n3nash commented on pull request #2012: [HUDI-1129] Deltastreamer Add support for schema evolution

2021-05-14 Thread GitBox
n3nash commented on pull request #2012: URL: https://github.com/apache/hudi/pull/2012#issuecomment-841601332 @vinothchandar We have found a way to avoid `BaseAvroPayloadWithSchema`. We are validating some more corner cases with respect to schema evolution in the PR @nsivabalan has pointed

[GitHub] [hudi] n3nash commented on pull request #2012: [HUDI-1129] Deltastreamer Add support for schema evolution

2021-05-08 Thread GitBox
n3nash commented on pull request #2012: URL: https://github.com/apache/hudi/pull/2012#issuecomment-835486764 At a high level, my understanding is there are 3 issues 1. Removing namespace could cause backwards compatibility -> Validated with [this](https://github.com/apache/hudi/pull/

[GitHub] [hudi] n3nash commented on pull request #2012: [HUDI-1129] Deltastreamer Add support for schema evolution

2021-03-30 Thread GitBox
n3nash commented on pull request #2012: URL: https://github.com/apache/hudi/pull/2012#issuecomment-809974270 @sathyaprakashg Can you rebase this PR ? I'll wait for sometime before I'll give it a shot by myself. -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [hudi] n3nash commented on pull request #2012: [HUDI-1129] Deltastreamer Add support for schema evolution

2020-09-15 Thread GitBox
n3nash commented on pull request #2012: URL: https://github.com/apache/hudi/pull/2012#issuecomment-693155102 @sathyaprakashg thanks for the explanation, please update the PR accordingly, rebase and squash the commits. This i

[GitHub] [hudi] n3nash commented on pull request #2012: [HUDI-1129] Deltastreamer Add support for schema evolution

2020-09-08 Thread GitBox
n3nash commented on pull request #2012: URL: https://github.com/apache/hudi/pull/2012#issuecomment-688954187 @sathyaprakashg Thanks for looking into this. I see that the `org.apache.spark.sql.avro.SchemaConverters` uses the `fixed` name so it's difficult to workaround it. Your approach sou

[GitHub] [hudi] n3nash commented on pull request #2012: HUDI-1129 Deltastreamer Add support for schema evolution

2020-09-01 Thread GitBox
n3nash commented on pull request #2012: URL: https://github.com/apache/hudi/pull/2012#issuecomment-685269655 @sathyaprakashg Looks good to me. Can you please see why the build is failing ? This is an automated message from t