[GitHub] [hudi] shenh062326 commented on a change in pull request #1868: [HUDI-1083] Optimization in determining insert bucket location for a given key

2020-08-04 Thread GitBox
shenh062326 commented on a change in pull request #1868: URL: https://github.com/apache/hudi/pull/1868#discussion_r465428805 ## File path: hudi-client/src/test/java/org/apache/hudi/table/action/commit/TestUpsertPartitioner.java ## @@ -252,8 +250,27 @@ public void testUpsertPar

[GitHub] [hudi] shenh062326 commented on a change in pull request #1868: [HUDI-1083] Optimization in determining insert bucket location for a given key

2020-08-04 Thread GitBox
shenh062326 commented on a change in pull request #1868: URL: https://github.com/apache/hudi/pull/1868#discussion_r465428805 ## File path: hudi-client/src/test/java/org/apache/hudi/table/action/commit/TestUpsertPartitioner.java ## @@ -252,8 +250,27 @@ public void testUpsertPar

[GitHub] [hudi] shenh062326 commented on a change in pull request #1868: [HUDI-1083] Optimization in determining insert bucket location for a given key

2020-08-03 Thread GitBox
shenh062326 commented on a change in pull request #1868: URL: https://github.com/apache/hudi/pull/1868#discussion_r464775753 ## File path: hudi-client/src/main/java/org/apache/hudi/table/action/commit/UpsertPartitioner.java ## @@ -270,20 +273,24 @@ public int getPartition(Obje

[GitHub] [hudi] shenh062326 commented on a change in pull request #1868: [HUDI-1083] Optimization in determining insert bucket location for a given key

2020-08-03 Thread GitBox
shenh062326 commented on a change in pull request #1868: URL: https://github.com/apache/hudi/pull/1868#discussion_r464768984 ## File path: hudi-client/src/test/java/org/apache/hudi/table/action/commit/TestUpsertPartitioner.java ## @@ -269,8 +267,8 @@ public void testUpsertPart

[GitHub] [hudi] shenh062326 commented on a change in pull request #1868: [HUDI-1083] Optimization in determining insert bucket location for a given key

2020-08-01 Thread GitBox
shenh062326 commented on a change in pull request #1868: URL: https://github.com/apache/hudi/pull/1868#discussion_r464014872 ## File path: hudi-client/src/test/java/org/apache/hudi/table/action/commit/TestUpsertPartitioner.java ## @@ -269,8 +267,8 @@ public void testUpsertPart

[GitHub] [hudi] shenh062326 commented on a change in pull request #1868: [HUDI-1083] Optimization in determining insert bucket location for a given key

2020-08-01 Thread GitBox
shenh062326 commented on a change in pull request #1868: URL: https://github.com/apache/hudi/pull/1868#discussion_r464014566 ## File path: hudi-client/src/main/java/org/apache/hudi/table/action/commit/UpsertPartitioner.java ## @@ -270,20 +273,24 @@ public int getPartition(Obje

[GitHub] [hudi] shenh062326 commented on a change in pull request #1868: [HUDI-1083] Optimization in determining insert bucket location for a given key

2020-08-01 Thread GitBox
shenh062326 commented on a change in pull request #1868: URL: https://github.com/apache/hudi/pull/1868#discussion_r464013661 ## File path: hudi-client/src/main/java/org/apache/hudi/table/action/commit/UpsertPartitioner.java ## @@ -99,7 +100,7 @@ public UpsertPartitioner(Worklo

[GitHub] [hudi] shenh062326 commented on a change in pull request #1868: [HUDI-1083] Optimization in determining insert bucket location for a given key

2020-08-01 Thread GitBox
shenh062326 commented on a change in pull request #1868: URL: https://github.com/apache/hudi/pull/1868#discussion_r463932989 ## File path: hudi-client/src/main/java/org/apache/hudi/table/action/commit/UpsertPartitioner.java ## @@ -272,21 +275,44 @@ public int getPartition(Obje