[GitHub] [incubator-nuttx] zhuyanlinzyl opened a new pull request, #6028: libc:xtensa: move syscall to swint call

2022-04-11 Thread GitBox
zhuyanlinzyl opened a new pull request, #6028: URL: https://github.com/apache/incubator-nuttx/pull/6028 Signed-off-by: zhuyanlin ## Summary ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-nuttx] pussuw closed pull request #5977: RISC-V: Common mtimer driver

2022-04-11 Thread GitBox
pussuw closed pull request #5977: RISC-V: Common mtimer driver URL: https://github.com/apache/incubator-nuttx/pull/5977 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [incubator-nuttx] pussuw commented on pull request #5977: RISC-V: Common mtimer driver

2022-04-11 Thread GitBox
pussuw commented on PR #5977: URL: https://github.com/apache/incubator-nuttx/pull/5977#issuecomment-1094632323 Abandoning -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #5985: RISC-V: Combine 3 variables that depend on CPU amount into one

2022-04-11 Thread GitBox
pussuw commented on code in PR #5985: URL: https://github.com/apache/incubator-nuttx/pull/5985#discussion_r847026388 ## arch/risc-v/src/mpfs/chip.h: ## @@ -29,4 +29,33 @@ #include "mpfs_memorymap.h" +#include "riscv_percpu.h" + +/

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6010: env_dup: fix copying of parent's env to child with ARCH_ADDRENV=y

2022-04-11 Thread GitBox
pussuw commented on code in PR #6010: URL: https://github.com/apache/incubator-nuttx/pull/6010#discussion_r846979680 ## sched/environ/env_dup.c: ## @@ -61,7 +61,7 @@ * / -int env_dup(FAR struct tas

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6010: env_dup: fix copying of parent's env to child with ARCH_ADDRENV=y

2022-04-11 Thread GitBox
xiaoxiang781216 commented on code in PR #6010: URL: https://github.com/apache/incubator-nuttx/pull/6010#discussion_r847034604 ## sched/task/task_init.c: ## @@ -103,6 +104,14 @@ int nxtask_init(FAR struct task_tcb_s *tcb, const char *name, int priority, return ret; }

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6010: env_dup: fix copying of parent's env to child with ARCH_ADDRENV=y

2022-04-11 Thread GitBox
xiaoxiang781216 commented on code in PR #6010: URL: https://github.com/apache/incubator-nuttx/pull/6010#discussion_r847038094 ## sched/environ/env_dup.c: ## @@ -61,7 +61,7 @@ * / -int env_dup(FAR s

[GitHub] [incubator-nuttx] anjiahao1 opened a new pull request, #6029: add strptime support

2022-04-11 Thread GitBox
anjiahao1 opened a new pull request, #6029: URL: https://github.com/apache/incubator-nuttx/pull/6029 ## Summary add strptime support -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6010: env_dup: fix copying of parent's env to child with ARCH_ADDRENV=y

2022-04-11 Thread GitBox
pussuw commented on code in PR #6010: URL: https://github.com/apache/incubator-nuttx/pull/6010#discussion_r847045322 ## sched/environ/env_dup.c: ## @@ -61,7 +61,7 @@ * / -int env_dup(FAR struct tas

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5948: libc/lib_localtime:fix deadcode

2022-04-11 Thread GitBox
pkarashchenko commented on PR #5948: URL: https://github.com/apache/incubator-nuttx/pull/5948#issuecomment-1094672830 Why the PR is closed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [incubator-nuttx] anjiahao1 opened a new pull request, #5948: libc/lib_localtime:fix deadcode

2022-04-11 Thread GitBox
anjiahao1 opened a new pull request, #5948: URL: https://github.com/apache/incubator-nuttx/pull/5948 isdst always is false. remove it Signed-off-by: anjiahao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[incubator-nuttx] branch master updated: arch/riscv: Add mtimer driver

2022-04-11 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new a90bdda1ae arch/riscv: Add mtime

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6020: arch/riscv: Add mtimer driver

2022-04-11 Thread GitBox
pkarashchenko merged PR #6020: URL: https://github.com/apache/incubator-nuttx/pull/6020 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [incubator-nuttx] anjiahao1 commented on pull request #5948: libc/lib_localtime:fix deadcode

2022-04-11 Thread GitBox
anjiahao1 commented on PR #5948: URL: https://github.com/apache/incubator-nuttx/pull/5948#issuecomment-1094674937 > Why the PR is closed? Sorry, I accidentally deleted the branch 😿 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-nuttx] SPRESENSE opened a new pull request, #6030: Add Sensirion's SCD41 driver and minor fix

2022-04-11 Thread GitBox
SPRESENSE opened a new pull request, #6030: URL: https://github.com/apache/incubator-nuttx/pull/6030 ## Summary * Add Sensirion's SCD41 CO2, temperature and humidity sensor driver. * Fix invalid parameter check and redundant conditions in Sensirion's SCD30 sensor driver. * Fix redun

[GitHub] [incubator-nuttx-apps] SPRESENSE opened a new pull request, #1131: examples/scd41: Add new example for scd41 CO2 sensor

2022-04-11 Thread GitBox
SPRESENSE opened a new pull request, #1131: URL: https://github.com/apache/incubator-nuttx-apps/pull/1131 ## Summary Add new example for scd41 CO2 sensor application. This is an example application of https://github.com/apache/incubator-nuttx/pull/6030. ## Impact None

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6029: libc:add strptime support

2022-04-11 Thread GitBox
xiaoxiang781216 commented on code in PR #6029: URL: https://github.com/apache/incubator-nuttx/pull/6029#discussion_r847068969 ## libs/libc/time/lib_strptime.c: ## @@ -53,382 +67,474 @@ static const struct { const char *d_fmt; const char *t_fmt; const char *t_fmt_a

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6026: sched/note: include-able from C++ files

2022-04-11 Thread GitBox
xiaoxiang781216 merged PR #6026: URL: https://github.com/apache/incubator-nuttx/pull/6026 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[incubator-nuttx] branch master updated (a90bdda1ae -> 609e949ab0)

2022-04-11 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from a90bdda1ae arch/riscv: Add mtimer driver add 609e949ab0 sched/note: include-able from C++ files No n

[GitHub] [incubator-nuttx] zhhyu7 opened a new pull request, #6031: usrsock: Don't clear recvfrom available flag

2022-04-11 Thread GitBox
zhhyu7 opened a new pull request, #6031: URL: https://github.com/apache/incubator-nuttx/pull/6031 ## Summary usrsock: Don't clear recvfrom available flag ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-nuttx-apps] zhhyu7 opened a new pull request, #1132: usrsock: Don't clear recv and send available flag

2022-04-11 Thread GitBox
zhhyu7 opened a new pull request, #1132: URL: https://github.com/apache/incubator-nuttx-apps/pull/1132 Don't clear available flag if the response indicate there is more data Signed-off-by: zhanghongyu ## Summary ## Impact ## Testing -- This is an automa

[GitHub] [incubator-nuttx] jlaitine commented on pull request #6025: Add vm map

2022-04-11 Thread GitBox
jlaitine commented on PR #6025: URL: https://github.com/apache/incubator-nuttx/pull/6025#issuecomment-1094734274 Now, looking at this myself, I forgot to de-allocate the mappings when the group is removed. I will add that too -- This is an automated message from the Apache Git Service. To

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6010: env_dup: fix copying of parent's env to child with ARCH_ADDRENV=y

2022-04-11 Thread GitBox
pussuw commented on code in PR #6010: URL: https://github.com/apache/incubator-nuttx/pull/6010#discussion_r847091951 ## binfmt/binfmt_execmodule.c: ## @@ -151,14 +152,22 @@ int exec_module(FAR const struct binary_s *binp, } #if defined(CONFIG_ARCH_ADDRENV) && defined(CON

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6010: env_dup: fix copying of parent's env to child with ARCH_ADDRENV=y

2022-04-11 Thread GitBox
pussuw commented on code in PR #6010: URL: https://github.com/apache/incubator-nuttx/pull/6010#discussion_r847092742 ## sched/task/task_init.c: ## @@ -103,6 +104,14 @@ int nxtask_init(FAR struct task_tcb_s *tcb, const char *name, int priority, return ret; } + /*

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6010: env_dup: fix copying of parent's env to child with ARCH_ADDRENV=y

2022-04-11 Thread GitBox
pussuw commented on code in PR #6010: URL: https://github.com/apache/incubator-nuttx/pull/6010#discussion_r847093129 ## binfmt/binfmt_execmodule.c: ## @@ -151,14 +152,22 @@ int exec_module(FAR const struct binary_s *binp, } #if defined(CONFIG_ARCH_ADDRENV) && defined(CON

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #5931: fix: pthread_rwlock_timedwrlock.

2022-04-11 Thread GitBox
xiaoxiang781216 commented on code in PR #5931: URL: https://github.com/apache/incubator-nuttx/pull/5931#discussion_r847140120 ## sched/pthread/pthread_condclockwait.c: ## @@ -207,7 +127,7 @@ int pthread_cond_clockwait(FAR pthread_cond_t *cond, * begins. */ -

[GitHub] [incubator-nuttx] SPRESENSE opened a new pull request, #6032: graphics/nxterm: Avoid accessing freed memory

2022-04-11 Thread GitBox
SPRESENSE opened a new pull request, #6032: URL: https://github.com/apache/incubator-nuttx/pull/6032 ## Summary Fix accessing freed priv data. ## Impact None ## Testing Build pass. -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #5931: fix: pthread_rwlock_timedwrlock.

2022-04-11 Thread GitBox
pkarashchenko commented on code in PR #5931: URL: https://github.com/apache/incubator-nuttx/pull/5931#discussion_r847170634 ## sched/pthread/pthread_condclockwait.c: ## @@ -262,42 +182,13 @@ int pthread_cond_clockwait(FAR pthread_cond_t *cond, } e

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #5931: fix: pthread_rwlock_timedwrlock.

2022-04-11 Thread GitBox
pkarashchenko commented on code in PR #5931: URL: https://github.com/apache/incubator-nuttx/pull/5931#discussion_r847173941 ## sched/pthread/pthread_condclockwait.c: ## @@ -262,42 +182,13 @@ int pthread_cond_clockwait(FAR pthread_cond_t *cond, } e

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #5931: fix: pthread_rwlock_timedwrlock.

2022-04-11 Thread GitBox
pkarashchenko commented on code in PR #5931: URL: https://github.com/apache/incubator-nuttx/pull/5931#discussion_r847173941 ## sched/pthread/pthread_condclockwait.c: ## @@ -262,42 +182,13 @@ int pthread_cond_clockwait(FAR pthread_cond_t *cond, } e

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #5931: fix: pthread_rwlock_timedwrlock.

2022-04-11 Thread GitBox
pkarashchenko commented on code in PR #5931: URL: https://github.com/apache/incubator-nuttx/pull/5931#discussion_r847175231 ## sched/pthread/pthread_condclockwait.c: ## @@ -262,42 +182,13 @@ int pthread_cond_clockwait(FAR pthread_cond_t *cond, } e

[incubator-nuttx] branch master updated (609e949ab0 -> 9cd53d714e)

2022-04-11 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 609e949ab0 sched/note: include-able from C++ files new bf332cf888 drivers/sensors: Add new driver

[incubator-nuttx] 01/03: drivers/sensors: Add new driver for scd41 sensor module

2022-04-11 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit bf332cf888349b102f85665900afbaa46d5b56bd Author: SPRESENSE <41312067+sprese...@users.noreply.github.com>

[incubator-nuttx] 02/03: drivers/sensors/scd30: Fix invalid parameter check

2022-04-11 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 3787a362bff25384216c7920ee2e46973210bd40 Author: SPRESENSE <41312067+sprese...@users.noreply.github.com>

[incubator-nuttx] 03/03: drivers/sensors/sgp30: Fix redundant parameter check

2022-04-11 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 9cd53d714ec43f51a1158f4b2c124ec6d585ae42 Author: SPRESENSE <41312067+sprese...@users.noreply.github.com>

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6030: Add Sensirion's SCD41 driver and minor fix

2022-04-11 Thread GitBox
pkarashchenko merged PR #6030: URL: https://github.com/apache/incubator-nuttx/pull/6030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [incubator-nuttx] pkarashchenko opened a new pull request, #6033: drivers/syslog: update description if Kconfig

2022-04-11 Thread GitBox
pkarashchenko opened a new pull request, #6033: URL: https://github.com/apache/incubator-nuttx/pull/6033 ## Summary `CONFIG_CLOCK_MONOTONIC` has been removed. Update description if Kconfig accordingly. ## Impact None ## Testing Pass CI -- This is an automated messag

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6023: littelfs: deal with block devices w/o ioctl

2022-04-11 Thread GitBox
pkarashchenko merged PR #6023: URL: https://github.com/apache/incubator-nuttx/pull/6023 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[incubator-nuttx] branch master updated (9cd53d714e -> c9f3b3a7f1)

2022-04-11 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 9cd53d714e drivers/sensors/sgp30: Fix redundant parameter check add c9f3b3a7f1 littelfs: deal wit

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6010: env_dup: fix copying of parent's env to child with ARCH_ADDRENV=y

2022-04-11 Thread GitBox
pussuw commented on code in PR #6010: URL: https://github.com/apache/incubator-nuttx/pull/6010#discussion_r847188323 ## sched/environ/env_dup.c: ## @@ -61,7 +61,7 @@ * / -int env_dup(FAR struct tas

[GitHub] [incubator-nuttx] no1wudi opened a new pull request, #6034: arch/risc-v: Apply common mtime driver to mtime based chps

2022-04-11 Thread GitBox
no1wudi opened a new pull request, #6034: URL: https://github.com/apache/incubator-nuttx/pull/6034 ## Summary See #6020, apply it to k210/bl602/qemu_rv etc ## Impact risc-v based chips ## Testing rv-virt/k210/bl602 -- This is an automated message from the Apache Git Serv

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #5931: fix: pthread_rwlock_timedwrlock.

2022-04-11 Thread GitBox
pkarashchenko commented on code in PR #5931: URL: https://github.com/apache/incubator-nuttx/pull/5931#discussion_r847189987 ## sched/pthread/pthread_condclockwait.c: ## @@ -202,134 +120,71 @@ int pthread_cond_clockwait(FAR pthread_cond_t *cond, sched_lock(); flags

[GitHub] [incubator-nuttx] jihandong commented on a diff in pull request #5931: fix: pthread_rwlock_timedwrlock.

2022-04-11 Thread GitBox
jihandong commented on code in PR #5931: URL: https://github.com/apache/incubator-nuttx/pull/5931#discussion_r847202817 ## sched/pthread/pthread_condclockwait.c: ## @@ -262,42 +182,13 @@ int pthread_cond_clockwait(FAR pthread_cond_t *cond, } else

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #6031: usrsock: Don't clear recvfrom available flag

2022-04-11 Thread GitBox
masayuki2009 commented on PR #6031: URL: https://github.com/apache/incubator-nuttx/pull/6031#issuecomment-1094922303 @zhhyu7 What is the intention of this PR? Does this PR fix a bug? -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [incubator-nuttx] Ouss4 commented on a diff in pull request #5985: RISC-V: Combine 3 variables that depend on CPU amount into one

2022-04-11 Thread GitBox
Ouss4 commented on code in PR #5985: URL: https://github.com/apache/incubator-nuttx/pull/5985#discussion_r847216610 ## arch/risc-v/src/common/riscv_percpu.c: ## @@ -86,13 +123,27 @@ void riscv_percpu_init(void) void riscv_percpu_add_hart(uintptr_t hartid) { - /* Hart IDs go

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #5931: fix: pthread_rwlock_timedwrlock.

2022-04-11 Thread GitBox
pkarashchenko commented on code in PR #5931: URL: https://github.com/apache/incubator-nuttx/pull/5931#discussion_r847218576 ## sched/pthread/pthread_condclockwait.c: ## @@ -262,42 +182,13 @@ int pthread_cond_clockwait(FAR pthread_cond_t *cond, } e

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #5985: RISC-V: Combine 3 variables that depend on CPU amount into one

2022-04-11 Thread GitBox
pussuw commented on code in PR #5985: URL: https://github.com/apache/incubator-nuttx/pull/5985#discussion_r847225063 ## arch/risc-v/src/common/riscv_percpu.c: ## @@ -86,13 +123,27 @@ void riscv_percpu_init(void) void riscv_percpu_add_hart(uintptr_t hartid) { - /* Hart IDs g

[GitHub] [incubator-nuttx] anchao opened a new pull request, #6035: sched/init: drivers_initialize() should be late than up_initialize()

2022-04-11 Thread GitBox
anchao opened a new pull request, #6035: URL: https://github.com/apache/incubator-nuttx/pull/6035 ## Summary sched/init: drivers_initialize() should be late than up_initialize() up_initialize | ->up_serialinit | ->uart_register /* ("/dev/console", &CONSOLE_D

[GitHub] [incubator-nuttx] SPRESENSE opened a new pull request, #6036: arch, boards: cxd56xx: Minor update for spresense

2022-04-11 Thread GitBox
SPRESENSE opened a new pull request, #6036: URL: https://github.com/apache/incubator-nuttx/pull/6036 ## Summary * arch: cxd56xx: Fix critical section in scu driver * arch: cxd56xx: Fix compile warning of cxd56_emmc driver * arch: cxd56xx: Update loader and gnssfw version * boards:

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6036: arch, boards: cxd56xx: Minor update for spresense

2022-04-11 Thread GitBox
pkarashchenko commented on code in PR #6036: URL: https://github.com/apache/incubator-nuttx/pull/6036#discussion_r847251217 ## boards/arm/cxd56xx/spresense/src/cxd56_ioctl.c: ## @@ -91,6 +92,22 @@ int board_ioctl(unsigned int cmd, uintptr_t arg) } break; #endi

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #6031: usrsock: Don't clear recvfrom available flag

2022-04-11 Thread GitBox
masayuki2009 commented on PR #6031: URL: https://github.com/apache/incubator-nuttx/pull/6031#issuecomment-1094968219 @zhhyu7 Hmm, spresense:wifi does not work. ``` nsh> uname -a NuttX 10.3.0-RC0 51a5248e47 Apr 11 2022 21:00:21 arm spresense nsh> ps PID GROUP PRI POLI

[GitHub] [incubator-nuttx] anjiahao1 opened a new issue, #6037: thread and task behavior should be consistent?

2022-04-11 Thread GitBox
anjiahao1 opened a new issue, #6037: URL: https://github.com/apache/incubator-nuttx/issues/6037 ```c #include #include #include static void *a_thread_func() { printf("123456\n"); pthread_exit(0); return NULL; } int main(void) {

[GitHub] [incubator-nuttx] pkarashchenko commented on issue #6037: thread and task behavior should be consistent?

2022-04-11 Thread GitBox
pkarashchenko commented on issue #6037: URL: https://github.com/apache/incubator-nuttx/issues/6037#issuecomment-1094979570 `gcc hello_main.c -o test -lpthread` -- is this tested on RT-Linux? What are the priorities of `main` vs `pthread`? -- This is an automated message from the Apache G

[GitHub] [incubator-nuttx] anjiahao1 commented on issue #6037: thread and task behavior should be consistent?

2022-04-11 Thread GitBox
anjiahao1 commented on issue #6037: URL: https://github.com/apache/incubator-nuttx/issues/6037#issuecomment-1094980789 > `gcc hello_main.c -o test -lpthread` -- is this tested on RT-Linux? What are the priorities of `main` vs `pthread`? i use ubuntu 20.04 -- This is an automated m

[GitHub] [incubator-nuttx] pkarashchenko commented on issue #6037: thread and task behavior should be consistent?

2022-04-11 Thread GitBox
pkarashchenko commented on issue #6037: URL: https://github.com/apache/incubator-nuttx/issues/6037#issuecomment-1094983635 And in NuttX case both `main` and `pthread` have the same priorities? From the first look it look like `a_thread_func` didn't have a chance to be scheduled. -- This

[GitHub] [incubator-nuttx] zhhyu7 commented on pull request #6031: usrsock: Don't clear recvfrom available flag

2022-04-11 Thread GitBox
zhhyu7 commented on PR #6031: URL: https://github.com/apache/incubator-nuttx/pull/6031#issuecomment-1094985909 > Yes, is a bug fix. we use netutils/usrsock_rpmsg to supports cross core network data access -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [incubator-nuttx] anjiahao1 commented on issue #6037: thread and task behavior should be consistent?

2022-04-11 Thread GitBox
anjiahao1 commented on issue #6037: URL: https://github.com/apache/incubator-nuttx/issues/6037#issuecomment-1094986574 > And in NuttX case both `main` and `pthread` have the same priorities? From the first look it look like `a_thread_func` didn't have a chance to be scheduled. This

[GitHub] [incubator-nuttx] zhhyu7 commented on pull request #6031: usrsock: Don't clear recvfrom available flag

2022-04-11 Thread GitBox
zhhyu7 commented on PR #6031: URL: https://github.com/apache/incubator-nuttx/pull/6031#issuecomment-1094989235 > @zhhyu7 What is the intention of this PR? Does this PR fix a bug? @masayuki2009 Yes, is a bug fix. we use netutils/usrsock_rpmsg to supports cross core network data acc

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6035: sched/init: drivers_initialize() should be late than up_initialize()

2022-04-11 Thread GitBox
xiaoxiang781216 commented on PR #6035: URL: https://github.com/apache/incubator-nuttx/pull/6035#issuecomment-1094989322 @masayuki2009 this PR could fix the problem you report at #5728 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-nuttx] anjiahao1 opened a new pull request, #6038: sched/pthread_create:fix bug,delete data_sem

2022-04-11 Thread GitBox
anjiahao1 opened a new pull request, #6038: URL: https://github.com/apache/incubator-nuttx/pull/6038 if a pthread set attr is detach,and when call pthread_create, new thread exit quikly,new thread's tcb be free,then pthread_create use new thread's tcb will crash. Signed-off-by: anjia

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6027: netdb/lib_dnsaddserver.c: Do not insert the duplicate DNS address

2022-04-11 Thread GitBox
xiaoxiang781216 merged PR #6027: URL: https://github.com/apache/incubator-nuttx/pull/6027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[incubator-nuttx] branch master updated: netdb/lib_dnsaddserver.c: Do not insert the duplicate DNS address

2022-04-11 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 8dd5d0d510 netdb/lib_dnsaddserver.c:

[GitHub] [incubator-nuttx] anjiahao1 commented on issue #6037: thread and task behavior should be consistent?

2022-04-11 Thread GitBox
anjiahao1 commented on issue #6037: URL: https://github.com/apache/incubator-nuttx/issues/6037#issuecomment-1094992729 > > And in NuttX case both `main` and `pthread` have the same priorities? From the first look it look like `a_thread_func` didn't have a chance to be scheduled. > >

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6034: arch/risc-v: Apply common mtime driver to mtime based chps

2022-04-11 Thread GitBox
xiaoxiang781216 commented on PR #6034: URL: https://github.com/apache/incubator-nuttx/pull/6034#issuecomment-1094995707 @pussuw could you try this patch with MPFS? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6032: graphics/nxterm: Avoid accessing freed memory

2022-04-11 Thread GitBox
xiaoxiang781216 merged PR #6032: URL: https://github.com/apache/incubator-nuttx/pull/6032 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[incubator-nuttx] branch master updated: graphics/nxterm: Avoid accessing freed memory

2022-04-11 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 46a92aeebb graphics/nxterm: Avoid ac

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1131: examples/scd41: Add new example for scd41 CO2 sensor

2022-04-11 Thread GitBox
xiaoxiang781216 merged PR #1131: URL: https://github.com/apache/incubator-nuttx-apps/pull/1131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[incubator-nuttx-apps] branch master updated: examples/scd41: Add new example for scd41 CO2 sensor

2022-04-11 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new f2e7faa47 examples/scd41: Add n

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6031: usrsock: Don't clear recvfrom available flag

2022-04-11 Thread GitBox
xiaoxiang781216 commented on PR #6031: URL: https://github.com/apache/incubator-nuttx/pull/6031#issuecomment-1095023143 We found that if the remote close the socket first, USRSOCK_EVENT_REMOTE_CLOSED may report prematurely before the client can read rest data from socket. This patch try to

[GitHub] [incubator-nuttx] pussuw commented on pull request #6034: arch/risc-v: Apply common mtime driver to mtime based chps

2022-04-11 Thread GitBox
pussuw commented on PR #6034: URL: https://github.com/apache/incubator-nuttx/pull/6034#issuecomment-1095032341 > @pussuw could you try this patch with MPFS? Yes, goes to tomorrow though -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #6012: Low priority tasks interrupt high priority threads

2022-04-11 Thread GitBox
xiaoxiang781216 commented on issue #6012: URL: https://github.com/apache/incubator-nuttx/issues/6012#issuecomment-1095076311 Another solution is switch to read-write lock, so there is no the contention in the most case except open/close. -- This is an automated message from the Apache Gi

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #5931: fix: pthread_rwlock_timedwrlock.

2022-04-11 Thread GitBox
pkarashchenko commented on code in PR #5931: URL: https://github.com/apache/incubator-nuttx/pull/5931#discussion_r847352629 ## sched/pthread/pthread_condclockwait.c: ## @@ -202,134 +128,64 @@ int pthread_cond_clockwait(FAR pthread_cond_t *cond, sched_lock(); flags

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6036: arch, boards: cxd56xx: Minor update for spresense

2022-04-11 Thread GitBox
xiaoxiang781216 commented on code in PR #6036: URL: https://github.com/apache/incubator-nuttx/pull/6036#discussion_r847379422 ## boards/arm/cxd56xx/spresense/src/cxd56_ioctl.c: ## @@ -91,6 +92,22 @@ int board_ioctl(unsigned int cmd, uintptr_t arg) } break; #en

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1130: nshlib/nsh_fscmds.c: Make losetup command take optional sector size

2022-04-11 Thread GitBox
xiaoxiang781216 merged PR #1130: URL: https://github.com/apache/incubator-nuttx-apps/pull/1130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[incubator-nuttx-apps] branch master updated: nshlib/nsh_fscmds.c: Make losetup command take optional sector size

2022-04-11 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new c7fcffd09 nshlib/nsh_fscmds.c:

[GitHub] [incubator-nuttx] zouboan commented on issue #6012: Low priority tasks interrupt high priority threads

2022-04-11 Thread GitBox
zouboan commented on issue #6012: URL: https://github.com/apache/incubator-nuttx/issues/6012#issuecomment-1095118824 Yes, both nx_vioctl and nxmq_receive just read tg_filelist, so ReadWriteLock is useful, but, does nuttx support read-write locks? -- This is an automated message from the

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 closed pull request #1095: examples/buttons: Remove the code which reference CONFIG_INPUT_BUTTONS_NPOLLWAITERS

2022-04-11 Thread GitBox
xiaoxiang781216 closed pull request #1095: examples/buttons: Remove the code which reference CONFIG_INPUT_BUTTONS_NPOLLWAITERS URL: https://github.com/apache/incubator-nuttx-apps/pull/1095 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6036: arch, boards: cxd56xx: Minor update for spresense

2022-04-11 Thread GitBox
pkarashchenko commented on code in PR #6036: URL: https://github.com/apache/incubator-nuttx/pull/6036#discussion_r847418807 ## boards/arm/cxd56xx/spresense/src/cxd56_ioctl.c: ## @@ -91,6 +92,22 @@ int board_ioctl(unsigned int cmd, uintptr_t arg) } break; #endi

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6036: arch, boards: cxd56xx: Minor update for spresense

2022-04-11 Thread GitBox
pkarashchenko commented on code in PR #6036: URL: https://github.com/apache/incubator-nuttx/pull/6036#discussion_r847422342 ## boards/arm/cxd56xx/spresense/src/cxd56_ioctl.c: ## @@ -91,6 +92,22 @@ int board_ioctl(unsigned int cmd, uintptr_t arg) } break; #endi

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6000: sched/pthread: thread id should updated before start routine

2022-04-11 Thread GitBox
pkarashchenko commented on PR #6000: URL: https://github.com/apache/incubator-nuttx/pull/6000#issuecomment-1095168769 This case covers `pthread` API only, but `task_create` case is still not handled. `pid = task_create(...)` is still updated outside of critical section and task thread can't

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6033: drivers/syslog: update description if Kconfig

2022-04-11 Thread GitBox
xiaoxiang781216 merged PR #6033: URL: https://github.com/apache/incubator-nuttx/pull/6033 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[incubator-nuttx] branch master updated (46a92aeebb -> ea5ffac7d1)

2022-04-11 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 46a92aeebb graphics/nxterm: Avoid accessing freed memory add ea5ffac7d1 drivers/syslog: update descri

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6022: arch/risc-v: Apply misaligned access handler for k210/bl602

2022-04-11 Thread GitBox
xiaoxiang781216 commented on code in PR #6022: URL: https://github.com/apache/incubator-nuttx/pull/6022#discussion_r847467324 ## arch/risc-v/src/common/Kconfig: ## @@ -27,3 +27,8 @@ config RISCV_TOOLCHAIN_GNU_RVGW configured for riscv64-unknown-elf. endchoice

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6022: arch/risc-v: Apply misaligned access handler for k210/bl602

2022-04-11 Thread GitBox
xiaoxiang781216 commented on code in PR #6022: URL: https://github.com/apache/incubator-nuttx/pull/6022#discussion_r847467324 ## arch/risc-v/src/common/Kconfig: ## @@ -27,3 +27,8 @@ config RISCV_TOOLCHAIN_GNU_RVGW configured for riscv64-unknown-elf. endchoice

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #6039: arch/riscv: Move toolchain config to arch/risc-v/Kconfig like xtensa

2022-04-11 Thread GitBox
xiaoxiang781216 opened a new pull request, #6039: URL: https://github.com/apache/incubator-nuttx/pull/6039 ## Summary ## Impact Minor, code refactor ## Testing Pass CI -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6034: arch/risc-v: Apply common mtime driver to mtime based chps

2022-04-11 Thread GitBox
pkarashchenko commented on code in PR #6034: URL: https://github.com/apache/incubator-nuttx/pull/6034#discussion_r847538224 ## arch/risc-v/src/c906/c906_timerisr.c: ## @@ -117,15 +64,7 @@ static int c906_timerisr(int irq, void *context, void *arg) void up_timer_initialize(voi

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6034: arch/risc-v: Apply common mtime driver to mtime based chps

2022-04-11 Thread GitBox
pkarashchenko commented on PR #6034: URL: https://github.com/apache/incubator-nuttx/pull/6034#issuecomment-1095294774 In general LGTM! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6034: arch/risc-v: Apply common mtime driver to mtime based chps

2022-04-11 Thread GitBox
pkarashchenko commented on PR #6034: URL: https://github.com/apache/incubator-nuttx/pull/6034#issuecomment-1095296094 I still observe some warnings on a CI ``` .config:118:warning: symbol value '' invalid for ARCH_CPU_COUNT Building NuttX... Makefile:123: target 'riscv_cpuindex.

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6038: sched/pthread_create:fix bug,delete data_sem

2022-04-11 Thread GitBox
pkarashchenko commented on code in PR #6038: URL: https://github.com/apache/incubator-nuttx/pull/6038#discussion_r847547104 ## sched/pthread/pthread_create.c: ## @@ -529,37 +521,28 @@ int nx_pthread_create(pthread_trampoline_t trampoline, FAR pthread_t *thread, pid = ptcb->c

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6029: libc:add strptime support

2022-04-11 Thread GitBox
pkarashchenko commented on code in PR #6029: URL: https://github.com/apache/incubator-nuttx/pull/6029#discussion_r847549566 ## libs/libc/time/lib_strptime.c: ## @@ -0,0 +1,540 @@ +/ + * libs/libc/time/li

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6029: libc:add strptime support

2022-04-11 Thread GitBox
pkarashchenko commented on code in PR #6029: URL: https://github.com/apache/incubator-nuttx/pull/6029#discussion_r847552771 ## libs/libc/time/lib_strptime.c: ## @@ -0,0 +1,540 @@ +/ + * libs/libc/time/li

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6024: fs/fcntl: add O_APPEND flag judge in fcntl

2022-04-11 Thread GitBox
pkarashchenko commented on code in PR #6024: URL: https://github.com/apache/incubator-nuttx/pull/6024#discussion_r847554241 ## fs/vfs/fs_fcntl.c: ## @@ -150,6 +150,11 @@ static int file_vfcntl(FAR struct file *filep, int cmd, va_list ap) oflags &= (FFCN

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5948: libc/lib_localtime:fix deadcode

2022-04-11 Thread GitBox
xiaoxiang781216 merged PR #5948: URL: https://github.com/apache/incubator-nuttx/pull/5948 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[incubator-nuttx] branch master updated: libc/lib_localtime:fix deadcode

2022-04-11 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new bb6279fe60 libc/lib_localtime:fix de

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5985: RISC-V: Combine 3 variables that depend on CPU amount into one

2022-04-11 Thread GitBox
xiaoxiang781216 merged PR #5985: URL: https://github.com/apache/incubator-nuttx/pull/5985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[incubator-nuttx] branch master updated (bb6279fe60 -> 2670f143b5)

2022-04-11 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from bb6279fe60 libc/lib_localtime:fix deadcode new d5ea259828 RISC-V: Combine 3 variables that depend on

[incubator-nuttx] 02/03: RISC-V: Remove riscv_cpuindex.c from platforms that don't need it

2022-04-11 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit b0a71ce3e7a229ec57d95e0c2203fb4c89c2e0bc Author: Ville Juven AuthorDate: Wed Apr 6 11:50:24 2022 +0300

[incubator-nuttx] 03/03: RISC-V: Add setintstack for k210 and qemu

2022-04-11 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 2670f143b58b8b97eae2ba0e6ee28771b74d Author: Ville Juven AuthorDate: Fri Apr 8 08:59:34 2022 +0300

[incubator-nuttx] 01/03: RISC-V: Combine 3 variables that depend on CPU amount into one

2022-04-11 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit d5ea2598282fce6da8eafe4398cb03ad1719d759 Author: Ville Juven AuthorDate: Tue Apr 5 13:24:28 2022 +0300

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6034: arch/risc-v: Apply common mtime driver to mtime based chps

2022-04-11 Thread GitBox
xiaoxiang781216 commented on PR #6034: URL: https://github.com/apache/incubator-nuttx/pull/6034#issuecomment-1095361099 > I still observe some warnings on a CI > > ``` > .config:118:warning: symbol value '' invalid for ARCH_CPU_COUNT > Building NuttX... > Makefile:123: targe

  1   2   >