[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5624: joystick/buttons: Fix the event lose between the invocation of poll

2022-03-01 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5624: URL: https://github.com/apache/incubator-nuttx/pull/5624#discussion_r817035988 ## File path: drivers/input/ajoystick.c ## @@ -722,6 +720,19 @@ static int ajoy_poll(FAR struct file *filep, FAR struct pollfd *fds,

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #5658: sched/group: Simplify the allocation and deallocation logic

2022-03-01 Thread GitBox
xiaoxiang781216 opened a new pull request #5658: URL: https://github.com/apache/incubator-nuttx/pull/5658 ## Summary 1.Move tg_membe allocation to group_alloc 2.Merge group_deallocate to group_release ## Impact Code refactor only ## Testing Pass CI and local test

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #5658: sched/group: Simplify the allocation and deallocation logic

2022-03-01 Thread GitBox
masayuki2009 commented on pull request #5658: URL: https://github.com/apache/incubator-nuttx/pull/5658#issuecomment-1055951392 @xiaoxiang781216 Hmm, sabre-6quad:knsh has an issue. ``` $ qemu-system-arm -semihosting -M sabrelite -m 1024 -smp 4 -kernel ./nuttx -nographic

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #5641: sim: add loop thread to handle dev loops

2022-03-01 Thread GitBox
masayuki2009 commented on pull request #5641: URL: https://github.com/apache/incubator-nuttx/pull/5641#issuecomment-1055957021 @GUIDINGLI Could you rebase your branch to the latest master? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-nuttx] no1wudi commented on pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
no1wudi commented on pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637#issuecomment-1056033742 > The errors are still the same. We are loosing compilation flags for compiler libs Maybe, but compilation passed on my local machine with latest gcc-arm-none-ea

[GitHub] [incubator-nuttx-apps] no1wudi opened a new pull request #1037: Ignore .context (follow NuttX main repo)

2022-03-01 Thread GitBox
no1wudi opened a new pull request #1037: URL: https://github.com/apache/incubator-nuttx-apps/pull/1037 ## Summary Add .context to ignore ## Impact ## Testing CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
pkarashchenko commented on pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637#issuecomment-1056049809 > > The errors are still the same. We are loosing compilation flags for compiler libs > > Maybe, but compilation passed on my local machine with latest gcc

[GitHub] [incubator-nuttx] no1wudi commented on pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
no1wudi commented on pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637#issuecomment-1056052568 @pkarashchenko Yes, I got compiling flags like: ``` arm-none-eabi-gcc -c -fno-common -fno-builtin -Wall -Wstrict-prototypes -Wshadow -Wundef -Os -fomit-frame-point

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
pkarashchenko commented on pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637#issuecomment-1056053377 @no1wudi but the build fails for `giant-board`. Could you please examine that case as well? -- This is an automated message from the Apache Git Service. To resp

[GitHub] [incubator-nuttx] no1wudi commented on pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
no1wudi commented on pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637#issuecomment-1056055658 > @no1wudi but the build fails for `giant-board`. Could you please examine that case as well? It also passed on my local machine with latest PR but failed on CI,

[GitHub] [incubator-nuttx] no1wudi edited a comment on pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
no1wudi edited a comment on pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637#issuecomment-1056055658 > @no1wudi but the build fails for `giant-board`. Could you please examine that case as well? It also passed on my local machine with latest PR but failed

[GitHub] [incubator-nuttx] no1wudi edited a comment on pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
no1wudi edited a comment on pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637#issuecomment-1056055658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
pkarashchenko commented on a change in pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637#discussion_r817286908 ## File path: boards/arm/imx6/sabre-6quad/scripts/Make.defs ## @@ -34,7 +34,6 @@ ifneq ($(CONFIG_DEBUG_NOOPT),y) ARCHOPTIMIZATION += $(MA

[GitHub] [incubator-nuttx] no1wudi edited a comment on pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
no1wudi edited a comment on pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637#issuecomment-1056055658 > @no1wudi but the build fails for `giant-board`. Could you please examine that case as well? It also passed on my local machine with latest PR but failed

[GitHub] [incubator-nuttx] no1wudi commented on a change in pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
no1wudi commented on a change in pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637#discussion_r817288958 ## File path: boards/arm/imx6/sabre-6quad/scripts/Make.defs ## @@ -34,7 +34,6 @@ ifneq ($(CONFIG_DEBUG_NOOPT),y) ARCHOPTIMIZATION += $(MAXOPTIM

[GitHub] [incubator-nuttx] no1wudi edited a comment on pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
no1wudi edited a comment on pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637#issuecomment-1056055658 > @no1wudi but the build fails for `giant-board`. Could you please examine that case as well? It also passed on my local machine with latest PR but failed

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #1037: Ignore .context (follow NuttX main repo)

2022-03-01 Thread GitBox
xiaoxiang781216 commented on a change in pull request #1037: URL: https://github.com/apache/incubator-nuttx-apps/pull/1037#discussion_r817297839 ## File path: .gitignore ## @@ -25,5 +25,6 @@ /symtab_apps.c cscope.out Make.dep +.context Review comment: which Makefile

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #1037: Ignore .context (follow NuttX main repo)

2022-03-01 Thread GitBox
xiaoxiang781216 commented on a change in pull request #1037: URL: https://github.com/apache/incubator-nuttx-apps/pull/1037#discussion_r817297839 ## File path: .gitignore ## @@ -25,5 +25,6 @@ /symtab_apps.c cscope.out Make.dep +.context Review comment: which Makefile

[GitHub] [incubator-nuttx] no1wudi commented on pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
no1wudi commented on pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637#issuecomment-1056109598 @xiaoxiang781216 @pkarashchenko There is a bug in arm-none-eabi-gcc 9.2 for cortex a that it dont report libgcc.a correctly for FPU enabled case: ``` gcc-arm-n

[GitHub] [incubator-nuttx] no1wudi edited a comment on pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
no1wudi edited a comment on pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637#issuecomment-1056109598 @xiaoxiang781216 @pkarashchenko There is a bug in arm-none-eabi-gcc 9.2 for cortex a that it don't report libgcc.a correctly for FPU enabled case: ``` g

[GitHub] [incubator-nuttx] no1wudi opened a new pull request #5659: ci: Update gcc-arm-none-eabi to 10.3-2021.10

2022-03-01 Thread GitBox
no1wudi opened a new pull request #5659: URL: https://github.com/apache/incubator-nuttx/pull/5659 ## Summary There is a bug in arm-none-eabi-gcc 9.2 for cortex a that it don't report libgcc.a correctly for FPU enabled case: ``` gcc-arm-none-eabi-9-2019-q4-major/bin/arm-none-eabi-gc

[GitHub] [incubator-nuttx-apps] no1wudi commented on a change in pull request #1037: Ignore .context (follow NuttX main repo)

2022-03-01 Thread GitBox
no1wudi commented on a change in pull request #1037: URL: https://github.com/apache/incubator-nuttx-apps/pull/1037#discussion_r817377794 ## File path: .gitignore ## @@ -25,5 +25,6 @@ /symtab_apps.c cscope.out Make.dep +.context Review comment: Not sure it was genera

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
pkarashchenko commented on pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637#issuecomment-1056413203 Can we use softfp libs if hardfp are not available? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [incubator-nuttx] no1wudi commented on pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
no1wudi commented on pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637#issuecomment-1056431517 Yes, but softfp may cause performance issue on these platforms. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [incubator-nuttx] no1wudi edited a comment on pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
no1wudi edited a comment on pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637#issuecomment-1056431517 Yes we can, but softfp may cause performance issue on these platforms. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5659: ci: Update gcc-arm-none-eabi to 10.3-2021.10

2022-03-01 Thread GitBox
xiaoxiang781216 merged pull request #5659: URL: https://github.com/apache/incubator-nuttx/pull/5659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-nuttx] xiaoxiang781216 closed pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
xiaoxiang781216 closed pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5647: assert.h: Don't use UNUSED macro since it's very easy happen conflict

2022-03-01 Thread GitBox
pkarashchenko commented on pull request #5647: URL: https://github.com/apache/incubator-nuttx/pull/5647#issuecomment-1056484275 @xiaoxiang781216 I think that we can drop dependency on `nuttx/compiler.h` now. -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5659: ci: Update gcc-arm-none-eabi to 10.3-2021.10

2022-03-01 Thread GitBox
pkarashchenko commented on pull request #5659: URL: https://github.com/apache/incubator-nuttx/pull/5659#issuecomment-1056486117 BTW, we can try moving to GCC11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [incubator-nuttx] GUIDINGLI commented on pull request #5641: sim: add loop thread to handle dev loops

2022-03-01 Thread GitBox
GUIDINGLI commented on pull request #5641: URL: https://github.com/apache/incubator-nuttx/pull/5641#issuecomment-1056493454 > @GUIDINGLI > > Could you rebase your branch to the latest master? done -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #5660: syscal: Remove .context form .gitignore

2022-03-01 Thread GitBox
xiaoxiang781216 opened a new pull request #5660: URL: https://github.com/apache/incubator-nuttx/pull/5660 ## Summary since it is already added in the top level of .gitignore in https://github.com/apache/incubator-nuttx/pull/5055 ## Impact Minor ## Testing Pass CI

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #1037: Ignore .context (follow NuttX main repo)

2022-03-01 Thread GitBox
xiaoxiang781216 commented on a change in pull request #1037: URL: https://github.com/apache/incubator-nuttx-apps/pull/1037#discussion_r817428618 ## File path: .gitignore ## @@ -25,5 +25,6 @@ /symtab_apps.c cscope.out Make.dep +.context Review comment: from this patc

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
pkarashchenko commented on pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637#issuecomment-1056497307 Why this PR is closed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1037: Ignore .context (follow NuttX main repo)

2022-03-01 Thread GitBox
xiaoxiang781216 merged pull request #1037: URL: https://github.com/apache/incubator-nuttx-apps/pull/1037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5519: Fix -Werror=nonnull-compare and -Werror=format-truncation=

2022-03-01 Thread GitBox
xiaoxiang781216 merged pull request #5519: URL: https://github.com/apache/incubator-nuttx/pull/5519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5647: assert.h: Don't use UNUSED macro since it's very easy happen conflict

2022-03-01 Thread GitBox
xiaoxiang781216 commented on pull request #5647: URL: https://github.com/apache/incubator-nuttx/pull/5647#issuecomment-1056502008 > @xiaoxiang781216 I think that we can drop dependency on `nuttx/compiler.h` now. I think so before, but assert reference noreturn_function:(. -- This

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5647: assert.h: Don't use UNUSED macro since it's very easy happen conflict

2022-03-02 Thread GitBox
pkarashchenko commented on pull request #5647: URL: https://github.com/apache/incubator-nuttx/pull/5647#issuecomment-1056508269 > > @xiaoxiang781216 I think that we can drop dependency on `nuttx/compiler.h` now. > > I think so before, but assert reference noreturn_function:(.

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #5647: assert.h: Don't use UNUSED macro since it's very easy happen conflict

2022-03-02 Thread GitBox
pkarashchenko merged pull request #5647: URL: https://github.com/apache/incubator-nuttx/pull/5647 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5659: ci: Update gcc-arm-none-eabi to 10.3-2021.10

2022-03-02 Thread GitBox
xiaoxiang781216 commented on pull request #5659: URL: https://github.com/apache/incubator-nuttx/pull/5659#issuecomment-1056517606 Does GCC11 for arm release? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-02 Thread GitBox
xiaoxiang781216 commented on pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637#issuecomment-1056522650 I close #5659, it strange that this one is closed too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5659: ci: Update gcc-arm-none-eabi to 10.3-2021.10

2022-03-02 Thread GitBox
pkarashchenko commented on pull request #5659: URL: https://github.com/apache/incubator-nuttx/pull/5659#issuecomment-1056570617 > Does GCC11 for arm release? https://developer.arm.com/-/media/Files/downloads/gnu/11.2-2022.02/binrel/gcc-arm-11.2-2022.02-x86_64-arm-none-eabi.tar.xz -

[GitHub] [incubator-nuttx] michi-jung opened a new pull request #5661: Include nuttx/compiler.h from string.h

2022-03-02 Thread GitBox
michi-jung opened a new pull request #5661: URL: https://github.com/apache/incubator-nuttx/pull/5661 NuttX' string.h is using the FAR preprocessor definition, which is defined in nuttx/compiler.h. Thus, it should include it. Signed-off-by: Michael Jung -- This is an automa

[GitHub] [incubator-nuttx] no1wudi commented on pull request #5659: ci: Update gcc-arm-none-eabi to 10.3-2021.10

2022-03-02 Thread GitBox
no1wudi commented on pull request #5659: URL: https://github.com/apache/incubator-nuttx/pull/5659#issuecomment-1056604711 But I only see 10.3 on download page: https://developer.arm.com/tools-and-software/open-source-software/developer-tools/gnu-toolchain/gnu-rm/downloads -- This is

[GitHub] [incubator-nuttx] no1wudi opened a new pull request #5662: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-02 Thread GitBox
no1wudi opened a new pull request #5662: URL: https://github.com/apache/incubator-nuttx/pull/5662 ## Summary Reopen #5637 ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [incubator-nuttx] no1wudi edited a comment on pull request #5659: ci: Update gcc-arm-none-eabi to 10.3-2021.10

2022-03-02 Thread GitBox
no1wudi edited a comment on pull request #5659: URL: https://github.com/apache/incubator-nuttx/pull/5659#issuecomment-1056604711 But I only see 10.3 on download page: https://developer.arm.com/tools-and-software/open-source-software/developer-tools/gnu-toolchain/gnu-rm/downloads -- This

[GitHub] [incubator-nuttx] no1wudi edited a comment on pull request #5659: ci: Update gcc-arm-none-eabi to 10.3-2021.10

2022-03-02 Thread GitBox
no1wudi edited a comment on pull request #5659: URL: https://github.com/apache/incubator-nuttx/pull/5659#issuecomment-1056604711 But I only see 10.3 in download page: https://developer.arm.com/tools-and-software/open-source-software/developer-tools/gnu-toolchain/gnu-rm/downloads -- This

[GitHub] [incubator-nuttx] no1wudi edited a comment on pull request #5659: ci: Update gcc-arm-none-eabi to 10.3-2021.10

2022-03-02 Thread GitBox
no1wudi edited a comment on pull request #5659: URL: https://github.com/apache/incubator-nuttx/pull/5659#issuecomment-1056604711 But I only see 10.3 in download page: https://developer.arm.com/tools-and-software/open-source-software/developer-tools/gnu-toolchain/gnu-rm/downloads Emm,

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5659: ci: Update gcc-arm-none-eabi to 10.3-2021.10

2022-03-02 Thread GitBox
pkarashchenko commented on pull request #5659: URL: https://github.com/apache/incubator-nuttx/pull/5659#issuecomment-1056634500 ![Screenshot from 2022-03-02 10-08-42](https://user-images.githubusercontent.com/17704713/156330535-753893cb-d120-413f-9d90-893a399e0f14.png) The button on

[GitHub] [incubator-nuttx] jerpelea opened a new pull request #5663: LICENSE: document licenses found in libs/libc

2022-03-02 Thread GitBox
jerpelea opened a new pull request #5663: URL: https://github.com/apache/incubator-nuttx/pull/5663 ## Summary Document licenses found in libs/libc ## Impact LICENSE ## Testing NONE -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5662: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-02 Thread GitBox
pkarashchenko commented on pull request #5662: URL: https://github.com/apache/incubator-nuttx/pull/5662#issuecomment-1056660366 Should we add softfp flag in case is GCC version is 9 or lower? What do you think? Also with this PR we drop some parts related to "old" toolchains. I think we ne

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5662: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-02 Thread GitBox
pkarashchenko commented on pull request #5662: URL: https://github.com/apache/incubator-nuttx/pull/5662#issuecomment-1056662309 Also neon flag is dropped. Is this expected? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5662: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-02 Thread GitBox
pkarashchenko commented on a change in pull request #5662: URL: https://github.com/apache/incubator-nuttx/pull/5662#discussion_r817500804 ## File path: boards/arm/lpc43xx/bambino-200e/README.txt ## @@ -111,18 +111,6 @@ ports. CONFIG_ARCH_FPU=y CONFIG_ARMV7M_LAZYFPU=

[GitHub] [incubator-nuttx] no1wudi commented on pull request #5662: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-02 Thread GitBox
no1wudi commented on pull request #5662: URL: https://github.com/apache/incubator-nuttx/pull/5662#issuecomment-1056669540 > Also neon flag is dropped. Is this expected? It's due to the incomplete SoC feature setting since there is a option `CONFIG_ARM_HAVE_NEON`, I'll submit new comm

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5662: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-02 Thread GitBox
pkarashchenko commented on a change in pull request #5662: URL: https://github.com/apache/incubator-nuttx/pull/5662#discussion_r817503006 ## File path: boards/arm/imx6/sabre-6quad/scripts/Make.defs ## @@ -34,7 +34,6 @@ ifneq ($(CONFIG_DEBUG_NOOPT),y) ARCHOPTIMIZATION += $(MA

[GitHub] [incubator-nuttx] no1wudi commented on a change in pull request #5662: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-02 Thread GitBox
no1wudi commented on a change in pull request #5662: URL: https://github.com/apache/incubator-nuttx/pull/5662#discussion_r817503319 ## File path: boards/arm/lpc43xx/bambino-200e/README.txt ## @@ -111,18 +111,6 @@ ports. CONFIG_ARCH_FPU=y CONFIG_ARMV7M_LAZYFPU=y -C

[GitHub] [incubator-nuttx] no1wudi commented on a change in pull request #5662: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-02 Thread GitBox
no1wudi commented on a change in pull request #5662: URL: https://github.com/apache/incubator-nuttx/pull/5662#discussion_r817504494 ## File path: boards/arm/imx6/sabre-6quad/scripts/Make.defs ## @@ -34,7 +34,6 @@ ifneq ($(CONFIG_DEBUG_NOOPT),y) ARCHOPTIMIZATION += $(MAXOPTIM

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #5660: syscal: Remove .context form .gitignore

2022-03-02 Thread GitBox
pkarashchenko merged pull request #5660: URL: https://github.com/apache/incubator-nuttx/pull/5660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5659: ci: Update gcc-arm-none-eabi to 10.3-2021.10

2022-03-02 Thread GitBox
pkarashchenko commented on pull request #5659: URL: https://github.com/apache/incubator-nuttx/pull/5659#issuecomment-1056720815 @xiaoxiang781216 seems that after toolchain update CI is not passing anymore -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [incubator-nuttx] pkarashchenko edited a comment on pull request #5659: ci: Update gcc-arm-none-eabi to 10.3-2021.10

2022-03-02 Thread GitBox
pkarashchenko edited a comment on pull request #5659: URL: https://github.com/apache/incubator-nuttx/pull/5659#issuecomment-1056720815 @xiaoxiang781216 seems that after toolchain update CI is not passing anymore ``` mmcsd/mmcsd_spi.c:223:28: note: while referencing 'g_mmcsdslot'

[GitHub] [incubator-nuttx] no1wudi commented on pull request #5659: ci: Update gcc-arm-none-eabi to 10.3-2021.10

2022-03-02 Thread GitBox
no1wudi commented on pull request #5659: URL: https://github.com/apache/incubator-nuttx/pull/5659#issuecomment-1056740504 It seems code check is more strict in this GCC, in this error: ``` /* A slot structure allocated for each configured slot */ static struct mmcsd_slot_s g_mmc

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5661: Include nuttx/compiler.h from string.h

2022-03-02 Thread GitBox
xiaoxiang781216 commented on pull request #5661: URL: https://github.com/apache/incubator-nuttx/pull/5661#issuecomment-1056748898 let's ignore the false alarm. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5661: Include nuttx/compiler.h from string.h

2022-03-02 Thread GitBox
xiaoxiang781216 merged pull request #5661: URL: https://github.com/apache/incubator-nuttx/pull/5661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5663: LICENSE: document licenses found in libs/libc

2022-03-02 Thread GitBox
xiaoxiang781216 commented on pull request #5663: URL: https://github.com/apache/incubator-nuttx/pull/5663#issuecomment-1056749316 let's ignore the false alarm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5663: LICENSE: document licenses found in libs/libc

2022-03-02 Thread GitBox
xiaoxiang781216 merged pull request #5663: URL: https://github.com/apache/incubator-nuttx/pull/5663 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-nuttx] no1wudi opened a new pull request #5664: nuttx/boards/arm/tiva/ekk-lm3s9b96: Disable unused mmcsd option

2022-03-02 Thread GitBox
no1wudi opened a new pull request #5664: URL: https://github.com/apache/incubator-nuttx/pull/5664 ## Summary Remove them to pass CI since they are not really used in board level logic. ## Impact None ## Testing CI -- This is an automated message from the Apache Git Serv

[GitHub] [incubator-nuttx] no1wudi commented on pull request #5659: ci: Update gcc-arm-none-eabi to 10.3-2021.10

2022-03-02 Thread GitBox
no1wudi commented on pull request #5659: URL: https://github.com/apache/incubator-nuttx/pull/5659#issuecomment-1056753057 @pkarashchenko Please see #5664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-nuttx] no1wudi commented on pull request #5664: nuttx/boards/arm/tiva/ekk-lm3s9b96: Disable unused mmcsd option

2022-03-02 Thread GitBox
no1wudi commented on pull request #5664: URL: https://github.com/apache/incubator-nuttx/pull/5664#issuecomment-1056759863 Commit message updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5664: ekk-lm3s9b96: Remove unused mmcsd option

2022-03-02 Thread GitBox
xiaoxiang781216 commented on pull request #5664: URL: https://github.com/apache/incubator-nuttx/pull/5664#issuecomment-1056763093 Let's directly merge this simple patch to unblock CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5664: ekk-lm3s9b96: Remove unused mmcsd option

2022-03-02 Thread GitBox
xiaoxiang781216 merged pull request #5664: URL: https://github.com/apache/incubator-nuttx/pull/5664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #5665: Add ESP32-S3 SPI-Flash support

2022-03-02 Thread GitBox
Ouss4 opened a new pull request #5665: URL: https://github.com/apache/incubator-nuttx/pull/5665 ## Summary Add support for the SPI-Flash for ESP32-S3. ## Impact New feature -- no impact on existing code. ## Testing Provided defconfig. -- This is an automated message from th

[GitHub] [incubator-nuttx] masayuki2009 merged pull request #5641: sim: add loop thread to handle dev loops

2022-03-02 Thread GitBox
masayuki2009 merged pull request #5641: URL: https://github.com/apache/incubator-nuttx/pull/5641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: c

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5624: joystick/buttons: Fix the event lose between the invocation of poll

2022-03-02 Thread GitBox
pkarashchenko commented on a change in pull request #5624: URL: https://github.com/apache/incubator-nuttx/pull/5624#discussion_r81760 ## File path: drivers/input/ajoystick.c ## @@ -722,6 +720,19 @@ static int ajoy_poll(FAR struct file *filep, FAR struct pollfd *fds,

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #5650: armv7-a/armv7-r:cache: modify hardcode in cache set/way operation

2022-03-02 Thread GitBox
masayuki2009 commented on pull request #5650: URL: https://github.com/apache/incubator-nuttx/pull/5650#issuecomment-1056827391 >Test on qemu sabre-6quad:smp @zhuyanlinzyl Did you test this PR with your dual Cortex-A7 platform? -- This is an automated message from the Ap

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5662: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-02 Thread GitBox
pkarashchenko commented on pull request #5662: URL: https://github.com/apache/incubator-nuttx/pull/5662#issuecomment-1056831143 > It's due to the incomplete SoC feature setting since there is a option `CONFIG_ARM_HAVE_NEON`, I'll submit new commit to this PR to keep its origin flags.

[GitHub] [incubator-nuttx] juniskane opened a new pull request #5666: arch/arm/src/stm32l4: STM32L4+ might need flash data cache corruption workaround

2022-03-02 Thread GitBox
juniskane opened a new pull request #5666: URL: https://github.com/apache/incubator-nuttx/pull/5666 ## Summary The STM32L4+ has flash data cache and errata documents say this issue exists, so enable workaround option for those chips. The "depends on" condition is also simplified t

[GitHub] [incubator-nuttx] zhuyanlinzyl commented on pull request #5650: armv7-a/armv7-r:cache: modify hardcode in cache set/way operation

2022-03-02 Thread GitBox
zhuyanlinzyl commented on pull request #5650: URL: https://github.com/apache/incubator-nuttx/pull/5650#issuecomment-1056833676 Yes, I also have test on dual Cortex-A7 platform @masayuki2009 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-nuttx] jerpelea opened a new pull request #5667: LICENSES: document licenses for include files

2022-03-02 Thread GitBox
jerpelea opened a new pull request #5667: URL: https://github.com/apache/incubator-nuttx/pull/5667 ## Summary Document licenses found in libs/libc ## Impact LICENSE ## Testing NONE -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [incubator-nuttx] gustavonihei opened a new pull request #5668: xtensa/esp32s3: Add support for Tickless kernel using Systimer

2022-03-02 Thread GitBox
gustavonihei opened a new pull request #5668: URL: https://github.com/apache/incubator-nuttx/pull/5668 ## Summary This PR intends to add support for Tickless operation of the NuttX kernel using the Systimer component. ## Impact Extended OS support for `esp32s3-devkit` platform.

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5668: xtensa/esp32s3: Add support for Tickless kernel using Systimer

2022-03-02 Thread GitBox
pkarashchenko commented on a change in pull request #5668: URL: https://github.com/apache/incubator-nuttx/pull/5668#discussion_r817661244 ## File path: arch/xtensa/src/esp32s3/esp32s3_tickless.c ## @@ -0,0 +1,484 @@ +/

[GitHub] [incubator-nuttx-apps] gustavonihei commented on pull request #929: MCUboot move apps to examples

2022-03-02 Thread GitBox
gustavonihei commented on pull request #929: URL: https://github.com/apache/incubator-nuttx-apps/pull/929#issuecomment-1056897731 > @nandojve why to move mcuboot to examples? I think boot/ is a better place to keep it, what do you think @gustavonihei ? Actually there are many "examples" i

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5668: xtensa/esp32s3: Add support for Tickless kernel using Systimer

2022-03-02 Thread GitBox
gustavonihei commented on a change in pull request #5668: URL: https://github.com/apache/incubator-nuttx/pull/5668#discussion_r817665684 ## File path: arch/xtensa/src/esp32s3/esp32s3_tickless.c ## @@ -0,0 +1,484 @@ +/*

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5668: xtensa/esp32s3: Add support for Tickless kernel using Systimer

2022-03-02 Thread GitBox
pkarashchenko commented on a change in pull request #5668: URL: https://github.com/apache/incubator-nuttx/pull/5668#discussion_r817666273 ## File path: arch/xtensa/src/esp32s3/esp32s3_tickless.c ## @@ -0,0 +1,484 @@ +/

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5668: xtensa/esp32s3: Add support for Tickless kernel using Systimer

2022-03-02 Thread GitBox
gustavonihei commented on a change in pull request #5668: URL: https://github.com/apache/incubator-nuttx/pull/5668#discussion_r817671140 ## File path: arch/xtensa/src/esp32s3/esp32s3_tickless.c ## @@ -0,0 +1,484 @@ +/*

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5668: xtensa/esp32s3: Add support for Tickless kernel using Systimer

2022-03-02 Thread GitBox
gustavonihei commented on a change in pull request #5668: URL: https://github.com/apache/incubator-nuttx/pull/5668#discussion_r817671140 ## File path: arch/xtensa/src/esp32s3/esp32s3_tickless.c ## @@ -0,0 +1,484 @@ +/*

[GitHub] [incubator-nuttx-apps] nandojve commented on pull request #929: MCUboot move apps to examples

2022-03-02 Thread GitBox
nandojve commented on pull request #929: URL: https://github.com/apache/incubator-nuttx-apps/pull/929#issuecomment-1056917598 Hi Folks, This change of feelings is that create bad projects. I invested a lot of time to put things in the correct way and, after weeks, now, it is about

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5624: joystick/buttons: Fix the event lose between the invocation of poll

2022-03-02 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5624: URL: https://github.com/apache/incubator-nuttx/pull/5624#discussion_r817692400 ## File path: drivers/input/ajoystick.c ## @@ -722,6 +720,19 @@ static int ajoy_poll(FAR struct file *filep, FAR struct pollfd *fds,

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5624: joystick/buttons: Fix the event lose between the invocation of poll

2022-03-02 Thread GitBox
pkarashchenko commented on a change in pull request #5624: URL: https://github.com/apache/incubator-nuttx/pull/5624#discussion_r817695866 ## File path: drivers/input/ajoystick.c ## @@ -722,6 +720,19 @@ static int ajoy_poll(FAR struct file *filep, FAR struct pollfd *fds,

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5662: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-02 Thread GitBox
pkarashchenko commented on a change in pull request #5662: URL: https://github.com/apache/incubator-nuttx/pull/5662#discussion_r817698716 ## File path: boards/arm/phy62xx/phy6222/scripts/Make.defs ## @@ -53,9 +53,6 @@ NXFLATLDFLAGS1 = -r -Wl,-d -Wl,-warn-common NXFLATLDFLAGS2

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5662: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-02 Thread GitBox
pkarashchenko commented on a change in pull request #5662: URL: https://github.com/apache/incubator-nuttx/pull/5662#discussion_r817702007 ## File path: boards/arm/phy62xx/phy6222/scripts/Make.defs ## @@ -53,9 +53,6 @@ NXFLATLDFLAGS1 = -r -Wl,-d -Wl,-warn-common NXFLATLDFLAGS2

[GitHub] [incubator-nuttx] no1wudi commented on a change in pull request #5662: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-02 Thread GitBox
no1wudi commented on a change in pull request #5662: URL: https://github.com/apache/incubator-nuttx/pull/5662#discussion_r817703636 ## File path: boards/arm/phy62xx/phy6222/scripts/Make.defs ## @@ -53,9 +53,6 @@ NXFLATLDFLAGS1 = -r -Wl,-d -Wl,-warn-common NXFLATLDFLAGS2 = $(NX

[GitHub] [incubator-nuttx] no1wudi commented on a change in pull request #5662: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-02 Thread GitBox
no1wudi commented on a change in pull request #5662: URL: https://github.com/apache/incubator-nuttx/pull/5662#discussion_r817704650 ## File path: boards/arm/phy62xx/phy6222/scripts/Make.defs ## @@ -53,9 +53,6 @@ NXFLATLDFLAGS1 = -r -Wl,-d -Wl,-warn-common NXFLATLDFLAGS2 = $(NX

[GitHub] [incubator-nuttx-apps] gustavonihei commented on pull request #929: MCUboot move apps to examples

2022-03-02 Thread GitBox
gustavonihei commented on pull request #929: URL: https://github.com/apache/incubator-nuttx-apps/pull/929#issuecomment-1056941297 > Hi Folks, > > This change of feelings is that create bad projects. I invested a lot of time to put things in the correct way and, after weeks, now, it

[GitHub] [incubator-nuttx-apps] gustavonihei edited a comment on pull request #929: MCUboot move apps to examples

2022-03-02 Thread GitBox
gustavonihei edited a comment on pull request #929: URL: https://github.com/apache/incubator-nuttx-apps/pull/929#issuecomment-1056941297 > Hi Folks, > > This change of feelings is that create bad projects. I invested a lot of time to put things in the correct way and, after weeks, n

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5662: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-02 Thread GitBox
pkarashchenko commented on a change in pull request #5662: URL: https://github.com/apache/incubator-nuttx/pull/5662#discussion_r817699643 ## File path: boards/arm/phy62xx/phy6222/scripts/Make.defs ## @@ -53,9 +53,6 @@ NXFLATLDFLAGS1 = -r -Wl,-d -Wl,-warn-common NXFLATLDFLAGS2

[GitHub] [incubator-nuttx] no1wudi opened a new pull request #5669: boards: Remove -nostartfiles -nodefaultlibs from phy62xx

2022-03-02 Thread GitBox
no1wudi opened a new pull request #5669: URL: https://github.com/apache/incubator-nuttx/pull/5669 ## Summary -nostartfiles -nodefaultlibs can't be recognized by gcc 10.3, and already removed from other socs. ## Impact phy62xx ## Testing CI -- This is an automated messa

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5662: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-02 Thread GitBox
pkarashchenko commented on a change in pull request #5662: URL: https://github.com/apache/incubator-nuttx/pull/5662#discussion_r817702007 ## File path: boards/arm/phy62xx/phy6222/scripts/Make.defs ## @@ -53,9 +53,6 @@ NXFLATLDFLAGS1 = -r -Wl,-d -Wl,-warn-common NXFLATLDFLAGS2

[GitHub] [incubator-nuttx-apps] gustavonihei edited a comment on pull request #929: MCUboot move apps to examples

2022-03-02 Thread GitBox
gustavonihei edited a comment on pull request #929: URL: https://github.com/apache/incubator-nuttx-apps/pull/929#issuecomment-1056941297 > Hi Folks, > > This change of feelings is that create bad projects. I invested a lot of time to put things in the correct way and, after weeks, n

[GitHub] [incubator-nuttx] no1wudi commented on pull request #5669: boards: Remove -nostartfiles -nodefaultlibs from phy62xx

2022-03-02 Thread GitBox
no1wudi commented on pull request #5669: URL: https://github.com/apache/incubator-nuttx/pull/5669#issuecomment-1056952488 @pkarashchenko Please see this PR, we should wait for CI pass to ensure there don't have other break. -- This is an automated message from the Apache Git Service. To

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5662: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-02 Thread GitBox
pkarashchenko commented on a change in pull request #5662: URL: https://github.com/apache/incubator-nuttx/pull/5662#discussion_r817707282 ## File path: boards/arm/phy62xx/phy6222/scripts/Make.defs ## @@ -53,9 +53,6 @@ NXFLATLDFLAGS1 = -r -Wl,-d -Wl,-warn-common NXFLATLDFLAGS2

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5667: LICENSES: document licenses for include files

2022-03-02 Thread GitBox
xiaoxiang781216 commented on pull request #5667: URL: https://github.com/apache/incubator-nuttx/pull/5667#issuecomment-1056955489 Let's ignore the false ci alarm by the new toolchain: https://github.com/apache/incubator-nuttx/pull/5659 -- This is an automated message from the Apache Git

<    1   2   3   4   5   6   7   8   9   10   >