ivankelly commented on a change in pull request #1205: Algorithm to find start
point of compacted ledger
URL: https://github.com/apache/incubator-pulsar/pull/1205#discussion_r167505885
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactedTopicImpl.java
#
ivankelly commented on a change in pull request #1103: PIP-13-1/3: Provide
`TopicsConsumer` to consume from several topics under same namespace
URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167516056
##
File path:
pulsar-client/src/main/java/org/apache/pulsa
ivankelly commented on a change in pull request #1103: PIP-13-1/3: Provide
`TopicsConsumer` to consume from several topics under same namespace
URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167516863
##
File path:
pulsar-client/src/main/java/org/apache/pulsa
ivankelly commented on a change in pull request #1103: PIP-13-1/3: Provide
`TopicsConsumer` to consume from several topics under same namespace
URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167517269
##
File path:
pulsar-client/src/main/java/org/apache/pulsa
ivankelly commented on a change in pull request #1066: Issue 937: add
CommandGetLastMessageId to make reader know the end of topic
URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r167522179
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/serv
sijie commented on a change in pull request #1066: Issue 937: add
CommandGetLastMessageId to make reader know the end of topic
URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r167588712
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/
mgodave opened a new pull request #1224: Checkstyle managed ledger
URL: https://github.com/apache/incubator-pulsar/pull/1224
Apply checkstyle rules from #1162 module-by-module, starting with managed
ledger.
This is an automat
merlimat commented on a change in pull request #1219: Xzy initialize
subscription config
URL: https://github.com/apache/incubator-pulsar/pull/1219#discussion_r167657264
##
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
##
merlimat commented on a change in pull request #1219: Xzy initialize
subscription config
URL: https://github.com/apache/incubator-pulsar/pull/1219#discussion_r167655939
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/api/ConsumerConfiguration.java
##
@@
merlimat commented on a change in pull request #1219: Xzy initialize
subscription config
URL: https://github.com/apache/incubator-pulsar/pull/1219#discussion_r167655263
##
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedger.java
##
@@ -138,
merlimat commented on a change in pull request #1219: Xzy initialize
subscription config
URL: https://github.com/apache/incubator-pulsar/pull/1219#discussion_r167656411
##
File path: pulsar-common/src/main/proto/PulsarApi.proto
##
@@ -193,6 +193,9 @@ message CommandSubscri
merlimat commented on a change in pull request #1219: Xzy initialize
subscription config
URL: https://github.com/apache/incubator-pulsar/pull/1219#discussion_r167657680
##
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedger.java
##
@@ -138,
ivankelly commented on issue #1205: Algorithm to find start point of compacted
ledger
URL: https://github.com/apache/incubator-pulsar/pull/1205#issuecomment-365054955
retest this please
This is an automated message from the A
jai1 opened a new pull request #1225: Enable specification of TLS Protocol
Versions and Cipher Suites
URL: https://github.com/apache/incubator-pulsar/pull/1225
### Motivation
Enable listening services (Broker, Proxy, Discovery Provider) to specify
which TLS Protocol Versions and Cip
ivankelly commented on issue #1137: Schema registry
URL: https://github.com/apache/incubator-pulsar/pull/1137#issuecomment-365058390
Almost 7000 LoCs. Any chance this could be broken into more digestible
pieces for review? Like leave this PR here for reference, for example submit
proto fil
mgodave commented on issue #1137: Schema registry
URL: https://github.com/apache/incubator-pulsar/pull/1137#issuecomment-365059450
I tried to do that before and I wasn't happy with how it worked out. I'll
take another look.
On Mon, Feb 12, 2018 at 1:54 PM, Ivan Kelly
wrote:
ivankelly commented on issue #1137: Schema registry
URL: https://github.com/apache/incubator-pulsar/pull/1137#issuecomment-365059871
Even just having the proto (and compiled stuff) separate would make it
easier to look at.
Th
mgodave commented on issue #1137: Schema registry
URL: https://github.com/apache/incubator-pulsar/pull/1137#issuecomment-365060102
Noted
On Mon, Feb 12, 2018 at 1:59 PM, Ivan Kelly
wrote:
> Even just having the proto (and compiled stuff) separate would make it
> easier t
ivankelly commented on issue #1137: Schema registry
URL: https://github.com/apache/incubator-pulsar/pull/1137#issuecomment-365060799
And maybe the bookkeeper schema storage implementation can be a separate
patch too?
This is
mgodave commented on issue #1137: Schema registry
URL: https://github.com/apache/incubator-pulsar/pull/1137#issuecomment-365061364
Yeah, I was thinking
1. Proto changes
2. Schema Registry
3. Default Implementation
The funny thing is that this is how my branches were origi
ivankelly commented on issue #1137: Schema registry
URL: https://github.com/apache/incubator-pulsar/pull/1137#issuecomment-365062216
Yes, github really sucks at this. gerrit does it much better.
What I do these days is to create a larger WIP patch which has everything
and is there fo
mgodave commented on issue #1137: Schema registry
URL: https://github.com/apache/incubator-pulsar/pull/1137#issuecomment-365065103
sounds good. I can easily break this apart again.
On Mon, Feb 12, 2018 at 2:07 PM, Ivan Kelly
wrote:
> Yes, github really sucks at this. gerrit
merlimat commented on a change in pull request #1225: Enable specification of
TLS Protocol Versions and Cipher Suites
URL: https://github.com/apache/incubator-pulsar/pull/1225#discussion_r167703706
##
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceCon
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new fbfd944 Algorithm to find start point
merlimat closed pull request #1205: Algorithm to find start point of compacted
ledger
URL: https://github.com/apache/incubator-pulsar/pull/1205
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As t
maskit commented on issue #1225: Enable specification of TLS Protocol Versions
and Cipher Suites
URL: https://github.com/apache/incubator-pulsar/pull/1225#issuecomment-365100577
Huge +1. I?ve been worried about this.
IIRC, we pass a string literal ?SSL? as an argument somewhere else,
rdhabalia commented on a change in pull request #1225: Enable specification of
TLS Protocol Versions and Cipher Suites
URL: https://github.com/apache/incubator-pulsar/pull/1225#discussion_r167724612
##
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceCo
rdhabalia commented on a change in pull request #1225: Enable specification of
TLS Protocol Versions and Cipher Suites
URL: https://github.com/apache/incubator-pulsar/pull/1225#discussion_r167724421
##
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/util/SecurityUti
merlimat opened a new pull request #1226: Bumped master to
2.0.0-incubating-SNAPSHOT
URL: https://github.com/apache/incubator-pulsar/pull/1226
### Motivation
Move development version to 2.0.0-incubating-SNAPSHOT
This i
merlimat opened a new pull request #1227: Regenerated the PulsarApi from proto
with latest protoc
URL: https://github.com/apache/incubator-pulsar/pull/1227
### Motivation
In #1200 the `PulsarApi.java` was regenerated with a protoc that didn't have
the latest patch with the fixes for
merlimat opened a new pull request #1228: Force to pull docker build image to
regenerate PulsarApi.java generat?
URL: https://github.com/apache/incubator-pulsar/pull/1228
?e_protobuf_docker.sh
### Motivation
Force to use the latest `apachepulsar/pulsar-build` image found in Do
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch branch-1.22
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/branch-1.22 by this push:
new 08913bd Regenerated the Pul
merlimat commented on issue #1150: PIP-10: Removing cluster from topic name
URL: https://github.com/apache/incubator-pulsar/pull/1150#issuecomment-365114101
retest this please
This is an automated message from the Apache Git S
merlimat commented on issue #1150: PIP-10: Removing cluster from topic name
URL: https://github.com/apache/incubator-pulsar/pull/1150#issuecomment-365114101
retest this please
This is an automated message from the Apache Git S
jai1 opened a new issue #1229: Documentation required for Pulsar Proxy and TLS
changes
URL: https://github.com/apache/incubator-pulsar/issues/1229
Need to add documentation for the flags added during Pulsar Proxy changes
and TLS changes:-
https://github.com/apache/incubator-pulsar/p
jai1 commented on issue #1225: Enable specification of TLS Protocol Versions
and Cipher Suites
URL: https://github.com/apache/incubator-pulsar/pull/1225#issuecomment-365127017
@rdhabalia - Have addressed your comments and added Tests
@merlimat - Have created a ticket for adding documenta
jai1 commented on a change in pull request #1225: Enable specification of TLS
Protocol Versions and Cipher Suites
URL: https://github.com/apache/incubator-pulsar/pull/1225#discussion_r167743242
##
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfigu
rdhabalia commented on a change in pull request #1225: Enable specification of
TLS Protocol Versions and Cipher Suites
URL: https://github.com/apache/incubator-pulsar/pull/1225#discussion_r167744955
##
File path:
pulsar-proxy/src/test/java/org/apache/pulsar/proxy/server/ProxyWithPr
yush1ga commented on issue #1223: Add a `backend` admin restful endpoint for
query backend information
URL: https://github.com/apache/incubator-pulsar/pull/1223#issuecomment-365129545
I think the class name `Backend` and `BackendData` is ambiguous.
As these handle only zookeeper's data,
yush1ga commented on issue #1223: Add a `backend` admin restful endpoint for
query backend information
URL: https://github.com/apache/incubator-pulsar/pull/1223#issuecomment-365129545
I think the class name `Backend` and `BackendData` are ambiguous.
As these handle only zookeeper's data,
rdhabalia commented on issue #1223: Add a `backend` admin restful endpoint for
query backend information
URL: https://github.com/apache/incubator-pulsar/pull/1223#issuecomment-365130333
> I think the class name Backend and BackendData are ambiguous.
or, we can use `InternalConfigurat
rdhabalia commented on a change in pull request #1225: Enable specification of
TLS Protocol Versions and Cipher Suites
URL: https://github.com/apache/incubator-pulsar/pull/1225#discussion_r167724421
##
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/util/SecurityUti
rdhabalia commented on a change in pull request #1225: Enable specification of
TLS Protocol Versions and Cipher Suites
URL: https://github.com/apache/incubator-pulsar/pull/1225#discussion_r167724421
##
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/util/SecurityUti
rdhabalia commented on issue #1226: Bumped master to 2.0.0-incubating-SNAPSHOT
URL: https://github.com/apache/incubator-pulsar/pull/1226#issuecomment-365134503
retest this please
This is an automated message from the Apache Gi
rdhabalia commented on issue #1227: Regenerated the PulsarApi from proto with
latest protoc
URL: https://github.com/apache/incubator-pulsar/pull/1227#issuecomment-365134556
retest this please
This is an automated message from
rdhabalia commented on issue #1226: Bumped master to 2.0.0-incubating-SNAPSHOT
URL: https://github.com/apache/incubator-pulsar/pull/1226#issuecomment-365134503
retest this please
This is an automated message from the Apache Gi
rdhabalia commented on issue #1228: Force to pull docker build image to
regenerate PulsarApi.java generat?
URL: https://github.com/apache/incubator-pulsar/pull/1228#issuecomment-365134612
retest this please
This is an automat
rdhabalia commented on issue #1228: Force to pull docker build image to
regenerate PulsarApi.java generat?
URL: https://github.com/apache/incubator-pulsar/pull/1228#issuecomment-365134612
retest this please
This is an automat
Author: jai1
Date: Tue Feb 13 04:06:25 2018
New Revision: 24989
Log:
Replaced gpg key for jai1
Modified:
dev/incubator/pulsar/KEYS
Modified: dev/incubator/pulsar/KEYS
==
--- dev/incubator/pulsar/KEYS (original)
+++ d
Author: jai1
Date: Tue Feb 13 04:09:43 2018
New Revision: 24990
Log:
Replaced gpg key for jai1
Modified:
dev/incubator/pulsar/KEYS
Modified: dev/incubator/pulsar/KEYS
==
--- dev/incubator/pulsar/KEYS (original)
+++ d
Author: jai1
Date: Tue Feb 13 04:10:24 2018
New Revision: 24991
Log:
Added gpg key for jai1
Modified:
release/incubator/pulsar/KEYS
Modified: release/incubator/pulsar/KEYS
==
--- release/incubator/pulsar/KEYS (origin
This is an automated email from the ASF dual-hosted git repository.
jai1 pushed a commit to branch branch-1.22
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/branch-1.22 by this push:
new 9d99dd3 Release 1.22.0-incuba
This is an automated email from the ASF dual-hosted git repository.
jai1 pushed a change to annotated tag v1.22.0-incubating-candidate-0
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git.
*** WARNING: tag v1.22.0-incubating-candidate-0 was modified! ***
from 9d99dd3 (c
merlimat closed pull request #1227: Regenerated the PulsarApi from proto with
latest protoc
URL: https://github.com/apache/incubator-pulsar/pull/1227
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 7dd64d0 Regenerated the PulsarApi fro
This is an automated email from the ASF dual-hosted git repository.
jai1 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new b990674 Enable specification of TLS Pro
jai1 closed pull request #1225: Enable specification of TLS Protocol Versions
and Cipher Suites
URL: https://github.com/apache/incubator-pulsar/pull/1225
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provena
57 matches
Mail list logo