yongfeng-nv commented on issue #4931: Tighten split's extent
URL: https://github.com/apache/incubator-tvm/pull/4931#issuecomment-596866979
> This PR is among one of the PRs affected by the github squash commit bug.
We take every contribution serious in the TVM community. The community has
yongfeng-nv commented on issue #4931: Tighten split's extent
URL: https://github.com/apache/incubator-tvm/pull/4931#issuecomment-594748097
@merrymercy, I have made your recommended changes. Please review it again.
Can you share your use case hitting this issue?
@tqchen, the flaky t
yongfeng-nv commented on issue #4931: Tighten split's extent
URL: https://github.com/apache/incubator-tvm/pull/4931#issuecomment-594306992
I need some help to reproduce the failure locally. I tried the CI twice and
both ended with the same failure (e.g.
https://ci.tvm.ai/blue/organization
yongfeng-nv commented on issue #4931: Tighten split's extent
URL: https://github.com/apache/incubator-tvm/pull/4931#issuecomment-592769137
I don't understand the current failure:
https://ci.tvm.ai/blue/organizations/jenkins/tvm/detail/PR-4931/7/pipeline.
How do I handle it?
-
yongfeng-nv commented on issue #4931: Tighten split's extent
URL: https://github.com/apache/incubator-tvm/pull/4931#issuecomment-592591273
> Use const reference when possible.
> The logic looks good to me.
> cc @tqchen for double check.
Thank you for the careful review. I forgo
yongfeng-nv commented on issue #4931: Tighten split's extent
URL: https://github.com/apache/incubator-tvm/pull/4931#issuecomment-591127743
@merrymercy, I have updated this PR description and refactor the code. All
tests are clear. Please review it. Thank you.
---
