[jira] [Commented] (HADOOP-16435) RpcMetrics should not be retained forever

2019-07-25 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16892514#comment-16892514 ] Zoltan Haindrich commented on HADOOP-16435: --- I don't think this is about a si

[GitHub] [hadoop] nandakumar131 opened a new pull request #1159: HDDS-1850. ReplicationManager should consider inflight replication and deletion while picking datanode for re-replication.

2019-07-25 Thread GitBox
nandakumar131 opened a new pull request #1159: HDDS-1850. ReplicationManager should consider inflight replication and deletion while picking datanode for re-replication. URL: https://github.com/apache/hadoop/pull/1159 When choosing the target datanode for re-replication ReplicationManager

[jira] [Updated] (HADOOP-16455) ABFS: Implement the access() method

2019-07-25 Thread Bilahari T H (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilahari T H updated HADOOP-16455: -- Summary: ABFS: Implement the access() method (was: ABFS: Implement the access method) > ABF

[jira] [Updated] (HADOOP-16455) ABFS: Implement access() method

2019-07-25 Thread Bilahari T H (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilahari T H updated HADOOP-16455: -- Summary: ABFS: Implement access() method (was: ABFS: Implement the access() method) > ABFS:

[jira] [Created] (HADOOP-16462) distcp should throw exception other than -999 error code while the exception is not classify, for us to know the real reason it failed

2019-07-25 Thread lifulong (JIRA)
lifulong created HADOOP-16462: - Summary: distcp should throw exception other than -999 error code while the exception is not classify, for us to know the real reason it failed Key: HADOOP-16462 URL: https://issues.ap

[jira] [Commented] (HADOOP-16462) distcp should throw exception other than -999 error code while the exception is not classify, for us to know the real reason it failed

2019-07-25 Thread lifulong (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16892666#comment-16892666 ] lifulong commented on HADOOP-16462: --- i have interest in submit one patch for this iss

[jira] [Comment Edited] (HADOOP-16462) distcp should throw exception other than -999 error code while the exception is not classify, for us to know the real reason it failed

2019-07-25 Thread lifulong (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16892666#comment-16892666 ] lifulong edited comment on HADOOP-16462 at 7/25/19 11:42 AM:

[jira] [Updated] (HADOOP-16447) Upgrade JUnit5 from 5.3.1 to 5.5+ to support global timeout

2019-07-25 Thread Takanobu Asanuma (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Takanobu Asanuma updated HADOOP-16447: -- Status: Patch Available (was: Open) > Upgrade JUnit5 from 5.3.1 to 5.5+ to support g

[GitHub] [hadoop] hadoop-yetus commented on issue #1159: HDDS-1850. ReplicationManager should consider inflight replication and deletion while picking datanode for re-replication.

2019-07-25 Thread GitBox
hadoop-yetus commented on issue #1159: HDDS-1850. ReplicationManager should consider inflight replication and deletion while picking datanode for re-replication. URL: https://github.com/apache/hadoop/pull/1159#issuecomment-515023939 :broken_heart: **-1 overall**

[jira] [Commented] (HADOOP-13373) Add S3A implementation of FSMainOperationsBaseTest

2019-07-25 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16892719#comment-16892719 ] Steve Loughran commented on HADOOP-13373: - working on this to get the glob stat

[jira] [Assigned] (HADOOP-13373) Add S3A implementation of FSMainOperationsBaseTest

2019-07-25 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran reassigned HADOOP-13373: --- Assignee: Steve Loughran > Add S3A implementation of FSMainOperationsBaseTest > --

[jira] [Work started] (HADOOP-13373) Add S3A implementation of FSMainOperationsBaseTest

2019-07-25 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HADOOP-13373 started by Steve Loughran. --- > Add S3A implementation of FSMainOperationsBaseTest > -

[GitHub] [hadoop] steveloughran commented on issue #1157: HADOOP-16461. Regression: FileSystem cache lock parses XML within the lock

2019-07-25 Thread GitBox
steveloughran commented on issue #1157: HADOOP-16461. Regression: FileSystem cache lock parses XML within the lock URL: https://github.com/apache/hadoop/pull/1157#issuecomment-515038390 patch LGTM, though Yetus isn't kicking off -presumably due to the ASF lockdown on who can run tests on A

[jira] [Issue Comment Deleted] (HADOOP-16462) distcp should throw exception other than -999 error code while the exception is not classify, for us to know the real reason it failed

2019-07-25 Thread lifulong (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lifulong updated HADOOP-16462: -- Comment: was deleted (was: i have interest in submit one patch for this issue, how can i do it? i ca

[jira] [Updated] (HADOOP-16462) distcp should throw exception other than -999 error code while the exception is not classify, for us to know the real reason it failed

2019-07-25 Thread lifulong (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lifulong updated HADOOP-16462: -- Environment: {code:java} // code placeholder @Override public int run(String[] argv) {

[jira] [Updated] (HADOOP-16462) distcp error log not print out while use java client to call distcp.run method, only get -999 error code

2019-07-25 Thread lifulong (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lifulong updated HADOOP-16462: -- Summary: distcp error log not print out while use java client to call distcp.run method, only get -99

[jira] [Commented] (HADOOP-16458) LocatedFileStatusFetcher.getFileStatuses failing intermittently with s3

2019-07-25 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16892731#comment-16892731 ] Steve Loughran commented on HADOOP-16458: - adding HADOOP-13373 to this ias it h

[GitHub] [hadoop] steveloughran opened a new pull request #1160: HADOOP-16458 LocatedFileStatusFetcher.getFileStatuses failing intermittently with s3

2019-07-25 Thread GitBox
steveloughran opened a new pull request #1160: HADOOP-16458 LocatedFileStatusFetcher.getFileStatuses failing intermittently with s3 URL: https://github.com/apache/hadoop/pull/1160 Improving diagnostics of scanning * stack traces don't get lost as failures get wrapped/aggregated *

[GitHub] [hadoop] steveloughran opened a new pull request #1161: HADOOP-16461. Regression: FileSystem cache lock parses XML within the lock

2019-07-25 Thread GitBox
steveloughran opened a new pull request #1161: HADOOP-16461. Regression: FileSystem cache lock parses XML within the lock URL: https://github.com/apache/hadoop/pull/1161 This is PR #1157 submitted by me to kick yetus off. Th

[jira] [Commented] (HADOOP-16447) Upgrade JUnit5 from 5.3.1 to 5.5+ to support global timeout

2019-07-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16892739#comment-16892739 ] Hadoop QA commented on HADOOP-16447: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[GitHub] [hadoop] steveloughran commented on issue #1157: HADOOP-16461. Regression: FileSystem cache lock parses XML within the lock

2019-07-25 Thread GitBox
steveloughran commented on issue #1157: HADOOP-16461. Regression: FileSystem cache lock parses XML within the lock URL: https://github.com/apache/hadoop/pull/1157#issuecomment-515043107 submitted PR #1161 to see if that will kick off yetus --

[jira] [Commented] (HADOOP-16455) ABFS: Implement access() method

2019-07-25 Thread Bilahari T H (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16892771#comment-16892771 ] Bilahari T H commented on HADOOP-16455: --- This is related to https://issues.apache

[jira] [Updated] (HADOOP-16462) distcp error log not print out while use java client to call distcp.run method, only get -999 error code

2019-07-25 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-16462: Environment: (was: {code:java} // code placeholder @Override public int run(St

[jira] [Commented] (HADOOP-16462) distcp error log not print out while use java client to call distcp.run method, only get -999 error code

2019-07-25 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16892780#comment-16892780 ] Steve Loughran commented on HADOOP-16462: - pasting from environment {code:java

[jira] [Commented] (HADOOP-16462) distcp error log not print out while use java client to call distcp.run method, only get -999 error code

2019-07-25 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16892782#comment-16892782 ] Steve Loughran commented on HADOOP-16462: - We aren't going to change the {{Too

[jira] [Updated] (HADOOP-16455) ABFS: Implement FileSystem.access() method

2019-07-25 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-16455: Summary: ABFS: Implement FileSystem.access() method (was: ABFS: Implement access() metho

[jira] [Commented] (HADOOP-16455) ABFS: Implement FileSystem.access() method

2019-07-25 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16892791#comment-16892791 ] Steve Loughran commented on HADOOP-16455: - OK, changed the title to be clearer

[jira] [Commented] (HADOOP-16439) Upgrade bundled Tomcat in branch-2

2019-07-25 Thread Wei-Chiu Chuang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16892798#comment-16892798 ] Wei-Chiu Chuang commented on HADOOP-16439: -- I verified that the Tomcat 7 port

[GitHub] [hadoop] bshashikant merged pull request #1124: HDDS-1749 : Ozone Client should randomize the list of nodes in pipeline for reads

2019-07-25 Thread GitBox
bshashikant merged pull request #1124: HDDS-1749 : Ozone Client should randomize the list of nodes in pipeline for reads URL: https://github.com/apache/hadoop/pull/1124 This is an automated message from the Apache Git Servic

[GitHub] [hadoop] bshashikant commented on issue #1124: HDDS-1749 : Ozone Client should randomize the list of nodes in pipeline for reads

2019-07-25 Thread GitBox
bshashikant commented on issue #1124: HDDS-1749 : Ozone Client should randomize the list of nodes in pipeline for reads URL: https://github.com/apache/hadoop/pull/1124#issuecomment-515078010 Thanks @avijayanhwx for working on this and @bharatviswa504 for the review. I have committed the ch

[GitHub] [hadoop] hadoop-yetus commented on issue #1124: HDDS-1749 : Ozone Client should randomize the list of nodes in pipeline for reads

2019-07-25 Thread GitBox
hadoop-yetus commented on issue #1124: HDDS-1749 : Ozone Client should randomize the list of nodes in pipeline for reads URL: https://github.com/apache/hadoop/pull/1124#issuecomment-515078126 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] hadoop-yetus commented on issue #1161: HADOOP-16461. Regression: FileSystem cache lock parses XML within the lock

2019-07-25 Thread GitBox
hadoop-yetus commented on issue #1161: HADOOP-16461. Regression: FileSystem cache lock parses XML within the lock URL: https://github.com/apache/hadoop/pull/1161#issuecomment-515087924 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:---

[GitHub] [hadoop] hadoop-yetus commented on issue #1160: HADOOP-16458 LocatedFileStatusFetcher.getFileStatuses failing intermittently with s3

2019-07-25 Thread GitBox
hadoop-yetus commented on issue #1160: HADOOP-16458 LocatedFileStatusFetcher.getFileStatuses failing intermittently with s3 URL: https://github.com/apache/hadoop/pull/1160#issuecomment-515099301 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment

[GitHub] [hadoop] bharatviswa504 commented on issue #1155: HDDS-1842. Implement S3 Abort MPU request to use Cache and DoubleBuffer.

2019-07-25 Thread GitBox
bharatviswa504 commented on issue #1155: HDDS-1842. Implement S3 Abort MPU request to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/1155#issuecomment-515099573 Thank You @arp7 for the review. Test failures are not related to this patch. I will commit this to the

[GitHub] [hadoop] bharatviswa504 merged pull request #1155: HDDS-1842. Implement S3 Abort MPU request to use Cache and DoubleBuffer.

2019-07-25 Thread GitBox
bharatviswa504 merged pull request #1155: HDDS-1842. Implement S3 Abort MPU request to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/1155 This is an automated message from the Apache Git Service. To

[jira] [Created] (HADOOP-16463) Migrate away from jsr305 jar

2019-07-25 Thread Eric Yang (JIRA)
Eric Yang created HADOOP-16463: -- Summary: Migrate away from jsr305 jar Key: HADOOP-16463 URL: https://issues.apache.org/jira/browse/HADOOP-16463 Project: Hadoop Common Issue Type: Bug

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1158: HDDS-1839: Change topology sorting related logs in Pipeline from INFO to DEBUG

2019-07-25 Thread GitBox
xiaoyuyao commented on a change in pull request #1158: HDDS-1839: Change topology sorting related logs in Pipeline from INFO to DEBUG URL: https://github.com/apache/hadoop/pull/1158#discussion_r307396865 ## File path: hadoop-hdds/container-service/src/main/resources/ozone-site.xml

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1158: HDDS-1839: Change topology sorting related logs in Pipeline from INFO to DEBUG

2019-07-25 Thread GitBox
xiaoyuyao commented on a change in pull request #1158: HDDS-1839: Change topology sorting related logs in Pipeline from INFO to DEBUG URL: https://github.com/apache/hadoop/pull/1158#discussion_r307396688 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/pipe

[GitHub] [hadoop] xiaoyuyao closed pull request #1008: HDDS-1713. ReplicationManager fail to find proper node topology based…

2019-07-25 Thread GitBox
xiaoyuyao closed pull request #1008: HDDS-1713. ReplicationManager fail to find proper node topology based… URL: https://github.com/apache/hadoop/pull/1008 This is an automated message from the Apache Git Service. To respond

[GitHub] [hadoop] xiaoyuyao commented on issue #1008: HDDS-1713. ReplicationManager fail to find proper node topology based…

2019-07-25 Thread GitBox
xiaoyuyao commented on issue #1008: HDDS-1713. ReplicationManager fail to find proper node topology based… URL: https://github.com/apache/hadoop/pull/1008#issuecomment-515135542 The JIRA has been taken over with a different PR. -

[GitHub] [hadoop] xiaoyuyao closed pull request #931: HDDS-1586. Allow Ozone RPC client to read with topology awareness.

2019-07-25 Thread GitBox
xiaoyuyao closed pull request #931: HDDS-1586. Allow Ozone RPC client to read with topology awareness. URL: https://github.com/apache/hadoop/pull/931 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [hadoop] xiaoyuyao commented on issue #931: HDDS-1586. Allow Ozone RPC client to read with topology awareness.

2019-07-25 Thread GitBox
xiaoyuyao commented on issue #931: HDDS-1586. Allow Ozone RPC client to read with topology awareness. URL: https://github.com/apache/hadoop/pull/931#issuecomment-515135949 The JIRA has been merged with a different PR. This i

[jira] [Commented] (HADOOP-16459) Backport [HADOOP-16266] "Add more fine-grained processing time metrics to the RPC layer" to branch-2

2019-07-25 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16893048#comment-16893048 ] Erik Krogen commented on HADOOP-16459: -- The checkstyles are carry-overs from match

[jira] [Commented] (HADOOP-16459) Backport [HADOOP-16266] "Add more fine-grained processing time metrics to the RPC layer" to branch-2

2019-07-25 Thread JIRA
[ https://issues.apache.org/jira/browse/HADOOP-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16893049#comment-16893049 ] Íñigo Goiri commented on HADOOP-16459: -- [^HADOOP-16266-branch-2.001.patch] LGTM. +

[jira] [Commented] (HADOOP-16453) Remove useless trace log in NetUtils.java

2019-07-25 Thread JIRA
[ https://issues.apache.org/jira/browse/HADOOP-16453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16893058#comment-16893058 ] Íñigo Goiri commented on HADOOP-16453: -- How does the exception thrown look like? I

[jira] [Commented] (HADOOP-16452) Increase ipc.maximum.data.length default from 64MB to 128MB

2019-07-25 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16893060#comment-16893060 ] Erik Krogen commented on HADOOP-16452: -- {quote} Breaking the BRs into multiple mes

[GitHub] [hadoop] swagle commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber

2019-07-25 Thread GitBox
swagle commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber URL: https://github.com/apache/hadoop/pull/1154#discussion_r307454335 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/HddsConfigKeys.java ##

[GitHub] [hadoop] hadoop-yetus commented on issue #1028: HDFS-14617 - Improve fsimage load time by writing sub-sections to the fsimage index

2019-07-25 Thread GitBox
hadoop-yetus commented on issue #1028: HDFS-14617 - Improve fsimage load time by writing sub-sections to the fsimage index URL: https://github.com/apache/hadoop/pull/1028#issuecomment-515186531 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1028: HDFS-14617 - Improve fsimage load time by writing sub-sections to the fsimage index

2019-07-25 Thread GitBox
hadoop-yetus commented on a change in pull request #1028: HDFS-14617 - Improve fsimage load time by writing sub-sections to the fsimage index URL: https://github.com/apache/hadoop/pull/1028#discussion_r307469373 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-d

[GitHub] [hadoop] chittshota opened a new pull request #1162: HDFS-14670: RBF: Create secret manager instance using FederationUtil#newInstance

2019-07-25 Thread GitBox
chittshota opened a new pull request #1162: HDFS-14670: RBF: Create secret manager instance using FederationUtil#newInstance URL: https://github.com/apache/hadoop/pull/1162 This is an automated message from the Apache Git Se

[GitHub] [hadoop] swagle commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber

2019-07-25 Thread GitBox
swagle commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber URL: https://github.com/apache/hadoop/pull/1154#discussion_r307494588 ## File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/o

[GitHub] [hadoop] anuengineer commented on issue #1159: HDDS-1850. ReplicationManager should consider inflight replication and deletion while picking datanode for re-replication.

2019-07-25 Thread GitBox
anuengineer commented on issue #1159: HDDS-1850. ReplicationManager should consider inflight replication and deletion while picking datanode for re-replication. URL: https://github.com/apache/hadoop/pull/1159#issuecomment-515227006 @nandakumar131 Thanks for your contribution. @mukul1987

[GitHub] [hadoop] goiri commented on issue #1162: HDFS-14670: RBF: Create secret manager instance using FederationUtil#newInstance

2019-07-25 Thread GitBox
goiri commented on issue #1162: HDFS-14670: RBF: Create secret manager instance using FederationUtil#newInstance URL: https://github.com/apache/hadoop/pull/1162#issuecomment-515226872 The code looks good. I think that Yatus used to run by itself but it got disabled? In Spark there is

[GitHub] [hadoop] anuengineer closed pull request #1159: HDDS-1850. ReplicationManager should consider inflight replication and deletion while picking datanode for re-replication.

2019-07-25 Thread GitBox
anuengineer closed pull request #1159: HDDS-1850. ReplicationManager should consider inflight replication and deletion while picking datanode for re-replication. URL: https://github.com/apache/hadoop/pull/1159 This is an au

[GitHub] [hadoop] avijayanhwx opened a new pull request #1163: HDDS-1786 : Datanodes takeSnapshot should delete previously created s…

2019-07-25 Thread GitBox
avijayanhwx opened a new pull request #1163: HDDS-1786 : Datanodes takeSnapshot should delete previously created s… URL: https://github.com/apache/hadoop/pull/1163 …napshots. Right now, after after taking a new snapshot, the previous snapshot file is left in the raft log directory.

[GitHub] [hadoop] chittshota commented on issue #1162: HDFS-14670: RBF: Create secret manager instance using FederationUtil#newInstance

2019-07-25 Thread GitBox
chittshota commented on issue #1162: HDFS-14670: RBF: Create secret manager instance using FederationUtil#newInstance URL: https://github.com/apache/hadoop/pull/1162#issuecomment-515234978 @goiri Thanks for the review. @steveloughran Could you help us know how to kick trigger the build

[GitHub] [hadoop] avijayanhwx commented on issue #1163: HDDS-1786 : Datanodes takeSnapshot should delete previously created s…

2019-07-25 Thread GitBox
avijayanhwx commented on issue #1163: HDDS-1786 : Datanodes takeSnapshot should delete previously created s… URL: https://github.com/apache/hadoop/pull/1163#issuecomment-515236951 /label ozone This is an automated message fro

[GitHub] [hadoop] avijayanhwx commented on issue #1163: HDDS-1786 : Datanodes takeSnapshot should delete previously created s…

2019-07-25 Thread GitBox
avijayanhwx commented on issue #1163: HDDS-1786 : Datanodes takeSnapshot should delete previously created s… URL: https://github.com/apache/hadoop/pull/1163#issuecomment-515236913 @mukul1987 / @lokeshj1703 / @bharatviswa504 / @bshashikant Please review when you have a chance. ---

[GitHub] [hadoop] avijayanhwx commented on issue #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API.

2019-07-25 Thread GitBox
avijayanhwx commented on issue #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API. URL: https://github.com/apache/hadoop/pull/1033#issuecomment-515238282 @arp7 Can you please review/commit this PR? Thi

[GitHub] [hadoop] arp7 commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API.

2019-07-25 Thread GitBox
arp7 commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API. URL: https://github.com/apache/hadoop/pull/1033#discussion_r307527606 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/DBUpdatesWrapper.ja

[GitHub] [hadoop] avijayanhwx commented on issue #1163: HDDS-1786 : Datanodes takeSnapshot should delete previously created s…

2019-07-25 Thread GitBox
avijayanhwx commented on issue #1163: HDDS-1786 : Datanodes takeSnapshot should delete previously created s… URL: https://github.com/apache/hadoop/pull/1163#issuecomment-515240355 cc @swagle This is an automated message from

[GitHub] [hadoop] swagle commented on a change in pull request #1163: HDDS-1786 : Datanodes takeSnapshot should delete previously created s…

2019-07-25 Thread GitBox
swagle commented on a change in pull request #1163: HDDS-1786 : Datanodes takeSnapshot should delete previously created s… URL: https://github.com/apache/hadoop/pull/1163#discussion_r307529271 ## File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/contain

[GitHub] [hadoop] arp7 commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API.

2019-07-25 Thread GitBox
arp7 commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API. URL: https://github.com/apache/hadoop/pull/1033#discussion_r307528176 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/RDBStore.java

[GitHub] [hadoop] arp7 commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API.

2019-07-25 Thread GitBox
arp7 commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API. URL: https://github.com/apache/hadoop/pull/1033#discussion_r307527924 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/RDBStore.java

[GitHub] [hadoop] arp7 commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API.

2019-07-25 Thread GitBox
arp7 commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API. URL: https://github.com/apache/hadoop/pull/1033#discussion_r307528281 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/RDBStore.java

[GitHub] [hadoop] arp7 commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API.

2019-07-25 Thread GitBox
arp7 commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API. URL: https://github.com/apache/hadoop/pull/1033#discussion_r307528628 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java ###

[GitHub] [hadoop] arp7 commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API.

2019-07-25 Thread GitBox
arp7 commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API. URL: https://github.com/apache/hadoop/pull/1033#discussion_r307529200 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzon

[GitHub] [hadoop] avijayanhwx commented on a change in pull request #1163: HDDS-1786 : Datanodes takeSnapshot should delete previously created s…

2019-07-25 Thread GitBox
avijayanhwx commented on a change in pull request #1163: HDDS-1786 : Datanodes takeSnapshot should delete previously created s… URL: https://github.com/apache/hadoop/pull/1163#discussion_r307529945 ## File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/co

[GitHub] [hadoop] smengcl opened a new pull request #1164: HDDS-1829 On OM reload/restart OmMetrics#numKeys should be updated

2019-07-25 Thread GitBox
smengcl opened a new pull request #1164: HDDS-1829 On OM reload/restart OmMetrics#numKeys should be updated URL: https://github.com/apache/hadoop/pull/1164 This is an automated message from the Apache Git Service. To respond

[GitHub] [hadoop] smengcl commented on a change in pull request #1164: HDDS-1829 On OM reload/restart OmMetrics#numKeys should be updated

2019-07-25 Thread GitBox
smengcl commented on a change in pull request #1164: HDDS-1829 On OM reload/restart OmMetrics#numKeys should be updated URL: https://github.com/apache/hadoop/pull/1164#discussion_r307530723 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/RDBTable.java ###

[GitHub] [hadoop] smengcl commented on a change in pull request #1164: HDDS-1829 On OM reload/restart OmMetrics#numKeys should be updated

2019-07-25 Thread GitBox
smengcl commented on a change in pull request #1164: HDDS-1829 On OM reload/restart OmMetrics#numKeys should be updated URL: https://github.com/apache/hadoop/pull/1164#discussion_r307531341 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/TypedTable.java #

[GitHub] [hadoop] smengcl commented on a change in pull request #1156: HDDS-1830 OzoneManagerDoubleBuffer#stop should wait for daemon thread to die

2019-07-25 Thread GitBox
smengcl commented on a change in pull request #1156: HDDS-1830 OzoneManagerDoubleBuffer#stop should wait for daemon thread to die URL: https://github.com/apache/hadoop/pull/1156#discussion_r307534380 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/

[GitHub] [hadoop] bharatviswa504 opened a new pull request #1165: HDDS-1861. Fix TableCacheImpl cleanup logic.

2019-07-25 Thread GitBox
bharatviswa504 opened a new pull request #1165: HDDS-1861. Fix TableCacheImpl cleanup logic. URL: https://github.com/apache/hadoop/pull/1165 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [hadoop] avijayanhwx commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API.

2019-07-25 Thread GitBox
avijayanhwx commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API. URL: https://github.com/apache/hadoop/pull/1033#discussion_r307535001 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java

[GitHub] [hadoop] anuengineer commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber

2019-07-25 Thread GitBox
anuengineer commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber URL: https://github.com/apache/hadoop/pull/1154#discussion_r307535953 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/HddsConfigKeys.jav

[GitHub] [hadoop] avijayanhwx commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API.

2019-07-25 Thread GitBox
avijayanhwx commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API. URL: https://github.com/apache/hadoop/pull/1033#discussion_r307536091 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/T

[GitHub] [hadoop] arp7 merged pull request #1156: HDDS-1830 OzoneManagerDoubleBuffer#stop should wait for daemon thread to die

2019-07-25 Thread GitBox
arp7 merged pull request #1156: HDDS-1830 OzoneManagerDoubleBuffer#stop should wait for daemon thread to die URL: https://github.com/apache/hadoop/pull/1156 This is an automated message from the Apache Git Service. To respon

[GitHub] [hadoop] avijayanhwx commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API.

2019-07-25 Thread GitBox
avijayanhwx commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API. URL: https://github.com/apache/hadoop/pull/1033#discussion_r307536807 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/RDBStore.jav

[GitHub] [hadoop] avijayanhwx commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API.

2019-07-25 Thread GitBox
avijayanhwx commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API. URL: https://github.com/apache/hadoop/pull/1033#discussion_r307536825 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/RDBStore.jav

[GitHub] [hadoop] arp7 commented on issue #1156: HDDS-1830 OzoneManagerDoubleBuffer#stop should wait for daemon thread to die

2019-07-25 Thread GitBox
arp7 commented on issue #1156: HDDS-1830 OzoneManagerDoubleBuffer#stop should wait for daemon thread to die URL: https://github.com/apache/hadoop/pull/1156#issuecomment-515248940 I merged this before CI had a chance to complete. Sorry about that. Let me revert and retest.

[GitHub] [hadoop] arp7 commented on issue #1156: HDDS-1830 OzoneManagerDoubleBuffer#stop should wait for daemon thread to die

2019-07-25 Thread GitBox
arp7 commented on issue #1156: HDDS-1830 OzoneManagerDoubleBuffer#stop should wait for daemon thread to die URL: https://github.com/apache/hadoop/pull/1156#issuecomment-515249526 I am not sure how revert will work with the PR. Will leave it alone for now. Let's see if subsequent CI runs un

[GitHub] [hadoop] bharatviswa504 opened a new pull request #1166: HDDS-1856. Merge HA and Non-HA code in OM.

2019-07-25 Thread GitBox
bharatviswa504 opened a new pull request #1166: HDDS-1856. Merge HA and Non-HA code in OM. URL: https://github.com/apache/hadoop/pull/1166 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] anuengineer commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber

2019-07-25 Thread GitBox
anuengineer commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber URL: https://github.com/apache/hadoop/pull/1154#discussion_r307537762 ## File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/contai

[GitHub] [hadoop] anuengineer commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber

2019-07-25 Thread GitBox
anuengineer commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber URL: https://github.com/apache/hadoop/pull/1154#discussion_r307538039 ## File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/contai

[GitHub] [hadoop] anuengineer commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber

2019-07-25 Thread GitBox
anuengineer commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber URL: https://github.com/apache/hadoop/pull/1154#discussion_r307538835 ## File path: hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/contai

[GitHub] [hadoop] anuengineer commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber

2019-07-25 Thread GitBox
anuengineer commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber URL: https://github.com/apache/hadoop/pull/1154#discussion_r307537516 ## File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/contai

[GitHub] [hadoop] anuengineer commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber

2019-07-25 Thread GitBox
anuengineer commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber URL: https://github.com/apache/hadoop/pull/1154#discussion_r307538592 ## File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/contai

[GitHub] [hadoop] anuengineer commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber

2019-07-25 Thread GitBox
anuengineer commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber URL: https://github.com/apache/hadoop/pull/1154#discussion_r307536162 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/HddsConfigKeys.jav

[GitHub] [hadoop] anuengineer commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber

2019-07-25 Thread GitBox
anuengineer commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber URL: https://github.com/apache/hadoop/pull/1154#discussion_r307539083 ## File path: hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/contai

[GitHub] [hadoop] anuengineer commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber

2019-07-25 Thread GitBox
anuengineer commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber URL: https://github.com/apache/hadoop/pull/1154#discussion_r307539277 ## File path: hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/contai

[GitHub] [hadoop] arp7 commented on a change in pull request #1164: HDDS-1829 On OM reload/restart OmMetrics#numKeys should be updated

2019-07-25 Thread GitBox
arp7 commented on a change in pull request #1164: HDDS-1829 On OM reload/restart OmMetrics#numKeys should be updated URL: https://github.com/apache/hadoop/pull/1164#discussion_r307539625 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/RDBTable.java ##

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1164: HDDS-1829 On OM reload/restart OmMetrics#numKeys should be updated

2019-07-25 Thread GitBox
bharatviswa504 commented on a change in pull request #1164: HDDS-1829 On OM reload/restart OmMetrics#numKeys should be updated URL: https://github.com/apache/hadoop/pull/1164#discussion_r307540522 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/RDBTable.ja

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1164: HDDS-1829 On OM reload/restart OmMetrics#numKeys should be updated

2019-07-25 Thread GitBox
bharatviswa504 commented on a change in pull request #1164: HDDS-1829 On OM reload/restart OmMetrics#numKeys should be updated URL: https://github.com/apache/hadoop/pull/1164#discussion_r307543280 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/TypedTable.

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1164: HDDS-1829 On OM reload/restart OmMetrics#numKeys should be updated

2019-07-25 Thread GitBox
bharatviswa504 commented on a change in pull request #1164: HDDS-1829 On OM reload/restart OmMetrics#numKeys should be updated URL: https://github.com/apache/hadoop/pull/1164#discussion_r307543280 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/TypedTable.

[GitHub] [hadoop] hadoop-yetus commented on issue #1166: HDDS-1856. Merge HA and Non-HA code in OM.

2019-07-25 Thread GitBox
hadoop-yetus commented on issue #1166: HDDS-1856. Merge HA and Non-HA code in OM. URL: https://github.com/apache/hadoop/pull/1166#issuecomment-515258588 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:--

[GitHub] [hadoop] bharatviswa504 commented on issue #1166: HDDS-1856. Merge HA and Non-HA code in OM.

2019-07-25 Thread GitBox
bharatviswa504 commented on issue #1166: HDDS-1856. Merge HA and Non-HA code in OM. URL: https://github.com/apache/hadoop/pull/1166#issuecomment-515263195 /retest This is an automated message from the Apache Git Service. To r

[GitHub] [hadoop] bharatviswa504 opened a new pull request #1167: HDDS-1863. Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key.

2019-07-25 Thread GitBox
bharatviswa504 opened a new pull request #1167: HDDS-1863. Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key. URL: https://github.com/apache/hadoop/pull/1167 This is an automated messa

[jira] [Commented] (HADOOP-16447) Upgrade JUnit5 from 5.3.1 to 5.5+ to support global timeout

2019-07-25 Thread Akira Ajisaka (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16893248#comment-16893248 ] Akira Ajisaka commented on HADOOP-16447: Thank you for the patch, [~pingsutw].

[GitHub] [hadoop] chenjunjiedada commented on a change in pull request #1158: HDDS-1839: Change topology sorting related logs in Pipeline from INFO to DEBUG

2019-07-25 Thread GitBox
chenjunjiedada commented on a change in pull request #1158: HDDS-1839: Change topology sorting related logs in Pipeline from INFO to DEBUG URL: https://github.com/apache/hadoop/pull/1158#discussion_r307557943 ## File path: hadoop-hdds/container-service/src/main/resources/ozone-site.

[GitHub] [hadoop] chenjunjiedada commented on a change in pull request #1158: HDDS-1839: Change topology sorting related logs in Pipeline from INFO to DEBUG

2019-07-25 Thread GitBox
chenjunjiedada commented on a change in pull request #1158: HDDS-1839: Change topology sorting related logs in Pipeline from INFO to DEBUG URL: https://github.com/apache/hadoop/pull/1158#discussion_r307557939 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm

  1   2   >