connman git works somewhat, kills /etc/resolv.conf

2011-02-08 Thread DJ Cozatt
Hello everyone, I've had some initial success starting connmand on a working connection. I have a desktop that is in another room from my wireless router. It has a static connection that way. Been using wpa to connect and checking connman occasionally to see if it would work with no success till t

[PATCH 5/7 l2tp-pptp] Add l2tp vpn support.

2011-02-08 Thread Mohamed Abbas
Initial. --- plugins/l2tp.c | 470 1 files changed, 470 insertions(+), 0 deletions(-) create mode 100644 plugins/l2tp.c diff --git a/plugins/l2tp.c b/plugins/l2tp.c new file mode 100644 index 000..df83e12 --- /dev/null +++ b/plugins/l

[PATCH 0/7 l2tp-pptp] Add pptp l2tp support.

2011-02-08 Thread Mohamed Abbas
The following patches will add support to pptp and l2tp vpn. I did email pptp patches but I have not got any response or feedback, so I am sending l2tp and pptp together in these patches, so please ignore any previous patches related to pptp. --- ___ con

[PATCH 6/7 l2tp-pptp] Add test script support for pptp/l2tp.

2011-02-08 Thread Mohamed Abbas
Modify connect-vpn script to handle pptp/l2tp connection. --- test/connect-vpn | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/test/connect-vpn b/test/connect-vpn index a43c4cd..27bd413 100755 --- a/test/connect-vpn +++ b/test/connect-vpn @@ -32,6 +32,20 @@ i

[PATCH 3/7 l2tp-pptp] Add pptp vpn support

2011-02-08 Thread Mohamed Abbas
Initial --- plugins/pptp.c | 278 1 files changed, 278 insertions(+), 0 deletions(-) create mode 100644 plugins/pptp.c diff --git a/plugins/pptp.c b/plugins/pptp.c new file mode 100644 index 000..ea0b599 --- /dev/null +++ b/plugins/pp

[PATCH 4/7 l2tp-pptp] Add ppp plugin library.

2011-02-08 Thread Mohamed Abbas
pppd will use this library to talk with connman vpn plugin. --- scripts/libppp-plugin.c | 305 +++ 1 files changed, 305 insertions(+), 0 deletions(-) create mode 100644 scripts/libppp-plugin.c diff --git a/scripts/libppp-plugin.c b/scripts/libppp-plug

[PATCH 2/7 l2tp-pptp] Allow vpn plugins to send reply.

2011-02-08 Thread Mohamed Abbas
Change task notify to allow client to send dbud reply. This will allow vpn plugin to send requested user/password info. --- include/task.h |2 +- plugins/vpn.c |6 -- src/task.c | 32 ++-- 3 files changed, 23 insertions(+), 17 deletions(-) diff --git

[PATCH 1/7 l2tp-pptp] Add support to allow ppp tunnelling.

2011-02-08 Thread Mohamed Abbas
pptp and l2tp does not use tun/tab approach so I changed the vpn.c to allow vpn daemon to create the interface. Now vpn plugin tell vpn to create the device or leave to vpn client. On connection vpn will get the interface name set the index for the provider. --- plugins/vpn.c | 116 ++

[PATCH 6/7 l2tp-pptp] Add test script support for pptpi/l2tp.

2011-02-08 Thread Mohamed Abbas
Modify connect-vpn script to handle pptp/l2tp connection. --- test/connect-vpn | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/test/connect-vpn b/test/connect-vpn index a43c4cd..27bd413 100755 --- a/test/connect-vpn +++ b/test/connect-vpn @@ -32,6 +32,20 @@ i

Re: connmand 0.67 crashing while processing timeserver option during S3 resume from standby

2011-02-08 Thread cityblue - other
Original Message Subject: Re: connmand 0.67 crashing while processing timeserver option during S3 resume from standby From: Neil MacLeod To: Date: 28 January 2011 22:09:40 That backtrace managed to get itself all mangled, here it is again: Setting domainname to croydon.loc

Re: [RFC v6 01/13] pacrunner: remove unitialised use of host_ret variable

2011-02-08 Thread Daniel Wagner
ignore that one. just noise ;) ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

[RFC v6 13/13] WIP: Random fixes

2011-02-08 Thread Daniel Wagner
From: Daniel Wagner Things which should go into one of the other patches. --- src/ipconfig.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/src/ipconfig.c b/src/ipconfig.c index abb548f..dd6ddef 100644 --- a/src/ipconfig.c +++ b/src/ipconfig.c @@ -1899,6 +189

[RFC v6 12/13] dhcp: Remove DHCP element

2011-02-08 Thread Daniel Wagner
From: Daniel Wagner WIP --- src/connman.h |9 ++ src/dhcp.c| 303 +--- src/element.c |2 - src/main.c|2 + src/network.c | 99 +-- 5 files changed, 217 insertions(+), 198 deletions(-) diff --git a/src/con

[RFC v6 11/13] openvpn: Use provider set/get functions

2011-02-08 Thread Daniel Wagner
From: Daniel Wagner --- plugins/openvpn.c | 45 ++--- 1 files changed, 42 insertions(+), 3 deletions(-) diff --git a/plugins/openvpn.c b/plugins/openvpn.c index 60e75dc..0eaa2cb 100644 --- a/plugins/openvpn.c +++ b/plugins/openvpn.c @@ -37,6 +37,7 @@ #

[RFC v6 10/13] provider: Add connman_provider_set_ipaddress

2011-02-08 Thread Daniel Wagner
From: Daniel Wagner And remove the unimplemented IP configuration functions. --- include/provider.h | 15 +++ src/provider.c | 41 + 2 files changed, 48 insertions(+), 8 deletions(-) diff --git a/include/provider.h b/include/provider.h

[RFC v6 09/13] connection: Add __connman_connection_gateway_add/remove

2011-02-08 Thread Daniel Wagner
From: Daniel Wagner --- include/element.h |1 - src/connection.c | 327 +--- src/connman.h | 11 ++ src/element.c | 11 +- src/ipconfig.c| 27 - src/ipv4.c| 35 +++--- src/main.c|2 + src/network.c

[RFC v6 08/13] service: Add __connman_service_pac_append/remove

2011-02-08 Thread Daniel Wagner
From: Daniel Wagner --- src/connman.h |4 src/service.c | 20 2 files changed, 24 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index 75edee0..c914555 100644 --- a/src/connman.h +++ b/src/connman.h @@ -279,6 +279,10 @@ void __connman_se

[RFC v6 07/13] service: Add __connman_service_timeserver_append/remove

2011-02-08 Thread Daniel Wagner
From: Daniel Wagner --- src/connman.h |5 + src/service.c | 21 + 2 files changed, 26 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index 1140664..75edee0 100644 --- a/src/connman.h +++ b/src/connman.h @@ -275,6 +275,11 @@ int __connman_i

[RFC v6 06/13] ipconfig: Add ipaddress setters/getters

2011-02-08 Thread Daniel Wagner
From: Daniel Wagner --- src/connman.h | 11 +++ src/ipconfig.c | 84 2 files changed, 95 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index ed68f91..1140664 100644 --- a/src/connman.h +++ b/src/connman

[RFC v6 05/13] ipconfig: Rename __connman_ipconig_set_gateway

2011-02-08 Thread Daniel Wagner
From: Daniel Wagner To avoid name clash with next patch. --- src/connman.h |2 +- src/ipconfig.c |2 +- src/network.c |4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/connman.h b/src/connman.h index 6a528e0..ed68f91 100644 --- a/src/connman.h +++ b/src/co

[RFC v6 04/13] ipconfig: Rename __connman_ipconfig_get_*(index)

2011-02-08 Thread Daniel Wagner
From: Daniel Wagner To avoid a name clash with the next patch, the __connman_ipconfig_get_*(index) have to be renamed. Since they all use an index as lookup argument rename them to __connman_ipconfig_get_*_from_index(index). --- src/connman.h |6 +++--- src/ipconfig.c |6 +++--- src/rtn

[RFC v6 03/13] ipconfig: Add __connman_ipconfig_set_ipv4/ipv6

2011-02-08 Thread Daniel Wagner
From: Daniel Wagner Remove also connman_ipaddress_set_ipv4/ipv6. --- include/inet.h |2 -- include/ipconfig.h |3 --- src/connman.h |6 ++ src/ipconfig.c | 48 +--- 4 files changed, 43 insertions(+), 16 deletions(-) diff

[RFC v6 02/13] service: Refactor Service nameserver API

2011-02-08 Thread Daniel Wagner
From: Daniel Wagner __connman_service_append/remove_namerserver() is renamed to __connman_service_nameserver_append/remove to be more consistent with the other Service API naming. Also the semantic changes to append/remove instead of set/clear. The list of configured nameservers takes preference

[RFC v6 00/13] DHCP refactoring (aka get rid of DHCP element)

2011-02-08 Thread Daniel Wagner
From: Daniel Wagner Hi, Just an update on my work. The first patch should be okay. I have changed it according Samual's wishes. Upto patch 9 it's only forplay. Patch 9 removes the connection element. It still crashes sometimes on my system, but it starts to be usable. The rest hasn't changed

[RFC v6 01/13] pacrunner: remove unitialised use of host_ret variable

2011-02-08 Thread Daniel Wagner
From: Kalle Valo For some reason there's a null check for host_ret in parse_url(), which is at that point is an uninitialised local variable. Just remove the check. plugins/pacrunner.c:316:5: error: 'host_ret' may be used uninitialized in this function --- plugins/pacrunner.c |3 --- 1 file

[PATCH v2] rtnl: fix some uninitalised warnings

2011-02-08 Thread Kalle Valo
src/rtnl.c:578:8: error: 'src' may be used uninitialized in this function src/rtnl.c:610:8: error: 'src' may be used uninitialized in this function src/rtnl.c:1108:19: error: 'servers' may be used uninitialized in this function --- src/rtnl.c | 12 +--- 1 files changed, 5 insertions(+),

Re: [RFC PATCH] dhcp: call dhcp_bound() only when something has changed

2011-02-08 Thread Kalle Valo
Samuel Ortiz writes: > Hi Kalle, > > On Mon, Feb 07, 2011 at 04:04:33PM +0200, Kalle Valo wrote: >> A user reported that his konversation (a kde irc client) is disconnecting >> periodically every 30 minutes. After some investigation the culprit was >> dhcp renewal handling in connman. connman rem

Re: [PATCH 2/4] rtnl: fix some uninitalised warnings

2011-02-08 Thread Kalle Valo
Samuel Ortiz writes: >> -} >> +} else >> +return; > I'm fine with this fix, but then please remove the > > if (family != AF_INET && family != AF_INET6) > return; > > check, as you noticed on IRC. This is quite dumb, but if we're going to hit > that problem

Re: [RFC PATCH] dhcp: call dhcp_bound() only when something has changed

2011-02-08 Thread Samuel Ortiz
Hi Kalle, On Mon, Feb 07, 2011 at 04:04:33PM +0200, Kalle Valo wrote: > A user reported that his konversation (a kde irc client) is disconnecting > periodically every 30 minutes. After some investigation the culprit was > dhcp renewal handling in connman. connman removes and adds again ip settings

Re: [PATCH] Using technology_find() instead of looping through technology_list in __connman_technology_remove_interface().

2011-02-08 Thread Samuel Ortiz
Hi Alok, On Mon, Feb 07, 2011 at 02:43:06PM +0200, Alok Barsode wrote: > From: Alok Barsode Patch applied as well. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ ___ connman mailing list connman@connman.net http://lists.

Re: [PATCH v2 1/2] Optimize __connman_technology_add_interface().

2011-02-08 Thread Samuel Ortiz
Hi Alok, On Tue, Feb 08, 2011 at 03:03:41PM +0200, Alok Barsode wrote: > From: Alok Barsode > > Instead of looping through the technology_list, using the technology pointer > returned by technology_get(). Nice catch. Patch applied, many thanks. Cheers, Samuel. -- Intel Open Source Technology

[PATCH v1] doc: Add service provisioning method in Manager API

2011-02-08 Thread Henri Bragge
--- v1: - config string is passed directly as an argument, rather than inside a dict RFC: - initial revision doc/manager-api.txt | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/doc/manager-api.txt b/doc/manager-api.txt index 743ba18..10ea2de 100644 --

[PATCH v1] doc: Add EAP login support in Agent API

2011-02-08 Thread Henri Bragge
--- doc/agent-api.txt | 31 --- 1 files changed, 28 insertions(+), 3 deletions(-) diff --git a/doc/agent-api.txt b/doc/agent-api.txt index 98499a3..d9caa4d 100644 --- a/doc/agent-api.txt +++ b/doc/agent-api.txt @@ -61,10 +61,15 @@ Fields string Name

[PATCH v1] EAP login support in Agent API

2011-02-08 Thread Henri Bragge
Hi, This patch adds support for interactive query of EAP credentials (username/password) in Agent API. I introduced a new "Identity" field for username and reused the "Passphrase" field for password. After the RFC round I dropped the "Challenge" field (no support in wpa_supplicant) and renamed "P

[PATCH v2 1/2] Optimize __connman_technology_add_interface().

2011-02-08 Thread Alok Barsode
From: Alok Barsode Instead of looping through the technology_list, using the technology pointer returned by technology_get(). --- src/technology.c | 21 +++-- 1 files changed, 7 insertions(+), 14 deletions(-) diff --git a/src/technology.c b/src/technology.c index 5ef3d10..0a89

Re: [PATCH 4/4] pacrunner: remove unitialised use of host_ret variable

2011-02-08 Thread Samuel Ortiz
Hi Kalle, On Mon, Feb 07, 2011 at 03:34:03PM +0200, Kalle Valo wrote: > For some reason there's a null check for host_ret in parse_url(), which > is at that point is an uninitialised local variable. Just remove the check. Weird one. Thanks for the patch, I applied it now. Cheers, Samuel. -- Int

Re: [PATCH 3/4] iptables: fix uninitialised use of entry_return

2011-02-08 Thread Samuel Ortiz
Hi Kalle, On Mon, Feb 07, 2011 at 03:33:56PM +0200, Kalle Valo wrote: > src/iptables.c:432:20: error: ‘entry_return’ may be used uninitialized in > this function > Patch applied as well, thanks. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ __

Re: [PATCH 1/4] iptables-test: fix uninitialised use of entry_head

2011-02-08 Thread Samuel Ortiz
Hi Kalle, On Mon, Feb 07, 2011 at 03:33:43PM +0200, Kalle Valo wrote: > tools/iptables-test.c:455:20: error: ‘entry_return’ may be used uninitialized > in this function > Patch applied, thanks. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ ___

Re: [PATCH 2/4] rtnl: fix some uninitalised warnings

2011-02-08 Thread Samuel Ortiz
Hi Kalle, On Mon, Feb 07, 2011 at 03:33:49PM +0200, Kalle Valo wrote: > src/rtnl.c:578:8: error: ‘src’ may be used uninitialized in this function > src/rtnl.c:610:8: error: ‘src’ may be used uninitialized in this function > src/rtnl.c:1108:19: error: ‘servers’ may be used uninitialized in this >

[PATCH ipv6 v2 14/15] service: Do not change state if combined state does not change.

2011-02-08 Thread Jukka Rissanen
--- src/service.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/service.c b/src/service.c index ff20e42..a5ade8d 100644 --- a/src/service.c +++ b/src/service.c @@ -3344,6 +3344,9 @@ int __connman_service_indicate_state(struct connman_service *service, else

[PATCH ipv6 v2 15/15] todo: Remove IPv6 enhancements as they are implemented.

2011-02-08 Thread Jukka Rissanen
--- TODO | 13 - 1 files changed, 0 insertions(+), 13 deletions(-) diff --git a/TODO b/TODO index 7ae6974..371eb07 100644 --- a/TODO +++ b/TODO @@ -67,19 +67,6 @@ Core credentials, ConnMan should be able to initiate a WiSPR authentication. -- IPv6 enhancements - - Priority

[PATCH ipv6 v2 12/15] service: Change IPv4 state when address is released.

2011-02-08 Thread Jukka Rissanen
--- src/service.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/service.c b/src/service.c index 2dff83a..ff20e42 100644 --- a/src/service.c +++ b/src/service.c @@ -4202,6 +4202,12 @@ static void service_ip_release(struct connman_ipconfig *ipconfig)

[PATCH ipv6 v2 13/15] ipconfig: Enable ipconfig if loading autoconfigurable IPv6 config.

2011-02-08 Thread Jukka Rissanen
--- src/ipconfig.c | 15 ++- 1 files changed, 14 insertions(+), 1 deletions(-) diff --git a/src/ipconfig.c b/src/ipconfig.c index 0627b5b..1fb8281 100644 --- a/src/ipconfig.c +++ b/src/ipconfig.c @@ -1782,8 +1782,21 @@ int __connman_ipconfig_load(struct connman_ipconfig *ipconfig,

[PATCH ipv6 v2 11/15] service: Check service state properly if user changes method.

2011-02-08 Thread Jukka Rissanen
--- src/service.c | 65 +++-- 1 files changed, 49 insertions(+), 16 deletions(-) diff --git a/src/service.c b/src/service.c index 28a8f6a..2dff83a 100644 --- a/src/service.c +++ b/src/service.c @@ -2012,6 +2012,49 @@ error: return -EIN

[PATCH ipv6 v2 10/15] service: IPv6 autoconf will change the service state.

2011-02-08 Thread Jukka Rissanen
--- src/service.c | 28 1 files changed, 28 insertions(+), 0 deletions(-) diff --git a/src/service.c b/src/service.c index 89f7b4d..28a8f6a 100644 --- a/src/service.c +++ b/src/service.c @@ -4129,18 +4129,46 @@ static void service_lower_down(struct connman_ipconfig

[PATCH ipv6 v2 09/15] network: Set service state correctly when ipconfig is cleared.

2011-02-08 Thread Jukka Rissanen
--- src/network.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/src/network.c b/src/network.c index c59a091..ec7666f 100644 --- a/src/network.c +++ b/src/network.c @@ -1094,12 +1094,14 @@ int __connman_network_clear_ipconfig(struct connman_network *network, {

[PATCH ipv6 v2 08/15] network: Set service state correctly when network is disconnected.

2011-02-08 Thread Jukka Rissanen
--- src/network.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/src/network.c b/src/network.c index a338a58..c59a091 100644 --- a/src/network.c +++ b/src/network.c @@ -877,8 +877,12 @@ static gboolean set_connected(gpointer user_data) service = __con

[PATCH ipv6 v2 04/15] service: Split service state to IPv4 and IPv6 parts.

2011-02-08 Thread Jukka Rissanen
--- src/connection.c |6 +- src/connman.h|3 +- src/location.c |3 +- src/network.c| 24 +++-- src/provider.c | 27 +++-- src/service.c| 309 +- 6 files changed, 300 insertions(+), 72 deletions(-) diff --git a/sr

[PATCH ipv6 v2 06/15] service: Only disconnect the service if both IPv4 and IPv6 states agree.

2011-02-08 Thread Jukka Rissanen
--- src/service.c | 17 + 1 files changed, 13 insertions(+), 4 deletions(-) diff --git a/src/service.c b/src/service.c index c27431c..89f7b4d 100644 --- a/src/service.c +++ b/src/service.c @@ -3245,6 +3245,7 @@ int __connman_service_indicate_state(struct connman_service *servic

[PATCH ipv6 v2 07/15] network: Enable IPv6 autoconf to change the service state to ready.

2011-02-08 Thread Jukka Rissanen
--- src/network.c | 35 +++ 1 files changed, 35 insertions(+), 0 deletions(-) diff --git a/src/network.c b/src/network.c index c3febd3..a338a58 100644 --- a/src/network.c +++ b/src/network.c @@ -768,6 +768,37 @@ static int manual_ipv6_set(struct connman_network *

[PATCH ipv6 v2 02/15] ipv6: Add property for IPv6 nameserver

2011-02-08 Thread Jukka Rissanen
--- include/property.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/property.h b/include/property.h index e18e1e9..487a170 100644 --- a/include/property.h +++ b/include/property.h @@ -57,6 +57,7 @@ enum connman_property_id { CONNMAN_PROPERTY_ID_IPV6_ADDR

[PATCH ipv6 v2 03/15] ipconfig: Added helper function that returns the config type.

2011-02-08 Thread Jukka Rissanen
--- src/connman.h |2 ++ src/ipconfig.c |6 ++ 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index 992d533..7f18ff4 100644 --- a/src/connman.h +++ b/src/connman.h @@ -218,6 +218,8 @@ void __connman_ipconfig_delroute(int index, int family,

[PATCH ipv6 v2 05/15] ipconfig: Enable or disable IPv6 when loading the saved service.

2011-02-08 Thread Jukka Rissanen
--- src/ipconfig.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/src/ipconfig.c b/src/ipconfig.c index 4d9b30f..0627b5b 100644 --- a/src/ipconfig.c +++ b/src/ipconfig.c @@ -1778,6 +1778,14 @@ int __connman_ipconfig_load(struct connman_ipconfig *ipconfig,

[PATCH ipv6 v2 01/15] ipconfig: Clear the ipaddress pointers when address is deleted.

2011-02-08 Thread Jukka Rissanen
--- src/ipconfig.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/ipconfig.c b/src/ipconfig.c index 6ef39c5..bd664f3 100644 --- a/src/ipconfig.c +++ b/src/ipconfig.c @@ -682,7 +682,8 @@ void __connman_ipconfig_deladdr(int index, int family, const char *label,

[PATCH ipv6 v2 00/15] Support IPv6 only networks

2011-02-08 Thread Jukka Rissanen
Hi Samuel, thanks for the comments to v1 patchset. This second version fixes the issues you found out: Patch #4: - connman_service_indicate_state() prototype changed so that only one state can be changed at a time - is_connected() and is_connecting() function prototypes changed back to what t