Re: CR 6860309 - solaris timing issue on thread startup

2011-11-11 Thread David Holmes
Hi Gary, On 12/11/2011 2:56 AM, Gary Adams wrote: CR 6860309 - TEST_BUG: Insufficient sleep time in java/lang/Runtime/exec/StreamsSurviveDestroy.java A timing problem is reported for slow solaris systems for this test to start up a process and systematically torture the underlying threads proce

Re: Code Review Request for 6578042

2011-11-11 Thread Darryl Mocek
The reason I used the Object's toString method is that there may indeed be an object which is not a String which is stored as a value (this was the reason for the bug report). In this case, the remove method will in fact remove the property. Returning null if the value is not a String gives t

Fwd: RE: Code Review Request for 4533691 (add Collections.EMPTY_SORTED_SET)

2011-11-11 Thread Darryl Mocek
Hi Jason. I'm the engineer implementing this RFE. Mike is committing the fix for me as I don't yet have commit rights to the repository. Please see my comments inline. Darryl Original Message Subject: RE: Code Review Request for 4533691 (add Collections.EMPTY_SORTED_SET)

CR 6860309 - solaris timing issue on thread startup

2011-11-11 Thread Gary Adams
CR 6860309 - TEST_BUG: Insufficient sleep time in java/lang/Runtime/exec/StreamsSurviveDestroy.java A timing problem is reported for slow solaris systems for this test to start up a process and systematically torture the underlying threads processing data from the running process. On my fast s

hg: jdk8/tl/corba: 7091388: Regular unexplained npe's from corba libs after system has been running for days

2011-11-11 Thread sean . coffey
Changeset: 44c269731425 Author:coffeys Date: 2011-11-11 10:16 + URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/44c269731425 7091388: Regular unexplained npe's from corba libs after system has been running for days Reviewed-by: alanb ! src/share/classes/com/sun/corba/se/impl

hg: jdk8/tl/jdk: 7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile

2011-11-11 Thread sean . coffey
Changeset: 9dd994f319ee Author:coffeys Date: 2011-11-11 10:08 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9dd994f319ee 7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile Reviewed-by: alanb ! src/share/classes/java/io/FileInputStream.java