Re: JDK 10 RFR JDK-8177153: LambdaMetafactory has default constructor

[cc'ing some errorprone folk ...] On Fri, Apr 28, 2017 at 2:22 PM, Martin Buchholz wrote: > http://errorprone.info/bugpattern/PrivateConstructorForUtilityClass > It's highly non-obvious how to run errorprone against recent jdk sources. You need a prerelease of errorprone, add a module to get ja

Re: RFR: 8179415: Update java.management and java.management.rmi to be HTML-5 friendly

> On Apr 28, 2017, at 4:16 PM, Kumar Srinivasan > wrote: > > Hello, > > Please review changes for java.management and java.management.rmi to > be HTML5 ready, there are outliers like cellpadding, cellspacing that needs > to be done separately, note this was *not* done mechanically by a script.

RFR: 8179415: Update java.management and java.management.rmi to be HTML-5 friendly

Hello, Please review changes for java.management and java.management.rmi to be HTML5 ready, there are outliers like cellpadding, cellspacing that needs to be done separately, note this was *not* done mechanically by a script. http://cr.openjdk.java.net/~ksrini/8179415/ https://bugs.openjdk.java.

Re: [JDK9] RFR 8167229: Improve VarHandle documentation

On 4/28/2017 3:39 PM, Paul Sandoz wrote: On 28 Apr 2017, at 14:55, Alex Buckley wrote: On 4/26/2017 4:06 PM, Paul Sandoz wrote: Please review some documentation changes to VarHandle: http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8167229-varhandle-docs/webrev/index.html I notice that "shape"

Re: [JDK9] RFR 8167229: Improve VarHandle documentation

> On 28 Apr 2017, at 14:55, Alex Buckley wrote: > > On 4/26/2017 4:06 PM, Paul Sandoz wrote: >> Please review some documentation changes to VarHandle: >> >> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8167229-varhandle-docs/webrev/index.html > > I notice that "shape" is still mentioned throug

Re: [JDK9] RFR 8167229: Improve VarHandle documentation

On 4/26/2017 4:06 PM, Paul Sandoz wrote: Please review some documentation changes to VarHandle: http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8167229-varhandle-docs/webrev/index.html I notice that "shape" is still mentioned throughout the MethodHandles.Lookup class. 59 * {@code CT1, CT2, ..

Re: JDK 10 RFR JDK-8177153: LambdaMetafactory has default constructor

http://errorprone.info/bugpattern/PrivateConstructorForUtilityClass On Fri, Apr 28, 2017 at 2:19 PM, Paul Sandoz wrote: > > > On 28 Apr 2017, at 14:10, joe darcy wrote: > > > > Hello, > > > > As this is a binary incompatible change, effectively removing a public > constructor, I'd prefer if thi

Re: JDK 10 RFR JDK-8177153: LambdaMetafactory has default constructor

> On 28 Apr 2017, at 14:10, joe darcy wrote: > > Hello, > > As this is a binary incompatible change, effectively removing a public > constructor, I'd prefer if this change got into JDK 9 instead, pending the > review process of course. > Fair point, the earlier the better in that regard.

Re: JDK 10 RFR JDK-8177153: LambdaMetafactory has default constructor

Hello, As this is a binary incompatible change, effectively removing a public constructor, I'd prefer if this change got into JDK 9 instead, pending the review process of course. (I've thought it would be worthwhile to audit the JDK for default constructors and/or add a javac lint warning fo

Re: JDK 10 RFR JDK-8174267: Stream.findFirst unnecessarily always allocates an Op

> On 28 Apr 2017, at 12:34, Ron Pressler wrote: > > Hi. > Please review the following patch, which creates static final instances of > FindOp. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8174267 > +1 > I believe an additional test is not required as this is an implementation > detai

Re: JDK test-only RFR of 8179452: Remove "intermittent" key from some tests which appear no longer to fail

Looks fine to me too. -Joe On 4/28/2017 12:52 PM, Lance Andersen wrote: +1 On Apr 28, 2017, at 3:43 PM, Brian Burkhalter wrote: Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8179452 Patch: [1] Thanks, Brian [1] diff --- a/test/java/io/FileInputStr

Re: JDK 10 RFR JDK-8177153: LambdaMetafactory has default constructor

Hi, This will require that we submit a CSR, when this opens up. (Sorry, i should of realised when suggesting easy bugs.) Still, i think this change is ok, grepcode.com shows no subtypes, and there are only static methods. So i think we can pursue this once the CSR is rea

Re: JDK test-only RFR of 8179452: Remove "intermittent" key from some tests which appear no longer to fail

+1 > On Apr 28, 2017, at 3:43 PM, Brian Burkhalter > wrote: > > Please review at your convenience. > > Issue:https://bugs.openjdk.java.net/browse/JDK-8179452 > Patch:[1] > > Thanks, > > Brian > > [1] diff > > --- a/test/java/io/FileInputStream/LargeFileAvailable.java > +++ b

JDK test-only RFR of 8179452: Remove "intermittent" key from some tests which appear no longer to fail

Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8179452 Patch: [1] Thanks, Brian [1] diff --- a/test/java/io/FileInputStream/LargeFileAvailable.java +++ b/test/java/io/FileInputStream/LargeFileAvailable.java @@ -24,7 +24,6 @@ /* * @test * @bug 6402006

JDK 10 RFR JDK-8174267: Stream.findFirst unnecessarily always allocates an Op

Hi. Please review the following patch, which creates static final instances of FindOp. Bug: https://bugs.openjdk.java.net/browse/JDK-8174267 I believe an additional test is not required as this is an implementation detail. --- diff -r 83d37efcd2a5 src/java.base/share/classes/java/util/

JDK 10 RFR JDK-8177153: LambdaMetafactory has default constructor

Hi. Please review this trivial fix: --- diff -r 83d37efcd2a5 src/java.base/share/classes/java/lang/invoke/LambdaMetafactory.java --- a/src/java.base/share/classes/java/lang/invoke/LambdaMetafactory.java Thu Apr 13 20:35:17 2017 + +++ b/src/java.base/share/classes/java/lang/invoke/Lamb

Re: JDK 9 RFR of JDK-8179448: Mark ImageModules.java as failing intermittently

Reviewed. I’ll take a look at 8175022 soon. -Chris. > On 28 Apr 2017, at 20:18, joe darcy wrote: > > Hello, > > The test > > jdk/modules/incubator/ImageModules.java > > has been seen to intermittently fail at a low frequency (JDK-8175022) and > should be marked accordingly. > > Please revi

JDK 9 RFR of JDK-8179448: Mark ImageModules.java as failing intermittently

Hello, The test jdk/modules/incubator/ImageModules.java has been seen to intermittently fail at a low frequency (JDK-8175022) and should be marked accordingly. Please review the patch below. Thanks, -Joe diff -r 7c04ab31b4d6 test/jdk/modules/incubator/ImageModules.java --- a/test/jdk/mod

Re: JDK 9 RFR: JDK-8177146 MethodHandles.Lookup::bind allows illegal protected access

Do you mean just in the class name or also the directory name? Ron On 26/04/2017 20:53, Vladimir Ivanov wrote: Ron, The fix looks good. One request: please, try to avoid bug ids in test names. It's much easier to work with tests when they have meaningful names and there's already @bug jtreg