+1
> On 08 Jun 2016, at 13:18, Hannes Wallnöfer
> wrote:
>
> Please review the following changes:
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8159031
> JDK webrev: http://cr.openjdk.java.net/~hannesw/8159031/jdk/webrev.00/
> Nashorn webrev: http://cr.openjdk.java.net/~hannesw/8159031/nas
Hi!
Is it possible to override lib/security/local_policy on app level without
patching jdk distro?
i.e. -Duse.this.policy.jar= … or something?
Can’t find a way to do it
Regards
Marcus
+1
> On 19 May 2015, at 14:15, A. Sundararajan
> wrote:
>
> Please review http://cr.openjdk.java.net/~sundar/8072002/webrev.00/ for
> https://bugs.openjdk.java.net/browse/JDK-8072002
>
> Thanks,
> -Sundar
Also +1
> On 18 May 2015, at 14:59, A. Sundararajan
> wrote:
>
> Thanks for the review. Updated test as per your suggestion. Uploaded fresh
> review @ http://cr.openjdk.java.net/~sundar/8072853/webrev.01/
>
> Thanks
> -Sundar
>
> Paul Sandoz wrote:
>> On May 18, 2015, at 12:44 PM, A. Sundar
+1
/M
> On 18 May 2015, at 12:44, A. Sundararajan
> wrote:
>
> Please review http://cr.openjdk.java.net/~sundar/8072853/webrev.00/ for
> https://bugs.openjdk.java.net/browse/JDK-8072853
>
> Thanks,
> -Sundar
Looks OK to me. +1
/M
> On 10 Feb 2015, at 08:21, A. Sundararajan
> wrote:
>
> Please review http://cr.openjdk.java.net/~sundar/8068587/ for
> https://bugs.openjdk.java.net/browse/JDK-8068587
>
> Thanks,
> -Sundar
+1 for me. I assume that Wrapper.java is only reformatting. It looks like it.
Regards
Marcus
On 15 Oct 2014, at 14:12, Vladimir Ivanov wrote:
> http://cr.openjdk.java.net/~vlivanov/8060483/webrev.00/
> https://bugs.openjdk.java.net/browse/JDK-8060483
>
> Recent changes broke MHs.explicitCastAr
I am reviewer and they look good to me too. ~30% better performance for random
indata- Do you pass the JCK? If so you have my blessing.
/M
On 16 Sep 2014, at 01:52, Brent Christian wrote:
> Hi, Claes
>
> I've looked over the latest changes, and they look good to me. I can sponsor
> this. N
To the style rant, I mean.
On 05 Sep 2014, at 13:40, Marcus Lagergren wrote:
> +1
>
> On 05 Sep 2014, at 12:46, Aleksey Shipilev
> wrote:
>
>> On 09/05/2014 12:09 PM, Vladimir Ivanov wrote:
>>> http://cr.openjdk.java.net/~vlivanov/8057654/webrev.00/
>>&g
+1
On 05 Sep 2014, at 12:46, Aleksey Shipilev wrote:
> On 09/05/2014 12:09 PM, Vladimir Ivanov wrote:
>> http://cr.openjdk.java.net/~vlivanov/8057654/webrev.00/
>> https://bugs.openjdk.java.net/browse/JDK-8057654
>
> Random style rant of the week, not particularly about this concrete
> patch. C
+1
On 03 Jun 2014, at 17:26, A. Sundararajan
wrote:
> Hi,
>
> Please review http://cr.openjdk.java.net/~sundar/8044647/
>
> Thanks,
> -Sundar
To get into this faster it would be nice if the new private fields (or the
existing ones for that matter) had a comment describing what they were for, e.g.
+ private final byte[] localTypes;
+ private final Class[] localClasses;
I can figure it out from the code, but it would have been a
Got catches, Paul!
/M
On 20 Feb 2014, at 18:57, Vladimir Ivanov wrote:
> Paul,
>
> Thanks for the feedback! See my answers inline.
>
> Updated webrev:
> http://cr.openjdk.java.net/~vlivanov/8027827/final/webrev.01/
>
> I finally figured out how to make caching work. This webrev contains thes
This looks good, and we have done a significant number of test runs to verify
its integrity.
I say ship it. +1
We know that there are some issues with sun.misc.ValueConversion.castReference
and similar internal methods not being inlined, but as far as I can understand
this is a separate issue
14 matches
Mail list logo
