Re: RFR: 8049343: (tz) Support tzdata2014g

2014-09-02 Thread Michael Fang
Aleksej, Yes, I agree the translation update of the time zone names can be handled separately as JDK-8057004. thanks, -michael On 14年09月01日 07:10 上午, Aleksej Efimov wrote: Masayoshi, I have addressed all your comments with proposed resolution. Thank you for such thorough analysis of this

Re: RFR: 8030822: (tz) Support tzdata2013i

2014-01-30 Thread Michael Fang
Looks good to me too. thanks, -michael On 14年01月29日 10:14 下午, Masayoshi Okutsu wrote: Looks good. Masayoshi On 1/30/2014 5:31 AM, Aleksej Efimov wrote: Masayoshi, Sean, Thank you for the review and your comments. I have prepared a second version of the fix [1] without the .properties file

hg: jdk8/tl/jdk: 3 new changesets

2014-01-08 Thread michael . fang
Changeset: 5d05be02629c Author:mfang Date: 2014-01-07 21:44 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5d05be02629c 8029239: jdk8 l10n resource file translation update - localenames Reviewed-by: okutsu ! src/share/classes/sun/util/resources/de/LocaleNames_de.properties !

Re: RFR: 8025051: Update resource files for TimeZone display names

2013-12-23 Thread Michael Fang
Thanks Aleksej for addressing the ACT issue. The l10n files look fine to me. I agree that we should work on translation consistency issues separately the next time we have a translation cycle. thanks, -michael On 13?12?22? 10:14 ??, Aleksej Efimov wrote: Hi, The new version of patch for Time

hg: jdk8/tl/corba: 8026741: jdk8 l10n resource file translation update 5

2013-12-18 Thread michael . fang
Changeset: eb5d3f8ca0ca Author:mfang Date: 2013-12-17 22:03 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/eb5d3f8ca0ca 8026741: jdk8 l10n resource file translation update 5 Reviewed-by: naoto, yhuang ! src/share/classes/com/sun/tools/corba/se/idl/idl_ja.prp

hg: jdk8/tl/langtools: 8026741: jdk8 l10n resource file translation update 5

2013-12-17 Thread michael . fang
Changeset: f1be939b49f6 Author:mfang Date: 2013-12-17 23:32 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f1be939b49f6 8026741: jdk8 l10n resource file translation update 5 Reviewed-by: naoto, yhuang ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resource

hg: jdk8/tl/jdk: 8026741: jdk8 l10n resource file translation update 5

2013-12-17 Thread michael . fang
Changeset: 9211877b25ba Author:mfang Date: 2013-12-17 23:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9211877b25ba 8026741: jdk8 l10n resource file translation update 5 Reviewed-by: naoto, yhuang ! src/share/classes/com/sun/java/util/jar/pack/DriverResource_ja.java ! sr

hg: jdk8/tl/jdk: 7090826: Newly added codes need to be localized into pt_BR in LocaleNames

2013-12-17 Thread michael . fang
Changeset: 4fa27233a3e9 Author:mfang Date: 2013-12-17 14:13 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4fa27233a3e9 7090826: Newly added codes need to be localized into pt_BR in LocaleNames Reviewed-by: okutsu ! src/share/classes/sun/util/resources/pt/LocaleNames_pt.prop

hg: jdk8/tl/jdk: 8026115: [zh_CN] inproper translation in output of jarsigner command

2013-12-11 Thread michael . fang
Changeset: 01b11184bcf9 Author:mfang Date: 2013-12-11 21:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/01b11184bcf9 8026115: [zh_CN] inproper translation in output of jarsigner command Reviewed-by: naoto, yhuang ! src/share/classes/sun/security/tools/jarsigner/Resources_

hg: jdk8/tl/jdk: 8025974: l10n for policytool

2013-12-09 Thread michael . fang
Changeset: 23a7524d930c Author:mfang Date: 2013-12-09 15:01 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/23a7524d930c 8025974: l10n for policytool Reviewed-by: naoto, leifs, yhuang ! src/share/classes/sun/security/tools/policytool/Resources_de.java ! src/share/classes/sun/

hg: jdk8/tl/jdk: 2 new changesets

2013-12-04 Thread michael . fang
Changeset: 6a5a54193118 Author:mfang Date: 2013-12-04 09:29 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6a5a54193118 8027244: Need to translate new error message and usage information for jar tool Reviewed-by: naoto, yhuang ! src/share/classes/sun/tools/jar/resources/jar_

hg: jdk8/tl/jaxp: 2 new changesets

2013-11-25 Thread michael . fang
Changeset: abd44ea60dbe Author:mfang Date: 2013-11-21 15:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/abd44ea60dbe 8028803: jdk8 l10n resource file translation update 5 - jaxp repo Reviewed-by: joehw, yhuang ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResource

hg: jdk8/tl/jdk: 2 new changesets

2013-10-30 Thread michael . fang
Changeset: 550244957351 Author:mfang Date: 2013-10-30 09:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/550244957351 6192407: s10_70, ko, s1/dvd, minor misspelling under "Select Software Localizations" Reviewed-by: yhuang ! src/share/classes/sun/util/resources/ko/LocaleN

core-libs-dev@openjdk.java.net

2013-10-29 Thread michael . fang
Changeset: bede752d1e3c Author:mfang Date: 2013-10-29 16:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bede752d1e3c 8025521: [de] mnemonic conflict in FileChooser for GTK Style feel&look Reviewed-by: naoto ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_de.

hg: jdk8/tl/jdk: 2 new changesets

2013-10-29 Thread michael . fang
Changeset: 8cfc73ad9f31 Author:mfang Date: 2013-10-29 15:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8cfc73ad9f31 8008647: [es] minor cosmetic issues in translated java command line outputs Reviewed-by: naoto ! src/share/classes/sun/tools/jar/resources/jar_es.propertie

hg: jdk8/tl/jdk: 3 new changesets

2013-10-29 Thread michael . fang
Changeset: 6fc2889fe7d0 Author:mfang Date: 2013-10-29 11:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6fc2889fe7d0 8026108: [it, ja, zh_CN] wrong translation in jar example. Reviewed-by: okutsu, yhuang ! src/share/classes/sun/tools/jar/resources/jar_it.properties ! src/

Re: RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

2013-10-24 Thread Michael Fang
On 10/24/2013 12:12 AM, Michael Fang wrote: Hi Masayoshi, At that time I was asked to have regression test to validate each translation changes. With our new translation process for TimeZoneNames and new planned regression tests from Aleksej for JDK-8025051 <https://bugs.openjdk.java.

Re: RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

2013-10-24 Thread Michael Fang
Hi Aleksej, The proposed change is fine for me. thanks, -michael On 13?10?24? 06:32 ??, Aleksej Efimov wrote: Alan, Masayoshi, Michael, If you agree with the proposed changes then we can proceed with closing this bug. Can I ask you to sponsorship this change in such case? The hg patch locat

Re: RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

2013-10-23 Thread Michael Fang
Hi Masayoshi, At that time I was asked to have regression test to validate each translation changes. With our new translation process for TimeZoneNames and new planned regression tests from Aleksej for JDK-8025051 , I believe we can remove t

hg: jdk8/tl/jdk: 3 new changesets

2013-10-22 Thread michael . fang
Changeset: e84413f066e0 Author:mfang Date: 2013-10-22 14:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e84413f066e0 8026109: [ja] overtranslation of jarsigner in command line output Reviewed-by: naoto ! src/share/classes/sun/security/tools/jarsigner/Resources_ja.java C

Re: RFR: 8025255: (tz) Support tzdata2013g

2013-10-16 Thread Michael Fang
Hi Aleksej and Masayoshi, The translation of the timezone names are correct according to the translators. So, the files in your webrev look fine to me. thanks, -michael On 13年10月14日 10:19 下午, Michael Fang wrote: Hi Masayoshi, I am not sure if the changes are correct. I need to check with

Re: RFR: 8025255: (tz) Support tzdata2013g

2013-10-14 Thread Michael Fang
2. I need another one approval from a JDK 8 reviewer for this one. Anyway, the hg changeset patch can be found here: http://cr.openjdk.java.net/~aefimov/8025255/8/8025255_jdk8.patch Best Regards, Aleksej On 10/12/2013 12:43 AM, Michael Fang wrote: Hi Aleksej, Yes, you are right. They can be han

Re: RFR: 8025255: (tz) Support tzdata2013g

2013-10-11 Thread Michael Fang
browse/JDK-8025051. I will work on it right > after the tzdata update and it will include this changes. > But anyway, it's not highly related to tzdata updates. I think, this two > processes can go separately. Do you agree? > > Thanks and Best Regards, > Aleksej > >

Re: RFR: 8025255: (tz) Support tzdata2013g

2013-10-11 Thread Michael Fang
Hi Aleksej, I took a look at the localized TimeZoneNames_*.java files. They do not contain generic time zone names for JSR310... I think we can file a separate bug to track that issue. thanks, -michael On 13年10月10日 09:54 下午, Masayoshi Okutsu wrote: Hi Aleksej, Here are my review comments.

hg: jdk8/tl/jaxp: 2 new changesets

2013-10-08 Thread michael . fang
Changeset: dbecbb685503 Author:mfang Date: 2013-10-08 09:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/dbecbb685503 8025215: jdk8 l10n resource file translation update 4 Reviewed-by: joehw, yhuang ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_de.java !

Re: RFR: 8025342: NLS: unsupported translation format in jar/pack/DriverResource.java

2013-10-01 Thread Michael Fang
Hi Kumar, Looks good. Thanks for addressing translatability conformance of this file. thanks, -michael On 13年10月01日 11:46 上午, Kumar Srinivasan wrote: Hi Naoto, Michael, Please review the webrev below. Apparently using variables to hold the common message strings between pack200(1) and unpa

hg: jdk8/tl/jdk: 3 new changesets

2013-09-25 Thread michael . fang
Changeset: 2b928330970a Author:mfang Date: 2013-09-24 14:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2b928330970a 8025215: jdk8 l10n resource file translation update 4 Reviewed-by: naoto, yhuang ! src/macosx/classes/com/apple/laf/resources/aqua_ko.properties ! src/sha

hg: jdk8/tl/langtools: 4 new changesets

2013-09-25 Thread michael . fang
Changeset: 1332a99572c5 Author:mfang Date: 2013-09-24 14:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1332a99572c5 8025215: jdk8 l10n resource file translation update 4 Reviewed-by: naoto, yhuang ! src/share/classes/com/sun/tools/doclets/formats/html/resources/st

hg: jdk8/tl/jaxp: 8016824: jdk8 l10n resource file translation update 3 - jaxp

2013-06-18 Thread michael . fang
Changeset: 21d9cbbb7bf3 Author:mfang Date: 2013-06-18 22:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/21d9cbbb7bf3 8016824: jdk8 l10n resource file translation update 3 - jaxp Reviewed-by: joehw ! src/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_de.propertie

hg: jdk8/tl/corba: 8015657: jdk8 l10n resource file translation update 3

2013-06-18 Thread michael . fang
Changeset: d406edd4f6fd Author:mfang Date: 2013-06-18 20:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/d406edd4f6fd 8015657: jdk8 l10n resource file translation update 3 Reviewed-by: yhuang ! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_ko.propertie

hg: jdk8/tl/jdk: 8015657: jdk8 l10n resource file translation update 3

2013-06-18 Thread michael . fang
Changeset: d82773b770ce Author:mfang Date: 2013-06-18 21:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d82773b770ce 8015657: jdk8 l10n resource file translation update 3 Reviewed-by: yhuang ! src/macosx/classes/com/apple/laf/resources/aqua_pt_BR.properties ! src/share/c

hg: jdk8/tl/langtools: 8015657: jdk8 l10n resource file translation update 3

2013-06-18 Thread michael . fang
Changeset: 792c40d5185a Author:mfang Date: 2013-06-18 20:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/792c40d5185a 8015657: jdk8 l10n resource file translation update 3 Reviewed-by: yhuang ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard_

hg: jdk8/tl/corba: 2 new changesets

2013-03-25 Thread michael . fang
Changeset: c3ec80715805 Author:mfang Date: 2013-03-25 16:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/c3ec80715805 8010521: jdk8 l10n resource file translation update 2 Reviewed-by: naoto, yhuang ! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_de.pr

Re: [8] Review request for 7196354 check-in jdk.tbom file to openjdk repo

2012-09-11 Thread Michael Fang
Thanks Mark for the comment. Yes, we will do that. thanks, -michael On 12年09月11日 08:09 上午, mark.reinh...@oracle.com wrote: 2012/9/10 14:26 -0700, michael.f...@oracle.com: I have updated the webrev: http://cr.openjdk.java.net/~mfang/7196354/webrev.01/ ... I am also moving the file from root

Re: [8] Review request for 7196354 check-in jdk.tbom file to openjdk repo

2012-09-10 Thread Michael Fang
hrough JEP process. We would like to keep the syntax internal. When I review dev team's changes related to resource files, I will keep an eye on the files to be translated and translation language scope. thanks, -michael Server Globalization Technology On 12年09月06日 04:46 下午, Michael Fang

Re: [8] Review request for 7196354 check-in jdk.tbom file to openjdk repo

2012-09-06 Thread Michael Fang
Hi Mark, Thanks for the review and feedback. Please see my comments inline below. thanks, -michael On 12年09月06日 01:29 下午, mark.reinh...@oracle.com wrote: 2012/9/5 14:08 -0700, michael.f...@oracle.com: Please help to review the new JDK8 file for the following CR: 7196354 check-in jdk.tbom fi

[8] Review request for 7196354 check-in jdk.tbom file to openjdk repo

2012-09-06 Thread Michael Fang
Hello, Please help to review the new JDK8 file for the following CR: 7196354 check-in jdk.tbom file to openjdk repo The webrev is located at: http://cr.openjdk.java.net/~mfang/7196354/webrev.00/ Build-dev: The file will be pushed to the top level openjdk repository http://hg.openjdk.java.net/j