Hi Naoto,
ok to correct some time later.
The bug hasn't been updated, it still appears to be in progress. (They
are working to fix hgupdater)
I think waiting more than an hour for reviews is a good idea,
24hrs might be a minimum unless its urgent to fix a broken build.
Regards, Roger
On
Hi Roger, thanks for the review.
On 3/18/20 7:42 AM, Roger Riggs wrote:
Hi Naoto,
EquivMapsGenerator.java: 242
It looks odd to put the warning about being an auto-generated file in
the middle of the declarations.
Perhaps add it to the headerText.
The existing maps are not pre-sized, is it
Hi Naoto,
EquivMapsGenerator.java: 242
It looks odd to put the warning about being an auto-generated file in
the middle of the declarations.
Perhaps add it to the headerText.
The existing maps are not pre-sized, is it important to pre-size the new
ones.
There's no particular reason to
Hi Naoto,
Looks good to me.
-Joe
On 3/17/20 1:58 PM, naoto.s...@oracle.com wrote:
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8241082
The proposed changeset is located at:
http://cr.openjdk.java.net/~naoto/8241082/webrev.00/
It is simply
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8241082
The proposed changeset is located at:
http://cr.openjdk.java.net/~naoto/8241082/webrev.00/
It is simply updating the data file. Since there is no change in
equivalency of language tags, no