Re: Inputs on patch for JDK-8225763? Inflater and Deflater should implement AutoCloseable

On 6/26/19 9:28 PM, Jaikiran Pai wrote: I am looking to contribute a patch for the enhancement noted in https://bugs.openjdk.java.net/browse/JDK-8225763. The change itself looks relatively straightforward to me and here's what I plan to do: 1. Have both java.util.zip.Inflater and java.util.zip.D

Re: Inputs on patch for JDK-8225763? Inflater and Deflater should implement AutoCloseable

Hello Stuart, Thank you for the detailed response. Comments inline. On 28/06/19 2:48 AM, Stuart Marks wrote: > On 6/26/19 9:28 PM, Jaikiran Pai wrote: >> I am looking to contribute a patch for the enhancement noted in >> https://bugs.openjdk.java.net/browse/JDK-8225763. The change itself >> looks

Re: Inputs on patch for JDK-8225763? Inflater and Deflater should implement AutoCloseable

On 29/06/19 4:31 PM, Jaikiran Pai wrote: > Hello Stuart, > > Thank you for the detailed response. Comments inline. > > On 28/06/19 2:48 AM, Stuart Marks wrote: >> On 6/26/19 9:28 PM, Jaikiran Pai wrote: >>> I am looking to contribute a patch for the enhancement noted in >>> https://bugs.openjdk.j

Re: Inputs on patch for JDK-8225763? Inflater and Deflater should implement AutoCloseable

Hi Jaikiran, OK, good analysis. Rather a lot of issues for what seems like a simple patch, eh? - Idempotency Yes, it looks to me like Inflater.end() and Deflater.end() implementations are idempotent. As you point out, overrides by subclasses might not be. We should be clear when we're talki

Re: Inputs on patch for JDK-8225763? Inflater and Deflater should implement AutoCloseable

Just a thought below to consider or ignore ;-) > On Jul 2, 2019, at 11:27 PM, Stuart Marks wrote: > > Hi Jaikiran, > > OK, good analysis. Rather a lot of issues for what seems like a simple patch, > eh? > > - Idempotency > > Yes, it looks to me like Inflater.end() and Deflater.end() impleme

Re: Inputs on patch for JDK-8225763? Inflater and Deflater should implement AutoCloseable

Hello Stuart, On 03/07/19 8:57 AM, Stuart Marks wrote: > Hi Jaikiran, > > OK, good analysis. Rather a lot of issues for what seems like a simple > patch, eh? Indeed, but I kind of expected that :) > >  - Idempotency > > Yes, it looks to me like Inflater.end() and Deflater.end() > implementation

Re: Inputs on patch for JDK-8225763? Inflater and Deflater should implement AutoCloseable

Hello Lance, On 03/07/19 11:27 PM, Lance Andersen wrote: >  Just a thought below to consider or ignore ;-)  >> On Jul 2, 2019, at 11:27 PM, Stuart Marks > > wrote: >> >> Hi Jaikiran, >> >> OK, good analysis. Rather a lot of issues for what seems like a >> simple pat

Re: Inputs on patch for JDK-8225763? Inflater and Deflater should implement AutoCloseable

Hi Jaikiran, Thank you for your efforts here. > On Jul 6, 2019, at 9:59 AM, Jaikiran Pai wrote: > >> >> - Idempotency >> >> Yes, it looks to me like Inflater.end() and Deflater.end() >> implementations are idempotent. As you point out, overrides by >> subclasses might not be. We should be cl

Re: Inputs on patch for JDK-8225763? Inflater and Deflater should implement AutoCloseable

Hello Lance, On 08/07/19 11:16 PM, Lance Andersen wrote: > Hi Jaikiran, > > Thank you for your efforts here. > >> On Jul 6, 2019, at 9:59 AM, Jaikiran Pai > > wrote: >> >>> >>>  - Idempotency >>> >>> Yes, it looks to me like Inflater.end() and Deflater.end() >>> im