Re: Proposal for new interface: TimeSource

2021-05-28 Thread Naoto Sato
As I commented on the PR, the test needs to run in othervm mode: https://github.com/openjdk/jdk/pull/4016#issuecomment-844551175 --- a/test/jdk/java/time/test/TEST.properties +++ b/test/jdk/java/time/test/TEST.properties @@ -1,5 +1,5 @@ # java.time tests use TestNG TestNG.dirs = ..

Re: Proposal for new interface: TimeSource

2021-05-27 Thread Joe Darcy
On 5/27/2021 5:03 PM, Stephen Colebourne wrote: Hi all, Is there anything I need to do to progress the CSR and/or PR? The CSR is in Provisional state. To request the second phase of CSR review, the assignee can Finalize the CSR; for more details see    

Re: Proposal for new interface: TimeSource

2021-05-27 Thread Stephen Colebourne
Hi all, Is there anything I need to do to progress the CSR and/or PR? thanks Stephen On Thu, 13 May 2021 at 22:05, Stephen Colebourne wrote: > > On Wed, 12 May 2021 at 18:41, Roger Riggs wrote: > > Will you be posting a PR for the implementation? > > It is frequently helpful to evaluate the CSR

Re: Proposal for new interface: TimeSource

2021-05-13 Thread Stephen Colebourne
On Wed, 12 May 2021 at 18:41, Roger Riggs wrote: > Will you be posting a PR for the implementation? > It is frequently helpful to evaluate the CSR and the implementation > concurrently. PR: https://github.com/openjdk/jdk/pull/4016 Issue: https://bugs.openjdk.java.net/browse/JDK-8266846 CSR:

Re: Proposal for new interface: TimeSource

2021-05-12 Thread Roger Riggs
Hi Stephen, A useful enhancement. Will you be posting a PR for the implementation? It is frequently helpful to evaluate the CSR and the implementation concurrently. Thanks, Roger On 5/10/21 1:06 AM, Aaron Scott-Boddendijk wrote: Yes please. I often have people ask how they should solve

Re: Proposal for new interface: TimeSource

2021-05-09 Thread Aaron Scott-Boddendijk
Yes please. I often have people ask how they should solve exactly this problem and we have several code-bases that have their own implementations of essentially this interface. We've used it not only for the request-contextual time localisation but for controlling the stepping for

Proposal for new interface: TimeSource

2021-05-06 Thread Stephen Colebourne
This is a proposal to add a new interface to java.time.* public interface TimeSource { public static TimeSource system() { ... } public abstract Instant instant(); public default long millis() { return instant().toEpochMilli(); } public default Clock withZone(ZoneId