Re: RFR(XS): 8147844: new method j.l.Runtime.onSpinWait()

2016-01-28 Thread Gil Tene
> On Jan 28, 2016, at 8:51 AM, mark.reinh...@oracle.com wrote: > > 2016/1/28 8:12 -0800, Gil Tene : >> On Jan 27, 2016, at 9:41 PM, David Holmes wrote: >>> On 27/01/2016 11:31 PM, Ivan Krylov wrote: Earlier there was a discussion on this mail alias about the spin loop hint proposal [1]

Re: RFR(XS): 8147844: new method j.l.Runtime.onSpinWait()

2016-01-28 Thread mark . reinhold
2016/1/28 8:12 -0800, Gil Tene : > On Jan 27, 2016, at 9:41 PM, David Holmes wrote: >> On 27/01/2016 11:31 PM, Ivan Krylov wrote: >>> Earlier there was a discussion on this mail alias about the spin loop >>> hint proposal [1]. Based on the feedback from that discussion some >>> changes were incorp

Re: RFR(XS): 8147844: new method j.l.Runtime.onSpinWait()

2016-01-28 Thread Gil Tene
> On Jan 27, 2016, at 9:41 PM, David Holmes wrote: > > HI Ivan, > > On 27/01/2016 11:31 PM, Ivan Krylov wrote: >> Hello, >> >> Earlier there was a discussion on this mail alias about the spin loop >> hint proposal [1]. Based on the feedback from that discussion some >> changes were incorporate

Re: RFR(XS): 8147844: new method j.l.Runtime.onSpinWait()

2016-01-27 Thread David Holmes
HI Ivan, On 27/01/2016 11:31 PM, Ivan Krylov wrote: Hello, Earlier there was a discussion on this mail alias about the spin loop hint proposal [1]. Based on the feedback from that discussion some changes were incorporated and the JEP has been filed [2]. There seems to be a consensus on the API

Re: RFR(XS): 8147844: new method j.l.Runtime.onSpinWait()

2016-01-27 Thread Ivan Krylov
Updated to http://cr.openjdk.java.net/~ikrylov/8147844.jdk.02/ The sample JavaDoc has been updated too: http://ivankrylov.github.io/onspinwait/api/java/lang/Runtime.html#onSpinWait-- Alan, Thank you. On 27/01/2016 18:20, Alan Bateman wrote: On 27/01/2016 14:10, Ivan Krylov wrote: Indeed, t

Re: RFR(XS): 8147844: new method j.l.Runtime.onSpinWait()

2016-01-27 Thread Alan Bateman
On 27/01/2016 14:10, Ivan Krylov wrote: Indeed, thanks! New webrev http://cr.openjdk.java.net/~ikrylov/8147844.jdk.01/ Can you add @since 9 too? -Alan.

Re: RFR(XS): 8147844: new method j.l.Runtime.onSpinWait()

2016-01-27 Thread Ivan Krylov
Indeed, thanks! New webrev http://cr.openjdk.java.net/~ikrylov/8147844.jdk.01/ On 27/01/2016 16:48, Andrej Golovnin wrote: Hi Ivan, Please review the upcoming API changes: http://cr.openjdk.java.net/~ikrylov/8147844.jdk.00/ I think the semicolon at the end of the line 887 is not needed, e.g:

Re: RFR(XS): 8147844: new method j.l.Runtime.onSpinWait()

2016-01-27 Thread Andrej Golovnin
Hi Ivan, > Please review the upcoming API changes: > http://cr.openjdk.java.net/~ikrylov/8147844.jdk.00/ I think the semicolon at the end of the line 887 is not needed, e.g: 887 public static void onSpinWait() {}; should be 887 public static void onSpinWait() {} Best regards, Andrej G

RFR(XS): 8147844: new method j.l.Runtime.onSpinWait()

2016-01-27 Thread Ivan Krylov
Hello, Earlier there was a discussion on this mail alias about the spin loop hint proposal [1]. Based on the feedback from that discussion some changes were incorporated and the JEP has been filed [2]. There seems to be a consensus on the API side. The JEP is now in a draft state and I hope t