Re: RFR: JDK-8051713 - URL constructor/equals/hashCode/sameFile/openConnection synchronization issues

2014-07-25 Thread Peter Levart
Hi Chris, Thanks for looking into this... On 07/25/2014 02:53 PM, Chris Hegarty wrote: Hi Peter, This is certainly a thorny issue, and I agree with the approach of using StampedLock. Some small comments / questions: 1) Why abuse fieldsLock in hostAddress(), rather than grabbing the writ

Re: RFR: JDK-8051713 - URL constructor/equals/hashCode/sameFile/openConnection synchronization issues

2014-07-25 Thread Chris Hegarty
Hi Peter, This is certainly a thorny issue, and I agree with the approach of using StampedLock. Some small comments / questions: 1) Why abuse fieldsLock in hostAddress(), rather than grabbing the writeLock ? 2) Does the setAccessible in readObject need to be in a doPriv? Also should th

RFR: JDK-8051713 - URL constructor/equals/hashCode/sameFile/openConnection synchronization issues

2014-07-23 Thread Peter Levart
I created an issue for this: https://bugs.openjdk.java.net/browse/JDK-8051713 The proposed patch is still the following: http://cr.openjdk.java.net/~plevart/jdk9-dev/URL.synchronization/webrev.01/ Regards, Peter On 07/11/2014 05:11 PM, Peter Levart wrote: Hi, java.net.URL is supposed t

URL constructor/equals/hashCode/sameFile/openConnection synchronization issues

2014-07-11 Thread Peter Levart
Hi, java.net.URL is supposed to behave as an immutable object, so URL instances can be shared among threads and among parts of code without fear that they will be modified. URL class has an unusual way to achieve this (or at least it tries to). Partly because of the design which uses: - URL