Re: RFR: 8281170: Test jdk/tools/jpackage/windows/WinInstallerIconTest always fails on Windows 11

On Tue, 15 Feb 2022 17:44:24 GMT, Alexey Semenyuk wrote: > Code clean up. Remove obsolete comments, unused imports, and unneeded jtreg > test parameter. > Fix the code to handle the case when installers are not created and there is > nothing to verify in the test. Marked as reviewed by almatve

Re: RFR: 8281874: Can't unpack msi installers from test/jdk/tools/jpackage/windows/test/jdk/tools/jpackage/windows/WinShortcutPromptTest.java test

On Tue, 15 Feb 2022 22:56:35 GMT, Alexey Semenyuk wrote: > 8281874: Can't unpack msi installers from > test/jdk/tools/jpackage/windows/test/jdk/tools/jpackage/windows/WinShortcutPromptTest.java > test Marked as reviewed by almatvee (Reviewer). - PR: https://git.openjdk.java.net/j

Re: RFR: 8282011: test/jdk/tools/jpackage/windows/WinL10nTest.java test fails if light.exe is not in %PATH%

On Wed, 16 Feb 2022 17:52:43 GMT, Alexey Semenyuk wrote: > 8282011: test/jdk/tools/jpackage/windows/WinL10nTest.java test fails if > light.exe is not in %PATH% Marked as reviewed by almatvee (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7500

Re: RFR: 8282007: Assorted enhancements to jpackage testing framework [v2]

On Wed, 16 Feb 2022 23:51:30 GMT, Alexey Semenyuk wrote: >> 8282007: Assorted enhancements to jpackage testing framework > > Alexey Semenyuk has updated the pull request incrementally with one > additional commit since the last revision: > > Don't fail if requested to uninstall not installed

Re: RFR: 8282007: Assorted enhancements to jpackage testing framework [v3]

On Thu, 17 Feb 2022 03:50:39 GMT, Alexey Semenyuk wrote: >> 8282007: Assorted enhancements to jpackage testing framework > > Alexey Semenyuk has updated the pull request incrementally with one > additional commit since the last revision: > > Copyright years fixed Marked as reviewed by almatv

Re: RFR: 8279995: jpackage --add-launcher option should allow overriding description [v4]

> Added ability to override description for additional launchers via > "description" property. Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision: 8279995: jpackage --add-launcher option should allow overriding

Re: RFR: 8279995: jpackage --add-launcher option should allow overriding description [v5]

> Added ability to override description for additional launchers via > "description" property. Alexander Matveev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: - Merge master - 8279995: jpackag

Re: RFR: 8279995: jpackage --add-launcher option should allow overriding description [v3]

On Tue, 15 Feb 2022 15:48:02 GMT, Alexey Semenyuk wrote: >> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8279995: jpackage --add-launcher option should allow overriding >> descr

Re: RFR: 8279995: jpackage --add-launcher option should allow overriding description [v6]

> Added ability to override description for additional launchers via > "description" property. Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision: 8279995: jpackage --add-launcher option should allow overriding

Re: RFR: 8279995: jpackage --add-launcher option should allow overriding description [v4]

On Thu, 17 Feb 2022 17:53:57 GMT, Alexey Semenyuk wrote: >> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8279995: jpackage --add-launcher option should allow overriding >> descr

Integrated: 8279995: jpackage --add-launcher option should allow overriding description

On Wed, 9 Feb 2022 07:37:42 GMT, Alexander Matveev wrote: > Added ability to override description for additional launchers via > "description" property. This pull request has now been integrated. Changeset: fb8bf818 Author:Alexander Matveev URL: https://git.open

RFR: 8282407: Missing ')' in MacResources.properties

- Fixed by adding missing ']'. - I changed '()' to '[]', since other error messages use '[]' and not '()'. - Commit messages: - 8282407: Missing ')' in MacResources.properties Changes: https://git.openjdk.java.net/jdk/pull/7797/files Webrev: https://webrevs.openjdk.java.net/?repo=

Re: RFR: JDK-8236128: Allow jpackage create installers for services

On Fri, 11 Mar 2022 23:37:06 GMT, Alexey Semenyuk wrote: > Implementation of [JDK-8275062: "Allow jpackage create installers for > services"](https://bugs.openjdk.java.net/browse/JDK-8275062) > CSR Marked as reviewed by almatvee (Reviewer). - PR: https://git.openjdk.java.net/jdk/

Integrated: 8282407: Missing ')' in MacResources.properties

On Sat, 12 Mar 2022 03:12:30 GMT, Alexander Matveev wrote: > - Fixed by adding missing ']'. > - I changed '()' to '[]', since other error messages use '[]' and not '()'. This pull request has now been integrated. Changeset:

Re: RFR: 8284067: jpackage'd launcher reports non-zero exit codes with error prompt

On Thu, 31 Mar 2022 20:08:13 GMT, Alexey Semenyuk wrote: > Add missing `exit(exitCode)` call. > Add relevant unit test. Marked as reviewed by almatvee (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8064

RFR: 8277493: [REDO] Quarantined jpackage apps are labeled as "damaged"

- No changes to code provided by original fix. - Added ad hoc signing on macOS aarch64, since macOS aarch64 cannot execute unsigned code and code should be at least ad hoc signed. - Signing of app bundle produced by AppContentTest.java fails, since it has invalid app bundle structure with added

Re: RFR: 8285616: [macos] Incorrect path for launcher-as-service.txt in .cfg file

On Thu, 5 May 2022 20:00:54 GMT, Alexey Semenyuk wrote: > - Replace `System.getProperty("java.io.tmpdir")` call with hardcoded `/tmp` > string to get root folder for test files. > - Fix test cleanup - the test didn't delete test files upon completion Marked as reviewed by almatvee (Reviewer).

Re: RFR: 8282351: jpackage does not work if class file has `$$` in the name on windows

On Mon, 9 May 2022 21:25:37 GMT, Alexey Semenyuk wrote: > 8282351: jpackage does not work if class file has `$$` in the name on windows Marked as reviewed by almatvee (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8613

RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

- It is not possible to support native JDK commands such as "java" inside Mac App Store bundles due to embedded info.plist. Workarounds suggested in JDK-8286122 does not seems to be visible. - With proposed fix we will enforce "--strip-native-commands" option for jlink, so native JDK commands a

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe [v2]

On Wed, 11 May 2022 21:58:46 GMT, Alexey Semenyuk wrote: >> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8286122: [macos]: App bundle cannot upload to Mac App Store due to >> info.

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe [v2]

tion for > jlink, so native JDK commands are not included when generating Mac App Store > bundles. > - Custom runtime provided via --runtime-image should not contain native > commands as well, otherwise jpackage will throw error. > - Added two tests to validate fix.

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

Hi Michael, > On May 11, 2022, at 3:17 PM, Michael Hall wrote: > > Is this restricted somehow to Mac App Store applications? Yes, helper tools (in our case JDK native commands) in Mac App Store applications cannot use same bundle ID as another application. Since we have bundle ID embedded in n

Re: RFR: 8277493: [REDO] Quarantined jpackage apps are labeled as "damaged"

On Wed, 4 May 2022 03:56:10 GMT, Alexander Matveev wrote: > - No changes to code provided by original fix. > - Added ad hoc signing on macOS aarch64, since macOS aarch64 cannot execute > unsigned code and code should be at least ad hoc signed. > - Signing of app bundle

Re: RFR: 8277493: [REDO] Quarantined jpackage apps are labeled as "damaged" [v2]

undle structure with added files into Content folder. Thus test > is executed but failure is always expected on macOS aarch64. Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision: 8277493: [REDO] Quarantined jpackage apps are l

Integrated: 8277493: [REDO] Quarantined jpackage apps are labeled as "damaged"

On Wed, 4 May 2022 03:56:10 GMT, Alexander Matveev wrote: > - No changes to code provided by original fix. > - Added ad hoc signing on macOS aarch64, since macOS aarch64 cannot execute > unsigned code and code should be at least ad hoc signed. > - Signing of app bundle

Re: [External] : Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

Hi Michael, > >>> >>> I’m not real familiar with the build process. But would it be possible for >>> the user to build their own jdk that substitutes something else for the >>> colliding identifier that gets embedded? >> Yes, it should be possible and in theory such JDK with native commands ca

Re: [External] : Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

jdk.jpackage module with your app, you should able to use jpackage functionality from your app via ToolProvider without actual jpackage native command. Thanks, Alexander > On May 16, 2022, at 6:03 PM, Michael Hall wrote: > > > >> On May 16, 2022, at 7:09 PM, Alexander Matveev &g

Integrated: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

On Wed, 11 May 2022 21:31:44 GMT, Alexander Matveev wrote: > - It is not possible to support native JDK commands such as "java" inside Mac > App Store bundles due to embedded info.plist. Workarounds suggested in > JDK-8286122 does not seems to be visible. > - Wit

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

to run in order to cleanup extracted files. Thanks, Alexander On May 18, 2022, at 6:44 PM, Michael Hall mailto:mik3h...@gmail.com>> wrote: On May 11, 2022, at 4:39 PM, Alexander Matveev mailto:almat...@openjdk.java.net>> wrote: - It is not possible to support native JDK comm

Re: RFR: 8281682: Redundant .ico files in Windows app-image cause unnecessary bloat

On Thu, 19 May 2022 19:13:12 GMT, Alexey Semenyuk wrote: > 8281682: Redundant .ico files in Windows app-image cause unnecessary bloat Marked as reviewed by almatvee (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8794

RFR: 8287125: [macos] Multiple jpackage tests fail/timeout on same host

Looks like regression from JDK-8277493. JDK-8277493 will always un-sign app image. Un-signing takes time since we enumerating all files and un-signing binaries one by one. Average increase 2-3 minutes for tests which generates multiple app images. Fixed by increasing timeout for reported tests.

RFR: 8286850: [macos] Add support for signing user provided app image

- Added support for signing predefined application image. - Following command can be used to sign predefined application images: jpackage --type app-image --app-image Test.app --mac-sign [additional signing options] - Main class and if --mac-app-store was specified will be saved in .jpackage.x

Integrated: 8287125: [macos] Multiple jpackage tests fail/timeout on same host

On Fri, 27 May 2022 03:12:39 GMT, Alexander Matveev wrote: > Looks like regression from JDK-8277493. JDK-8277493 will always un-sign app > image. Un-signing takes time since we enumerating all files and un-signing > binaries one by one. Average increase 2-3 minutes for tests which

Re: RFR: 8286850: [macos] Add support for signing user provided app image [v2]

app images are supported. App image will be > completely unsigned before signing. Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision: 8286850: [macos] Add support for signing user provided app image [v2] - Changes: -

Re: RFR: 8286850: [macos] Add support for signing user provided app image [v2]

On Fri, 3 Jun 2022 01:56:01 GMT, Alexander Matveev wrote: >> - Added support for signing predefined application image. >> - Following command can be used to sign predefined application images: >> jpackage --type app-image --app-image Test.app --mac-sign [additional

Re: RFR: 8286850: [macos] Add support for signing user provided app image [v3]

app images are supported. App image will be > completely unsigned before signing. Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision: 8286850: [macos] Add support for signing user provided app image [v3] - Changes: -

Integrated: 8286850: [macos] Add support for signing user provided app image

On Thu, 2 Jun 2022 05:17:25 GMT, Alexander Matveev wrote: > - Added support for signing predefined application image. > - Following command can be used to sign predefined application images: > jpackage --type app-image --app-image Test.app --mac-sign [additional signing > option

Re: RFR: 8250950: Allow per-user and system wide configuration of a jpackaged app

On Fri, 3 Jun 2022 21:07:47 GMT, Alexey Semenyuk wrote: > 8250950: Allow per-user and system wide configuration of a jpackaged app test/jdk/tools/jpackage/share/PerUserCfgTest.java line 174: > 172: action.accept(cmd); > 173: } finally { > 174: Files.deleteIfExist

Re: RFR: 8250950: Allow per-user and system wide configuration of a jpackaged app [v2]

On Mon, 6 Jun 2022 20:37:11 GMT, Alexey Semenyuk wrote: >> 8250950: Allow per-user and system wide configuration of a jpackaged app > > Alexey Semenyuk has updated the pull request incrementally with one > additional commit since the last revision: > > Add TKit.createDirectories() method that

Re: RFR: 8286850: [macos] Add support for signing user provided app image [v2]

Hi Michael, Printing "Warning: Using unsigned app-image to build signed dmg.” with signed application should be fixed with JDK-8286850. Did you reproduce it on build containing JDK-8286850? Thanks, Alexander > On Jun 5, 2022, at 3:06 PM, Michael Hall wrote: > > > >> On Jun 5, 2022, at 8:56

Re: RFR: 8286850: [macos] Add support for signing user provided app image [v2]

Hi Michael, See below. On Jun 5, 2022, at 5:58 PM, Michael Hall mailto:mik3h...@gmail.com>> wrote: ./build/*/images/jdk/bin/jpackage --app-image ~/HalfPipe/halfpipe_jpkg/outputdir/HalfPipe.app --mac-sign --mac-signing-key-user-name "Developer ID Application: Michael Hall (5X6BXQB3Q7)" Bundl

Re: [External] : Re: RFR: 8286850: [macos] Add support for signing user provided app image [v2]

Hi Michael, Yes, this is correct. It is a three step process as you outlined it below. Thanks, Alexander On Jun 7, 2022, at 12:00 AM, Michael Hall mailto:mik3h...@gmail.com>> wrote: Alexander, I had an existing local GitHub repo for the jdk I updated that appeared to accept the parameters yo

RFR: 8287971: Throw exception for missing values in .jpackage.xml

- Warning will be printed if .jpackage.xml has old version number. - Error will be thrown if main-class and app-store values are missing from .jpackage.xml. - Both main-class and app-store are required values for JDK-8286850 and they might be missing if user uses app images generated by previou

Re: RFR: JDK-8217269: jpackage Makefile improvments

Hi Andy, Looks good. Thanks, Alexander On 1/18/2019 6:18 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). The webrev includes all the jpackage Makefile Improvements listed i

Re: RFR: JDK-8217331: Problems when space in application name

Hi Andy, Looks fine. Thanks, Alexander On 1/27/2019 4:56 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). The webrev includes removal of the APP_FS_NAME DeployParam, and en

Re: RFR: JKDK-8217331, JDK-8217792

Hi Andy, http://cr.openjdk.java.net/~herrick/8217792/webrev.01/src/jdk.jpackage/share/classes/jdk/jpackage/internal/JLinkBundlerHelper.java.frames.html Line 419 - Log.info() logs always. I think it is better to use Log.verbose() or just remove it. Otherwise looks good. Thanks, Alexander On

Re: RFR: JDK-82177923: Modular jars in jpackage are not working

Hi Andy, Looks fine. Thanks, Alexander On 1/30/2019 5:27 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). JDK-8217793 fixes the use of modular jars [1] https://bugs.openjdk

Re: RFR: JDK-8217792 : Investigate what modules are included

Hi Andy, http://cr.openjdk.java.net/~herrick/8217792/webrev.03/src/jdk.jpackage/share/classes/jdk/jpackage/internal/JLinkBundlerHelper.java.frames.html Line 272: Did you mean "if" here? I think it should be changed back to "else if". Otherwise looks fine. Thanks, Alexander On 1/30/2019 2:05

RFR: JDK-8217317 : Create jpackage native library for windows

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - jpackage launcher will now build same as Linux and OS X using SetupBuildLauncher. - jpackage.dll was added based on Windows jpackage.exe launcher whi

Re: RFR: JDK-8217751: jpackage messages and failures

Hi Andy, Looks good. Thanks, Alexander On 2/1/2019 6:54 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). RFR:  JDK-8217751: jpackage messages and failures This is a fix to E

Re: RFR: JDK-8217317 : Create jpackage native library for windows

Hi Magnus, http://cr.openjdk.java.net/~almatvee/8217317/webrev.01/ Moved files to libjpackage and remove JPACKAGELIB_SRC. Old wmain() was in jpackage.cpp line 461. Thanks, Alexander On 2/1/2019 3:39 AM, Magnus Ihse Bursie wrote: Hi Alexander, On 2019-02-01 05:22, Alexander Matveev wrote

Re: RFR: JDK-8217894: jpackage CLI syntax changes

Hi Andy, http://cr.openjdk.java.net/~herrick/8217894/webrev.01/src/jdk.jpackage/share/classes/jdk/jpackage/internal/ValidOptions.java.frames.html Line 108 and 113 looks same. I think one of them can be removed. http://cr.openjdk.java.net/~herrick/8217894/webrev.01/src/jdk.jpackage/share/classes/

RFR: JDK-8214564 : --win-upgrade-uuid does not work as expected

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Upgrade did not work, because element was missing. Fixed by adding this element if --win-upgrade-uuid was provided. - Minor code clean up. Removed

Re: RFR: JDK-8217687: jpackage --help improvements

Hi Andy, http://cr.openjdk.java.net/~herrick/8217687/webrev.01/src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/MainResources.properties.frames.html Line 140: I think we do not need " at the end. Otherwise looks fine. Thanks, Alexander On 2/7/2019 9:11 AM, Andy Herrick wrote: Pl

RFR: JDK-8212091 : Move native code under platform specific folders and files

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Moved native code under platform specific folder. - Removed most usage on #ifdefs for WINDOWS, LINUX, MAC and POSIX. - MAC define is still used in Jav

Re: RFR: JDK-8217802: Invalid Option warning message.

Looks good. On 2/15/2019 7:30 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This is a simple fix to the unsupported Option warning message, and also fixes a problem when t

Re: RFR: JDK-8212091 : Move native code under platform specific folders and files

ie wrote: On 2019-02-15 04:31, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Moved native code under platform specific folder. - Removed most usage on #ifdefs for WIN

Re: RFR: JDK-8217798: modular jar linking in jpackage

Hi Andy, Looks good. Thanks, Alexander On 2/19/2019 7:59 AM, Andy Herrick wrote: JDK-8217798: modular jar linking in jpackage Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.open

Re: RFR: JDK-8212091 : Move native code under platform specific folders and files

02/15/2019 10:03 PM, Alexander Matveev wrote: Hi Magnus, http://cr.openjdk.java.net/~almatvee/8212091/webrev.01/ Moved all files from "posix" to "unix" folder and reverted Lib-jdk.jpackage.gmk changes. Webrev updated with files moved, instead of add/remove. Thanks, Alexander

RFR: JDK-8218681 : Windows exe's generated by jpackage have wrong info

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - User provided version was not display, because it was added as additional LANG_ENGLISH resource and Windows Explorer was displaying default one adde

Re: RFR: JDK-8218055: Use ToolProvider instead of AppRuntimeImageBuilder.

Hi Andy, Updated changes looks fine. Thanks, Alexander On 2/22/2019 9:50 AM, Andy Herrick wrote: revised webrev t address issues brought up by Mandy: [2] http://cr.openjdk.java.net/~herrick/8218055/webrev.03 /Andy On 2/21/2019 8:54 PM, Mandy Chung wrote: On 2/21/19 4:49 PM, Andy Herrick

Re: RFR: JDK-8218055: Use ToolProvider instead of AppRuntimeImageBuilder.

Hi Andy, Updated version looks fine as well. Thank, Alexander On 2/25/2019 5:19 AM, Andy Herrick wrote: I uploaded webrev version 04 (http://cr.openjdk.java.net/~herrick/8218055/webrev.04) which is same as version 03 except "JLink" is changed to "jlink" in several messages. /ANdy On 2/22/

RFR: JDK-8191709 : javapackager detects WiX 3.10 as 3.1 and fails to use WiX 3.6+ compatible code

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Problem was in how we compare versions. We used to compare it as float number, so 3.10 -> 3.1 which was less then 3.6. - Fixed by comparing major an

Re: RFR: JDK-8217902: jpackage fails with --app-image option on mac

Hi Andy, http://cr.openjdk.java.net/~herrick/8217902/webrev.01/src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WinAppBundler.java.frames.html Line 135 - Did you mean to put error message in else statement before throwing exception? Otherwise looks fine. Thanks, Alexander On 2/26/2019

RFR: JDK-8219144 : Cannot find installed application on Mac

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). By default pkgbuild generates package with BundleIsRelocatable set to true, which means if an application already exist on system (installed, generate

Re: RFR: JDK-8191709 : javapackager detects WiX 3.10 as 3.1 and fails to use WiX 3.6+ compatible code

means, for example, that 4.1 will be considered less than 3.6. -- Kevin On 2/26/2019 3:25 PM, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Problem was in how we co

Re: RFR: JDK-8217902: jpackage fails with --app-image option on mac

Hi Andy, Revised webrev looks good. Thanks, Alexander On 2/27/2019 4:41 PM, Andy Herrick wrote: revised webrev at http://cr.openjdk.java.net/~herrick/8217902/webrev.02/ Do not Log a verbose message when cfg not found in getAppName() - just use APP_NAME parameter as is done on Linux and Mac

RFR: JDK-8219889 : Update jpackage tests for JDK-8219678 changes

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Remove JPackageCreateImageOverwriteTest and JPackageCreateImageStripNativeCommandsTest. - Remove usage of --overwrite. [1] https://bugs.openjdk.jav

Re: RFR: JDK-8219679: Help text changes in jpackage

Hi Andy, http://cr.openjdk.java.net/~herrick/8219679/webrev.02/src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources.properties.frames.html Line 109: Missing ">" after main class? Line 132: additionl - > additional Otherwise looks fine. Thanks, Alexander On 3/3/2019 7:34

Re: RFR: JDK-8219678: CLI changes in jpackage

Hi Andy, http://cr.openjdk.java.net/~herrick/8219678/webrev.03/src/jdk.jpackage/share/classes/jdk/jpackage/internal/BundlerParamInfo.java.frames.html Line 32: Do we need this import? I do not see any changes which might require it. Otherwise looks fine. Thanks, Alexander On 3/3/2019 7:48 AM,

RFR: JDK-8214566 : --win-dir-chooser does not prompt if destination folder is not empty

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Added custom action to check installation folder and display confirmation dialog to ask user to continue installation if destination folder is not e

Re: RFR: JDK-8214566 : --win-dir-chooser does not prompt if destination folder is not empty

TOOLCHAIN_LINK_CXX have no effect on Windows, so should be removed to avoid confusion in the future. This new library does not link with libjava so I see no need to add that prerequisite declaration. /Erik On 2019-03-06 17:10, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at

Re: RFR: JDK-171959: add-launcher is not working when normal jar is used for first launcher and module is used for second launcher

Hi Andy, Looks good. Thanks, Alexander On 3/8/2019 12:57 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8171959 [2] http://cr

RFR: JDK-8215574 : Investigate and document usage of --category, --copyright, --vendor and --description

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Removed unused TITLE which is just APP_NAME. - Fix maintainer for DEB packages "vendor " instead of vendor or just email. - Fixed description for RP

Re: RFR: 8220505: Allow building available installers when --installer-type not specified

Hi Andy, Looks good. Thanks, Alexander On 3/12/2019 9:46 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8220505 [2] http://c

RFR: JDK-8220264: msi installer does not remove some files if app installed into non-default location

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Problem was that we did not restore APPLICATIONFOLDER correctly and it was set to default value. Fixed by forcing reading registry from 64-bit. [1]

Re: RFR: JDK-8220804: Help message for @ argfile option is printed in the wrong place

Hi Andy, Looks good. Thanks, Alexander On 3/18/2019 5:44 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8220804 [2] http://cr

RFR: JDK-8215019: Allow --install-dir on windows

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Added support for --install-dir on Windows. It should be relative path to "Program Files" or "AppData". - If --install-dir is invalid we will use ap

RFR: JDK-8221101: Update JNLPConverter to support latest jpackage CLI changes

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Updated JNLPConverter to support latest CLI changes and bug fixes. - Added getMessage() to exceptions, otherwise null was printed. - Restored characte

Re: RFR: JDK-8215019: Allow --install-dir on windows

The error message says: 'sub-path under default installation location" which is a little better. (though there should be a "the" before default). /Andy On 3/20/2019 8:05 PM, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the J

Re: RFR: JDK-8221256: Fix create-installer specific options on MAC

Hi Andy, Looks good. Thanks, Alexander On 3/26/2019 12:53 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8221256 [2] http://c

RFR: JDK-8221525: jpackage fails with non-ASCII characters in --copyright

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - .properties file was written in default encoding (file.encoding=Cp1252). Native code was expecting UTF-8 and thus was not able to read non-ASCII char

Re: RFR: JDK-8221565: Linux build broken after merge with default branch

Hi Andy, Changes looks fine, but do we really need such try/catch block? I think this code needs to be modify, so we do not need such try/catch or handle this error as real error. Probably another bug can be filed to do this. Thanks, Alexander On 3/27/2019 12:33 PM, Andy Herrick wrote: Plea

Re: RFR: JDK-8215241: Permissions are not set correctly on sub-folders in /Applications

Hi Semyon, Looks good. Thanks, Alexander On 3/27/2019 1:43 PM, semyon.sadet...@oracle.com wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8215241 webrev: http://cr.openjdk.java.net/~ssadetsky/8215241/webrev.00/ The fix adds p

Re: RFR: JDK-8221582: Rename jvm-args option to java-options

Hi Andy, webrev.02 looks fine. Thanks, Alexander On 3/28/2019 11:20 AM, Alexey Semenyuk wrote: Agreed. Would you like me to create a record to track this follow up clean up? - Alexey On 3/28/2019 2:01 PM, Andy Herrick wrote: On 3/28/2019 1:54 PM, Kevin Rushforth wrote: That seems like a

Re: RFR: JDK-8208652: JPackageCreateInstallerFileAssociationsTest.java fails on Mac.

Hi Semyon, Looks good. I assume you did run all tests on all platforms, since it is shared code for most tests. Thanks, Alexander On 4/3/2019 12:16 PM, semyon.sadet...@oracle.com wrote: Hello, bug: https://bugs.openjdk.java.net/browse/JDK-8208652 webrev: http://cr.openjdk.java.net/~ssadets

Re: RFR: JDK-8221876:[macOS] JPackage install takes long time

Hi Semyon, Looks good. Thanks, Alexander On 4/3/2019 2:30 PM, semyon.sadet...@oracle.com wrote: Hello, bug: https://bugs.openjdk.java.net/browse/JDK-8221876 webrev: http://cr.openjdk.java.net/~ssadetsky/8221876/webrev.00/ The fix eliminate delay in install which is caused by postinstall sc

Re: RFR: JDK-8221779: Help text changes from JDK-8221777 and other jpackage EA5 feedback

Hi Andy, Looks good. Thanks, Alexander On 4/4/2019 4:27 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8221779 [2] http://cr.

Re: RFR: JDK8221777: CLI changes from jpackage EA5 feedback

Hi Andy, Looks good. Thanks, Alexander On 4/4/2019 4:32 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This change renames the "create-image" mode to "create-app-image", a

Re: RFR: JDK-8221749: Error messages

Hi Andy, Looks good. Also, many messages (including added in this review) in MainResources.properties do have "." at the end and some don't. I think we should cleanup it and add "." if needed. Thanks, Alexander On 4/8/2019 4:41 AM, Andy Herrick wrote: Please review the jpackage fix for bug

Re: RFR: JDK-8221749: Error messages

Hi Andy, webrev.02 looks good. Thanks, Alexander On 4/9/2019 4:45 AM, Andy Herrick wrote: On 4/8/2019 6:05 PM, Andy Herrick wrote: On 4/8/2019 5:41 PM, Alexander Matveev wrote: Hi Andy, Looks good. Also, many messages (including added in this review) in MainResources.properties do have

Re: RFR: JDK-8221641: Follow up code clean up for JDK-8221582

Hi Andy, Looks good. Thanks, Alexander On 4/9/2019 9:33 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8221641 [2] http://cr.

Re: RFE: JDK-8217895: jpackage --identifier purpose

Hi Andy, Looks good. Thanks, Alexander On 4/11/2019 12:05 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8217895 [2] http://c

Re: RFR: JDK-8222406: Multiple arguments for the same option - aggragation broken.

Hi Andy, Looks good. Thanks, Alexander On 4/12/2019 10:35 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8222406 [2] http://c

Re: RFR: 8222486: Reorder sample usage in jpackage help output

Hi Andy, Looks good. Thanks, Alexander On 4/15/2019 6:32 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8222486 [2] http://cr

Re: RFR: JDK-8222733: Modify jpackage option --add-launcher syntax

Hi Andy, Looks good. Thanks, Alexander On 4/18/2019 12:49 PM, Andy Herrick wrote: Please review the jpackage fix for bugs [1] and [2] at [3]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8222733 [2]

RFR: JDK-8222676: create-installer with --app-image fails on mac

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Fixed issue when app image is located at root of working folder, since fix for JDK-8219144 assumed app image located under some folder other then wo

Re: RFR: JDK-8223038: JPackage code signing fails on Mac.

Hi Semyon, Looks good. Thanks, Alexander On 4/26/2019 12:28 PM, semyon.sadet...@oracle.com wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8223038 webrev: http://cr.openjdk.java.net/~ssadetsky/8223038/webrev.00/ This is a regression of 8219683 where Java runtime was moved out from Plug

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

Hi Andy, Looks good overall. http://cr.openjdk.java.net/~herrick/8212780/webrev.ea6/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/Info-lite.plist.template.html http://cr.openjdk.java.net/~herrick/8212780/webrev.ea6/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

Hi Kevin, See below. On 5/2/2019 5:38 PM, Kevin Rushforth wrote: Here are a few follow-on comments. As with my earlier comments, none of these need to be addressed prior to integration. 1. I found a few more classes that do I/O and could benefit from using try-with-resources:    IOUtils, Li

<    1   2   3   4   5   6   >