[PATCH] build: fix a build warning on 32 bit systems in shuf.c

2013-07-10 Thread Pádraig Brady
commit b45c5a7cf04b9f304cc4223dab3b98dda6874527 Author: Pádraig Brady Date: Thu Jul 11 03:20:18 2013 +0100 build: fix a build warning on 32 bit systems in shuf.c Prompted by the continuous integration build failure at: http://hydra.nixos.org/build/5508873 * src/shuf.c (write_r

Re: Generate random numbers with shuf

2013-07-10 Thread Pádraig Brady
On 07/11/2013 12:54 AM, Assaf Gordon wrote: > On 07/10/2013 09:20 AM, Pádraig Brady wrote: >> >> I've split to two patches. >> 1. Unrelated test improvements. >> 2. All the rest > > <...> > >> Note in both patches I made adjustments to the tests [...] > <...> >> I.E. avoid cat unless needed, and

Re: Generate random numbers with shuf

2013-07-10 Thread Assaf Gordon
On 07/10/2013 09:20 AM, Pádraig Brady wrote: I've split to two patches. 1. Unrelated test improvements. 2. All the rest <...> Note in both patches I made adjustments to the tests [...] <...> I.E. avoid cat unless needed, and paste is more general than fmt in this usage. <...> Also I sim

Re: [PATCH] df: fix mount list processing with unstatable mount dirs

2013-07-10 Thread Pádraig Brady
On 07/10/2013 05:31 PM, Bernhard Voelker wrote: > On 07/09/2013 05:00 PM, Pádraig Brady wrote: >> On 07/09/2013 03:12 PM, Bernhard Voelker wrote: >>> Tomorrow, I'll have time for a review. > > The patch looks good. Thanks. > > Have a nice day, > Berny > Pushed. thanks for the review! Pádraig.

Re: [PATCH] df: fix mount list processing with unstatable mount dirs

2013-07-10 Thread Bernhard Voelker
On 07/09/2013 05:00 PM, Pádraig Brady wrote: > On 07/09/2013 03:12 PM, Bernhard Voelker wrote: >> Tomorrow, I'll have time for a review. The patch looks good. Thanks. Have a nice day, Berny

Re: Generate random numbers with shuf

2013-07-10 Thread Pádraig Brady
On 07/05/2013 10:43 PM, Assaf Gordon wrote: > > On 07/05/2013 12:12 PM, Pádraig Brady wrote: >> On 07/05/2013 07:04 PM, Assaf Gordon wrote: >>> Hello, > Regarding old discussion here: > http://lists.gnu.org/archive/html/coreutils/2011-02/msg00030.html > > Attached is a patch w

[PATCH] maint: avoid a valgrind memory leak warning from pinky

2013-07-10 Thread Pádraig Brady
Similarly to commit v8.21-84-g8d2da3f in src/uptime.c avoid a "definitely lost" error from valgrind. Note this only happens with pinky when compiled without optimization, in which case certain paths aren't eliminated casuing valgrind to trigger the message. Note also that coverity flags this "res