Re: [PATCH] updated pthread list patch

2003-03-20 Thread Robert Collins
On Thu, 2003-03-20 at 18:50, Thomas Pfaff wrote: > On Wed, 19 Mar 2003, Robert Collins wrote: > I just followed the already existing method names in thread.h. Methods > like forEach, initMutex or isGoodObject were made by you. Yes, I realise that. > I would suggest to commit my patch now and do

Re: [PATCH] updated pthread list patch

2003-03-19 Thread Thomas Pfaff
On Wed, 19 Mar 2003, Robert Collins wrote: > I'm happy with changing the method naming format, but is it GNU > standard? Thats a requirement for the cygwin project. > > http://www.gnu.org/prep/standards_26.html#SEC26 says that > "For example, you should use names like ignore_space_change_flag; d

Re: [PATCH] updated pthread list patch

2003-03-19 Thread Christopher Faylor
On Thu, Mar 20, 2003 at 09:22:42AM +1100, Robert Collins wrote: >I'm happy with changing the method naming format, but is it GNU >standard? Thats a requirement for the cygwin project. > >http://www.gnu.org/prep/standards_26.html#SEC26 says that >"For example, you should use names like ignore_space

Re: [PATCH] updated pthread list patch

2003-03-19 Thread Robert Collins
I'm happy with changing the method naming format, but is it GNU standard? Thats a requirement for the cygwin project. http://www.gnu.org/prep/standards_26.html#SEC26 says that "For example, you should use names like ignore_space_change_flag; don't use names like iCantReadThis." Now, I happen to

[PATCH] updated pthread list patch

2003-03-19 Thread Thomas Pfaff
2002-03-19 Thomas Pfaff <[EMAIL PROTECTED]> * thread.h (class List): Move inline code inside class declaration. (List::forEach): Change callback parameter to member function pointer. (pthread_keys::fixup_before_fork): Change to inline. Use List::f