[GitHub] activemq-artemis pull request #788: ARTEMIS-732 loading wrong arch lib

2016-09-21 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/788#discussion_r79899253 --- Diff: artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/bin/artemis --- @@ -105,6 +105,16 @@ if [ -z "$LOG_MA

[GitHub] activemq-artemis pull request #788: ARTEMIS-732 loading wrong arch lib

2016-09-21 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/788 ARTEMIS-732 loading wrong arch lib You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-732

[GitHub] activemq-artemis issue #756: ARTEMIS-715 In rare circumstances MessageProduc...

2016-09-07 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/756 The first line of the commit is longer than 50 characters. This doesn't conform to the aforementioned format. --- If your project is set up for it, you can reply to this email and

[GitHub] activemq-artemis issue #756: [ARTEMIS-715] In rare circumstances MessageProd...

2016-09-07 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/756 The commit message should follow the 50/72 format as discussed in the [Hacking Guide](https://github.com/apache/activemq-artemis/blob/master/docs/hacking-guide/en/code.md#typical

[GitHub] activemq-artemis pull request #752: Fix test race condition

2016-09-06 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/752 Fix test race condition You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work Alternatively you can

[GitHub] activemq-artemis pull request #747: ARTEMIS-711 Fix handling of 'bare' heade...

2016-09-01 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/747#discussion_r77227583 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/util/Wait.java --- @@ -41,13 +41,13

[GitHub] activemq-artemis pull request #747: ARTEMIS-711 Fix handling of 'bare' heade...

2016-09-01 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/747 ARTEMIS-711 Fix handling of 'bare' header You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis A

[GitHub] activemq-artemis pull request #743: ARTEMIS-699 group ID reaper tx bug

2016-08-30 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/743 ARTEMIS-699 group ID reaper tx bug You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-699

[GitHub] activemq-artemis issue #736: Remove thread.sleep in JDBCTest

2016-08-30 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/736 Is this related to a particular JIRA? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] activemq-artemis pull request #741: ARTEMIS-702 JMS 2 spec violation for rec...

2016-08-30 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/741 ARTEMIS-702 JMS 2 spec violation for receiveBody You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS

[GitHub] activemq-artemis pull request #739: Script to help compare old commits

2016-08-29 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/739#discussion_r76647463 --- Diff: docs/hacking-guide/en/history.md --- @@ -19,3 +19,13 @@ Credit should be given to those developers who contributed to the HornetQ projec

[GitHub] activemq-artemis pull request #729: ARTEMIS-695 fix URI syntax in doc

2016-08-23 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/729 ARTEMIS-695 fix URI syntax in doc You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-695

[GitHub] activemq-artemis issue #728: ARTEMIS-690 fix link in JMS doc

2016-08-23 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/728 I updated the link and removed the . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] activemq-artemis pull request #728: ARTEMIS-690 fix link in JMS doc

2016-08-22 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/728 ARTEMIS-690 fix link in JMS doc You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-690 Alternatively

[GitHub] activemq-artemis pull request #727: ARTEMIS-686 shutdown external components

2016-08-19 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/727 ARTEMIS-686 shutdown external components You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-686

[GitHub] activemq-artemis issue #724: [ARTEMIS-684] Client connection are not balance...

2016-08-17 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/724 I'm not sure I agree with this change since it will impact existing load-balancing semantics which users may depend on. Connection load-balancing is done per connection fa

[GitHub] activemq-artemis pull request #720: SSL improvements

2016-08-12 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/720 SSL improvements You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-656 Alternatively you can review

[GitHub] activemq-artemis issue #718: just some refactorings

2016-08-11 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/718 Also, you have 3 checkstyle violations: [ERROR] src/main/java/org/apache/activemq/artemis/integration/vertx/OutgoingVertxEventHandler.java:[21,8] (imports) UnusedImports: Unused

[GitHub] activemq-artemis issue #718: just some refactorings

2016-08-11 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/718 Can you squash those commits together so there's not a commit making the change and another commit undoing it? That's a bit messy. Also, your commit messages should fol

[GitHub] activemq-artemis pull request #718: just some refactorings

2016-08-11 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/718#discussion_r74492945 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/vertx/ActiveMQVertxUnitTest.java --- @@ -282,19

[GitHub] activemq-artemis pull request #716: ARTEMIS-678 refactor log for expiry opti...

2016-08-10 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/716 ARTEMIS-678 refactor log for expiry optimization You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis

[GitHub] activemq-artemis issue #714: ARTEMIS-677 Support websocket subprotocol hands...

2016-08-10 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/714 NPE in org.apache.activemq.artemis.tests.unit.core.remoting.impl.netty.NettyAcceptorTest.testStartStop(). --- If your project is set up for it, you can reply to this email and have your

[GitHub] activemq-artemis issue #705: ARTEMIS-670 Adding destination creation and del...

2016-08-09 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/705 One concern I have is that I can't tell by the names if these commands are operating on JMS resources or core resources. Obviously there's no such thing as a core topic so I a

[GitHub] activemq-artemis issue #701: ARTEMIS-592 finer-grained security for queues

2016-08-08 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/701 The original use-case was related to Stomp durable subscriptions which in core terms is simply a durable, non-temporary queue. Our Stomp implementation allows individual Stomp clients to

[GitHub] activemq-artemis issue #701: ARTEMIS-592 finer-grained security for queues

2016-08-08 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/701 @clebertsuconic, was your question for me or @mtaylor? If it's for me can you elaborate a bit more. I'm not clear on what you're asking. --- If your project is set up

[GitHub] activemq-artemis pull request #703: ARTEMIS-601 + logger fixes

2016-08-05 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/703 ARTEMIS-601 + logger fixes You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-601 Alternatively you

[GitHub] activemq-artemis issue #701: ARTEMIS-592 finer-grained security for queues

2016-08-04 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/701 There's no way to eliminate the user's need to understand how non-core protocols map to the core implementation. We have addresses and queues and just about all the configu

[GitHub] activemq-artemis pull request #701: ARTEMIS-529 finer-grained security for q...

2016-08-03 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/701 ARTEMIS-529 finer-grained security for queues This was the simplest way I could think of to implement this feature. It allows a security-setting to match to a particular queue by using

[GitHub] activemq-artemis pull request #697: Fix ExtraStompTest

2016-08-02 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/697 Fix ExtraStompTest You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work Alternatively you can

[GitHub] activemq-artemis pull request #696: Fix AcceptorControlUsingCoreTest

2016-08-02 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/696 Fix AcceptorControlUsingCoreTest You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work

[GitHub] activemq-artemis pull request #692: JSON fixes

2016-08-01 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/692 JSON fixes You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis JSONfixes Alternatively you can review and

[GitHub] activemq-artemis pull request #681: ARTEMIS-565 fix TopicControlUsingJMSTest

2016-07-28 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/681 ARTEMIS-565 fix TopicControlUsingJMSTest You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis JSONfixes

[GitHub] activemq-artemis pull request #678: ARTEMIS-405 more bits of JMX doc

2016-07-28 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/678 ARTEMIS-405 more bits of JMX doc You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-405

[GitHub] activemq-artemis pull request #677: ARTEMIS-565 additional JSON fixes

2016-07-28 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/677#discussion_r72638984 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/JsonUtil.java --- @@ -295,6 +295,13 @@ else if (jsonValue

[GitHub] activemq-artemis pull request #677: ARTEMIS-595 additional JSON fixes

2016-07-28 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/677#discussion_r72633668 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/JsonUtil.java --- @@ -295,6 +295,13 @@ else if (jsonValue

[GitHub] activemq-artemis pull request #677: ARTEMIS-595 additional JSON fixes

2016-07-28 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/677 ARTEMIS-595 additional JSON fixes You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis JSONfixes Alternatively

[GitHub] activemq-artemis pull request #676: ARTEMIS-569 correct method spelling

2016-07-28 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/676 ARTEMIS-569 correct method spelling You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work

[GitHub] activemq-artemis pull request #674: ARTEMIS-647 track 'killed' msg count on ...

2016-07-27 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/674 ARTEMIS-647 track 'killed' msg count on queue A 'killed' message is one that has been sent to a dead-letter address or otherwise removed from the queue due

[GitHub] activemq-artemis pull request #673: ARTEMIS-565 more JSON fixes

2016-07-27 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/673 ARTEMIS-565 more JSON fixes You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis JSONfixes Alternatively you

[GitHub] activemq-artemis pull request #671: ARTEMIS-646 track expired msg count on q...

2016-07-26 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/671 ARTEMIS-646 track expired msg count on queue You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-646

[GitHub] activemq-artemis pull request #669: ARTEMIS-565 fix more broken Json stuff

2016-07-26 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/669 ARTEMIS-565 fix more broken Json stuff You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work

[GitHub] activemq-artemis issue #662: ARTEMIS-587 add more JSON JMX mgmt methods to c...

2016-07-25 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/662 I rebased this on John's recent JSON changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] activemq-artemis issue #640: ARTEMIS-565 Replace json.org with javax.json

2016-07-25 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/640 You need to rebase. That issue was resolved last week I believe. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] activemq-artemis pull request #662: ARTEMIS-587 add more JSON JMX mgmt metho...

2016-07-25 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/662#discussion_r72130781 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java --- @@ -1360,6 +1359,130

[GitHub] activemq-artemis pull request #662: ARTEMIS-587 add more JSON JMX mgmt metho...

2016-07-25 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/662 ARTEMIS-587 add more JSON JMX mgmt methods to core You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS

[GitHub] activemq-artemis pull request #661: ARTEMIS-628 Adding back old constructor ...

2016-07-25 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/661#discussion_r72120144 --- Diff: README.md --- @@ -44,4 +44,7 @@ If you are trying to copy the examples somewhere else and modifying them. Consid # if trying to

[GitHub] activemq-artemis pull request #657: ARTEMIS-650 clarify doc, use TTL default...

2016-07-24 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/657 ARTEMIS-650 clarify doc, use TTL default for 0 heartbeat You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis

[GitHub] activemq-artemis pull request #656: ARTEMIS-650 clarify doc, use TTL default...

2016-07-24 Thread jbertram
Github user jbertram closed the pull request at: https://github.com/apache/activemq-artemis/pull/656 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis pull request #656: ARTEMIS-611 clarify doc, use TTL default...

2016-07-24 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/656 ARTEMIS-611 clarify doc, use TTL default for 0 heartbeat You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis

[GitHub] activemq-artemis issue #641: Update version of netty4

2016-07-22 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/641 I sent a PR to deal with the regression. See https://github.com/apache/activemq-artemis/pull/655. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] activemq-artemis pull request #655: Fix ByteBuffer regression from Netty upg...

2016-07-22 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/655 Fix ByteBuffer regression from Netty upgrade Using array() is a bit dangerous as it's an optional part of any ByteBuffer implementation. This new method will deal with va

[GitHub] activemq-artemis issue #653: ARTEMIS-548 Stomp durable sub unsubscrbe

2016-07-22 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/653 There's a handful of Stomp subscriber tests running without issues. Can you clarify a bit on what is broken. If you can outline a specific use-case then I can write a test f

[GitHub] activemq-artemis issue #641: Update version of netty4

2016-07-21 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/641 I think the Netty upgrade may have broken a bunch of the large-message tests. See https://builds.apache.org/job/ActiveMQ-Artemis-Nightly-Regression-Test/582/. I get failures in

[GitHub] activemq-artemis pull request #654: ARTEMIS-413 doc for Stomp durable subs

2016-07-21 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/654 ARTEMIS-413 doc for Stomp durable subs You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-413

[GitHub] activemq-artemis pull request #653: ARTEMIS-548 Stomp durable sub unsubscrbe

2016-07-21 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/653 ARTEMIS-548 Stomp durable sub unsubscrbe Implement ability for Stomp clients to unsubscribe durable subscriptions. You can merge this pull request into a Git repository by running

[GitHub] activemq-artemis pull request #651: ARTEMIS-405 more docs for JMS destinatio...

2016-07-20 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/651 ARTEMIS-405 more docs for JMS destinations You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-405

[GitHub] activemq-artemis pull request #650: ARTEMIS-611 fix logging

2016-07-20 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/650 ARTEMIS-611 fix logging You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-611 Alternatively you can

[GitHub] activemq-artemis pull request #646: ARTEMIS-234 fix content-length for Stomp...

2016-07-19 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/646 ARTEMIS-234 fix content-length for Stomp 1.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-234

[GitHub] activemq-artemis pull request #643: ARTEMIS-611 refactor STOMP cxn TTL + hea...

2016-07-18 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/643 ARTEMIS-611 refactor STOMP cxn TTL + heart-beat You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS

[GitHub] activemq-artemis pull request #639: ARTEMIS-631 log invalid filter trace at ...

2016-07-15 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/639 ARTEMIS-631 log invalid filter trace at DEBUG You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-631

[GitHub] activemq-artemis pull request #633: ARTEMIS-573 clarify filter documentation

2016-07-13 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/633 ARTEMIS-573 clarify filter documentation You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-573

[GitHub] activemq-artemis issue #630: ARTEMIS-628 add BROWSE role

2016-07-12 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/630 Failed PR tests succeed locally. It looks like there's a port conflict on the Apache CI hardware. --- If your project is set up for it, you can reply to this email and have your

[GitHub] activemq-artemis pull request #630: ARTEMIS-628 add BROWSE role

2016-07-12 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/630 ARTEMIS-628 add BROWSE role You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-628 Alternatively you

[GitHub] activemq-artemis pull request #629: ARTEMIS-626 re-use context for LDAP

2016-07-11 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/629 ARTEMIS-626 re-use context for LDAP You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-626

[GitHub] activemq-artemis pull request #628: ARTEMIS-620 clean up large messages

2016-07-11 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/628 ARTEMIS-620 clean up large messages You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-620

[GitHub] activemq-artemis pull request #626: ARTEMIS-619 stop components along with s...

2016-07-08 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/626 ARTEMIS-619 stop components along with server You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-619

[GitHub] activemq-artemis pull request #624: ARTEMIS-584 fix test

2016-07-06 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/624 ARTEMIS-584 fix test You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work Alternatively you can

[GitHub] activemq-artemis pull request #621: ARTEMIS-584 add validated user to msg

2016-07-06 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/621#discussion_r69742648 --- Diff: docs/user-manual/en/security.md --- @@ -10,6 +10,13 @@ long. To change this period set the property `security-invalidation-interval

[GitHub] activemq-artemis pull request #622: ARTEMIS-578 cert authn/z for STOMP

2016-07-05 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/622#discussion_r69647599 --- Diff: artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/v11/StompFrameHandlerV11.java

[GitHub] activemq-artemis pull request #622: ARTEMIS-578 cert authn/z for STOMP

2016-07-05 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/622 ARTEMIS-578 cert authn/z for STOMP You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-578

[GitHub] activemq-artemis pull request #621: ARTEMIS-584 add validated user to msg

2016-07-05 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/621 ARTEMIS-584 add validated user to msg Implements a new feature to aid in security auditing by adding the name of the validated user to the messages it sends. You can merge this pull

[GitHub] activemq-artemis issue #621: ARTEMIS-584 add validated user to msg

2016-07-05 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/621 I ran the full test-suite. There were no new failures. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] activemq-artemis pull request #619: ARTEMIS-610 update clientFailureCheckPer...

2016-07-05 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/619 ARTEMIS-610 update clientFailureCheckPeriod doc You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS

[GitHub] activemq-artemis issue #617: ARTEMIS-607 Added interceptor support for MQTT ...

2016-07-05 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/617 Could you squash these two commits together? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] activemq-artemis pull request #613: ARTEMIS-602 Fix REST examples

2016-07-01 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/613#discussion_r69371083 --- Diff: examples/features/standard/rest/dup-send/README.txt --- @@ -1,5 +1,5 @@ System Requirements: -You will need JDK 1.6 and Maven to

[GitHub] activemq-artemis pull request #615: ARTEMIS-598 fix native logger code

2016-07-01 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/615 ARTEMIS-598 fix native logger code You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-598

[GitHub] activemq-artemis issue #613: ARTEMIS-602 Fix REST examples

2016-07-01 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/613 I sorted the dependency issue out, and I also ran the PR check on my local machine since the Apache CI seems to be flaky right now. It passed. --- If your project is set up for it, you

[GitHub] activemq-artemis issue #613: ARTEMIS-602 Fix REST examples

2016-06-30 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/613 The PR test build fails with: [ERROR] Failed to execute goal on project artemis-web: Could not resolve dependencies for project org.apache.activemq:artemis-web:jar:1.4.0-SNAPSHOT

[GitHub] activemq-artemis pull request #613: ARTEMIS-602 Fix REST examples

2016-06-30 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/613 ARTEMIS-602 Fix REST examples You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis restExamples Alternatively

[GitHub] activemq-artemis pull request #611: ARTEMIS-602 fix web.xml examples for RES...

2016-06-30 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/611 ARTEMIS-602 fix web.xml examples for REST You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work

[GitHub] activemq-artemis pull request #608: ARTEMIS-602 update pom info for REST WAR

2016-06-29 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/608 ARTEMIS-602 update pom info for REST WAR You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work

[GitHub] activemq-artemis pull request #605: ARTEMIS-569 add missing method

2016-06-27 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/605 ARTEMIS-569 add missing method This should fix the test failing in the test-suite. You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] activemq-artemis pull request #604: ARTEMIS-593 + small fix for ARTEMIS-322

2016-06-27 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/604 ARTEMIS-593 + small fix for ARTEMIS-322 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-593

[GitHub] activemq-artemis pull request #603: ARTEMIS-569 fix test failure

2016-06-27 Thread jbertram
Github user jbertram closed the pull request at: https://github.com/apache/activemq-artemis/pull/603 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis pull request #601: ARTEMIS-596 fix JMS bridge example

2016-06-27 Thread jbertram
Github user jbertram closed the pull request at: https://github.com/apache/activemq-artemis/pull/601 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis pull request #603: ARTEMIS-569 fix test failure

2016-06-27 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/603 ARTEMIS-569 fix test failure You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-569 Alternatively

[GitHub] activemq-artemis pull request #601: ARTEMIS-596 fix JMS bridge example

2016-06-24 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/601 ARTEMIS-596 fix JMS bridge example You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work

[GitHub] activemq-artemis pull request #600: ARTEMIS-569 fix bridge producerWindowSiz...

2016-06-24 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/600 ARTEMIS-569 fix bridge producerWindowSize Something bizarre happened with commit 8f52a622d0d883ca5e9f60ba7754ed51de38cc5c in April 2015. It reverted the changes from both

[GitHub] activemq-artemis issue #597: [ARTEMIS-595] When creating JMS bridge manageme...

2016-06-24 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/597 Go ahead and close this PR please. Tom sent https://github.com/apache/activemq-artemis/pull/599 which has (most of) the appropriate changes. --- If your project is set up for it, you

[GitHub] activemq-artemis issue #595: [ARTEMIS-591] Wrong XAException return code whe...

2016-06-24 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/595 Can you add a test to your commit which verifies the proper exception code is returned in the case of a timeout? --- If your project is set up for it, you can reply to this email and

[GitHub] activemq-artemis issue #597: [ARTEMIS-595] When creating JMS bridge manageme...

2016-06-24 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/597 Commit messages should follow the 50/72 pattern as noted in the "Commit Messages" section on http://activemq.apache.org/artemis/docs/1.3.0/hacking-guide/maintainers.html. -

[GitHub] activemq-artemis pull request #596: ARTEMIS-577 clarify SSL handshake failur...

2016-06-23 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/596 ARTEMIS-577 clarify SSL handshake failure log You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-577

[GitHub] activemq-artemis pull request #594: ARTEMIS-579 document reload for JAAS mod...

2016-06-20 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/594 ARTEMIS-579 document reload for JAAS modules You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-579

[GitHub] activemq-artemis pull request #588: ARTEMIS-563 update POODLE message

2016-06-20 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/588#discussion_r67690084 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java --- @@ -309,6 +309,12 @@ void

[GitHub] activemq-artemis pull request #589: ARTEMIS-409 clarify STOMP login failure ...

2016-06-17 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/589 ARTEMIS-409 clarify STOMP login failure response You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS

[GitHub] activemq-artemis pull request #588: ARTEMIS-563 update POODLE message

2016-06-17 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/588 ARTEMIS-563 update POODLE message You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-563

[GitHub] activemq-artemis pull request #585: ARTEMIS-529 support dual auth

2016-06-17 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/585 ARTEMIS-529 support dual auth A new feature whereby 2-way SSL connections can be authenticated differently than non-SSL connections. You can merge this pull request into a Git

[GitHub] activemq-artemis issue #573: Fix possible leaks in LDAP tests

2016-06-08 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/573 The issue with the threads is that org.apache.directory.server.core.integ.FrameworkRunner which is being used for @RunWith is managing the LDAP server and I believe by the time the thread

[GitHub] activemq-artemis pull request #573: Fix possible leaks in LDAP tests

2016-06-08 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/573 Fix possible leaks in LDAP tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work

[GitHub] activemq-artemis pull request #564: Update embedded docs/example

2016-06-06 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/564 Update embedded docs/example You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work Alternatively

<    4   5   6   7   8   9   10   11   >